Debian Bug report logs - #419314
Switch to dh_gtkmodules for the gtk 2.10 transition

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Loïc Minier <lool@dooz.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Sat, 14 Apr 2007 23:33:43 +0200

Package: scim-gtk2-immodule
Version: 1.4.4-7
Severity: serious
Usertags: gtk-2.10-transition

        Hi,

 I've uploaded Gtk 2.10 to unstable and it changes ABI, which means that
 your package will not work with Gtk 2.10 as is.  The Gtk 2.10 package
 added conflicts with the above version of your package to prevent any
 problem, but you need to update your package to call the new
 dh_gtkmodules tool: this tool will add a virtual dependency on the gtk
 ABI via ${misc:Depends} to make the next transition easier -- only an
 automatic rebuild will be needed for the next transition.


 Updating your package should be relatively easy:

 1) Bump up the libgtk2.0-dev build-dep to >= 2.10.1-1.

 2) Call dh_gtkmodules on the package(s) shipping the module(s).
      If you build a library in the same source, you might need to set
      an appropriate LD_LIBRARY_PATH for dh_gtkmodules to work.

 3) Make sure you have ${misc:Depends} in the dependencies of the
    package(s) shipping the module(s); this should add a
    gtk2.0-binver-2.10.0 dependency.

 4) If your package ships "gdk-pixbuf loaders" modules or "input
    methods" modules:
    a) Make sure you ship the new /usr/lib/gtk-2.0/*/loader-files.d/*
       and/or /usr/lib/gtk-2.0/*/immodule-files.d/* lists.
    b) Remove any call to update-gdkpixbuf-loaders or
       update-gtk-immodules or anything touching files in /etc/gtk-2.0
       in your postinst/postrm/etc. scripts.

 Please ask me if anything above isn't clear!


 A concrete example of all the above changes (worst case) is libwmf;
 this is how the necessary changes look like:
    <http://lists.debian.org/debian-gtk-gnome/2006/10/msg00045.html>

   Bye,
-- 
Loïc Minier

Message #10 received at 419314@bugs.debian.org (full text, mbox, reply):

From: Ming Hua <minghua@rice.edu>

To: Loïc Minier <lool@dooz.org>, 419314@bugs.debian.org

Subject: Re: Bug#419314: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Sat, 14 Apr 2007 22:05:38 -0500

On Sat, Apr 14, 2007 at 11:33:43PM +0200, Loïc Minier wrote:
> 
>  Updating your package should be relatively easy:

Hi Loïc,

Thanks for your clear instructions and example, I've managed to finish
this GTK ABI transition for scim (source package of scim-gtk2-immodule),
and I think it's working well here.

I have one small question:  In the etch days, input method module
packages need to depend on libgtk2.0-bin to be able to call
/usr/sbin/update-gtk-immodules in their maintainer scripts reliably.
Now that the book-keeping mechanism is completely changed and
update-gtk-immodules is deprecated, do we still need to depend on
libgtk2.0-bin?

Thanks,
Ming
2007.04.14

Message #15 received at 419314@bugs.debian.org (full text, mbox, reply):

From: Loïc Minier <lool@dooz.org>

To: Ming Hua <minghua@rice.edu>

Cc: 419314@bugs.debian.org

Subject: Re: Bug#419314: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Sun, 15 Apr 2007 09:09:25 +0200

        Hi,

On Sat, Apr 14, 2007, Ming Hua wrote:
> I have one small question:  In the etch days, input method module
> packages need to depend on libgtk2.0-bin to be able to call
> /usr/sbin/update-gtk-immodules in their maintainer scripts reliably.
> Now that the book-keeping mechanism is completely changed and
> update-gtk-immodules is deprecated, do we still need to depend on
> libgtk2.0-bin?

 Good point, you don't need the libgtk2.0-bin dependency anymore.

   Bye,
-- 
Loïc Minier
"For subalterns, saying something intelligent is as risky as saying something
 stupid."

Message #20 received at 419314-quiet@bugs.debian.org (full text, mbox, reply):

From: Ming Hua <minghua@rice.edu>

To: Loïc Minier <lool@dooz.org>, 419314-quiet@bugs.debian.org

Subject: Re: Bug#419314: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Tue, 17 Apr 2007 03:14:12 -0500

[Message part 1 (text/plain, inline)]

On Sat, Apr 14, 2007 at 11:33:43PM +0200, Loïc Minier wrote:
> 
>  I've uploaded Gtk 2.10 to unstable and it changes ABI, which means that
>  your package will not work with Gtk 2.10 as is.

Hi Loïc,

I've prepared a new upload for scim that is compatible with the new GTK+
ABI and sent it to my sponsor, so this bug should be fixed soon.

As there are also other changes, and from bug #419366 I see that you
check the changes in the new uploads, I'll attach the GTK+ ABI
transition patch for your convenience.  You can also check it at
svn.debian.org [1], the relevant changes are r834 and r835.

1. http://svn.debian.org/wsvn/pkg-ime/scim/

Also the scim package has the same problem as gcin package, i.e.,
hardcoding the /usr/lib/gtk-2.0/2.10.0/ directory.  In scim this is
done in quite a few different places, and as I don't know much about
autotools, hardcoding is the easiest way for me.  If you think this is
very bad practice and can provide a patch, I'd be very happy to fix it.

Regards,
Ming
2007.04.17

[gtk-abi-transition.diff (text/x-diff, attachment)]

Message #25 received at 419314-quiet@bugs.debian.org (full text, mbox, reply):

From: Loïc Minier <lool@dooz.org>

To: Ming Hua <minghua@rice.edu>

Cc: 419314-quiet@bugs.debian.org

Subject: Re: Bug#419314: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Tue, 17 Apr 2007 13:19:25 +0200

[Message part 1 (text/plain, inline)]

On Tue, Apr 17, 2007, Ming Hua wrote:
> I've prepared a new upload for scim that is compatible with the new GTK+
> ABI and sent it to my sponsor, so this bug should be fixed soon.

 (Let me know if you need sponsoring.)

> As there are also other changes, and from bug #419366 I see that you
> check the changes in the new uploads, I'll attach the GTK+ ABI
> transition patch for your convenience.  You can also check it at
> svn.debian.org [1], the relevant changes are r834 and r835.

 Thanks; your patch seems correct.  Thank you for taking care of it so
 quickly.

> Also the scim package has the same problem as gcin package, i.e.,
> hardcoding the /usr/lib/gtk-2.0/2.10.0/ directory.  In scim this is
> done in quite a few different places, and as I don't know much about
> autotools, hardcoding is the easiest way for me.  If you think this is
> very bad practice and can provide a patch, I'd be very happy to fix it.

 Yes; the hardcoding comes from a Debian specific patch, but the
 upstream configure already defines "GTK_BINARY_VERSION", so it's not
 too intrusive to change.  I'm attaching you the updated patches and
 interdiff which I hacked starting from 1.4.4-7 (unstable), but it
 should apply to your SVN I suppose.  I also fixed debian/rules and
 debian/scim-gtk2-immodule.install again here.


 Could you try to bring this patch upstream?  Upstream should be
 installing in the ABI dependent dir anyway, otherwise their modules may
 break silently when the IM Module ABI changes.

-- 
Loïc Minier

[10_gtk-immodule-install-dir.dpatch (text/plain, attachment)]

[rules (text/plain, attachment)]

[changelog (text/plain, attachment)]

[11_relibtoolize.dpatch.gz (application/octet-stream, attachment)]

[scim-gtk2-immodule.install (text/plain, attachment)]

[scim_1.4.4-7.1.diff (text/x-diff, attachment)]

Message #30 received at 419314-close@bugs.debian.org (full text, mbox, reply):

From: Ming Hua <minghua@rice.edu>

To: 419314-close@bugs.debian.org

Subject: Bug#419314: fixed in scim 1.4.4-8

Date: Tue, 17 Apr 2007 16:47:04 +0000

Source: scim
Source-Version: 1.4.4-8

We believe that the bug you reported is fixed in the latest version of
scim, which is due to be installed in the Debian FTP archive:

libscim-dev_1.4.4-8_amd64.deb
  to pool/main/s/scim/libscim-dev_1.4.4-8_amd64.deb
libscim8c2a_1.4.4-8_amd64.deb
  to pool/main/s/scim/libscim8c2a_1.4.4-8_amd64.deb
scim-dev-doc_1.4.4-8_all.deb
  to pool/main/s/scim/scim-dev-doc_1.4.4-8_all.deb
scim-dev_1.4.4-8_all.deb
  to pool/main/s/scim/scim-dev_1.4.4-8_all.deb
scim-gtk2-immodule_1.4.4-8_amd64.deb
  to pool/main/s/scim/scim-gtk2-immodule_1.4.4-8_amd64.deb
scim-modules-socket_1.4.4-8_amd64.deb
  to pool/main/s/scim/scim-modules-socket_1.4.4-8_amd64.deb
scim_1.4.4-8.diff.gz
  to pool/main/s/scim/scim_1.4.4-8.diff.gz
scim_1.4.4-8.dsc
  to pool/main/s/scim/scim_1.4.4-8.dsc
scim_1.4.4-8_amd64.deb
  to pool/main/s/scim/scim_1.4.4-8_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 419314@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ming Hua <minghua@rice.edu> (supplier of updated scim package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 17 Apr 2007 02:26:48 -0500
Source: scim
Binary: scim-dev libscim-dev libscim8c2a scim-modules-socket scim-dev-doc scim-gtk2-immodule scim
Architecture: source all amd64
Version: 1.4.4-8
Distribution: unstable
Urgency: low
Maintainer: Ming Hua <minghua@rice.edu>
Changed-By: Ming Hua <minghua@rice.edu>
Description: 
 libscim-dev - development library for SCIM platform
 libscim8c2a - library for SCIM platform
 scim       - smart common input method platform
 scim-dev   - development files for SCIM platform
 scim-dev-doc - development documentation for SCIM platform
 scim-gtk2-immodule - GTK+2 input method module with SCIM as backend
 scim-modules-socket - socket modules for SCIM platform
Closes: 419314
Changes: 
 scim (1.4.4-8) unstable; urgency=low
 .
   The "etch is released, welcome lenny" release.
 .
   * Rewrite debian/rules.
     - Use the platform detection code recommended by autotools-dev.
     - Drop unused "-W -g" compiler flags.
     - Do not use binary-common target anymore and separate binary-arch and
       binary-indep target completely.
     - Add more safeguarding code to detect building errors.
     - Finally remove all the cruft introduced by dh_make.
   * Adapt to GTK+ 2.10 ABI change.  (Closes: 419314)
     - Install GTK IM module into /usr/lib/gtk-2.0/2.10.0/immodules.
     - Bump libgtk2.0-dev build dependency to >= 2.10.1-1.
     - Use dh_gtkmodules in debian/rules instead of calling
       update-gtk-immodules in maintainer scripts.  The postinst and postrm
       scripts for scim-gtk2-immodule are empty now and therefore removed.
     - Add ${misc:Depends} to scim-gtk2-immodule's dependency list, and remove
       libgtk2.0-bin.
   * Update debian/watch file to format version 3 and use qa.debian.org
     redirector for sourceforge.net.
   * Drop libxt-dev in build dependency as it's not necessary anymore after
     relibtoolization.
Files: 
 09777ce4d6cce0a1c5cfb2be77e8c45f 771 utils optional scim_1.4.4-8.dsc
 d32926cc4f2020f829ea83e05be6197c 211834 utils optional scim_1.4.4-8.diff.gz
 6fa8d1fefd74f3598138f86133c76211 838634 utils optional scim_1.4.4-8_amd64.deb
 2c5beda427c28fbc506139e4ee7652d3 379520 libs optional libscim8c2a_1.4.4-8_amd64.deb
 c4842375fd13e37e685a815a872dfae2 575204 libdevel optional libscim-dev_1.4.4-8_amd64.deb
 9413a706b4952aedd510cf3a64c7de6f 96484 utils optional scim-gtk2-immodule_1.4.4-8_amd64.deb
 c3bbb1bd1f2218ecf953409445223b32 114114 utils optional scim-modules-socket_1.4.4-8_amd64.deb
 807ada2c763d93de3c8d8849ea2b868d 44740 devel optional scim-dev_1.4.4-8_all.deb
 0b221cc0723b4be667ec8f4a28b1408c 996120 doc optional scim-dev-doc_1.4.4-8_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGJPid6A/EwagGHzIRAhg6AJ0aGEB3FClhhoVqBeVtCZly0IPv2wCeOHNM
MNMVlcI0WQG4O46TvZTnEEM=
=DlSd
-----END PGP SIGNATURE-----

Message #35 received at 419314-quiet@bugs.debian.org (full text, mbox, reply):

From: Ming Hua <minghua@rice.edu>

To: Loïc Minier <lool@dooz.org>

Cc: 419314-quiet@bugs.debian.org

Subject: Re: Bug#419314: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Thu, 19 Apr 2007 23:27:28 -0500

On Tue, Apr 17, 2007 at 01:19:25PM +0200, Loïc Minier wrote:
> On Tue, Apr 17, 2007, Ming Hua wrote:
> > I've prepared a new upload for scim that is compatible with the new GTK+
> > ABI and sent it to my sponsor, so this bug should be fixed soon.
> 
>  (Let me know if you need sponsoring.)

It has be uploaded, but your offer is still appreciated.

> > Also the scim package has the same problem as gcin package, i.e.,
> > hardcoding the /usr/lib/gtk-2.0/2.10.0/ directory.  In scim this is
> > done in quite a few different places, and as I don't know much about
> > autotools, hardcoding is the easiest way for me.  If you think this is
> > very bad practice and can provide a patch, I'd be very happy to fix it.
> 
>  Yes; the hardcoding comes from a Debian specific patch, but the
>  upstream configure already defines "GTK_BINARY_VERSION", so it's not
>  too intrusive to change.  I'm attaching you the updated patches and
>  interdiff which I hacked starting from 1.4.4-7 (unstable), but it
>  should apply to your SVN I suppose.  I also fixed debian/rules and
>  debian/scim-gtk2-immodule.install again here.

Thanks a lot for this quick and nice patch!  I now have a good idea
about what should be done here to get rid of the hardcoding.  As there
has been a new upstream release and I plan to do a new upload soon, I'll
incorporate your patch on the new upstream upload.

>  Could you try to bring this patch upstream?  Upstream should be
>  installing in the ABI dependent dir anyway, otherwise their modules may
>  break silently when the IM Module ABI changes.

Upstream is aware of this issue.  And IIRC there was discussion about
this but I forgot the details.  I'll see what I can do.

Ming
2007.04.19

Message #40 received at 419314@bugs.debian.org (full text, mbox, reply):

From: Loïc Minier <lool@dooz.org>

To: Ming Hua <minghua@rice.edu>

Cc: 419314@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#419314: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Sun, 22 Apr 2007 19:52:51 +0200

clone 419314 -1
severity -1 important
retitle -1 Hardcoded Gtk+ module ABI version in debian/patches/10_gtk-immodule-install-dir.dpatch
found -1 1.4.4-8
stop

On Thu, Apr 19, 2007, Ming Hua wrote:
> Thanks a lot for this quick and nice patch!  I now have a good idea
> about what should be done here to get rid of the hardcoding.  As there
> has been a new upstream release and I plan to do a new upload soon, I'll
> incorporate your patch on the new upstream upload.

 Cool; I'm afraid it might not apply cleanly to the SVN: I tried and it
 failed, but it shouldn't be too hard to update it.

 I'm cloning the original bug to track the remaining issue.

   Bye,
-- 
Loïc Minier

Message #47 received at 419314-quiet@bugs.debian.org (full text, mbox, reply):

From: Loïc Minier <lool@dooz.org>

To: Ming Hua <minghua@rice.edu>

Cc: 419314-quiet@bugs.debian.org

Subject: Re: Bug#419314: Switch to dh_gtkmodules for the gtk 2.10 transition

Date: Sun, 22 Apr 2007 20:33:07 +0200

On Tue, Apr 17, 2007, Ming Hua wrote:
> Also the scim package has the same problem as gcin package, i.e.,
> hardcoding the /usr/lib/gtk-2.0/2.10.0/ directory.

 Thanks; I've filed a bug against gcin.

-- 
Loïc Minier

Send a report that this bug log contains spam.