Debian Bug report logs - #406491
oops: FTBFS with glibc2.5 - rwlock implementation related

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@tauware.de>

To: submit@bugs.debian.org

Cc: emmet.hikory@gmail.com

Subject: Build failure of oops 1.5.23.cvs-3

Date: Thu, 11 Jan 2007 16:12:22 +0100

[Message part 1 (text/plain, inline)]

Package: glibc
Version: 2.5-0exp3

Please see the forwarded email from Emmet Hikory. He tried to build oops
with glibc 2.5, which is default in ubuntu/feisty. He confirmed that
this problem does also occur with glibc from debian/experimental, in an
sid chroot.

I'm not sure what the problem is, and am therefore requesting your input.

[Message part 2 (application/pgp-signature, inline)]

[Message part 3 (message/rfc822, inline)]

From: "Emmet Hikory" <emmet.hikory@gmail.com>

Subject: Re: Build failure of oops 1.5.23.cvs-3 on feisty

[Message part 4 (text/plain, inline)]

Reinhard Tartler <siretart@tauware.de> wrote:
> thanks for the buildlog. In debian, the build is fine:
>
> http://buildd.debian.org/fetch.cgi?pkg=oops;ver=1.5.23.cvs-3;arch=amd64;stamp=1142759810

[...]

Towards furthering the resolution of the FTBFS, I used the sid-source
chroot on the lvm to build oops 1.5.23.cvs-3, which worked fine.  I
then downloaded and installed four additional packages from
ftp.debian.org:

libc6-dev_2.5-0exp3_amd64.deb
libc6_2.5-0exp3_amd64.deb
locales_2.5-0exp3_all.deb
nscd_2.5-0exp3_amd64.deb

Still within the chroot (now sid+experimental glibc), I removed the
last build, re-ran dpkg-source -x, and again ran debuid, resuling in a
buildlog (attached) that looks very simiar to that from feisty,
reinforcing my opinion that it is due to the 2.3->2.5 transition.

[...]

-- 
Emmet HIKORY

[oops_1.5.23.cvs-3_amd64.build (application/octet-stream, attachment)]

[Message part 6 (text/plain, inline)]

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

Message #10 received at 406491@bugs.debian.org (full text, mbox, reply):

From: Aurelien Jarno <aurelien@aurel32.net>

To: Reinhard Tartler <siretart@tauware.de>, 406491@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#406491: Build failure of oops 1.5.23.cvs-3

Date: Fri, 12 Jan 2007 00:16:58 +0100

[Message part 1 (text/plain, inline)]

reassign 406491 oops
found 406491 1.5.23.cvs-3
retitle 406491 oops: should not use its own rwlock implementation
tag 406491 + patch
thanks

Reinhard Tartler a écrit :
> Package: glibc
> Version: 2.5-0exp3
> 
> Please see the forwarded email from Emmet Hikory. He tried to build oops
> with glibc 2.5, which is default in ubuntu/feisty. He confirmed that
> this problem does also occur with glibc from debian/experimental, in an
> sid chroot.
> 
> I'm not sure what the problem is, and am therefore requesting your input.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Sujet:
> Re: Build failure of oops 1.5.23.cvs-3 on feisty
> Expéditeur:
> "Emmet Hikory" <emmet.hikory@gmail.com>
> 
> 
> Reinhard Tartler <siretart@tauware.de> wrote:
>> thanks for the buildlog. In debian, the build is fine:
>>
>> http://buildd.debian.org/fetch.cgi?pkg=oops;ver=1.5.23.cvs-3;arch=amd64;stamp=1142759810
> 
> [...]
> 
> Towards furthering the resolution of the FTBFS, I used the sid-source
> chroot on the lvm to build oops 1.5.23.cvs-3, which worked fine.  I
> then downloaded and installed four additional packages from
> ftp.debian.org:
> 
> libc6-dev_2.5-0exp3_amd64.deb
> libc6_2.5-0exp3_amd64.deb
> locales_2.5-0exp3_all.deb
> nscd_2.5-0exp3_amd64.deb
> 
> Still within the chroot (now sid+experimental glibc), I removed the
> last build, re-ran dpkg-source -x, and again ran debuid, resuling in a
> buildlog (attached) that looks very simiar to that from feisty,
> reinforcing my opinion that it is due to the 2.3->2.5 transition.

The glibc implementation of rwlock has changed between version 2.3.6 and
2.5, but not the API. Oops is currenly using its own copy of the rwlock
implementation, accessing directly to the internal variables.

It should instead use the glibc implementation. For that you should use
-D_BSD_SOURCE -D_XOPEN_SOURCE=600, as defined in the XG6 standard.

Please see the attached patch.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

[oops.patch (text/x-patch, inline)]

diff -u oops-1.5.23.cvs/configure oops-1.5.23.cvs/configure
--- oops-1.5.23.cvs/configure
+++ oops-1.5.23.cvs/configure
@@ -5517,7 +5517,7 @@
 	  LIBS="$LEXLIB $LIBS"
 	  CXX=g++
 	  ;;
-gnu*|linux*)   CFLAGS="$CFLAGS -D_REENTRANT -DLINUX"
+gnu*|linux*)   CFLAGS="$CFLAGS -D_REENTRANT -DLINUX -D_XOPEN_SOURCE=600 -D_BSD_SOURCE"
 	  CXX=g++
 	  if test "$pthread_in" = "pthreads" ; then
 		CFLAGS="$CFLAGS -D_MIT_POSIX_THREADS"
@@ -6074,13 +6074,6 @@
 esac
 
 case "$host_os" in
-gnu*|linux*)
-    EXTRASRC="$EXTRASRC rwlock.c" ;
-    cd src;
-    cp -f lib/rwlock/rwlock.c ./;
-    cp -f lib/rwlock/rwlock.h ./;
-    cd ..
-    ;;
 freebsd*)
     cat >>confdefs.h <<\_ACEOF
 #define HAVE_PTHREAD_RWLOCK_INIT 1
diff -u oops-1.5.23.cvs/configure.in oops-1.5.23.cvs/configure.in
--- oops-1.5.23.cvs/configure.in
+++ oops-1.5.23.cvs/configure.in
@@ -358,7 +358,7 @@
 	  LIBS="$LEXLIB $LIBS"
 	  CXX=g++
 	  ;;
-gnu*|linux*)   CFLAGS="$CFLAGS -D_REENTRANT -DLINUX"
+gnu*|linux*)   CFLAGS="$CFLAGS -D_REENTRANT -DLINUX -D_XOPEN_SOURCE=600 -D_BSD_SOURCE"
 	  CXX=g++
 	  if test "$pthread_in" = "pthreads" ; then
 		CFLAGS="$CFLAGS -D_MIT_POSIX_THREADS"
@@ -492,13 +492,6 @@
 esac
 
 case "$host_os" in
-gnu*|linux*)
-    EXTRASRC="$EXTRASRC rwlock.c" ; 
-    cd src;
-    cp -f lib/rwlock/rwlock.c ./;
-    cp -f lib/rwlock/rwlock.h ./; 
-    cd ..
-    ;;
 freebsd*)
     AC_DEFINE(HAVE_PTHREAD_RWLOCK_INIT)
     ;;

Message #23 received at 406491@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@tauware.de>

To: Aurelien Jarno <aurelien@aurel32.net>

Cc: 406491@bugs.debian.org

Subject: Re: Bug#406491: Build failure of oops 1.5.23.cvs-3

Date: Fri, 12 Jan 2007 10:52:18 +0100

[Message part 1 (text/plain, inline)]

Aurelien Jarno <aurelien@aurel32.net> writes:

> The glibc implementation of rwlock has changed between version 2.3.6 and
> 2.5, but not the API. Oops is currenly using its own copy of the rwlock
> implementation, accessing directly to the internal variables.
>
> It should instead use the glibc implementation. For that you should use
> -D_BSD_SOURCE -D_XOPEN_SOURCE=600, as defined in the XG6 standard.
>
> Please see the attached patch.

Thank you very much, I just uploaded a modified one, which applies to
configure.in instead. (had to reinvoke autoconf of course).

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

[Message part 2 (application/pgp-signature, inline)]

Message #28 received at 406491-close@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@tauware.de>

To: 406491-close@bugs.debian.org

Subject: Bug#406491: fixed in oops 1.5.23.cvs-4

Date: Fri, 12 Jan 2007 10:02:17 +0000

Source: oops
Source-Version: 1.5.23.cvs-4

We believe that the bug you reported is fixed in the latest version of
oops, which is due to be installed in the Debian FTP archive:

oops_1.5.23.cvs-4.diff.gz
  to pool/main/o/oops/oops_1.5.23.cvs-4.diff.gz
oops_1.5.23.cvs-4.dsc
  to pool/main/o/oops/oops_1.5.23.cvs-4.dsc
oops_1.5.23.cvs-4_amd64.deb
  to pool/main/o/oops/oops_1.5.23.cvs-4_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 406491@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Reinhard Tartler <siretart@tauware.de> (supplier of updated oops package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 12 Jan 2007 08:49:04 +0000
Source: oops
Binary: oops
Architecture: source amd64
Version: 1.5.23.cvs-4
Distribution: unstable
Urgency: low
Maintainer: Michael Zehrer <zehrer@zepan.org>
Changed-By: Reinhard Tartler <siretart@tauware.de>
Description: 
 oops       - caching HTTP proxy server written for performance
Closes: 406491
Changes: 
 oops (1.5.23.cvs-4) unstable; urgency=low
 .
   * Don't use internal rwlock implementation. Use the one in glibc, which
     fixes FTBFS with glibc 2.5 and Closes: #406491
   * therefore regenerate ./configure with autoconf 2.61
   * update config.{guess,sub}
   * small cleanups to debian/rules
   * use dh_installman instead of dh_installmanpages
   * add po-debconf to build-depends
   * make Init Script LSB-compliant, See
     http://wiki.debian.org/LSBInitScripts and Policy 9.3.2
   * preinst: use invoke-rc.d (policy 9.3.3.2)
   * with the above changes, bump Standards Version to 3.7.2.2
Files: 
 ec49f23e35fa48fe26b4ea426372fdd6 737 web optional oops_1.5.23.cvs-4.dsc
 34b801178f0364c59055f29e49faaf14 101889 web optional oops_1.5.23.cvs-4.diff.gz
 d60d5658c7bb3bf4bb84588a3246ce3d 334432 web optional oops_1.5.23.cvs-4_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Debian Powered!

iD8DBQFFp1h3mAg1RJRTSKQRAh8TAJ9TDi6sbjmtLWTDaIXB0QheIZhBZgCfR1LE
Itf1MO6Pt/3JPAKiS8CS3OM=
=elvn
-----END PGP SIGNATURE-----

Message #33 received at 406491@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@tauware.de>

To: Max Kutny <mkut@umc.com.ua>

Cc: 406972@bugs.debian.org, 406491@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#406972: oops: constantly aborts

Date: Tue, 16 Jan 2007 08:51:14 +0100

reopen 406491
severity 406491 serious
severity 406972 serious
merge 406972 406491
found 406491 1.5.23.cvs-4
found 406972 1.5.23.cvs-4
retitle 406491 oops: FTBFS with glibc2.5 - rwlock implementation related
stop

Max Kutny <mkut@umc.com.ua> writes:
> Err. Sorry for misleading but I meant that it pesists the way I
> initially described it (1.5.23.cvs-3 is ok and 1.5.23.cvs-4 fails).

Ah, okay. Thank you very much for your diagnostics, they were really
helpful! The only change is the change of the rwlock implementation,
which was switched from -3 to -4. This means that further investigation
is needed, most probably we need upstream input on this.

I think I'll make an upload soon and revert the patch from -5. Until
then I keep this bug RC, with the knowledge that the etch version (-3)
is not affected by this. 

Thomas, how do you feel about this?

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

Message #62 received at 406491-done@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@debian.org>

To: 406491-done@bugs.debian.org, 101772-done@bugs.debian.org, 103642-done@bugs.debian.org, 104390-done@bugs.debian.org, 106691-done@bugs.debian.org, 137444-done@bugs.debian.org, 406724-done@bugs.debian.org, 426971-done@bugs.debian.org, 194712-done@bugs.debian.org, 413223-done@bugs.debian.org, 171376-done@bugs.debian.org

Subject: Closing old 'oops' bugs

Date: Wed, 10 Oct 2007 07:27:45 +0200

Package: oops

Dear submitter,

Oops has been removed from debian/unstable on 19 Aug 2007 as documented
in http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=438648. I'm
therefore closing the bugs as directed by the removal notification.

Thanks again for your interest in the oops package. I'm sorry that this
package was in such a bad shape, therefore I think removing it was the
best way to deal with the package.


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

Send a report that this bug log contains spam.