Debian Bug report logs - #402715
gnome-hearts crashes on startup

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Torbj|rn Andersson <d91tan@Update.UU.SE>

To: submit@bugs.debian.org

Subject: gnome-hearts crashes on startup

Date: Tue, 12 Dec 2006 09:58:10 +0100 (CET)

[Message part 1 (text/plain, inline)]

Package: gnome-hearts
Version: 0.1.3-1
Severity: grave

Hi,

I've already commented on this in bug #396043, but I'm afraid that it will 
get lost there, what with the Etch freeze, and my problem doesn't appear 
to be quite the same as that one anyway (though it may have been 
introduced by the fix for it).

Basically, as soon as I try to start gnome-hearts, it crashes, rendering 
the package completely unusable for me. The reason for the crash appears 
to be the way load_card_styles() in hearts.c works. It assembles a hash 
table of all the available card styles, and then calls:

    g_hash_table_foreach(game_card_styles, card_style_add, NULL);

This NULL pointer is passed as the 'first_style' parameter to 
card_style_add(), where it's dereferenced like this:

    if (*first_style == NULL)
        *first_style = g_string_new(value);

This, of course, causes a crash. So what it probably *should* say 
instead is something like this:

    g_hash_table_foreach(game_card_style, card_style_add, &first_style);

Incidentally, this is pretty much what it says in the original version of 
card_style_add(), before the Debian-specific patches have been applied, 
except that card_style_add is cast to a GHFunc. The patched line is 
identical to what it looked like in 0.1.2, though, so I guess the Debian 
patch just wasn't correctly updated to 0.1.3.

Sincerely,

Torbjörn Andersson

Message #10 received at 402715@bugs.debian.org (full text, mbox, reply):

From: Sander Marechal <s.marechal@jejik.com>

To: Torbj|rn Andersson <d91tan@Update.UU.SE>, 402715@bugs.debian.org

Subject: Re: Bug#402715: gnome-hearts crashes on startup

Date: Tue, 12 Dec 2006 23:44:25 +0100

Torbj|rn Andersson wrote:
> Package: gnome-hearts
> Version: 0.1.3-1
> Severity: grave
> 
> Hi,
> 
> I've already commented on this in bug #396043, but I'm afraid that it
> will get lost there, what with the Etch freeze

Nope, I spotted it. I just didn't have time to figure it all out.

> Incidentally, this is pretty much what it says in the original version
> of card_style_add(), before the Debian-specific patches have been
> applied, except that card_style_add is cast to a GHFunc. The patched
> line is identical to what it looked like in 0.1.2, though, so I guess
> the Debian patch just wasn't correctly updated to 0.1.3.

That's indeed what happened. And I didn't catch it earlier because my
personal apt repository overrides the standard one's. Oops... I'm
building gnome-hearts-0.1.3-2 with a corrected Debian patch as I'm
writing this.

Thanks for the report!

-- 
Sander Marechal

Message #15 received at 402715-close@bugs.debian.org (full text, mbox, reply):

From: Loic Minier <lool@dooz.org>

To: 402715-close@bugs.debian.org

Subject: Bug#402715: fixed in gnome-hearts 0.1.3-2

Date: Tue, 12 Dec 2006 23:47:04 +0000

Source: gnome-hearts
Source-Version: 0.1.3-2

We believe that the bug you reported is fixed in the latest version of
gnome-hearts, which is due to be installed in the Debian FTP archive:

gnome-hearts_0.1.3-2.diff.gz
  to pool/main/g/gnome-hearts/gnome-hearts_0.1.3-2.diff.gz
gnome-hearts_0.1.3-2.dsc
  to pool/main/g/gnome-hearts/gnome-hearts_0.1.3-2.dsc
gnome-hearts_0.1.3-2_i386.deb
  to pool/main/g/gnome-hearts/gnome-hearts_0.1.3-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 402715@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Loic Minier <lool@dooz.org> (supplier of updated gnome-hearts package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 13 Dec 2006 00:29:47 +0100
Source: gnome-hearts
Binary: gnome-hearts
Architecture: source i386
Version: 0.1.3-2
Distribution: unstable
Urgency: high
Maintainer: Sander Marechal <s.marechal@jejik.com>
Changed-By: Loic Minier <lool@dooz.org>
Description: 
 gnome-hearts - The classic hearts card game for the GNOME desktop
Closes: 402715
Changes: 
 gnome-hearts (0.1.3-2) unstable; urgency=high
 .
   [ Sander Marechal ]
   * Fixed the 01_gnome_cards_data.patch. Closes: #402715
 .
   [ Loic Minier ]
   * Urgency high for RC fix.
Files: 
 7b0389756ca5c175f3c638f5e287e0f3 1571 games optional gnome-hearts_0.1.3-2.dsc
 8eec14ff0743b01b2be759b1622d4848 198285 games optional gnome-hearts_0.1.3-2.diff.gz
 79b12c7d59c965a664df35c14c44bc69 109294 games optional gnome-hearts_0.1.3-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFFfzwo4VUX8isJIMARAun3AKCiFFOLo0r9MEKP8KSWgBNjWYvMhwCfYUNQ
gNJc4ptSRVwUlLjP+PNAnlo=
=v4yo
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.