Debian Bug report logs - #401066
php5: Please patch PHP to add a mail header when sending mail

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alberto Gonzalez Iniesta <agi@inittab.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: php5: Please patch PHP to add a mail header when sending mail

Date: Thu, 30 Nov 2006 18:11:23 +0100

Package: php5
Severity: wishlist
Tags: patch

We all know PHP is (ab)used by many developers with not all the care and
experience one would want. Since PHP under Debian is widely used in
multi hosting enviroments, one of the common headaches of these sites
sysadmins is controling which site is being abused to send SPAM.

There's a patch [1] that adds and extra header to the mails sent from
PHP, with all the info required (server name, script name, remote addr)
to track the origin of the mail. This patch will help A LOT Debian
admins/users with PHP scripts that send mail.

Please consider adding this patch to PHP4/5 for etch.

Thanks,

Alberto


[1] http://choon.net/php-mail-header.php


-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18.1
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Message #10 received at 401066@bugs.debian.org (full text, mbox, reply):

From: Ondřej Surý <ondrej@sury.org>

To: 401066@bugs.debian.org

Subject: Re: Bug#401066: php5: Please patch PHP to add a mail header when sending mail

Date: Thu, 30 Nov 2006 18:48:36 +0100

Hi agi,

Alberto Gonzalez Iniesta píše v Čt 30. 11. 2006 v 18:10 +0100:
> Package: php4
> Severity: wishlist
> Tags: patch
> 
> 
> We all know PHP is (ab)used by many developers with not all the care and
> experience one would want. Since PHP under Debian is widely used in
> multi hosting enviroments, one of the common headaches of these sites
> sysadmins is controling which site is being abused to send SPAM.
> 
> There's a patch [1] that adds and extra header to the mails sent from
> PHP, with all the info required (server name, script name, remote addr)
> to track the origin of the mail. This patch will help A LOT Debian
> admins/users with PHP scripts that send mail.
> 
> Please consider adding this patch to PHP4/5 for etch.

idea in the patch is perfect, but I have two objections for adding this
patch to debian PHP.

Firstly I consider this as big intrusion into privacy of users, so I
think it has to be configurable and it has to default to off, so it's up
to each individual administrator to enable/disable this feature.

My second objection is that I do not consider programming style of:

while (1) {
 if (condition)
   break;
 if (condition)
   break;
}

appropriate for C code and I think it needs rewrite to some more normal
programming style.  PHP is broken enough as is.

After that I would be more then happy to add this patch to both php4 and
php5 in debian.

However I am unable to promise that I will make time and rewrite this
patch to include those two things.

Ondrej.
-- 
Ondřej Surý <ondrej@sury.org> ^_^ http://blog.rfc1925.org/

Message #15 received at 401066@bugs.debian.org (full text, mbox, reply):

From: "Krasimir Ganchev" <jeronimo@fixity.net>

To: <401066@bugs.debian.org>

Subject: Re: Bug#401066: php5: Please patch PHP to add a mail header when sending mail

Date: Mon, 14 Dec 2009 17:07:14 +0200

mail() function logging has been added to PHP code since version 5.3.0. http://php.net/manual/en/mail.configuration.php

It is configured by two additional configuration directives and is fairly nice written.

The patch should be backwards compatible for PHP 5.2 so it could be applied to the current 5.2.x version distributed in testing/unstable. The source could be found at http://news.php.net/php.cvs/55496


Regards,
Krasimir Ganchev

Message #20 received at 401066@bugs.debian.org (full text, mbox, reply):

From: Raphael Geissert <geissert@debian.org>

To: Krasimir Ganchev <jeronimo@fixity.net>, 401066@bugs.debian.org

Subject: Re: [php-maint] Bug#401066: php5: Please patch PHP to add a mail header when sending mail

Date: Mon, 14 Dec 2009 09:34:38 -0600

2009/12/14 Krasimir Ganchev <jeronimo@fixity.net>:
> mail() function logging has been added to PHP code since version 5.3.0. http://php.net/manual/en/mail.configuration.php
>
> It is configured by two additional configuration directives and is fairly nice written.
>
> The patch should be backwards compatible for PHP 5.2 so it could be applied to the current 5.2.x version distributed in testing/unstable. The source could be found at http://news.php.net/php.cvs/55496
>
>

I'm personally not keen on this kind of "features" and they tend to
introduce more bugs and information leaks. As such, I won't be working
on it and I hope anyone who may want to work on it to fully understand
the consequences be willing to give full support.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

Message #25 received at 401066@bugs.debian.org (full text, mbox, reply):

From: "Krasimir Ganchev" <jeronimo@fixity.net>

To: "'Raphael Geissert'" <geissert@debian.org>, <401066@bugs.debian.org>

Subject: RE: [php-maint] Bug#401066: php5: Please patch PHP to add a mail header when sending mail

Date: Mon, 14 Dec 2009 18:54:06 +0200

Raphael I understand your point and it's nothing wrong with that
but please note that this is official code not a third party patch.
It is part of PHP 5.3.0 code and a useful feature for some admins.

Regards,
Krasimir Ganchev


-----Original Message-----
From: atomo64@gmail.com [mailto:atomo64@gmail.com] On Behalf Of Raphael Geissert
Sent: Monday, December 14, 2009 5:35 PM
To: Krasimir Ganchev; 401066@bugs.debian.org
Subject: Re: [php-maint] Bug#401066: php5: Please patch PHP to add a mail header when sending mail

2009/12/14 Krasimir Ganchev <jeronimo@fixity.net>:
> mail() function logging has been added to PHP code since version 5.3.0. http://php.net/manual/en/mail.configuration.php
>
> It is configured by two additional configuration directives and is fairly nice written.
>
> The patch should be backwards compatible for PHP 5.2 so it could be applied to the current 5.2.x version distributed in testing/unstable. The source could be found at http://news.php.net/php.cvs/55496
>
>

I'm personally not keen on this kind of "features" and they tend to
introduce more bugs and information leaks. As such, I won't be working
on it and I hope anyone who may want to work on it to fully understand
the consequences be willing to give full support.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net

Message #30 received at 401066-done@bugs.debian.org (full text, mbox, reply):

From: Thijs Kinkhorst <thijs@debian.org>

To: Krasimir Ganchev <jeronimo@fixity.net>, 401066-done@bugs.debian.org

Subject: Re: [php-maint] Bug#401066: Bug#401066: php5: Please patch PHP to add a mail header when sending mail

Date: Wed, 30 Dec 2009 17:26:49 +0100

Version: 5.3.0-1

On moandei 14 Desimber 2009, Krasimir Ganchev wrote:
> Raphael I understand your point and it's nothing wrong with that
> but please note that this is official code not a third party patch.
> It is part of PHP 5.3.0 code and a useful feature for some admins.

I would suggest to just wait until 5.3 enters sid then. Marking as fixed per 
that version.


Thijs

Send a report that this bug log contains spam.