Debian Bug report logs - #400874
apt-get: glibc detected: double free or corruption

version graph

Package: apt; Maintainer for apt is APT Development Team <deity@lists.debian.org>; Source for apt is src:apt (PTS, buildd, popcon).

Reported by: Andreas Barth <aba@not.so.argh.org>

Date: Wed, 29 Nov 2006 10:33:06 UTC

Severity: grave

Tags: patch

Found in version apt/0.6.46.2

Fixed in versions apt/0.6.46.3-0.1, apt/0.6.46.4

Done: Michael Vogt <mvo@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Barth <aba@not.so.argh.org>:
New Bug report received and forwarded. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
To: submit@bugs.debian.org
Subject: apt-get: glibc detected: double free or corruption
Date: Wed, 29 Nov 2006 11:19:51 +0100
Package: apt
Severity: grave
Version: 0.6.46.2

Hi,

on my freshly installed etch amd64-system, I get this error now:

aba@auxo:~$ apt-get source php-imagick
Reading package lists... Done
Building dependency tree... Done
*** glibc detected *** double free or corruption (!prev): 0x00000000005b0980 ***
Aborted

The same happens with apt-get source bash. My /etc/apt/sources.list
contains:
deb http://ftp2.de.debian.org/debian etch main
deb-src http://ftp2.de.debian.org/debian etch main
deb-src http://ftp2.de.debian.org/debian sid main

Any hints for me?


Cheers,
Andi
-- 
  http://home.arcor.de/andreas-barth/



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Barth <aba@not.so.argh.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #10 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
To: 400874@bugs.debian.org
Subject: valgrind output
Date: Wed, 29 Nov 2006 11:40:08 +0100
Hi,

valgrind gives these issues during running apt-get source php-imagick.

Cheers,
Andi

==11369== Invalid write of size 1
==11369==    at 0x4A1CDA0: strcpy (mc_replace_strmem.c:272)
==11369==    by 0x4BB97B4: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==  Address 0x6BD0E1D is 0 bytes after a block of size 10,541 alloc'd
==11369==    at 0x4A1BD09: operator new[](unsigned long) (vg_replace_malloc.c:199)
==11369==    by 0x4BB9814: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==
==11369== Invalid read of size 1
==11369==    at 0x4A1C713: strlen (mc_replace_strmem.c:246)
==11369==    by 0x4B477FB: TokSplitString(char, char*, char**, unsigned long) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4BB97C9: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==  Address 0x6BD0E1D is 0 bytes after a block of size 10,541 alloc'd
==11369==    at 0x4A1BD09: operator new[](unsigned long) (vg_replace_malloc.c:199)
==11369==    by 0x4BB9814: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==
==11369== Invalid write of size 1
==11369==    at 0x4B47884: TokSplitString(char, char*, char**, unsigned long) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4BB97C9: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==  Address 0x6BD0E1D is 0 bytes after a block of size 10,541 alloc'd
==11369==    at 0x4A1BD09: operator new[](unsigned long) (vg_replace_malloc.c:199)
==11369==    by 0x4BB9814: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==
==11369== Mismatched free() / delete / delete []
==11369==    at 0x4A1B17F: operator delete(void*) (vg_replace_malloc.c:244)
==11369==    by 0x4BB97DA: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==  Address 0x6BCE4F0 is 0 bytes inside a block of size 10,541 alloc'd
==11369==    at 0x4A1BD09: operator new[](unsigned long) (vg_replace_malloc.c:199)
==11369==    by 0x4BB9814: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==
==11369== Invalid read of size 1
==11369==    at 0x4A1C7D4: strcmp (mc_replace_strmem.c:341)
==11369==    by 0x4B802AD: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
==11369==  Address 0x6BCE4F0 is 0 bytes inside a block of size 10,541 free'd
==11369==    at 0x4A1B17F: operator delete(void*) (vg_replace_malloc.c:244)
==11369==    by 0x4BB97DA: debSrcRecordParser::Binaries() (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x4B8027F: pkgSrcRecords::Find(char const*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407CA5: (within /usr/bin/apt-get)
==11369==    by 0x408CDA: (within /usr/bin/apt-get)
==11369==    by 0x4B530A9: CommandLine::DispatchArg(CommandLine::Dispatch*, bool) (in /usr/lib/libapt-pkg-libc6.3-6.so.3.11.0)
==11369==    by 0x407869: (within /usr/bin/apt-get)
==11369==    by 0x51934C9: (below main) (in /lib/libc-2.3.6.so)
-- 
  http://home.arcor.de/andreas-barth/



Message sent on to Andreas Barth <aba@not.so.argh.org>:
Bug#400874. (full text, mbox, link).


Message #13 received at 400874-submitter@bugs.debian.org (full text, mbox, reply):

From: Filipus Klutiero <philippe.cloutier.2@ulaval.ca>
To: 400874-submitter@bugs.debian.org
Subject: grave?
Date: Wed, 29 Nov 2006 08:25:07 -0500
Hi Andreas,
I am unable to reproduce on my Etch box. Please justify grave severity.



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Barth <aba@not.so.argh.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #18 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
To: 400874@bugs.debian.org
Subject: Re: Bug#400874: grave?
Date: Wed, 29 Nov 2006 15:24:54 +0100
* Filipus Klutiero (philippe.cloutier.2@ulaval.ca) [061129 14:37]:
> I am unable to reproduce on my Etch box. Please justify grave severity.

I know of a second person who had the same issues, that is Michael
Ablassmeier. I guess it is connected with the exact content of the
source lists for today.

I put the contents of my /var/lib/apt/lists-directory to
http://alius.turmzimmer.net/~aba/broken-var-lib-apt-lists.tgz - it is
too large to attach it IMHO.

Cheers,
Andi
-- 
  http://home.arcor.de/andreas-barth/



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Michael Ablassmeier <abi@grinser.de>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #23 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Michael Ablassmeier <abi@grinser.de>
To: 400874@bugs.debian.org
Subject: reproducible for me
Date: Wed, 29 Nov 2006 16:28:21 +0100
hi,

like Andreas already mentioned, im capable of reproducing this failure
on my (unstable) amd64 system. I apt-get sourced something on Monday and
it worked for me, so this problem appeared yesterday or today.

You can download my /var/lib/apt/lists aswell from:

 http://www.grinser.de/~abi/lists.tar.gz (a5b22431ef8ed0ccd6cc952df6a64944)

sources lists are from ftp.debian.org, binary from a lokal mirror,
please speak up if you need them aswell.

bye,
    - michael



Message sent on to Andreas Barth <aba@not.so.argh.org>:
Bug#400874. (full text, mbox, link).


Message #26 received at 400874-submitter@bugs.debian.org (full text, mbox, reply):

From: Filipus Klutiero <philippe.cloutier.2@ulaval.ca>
To: 400874-submitter@bugs.debian.org
Subject: amd64-specific?
Date: Wed, 29 Nov 2006 10:55:46 -0500
I've tested with your sources.list but I can't reproduce. Could this be 
amd64-specific? Does Michael Ablassmeier use an amd64? Is anyone able to 
reproduce this on i386?



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Barth <aba@not.so.argh.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #31 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
Cc: 400874@bugs.debian.org
Subject: Re: Bug#400874: amd64-specific?
Date: Wed, 29 Nov 2006 17:43:55 +0100
* Filipus Klutiero (philippe.cloutier.2@ulaval.ca) [061129 17:40]:
> I've tested with your sources.list but I can't reproduce. Could this be 
> amd64-specific? Does Michael Ablassmeier use an amd64? Is anyone able to 
> reproduce this on i386?

Michael also uses amd64. BTW, if you just keep <bugnumber>@b.d.o in the
To-line, I get the bug (well, because I read bugs-rc), and almost every
one else as well.


Cheers,
Andi
-- 
  http://home.arcor.de/andreas-barth/



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Henriksson <andreas@fatal.se>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #36 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Henriksson <andreas@fatal.se>
To: 400874@bugs.debian.org
Subject: found the case when it blows up...
Date: Wed, 29 Nov 2006 18:29:50 +0100
This problem appeared on my Debian Unstable AMD64 today.

file: apt-pkg/deb/debsrcrecords.cc
function: const char **debSrcRecordParser::Binaries()

When:
	if (Bins.length() > sizeof(Buffer))

is true, then it blows up....


Judging from the comment there seems to be some performance hack there
for when there is a long string....

Buf contains this long string when it blows up:

spca5xx-modules-2.6.18-3-686-bigmem, unionfs-modules-2.6-r4k-kn04, spca5xx-modules-2.6-amd64, redhat-cluster-modules-2.6.18-3-atari, unionfs-modules-2.6.18-3-itanium, redhat-cluster-modules-2.6.18-3-sparc32, redhat-cluster-modules-2.6-vserver-s390x, unionfs-modules-2.6-iop32x, unionfs-modules-2.6.18-3-686, redhat-cluster-modules-2.6.18-3-powerpc-miboot, unionfs-modules-2.6-r3k-kn02, unionfs-modules-2.6.18-3-r5k-cobalt, squashfs-modules-2.6-parisc, unionfs-modules-2.6-itanium, redhat-cluster-modules-2.6-686-bigmem, squashfs-modules-2.6-s390, redhat-cluster-modules-2.6.18-3-alpha-legacy, spca5xx-modules-2.6-686, redhat-cluster-modules-2.6.18-3-rpc, redhat-cluster-modules-2.6.18-3-vserver-k7, unionfs-modules-2.6.18-3-ixp4xx, unionfs-modules-2.6-s3c2410, unionfs-modules-2.6.18-3-rpc, squashfs-modules-2.6-r4k-ip22, redhat-cluster-modules-2.6.18-3-vserver-alpha, spca5xx-modules-2.6.18-3-vserver-686, spca5xx-modules-2.6.18-3-xen-686, squashfs-modules-2.6-parisc64-smp, squashfs-modules-2.6.18-3-r4k-ip22, spca5xx-modules-2.6.18-3-amd64, unionfs-modules-2.6.18-3-powerpc-smp, squashfs-modules-2.6-vserver-powerpc, redhat-cluster-modules-2.6.18-3-alpha-smp, spca5xx-modules-2.6-vserver-k7, spca5xx-modules-2.6.18-3-486, unionfs-modules-2.6-sb1a-bcm91480b, squashfs-modules-2.6-mckinley, redhat-cluster-modules-2.6-sparc32, squashfs-modules-2.6.18-3-xen-amd64, squashfs-modules-2.6.18-3-vserver-686, unionfs-modules-2.6.18-3-s390x, mol-modules-2.6.18-3-powerpc-miboot, redhat-cluster-modules-2.6-r5k-ip32, redhat-cluster-modules-2.6-alpha-legacy, redhat-cluster-modules-2.6-sb1a-bcm91480b, unionfs-modules-2.6-powerpc-smp, unionfs-modules-2.6.18-3-k7, redhat-cluster-modules-2.6.18-3-xen-amd64, squashfs-modules-2.6.18-3-amd64, squashfs-modules-2.6.18-3-r5k-ip32, squashfs-modules-2.6.18-3-vserver-alpha, squashfs-modules-2.6.18-3-s390, unionfs-modules-2.6.18-3-prep, squashfs-modules-2.6-686, squashfs-modules-2.6-prep, squashfs-modules-2.6.18-3-mckinley, redhat-cluster-modules-2.6-amiga, unionfs-modules-2.6.18-3-footbridge, unionfs-modules-2.6-parisc, redhat-cluster-modules-2.6.18-3-parisc64-smp, redhat-cluster-modules-2.6.18-3-itanium, unionfs-modules-2.6-alpha-smp, spca5xx-modules-2.6-powerpc64, squashfs-modules-2.6.18-3-vserver-amd64, redhat-cluster-modules-2.6-mckinley, redhat-cluster-modules-2.6.18-3-xen-k7, squashfs-modules-2.6.18-3-footbridge, squashfs-modules-2.6-sb1-bcm91250a, squashfs-modules-2.6.18-3-xen-686, redhat-cluster-modules-2.6-parisc, redhat-cluster-modules-2.6.18-3-alpha-generic, unionfs-modules-2.6-k7, redhat-cluster-modules-2.6.18-3-486, redhat-cluster-modules-2.6-486, redhat-cluster-modules-2.6.18-3-parisc-smp, unionfs-modules-2.6.18-3-486, redhat-cluster-modules-2.6.18-3-qemu, unionfs-modules-2.6-powerpc64, unionfs-modules-2.6.18-3-sparc64, unionfs-modules-2.6-686-bigmem, redhat-cluster-modules-2.6.18-3-sb1-bcm91250a, squashfs-modules-2.6.18-3-vserver-powerpc64, redhat-cluster-modules-2.6.18-3-xen-vserver-amd64, squashfs-modules-2.6-atari, unionfs-modules-2.6-r5k-cobalt, redhat-cluster-modules-2.6.18-3-iop32x, squashfs-modules-2.6.18-3-xen-k7, redhat-cluster-modules-2.6-vserver-686, squashfs-modules-2.6-xen-686, unionfs-modules-2.6-parisc-smp, spca5xx-modules-2.6.18-3-xen-vserver-amd64, squashfs-modules-2.6.18-3-sparc64-smp, redhat-cluster-modules-2.6-parisc64-smp, redhat-cluster-modules-2.6.18-3-k7, squashfs-modules-2.6.18-3-xen-vserver-amd64, redhat-cluster-modules-2.6-atari, mol-modules-2.6-powerpc-smp, squashfs-modules-2.6-amiga, squashfs-modules-2.6-xen-vserver-686, squashfs-modules-2.6.18-3-atari, squashfs-modules-2.6.18-3-sb1a-bcm91480b, squashfs-modules-2.6.18-3-xen-vserver-686, redhat-cluster-modules-2.6-r4k-kn04, redhat-cluster-modules-2.6-vserver-sparc64, redhat-cluster-modules-2.6-powerpc-miboot, redhat-cluster-modules-2.6-mac, spca5xx-modules-2.6-vserver-amd64, unionfs-modules-2.6.18-3-alpha-legacy, spca5xx-modules-2.6.18-3-vserver-amd64, redhat-cluster-modules-2.6.18-3-xen-686, redhat-cluster-modules-2.6.18-3-prep, redhat-cluster-modules-2.6.18-3-vserver-amd64, squashfs-modules-2.6-486, unionfs-modules-2.6.18-3-sparc32, spca5xx-modules-2.6.18-3-powerpc64, redhat-cluster-modules-2.6-powerpc, mol-modules-2.6.18-3-powerpc-smp, squashfs-modules-2.6-sb1a-bcm91480b, squashfs-modules-2.6.18-3-486, unionfs-modules-2.6-686, squashfs-modules-2.6.18-3-powerpc, squashfs-modules-2.6.18-3-sparc32, squashfs-modules-2.6-iop32x, redhat-cluster-modules-2.6-alpha-generic, redhat-cluster-modules-2.6.18-3-vserver-powerpc, redhat-cluster-modules-2.6.18-3-amiga, unionfs-modules-2.6-sb1-bcm91250a, squashfs-modules-2.6-r5k-ip32, squashfs-modules-2.6-powerpc-miboot, redhat-cluster-modules-2.6-powerpc-smp, unionfs-modules-2.6-r4k-ip22, unionfs-modules-2.6.18-3-sb1-bcm91250a, redhat-cluster-modules-2.6-xen-686, redhat-cluster-modules-2.6-vserver-powerpc64, unionfs-modules-2.6.18-3-powerpc64, redhat-cluster-modules-2.6-parisc-smp, squashfs-modules-2.6.18-3-vserver-k7, squashfs-modules-2.6-vserver-686, squashfs-modules-2.6.18-3-k7, redhat-cluster-modules-2.6-s390x, squashfs-modules-2.6-ixp4xx, mol-modules-2.6-powerpc, spca5xx-modules-2.6-xen-686, squashfs-modules-2.6-s3c2410, unionfs-modules-2.6.18-3-alpha-smp, spca5xx-modules-2.6-k7, redhat-cluster-modules-2.6.18-3-vserver-s390x, spca5xx-modules-2.6-xen-k7, spca5xx-modules-2.6.18-3-powerpc-miboot, spca5xx-modules-2.6.18-3-prep, unionfs-modules-2.6-s390x, squashfs-modules-2.6.18-3-powerpc-smp, unionfs-modules-2.6.18-3-sb1a-bcm91480b, redhat-cluster-modules-2.6-vserver-powerpc, redhat-cluster-modules-2.6-r3k-kn02, unionfs-modules-2.6.18-3-parisc64-smp, spca5xx-modules-2.6.18-3-powerpc-smp, spca5xx-modules-2.6-xen-vserver-amd64, unionfs-modules-2.6.18-3-atari, squashfs-modules-2.6-parisc-smp, unionfs-modules-2.6.18-3-powerpc-miboot, unionfs-modules-2.6-alpha-legacy, redhat-cluster-modules-2.6.18-3-r4k-ip22, squashfs-modules-2.6.18-3-vserver-powerpc, squashfs-modules-2.6-powerpc64, mol-modules-2.6-powerpc-miboot, redhat-cluster-modules-2.6.18-3-ixp4xx, unionfs-modules-2.6-486, squashfs-modules-2.6-vserver-alpha, unionfs-modules-2.6-alpha-generic, spca5xx-modules-2.6.18-3-vserver-powerpc, spca5xx-modules-2.6.18-3-powerpc, redhat-cluster-modules-2.6.18-3-r3k-kn02, redhat-cluster-modules-2.6.18-3-powerpc-smp, unionfs-modules-2.6-rpc, unionfs-modules-2.6.18-3-alpha-generic, squashfs-modules-2.6-itanium, spca5xx-modules-2.6.18-3-k7, redhat-cluster-modules-2.6.18-3-s390x, squashfs-modules-2.6-footbridge, redhat-cluster-modules-2.6-amd64, squashfs-modules-2.6-alpha-legacy, squashfs-modules-2.6-vserver-powerpc64, redhat-cluster-modules-2.6-itanium, spca5xx-modules-2.6-powerpc-miboot, mol-modules-2.6.18-3-vserver-powerpc, squashfs-modules-2.6-vserver-k7, redhat-cluster-modules-2.6-powerpc64, squashfs-modules-2.6.18-3-qemu, squashfs-modules-2.6.18-3-parisc, squashfs-modules-2.6.18-3-mac, unionfs-modules-2.6.18-3-r4k-kn04, unionfs-modules-2.6-mckinley, squashfs-modules-2.6-mac, squashfs-modules-2.6.18-3-prep, squashfs-modules-2.6-alpha-smp, redhat-cluster-modules-2.6-prep, squashfs-modules-2.6-r4k-kn04, squashfs-modules-2.6.18-3-sparc64, redhat-cluster-modules-2.6-sb1-bcm91250a, unionfs-modules-2.6.18-3-powerpc, unionfs-modules-2.6.18-3-686-bigmem, spca5xx-modules-2.6.18-3-vserver-powerpc64, redhat-cluster-modules-2.6-xen-vserver-amd64, unionfs-modules-2.6.18-3-s390, squashfs-modules-2.6-xen-amd64, squashfs-modules-2.6-xen-k7, squashfs-modules-2.6.18-3-alpha-generic, squashfs-modules-2.6.18-3-686-bigmem, redhat-cluster-modules-2.6.18-3-s3c2410, squashfs-modules-2.6.18-3-itanium, redhat-cluster-modules-2.6.18-3-vserver-sparc64, redhat-cluster-modules-2.6.18-3-r5k-cobalt, squashfs-modules-2.6.18-3-alpha-legacy, squashfs-modules-2.6-vserver-amd64, redhat-cluster-modules-2.6.18-3-sb1a-bcm91480b, squashfs-modules-2.6.18-3-r5k-cobalt, redhat-cluster-modules-2.6.18-3-powerpc, redhat-cluster-modules-2.6.18-3-mac, spca5xx-modules-2.6.18-3-xen-vserver-686, unionfs-modules-2.6-s390, squashfs-modules-2.6.18-3-ixp4xx, redhat-cluster-modules-2.6.18-3-mckinley, squashfs-modules-2.6-qemu, spca5xx-modules-2.6.18-3-686, redhat-cluster-modules-2.6.18-3-parisc64, squashfs-modules-2.6-sparc64, squashfs-modules-2.6.18-3-vserver-s390x, squashfs-modules-2.6.18-3-powerpc-miboot, unionfs-modules-2.6-amiga, unionfs-modules-2.6.18-3-qemu, squashfs-modules-2.6-686-bigmem, unionfs-modules-2.6.18-3-mac, squashfs-modules-2.6.18-3-rpc, unionfs-modules-2.6.18-3-r4k-ip22, redhat-cluster-modules-2.6-xen-amd64, unionfs-modules-2.6.18-3-iop32x, squashfs-modules-2.6.18-3-sb1-bcm91250a, redhat-cluster-modules-2.6-686, redhat-cluster-modules-2.6.18-3-s390, squashfs-modules-2.6.18-3-parisc-smp, spca5xx-modules-2.6-486, unionfs-modules-2.6-sparc64-smp, unionfs-modules-2.6-r5k-ip32, unionfs-modules-2.6.18-3-sparc64-smp, squashfs-modules-2.6-parisc64, squashfs-modules-2.6.18-3-vserver-sparc64, unionfs-modules-2.6.18-3-r5k-ip32, unionfs-modules-2.6.18-3-r3k-kn02, unionfs-modules-2.6-sparc64, spca5xx-modules-2.6.18-3-xen-k7, unionfs-modules-2.6-powerpc, squashfs-modules-2.6-rpc, squashfs-modules-2.6-sparc32, unionfs-modules-2.6-sparc32, unionfs-modules-2.6-powerpc-miboot, unionfs-modules-2.6-prep, redhat-cluster-modules-2.6-iop32x, redhat-cluster-modules-2.6.18-3-powerpc64, redhat-cluster-modules-2.6.18-3-r4k-kn04, redhat-cluster-modules-2.6.18-3-vserver-686, squashfs-modules-2.6.18-3-r4k-kn04, mol-modules-2.6.18-3-powerpc, redhat-cluster-modules-2.6-alpha-smp, unionfs-modules-2.6.18-3-s3c2410, redhat-cluster-modules-2.6.18-3-amd64, spca5xx-modules-2.6-vserver-powerpc64, spca5xx-modules-2.6-vserver-powerpc, squashfs-modules-2.6-r3k-kn02, squashfs-modules-2.6-powerpc-smp, squashfs-modules-2.6-k7, redhat-cluster-modules-2.6-vserver-alpha, unionfs-modules-2.6.18-3-parisc, redhat-cluster-modules-2.6-s390, redhat-cluster-modules-2.6.18-3-xen-vserver-686, squashfs-modules-2.6-alpha-generic, squashfs-modules-2.6-amd64, spca5xx-modules-2.6-xen-amd64, redhat-cluster-modules-2.6.18-3-sparc64-smp, redhat-cluster-modules-2.6.18-3-parisc, redhat-cluster-modules-2.6-xen-vserver-686, squashfs-modules-2.6-vserver-s390x, redhat-cluster-modules-2.6-r4k-ip22, squashfs-modules-2.6-r5k-cobalt, squashfs-modules-2.6-s390x, spca5xx-modules-2.6.18-3-vserver-k7, unionfs-modules-2.6-parisc64-smp, redhat-cluster-modules-2.6-sparc64, unionfs-modules-2.6-atari, redhat-cluster-modules-2.6.18-3-686-bigmem, squashfs-modules-2.6-vserver-sparc64, redhat-cluster-modules-2.6.18-3-vserver-powerpc64, squashfs-modules-2.6.18-3-r3k-kn02, spca5xx-modules-2.6-686-bigmem, unionfs-modules-2.6-footbridge, unionfs-modules-2.6-parisc64, spca5xx-modules-2.6-vserver-686, squashfs-modules-2.6.18-3-alpha-smp, squashfs-modules-2.6.18-3-parisc64-smp, unionfs-modules-2.6-mac, squashfs-modules-2.6.18-3-s390x, squashfs-modules-2.6.18-3-s3c2410, spca5xx-modules-2.6-prep, redhat-cluster-modules-2.6-sparc64-smp, redhat-cluster-modules-2.6-rpc, unionfs-modules-2.6-amd64, redhat-cluster-modules-2.6-vserver-k7, redhat-cluster-modules-2.6.18-3-sparc64, redhat-cluster-modules-2.6-s3c2410, squashfs-modules-2.6.18-3-iop32x, redhat-cluster-modules-2.6.18-3-r5k-ip32, squashfs-modules-2.6.18-3-powerpc64, redhat-cluster-modules-2.6.18-3-686, spca5xx-modules-2.6-powerpc, unionfs-modules-2.6.18-3-parisc-smp, unionfs-modules-2.6-ixp4xx, unionfs-modules-2.6.18-3-parisc64, redhat-cluster-modules-2.6.18-3-footbridge, unionfs-modules-2.6-qemu, spca5xx-modules-2.6-powerpc-smp, redhat-cluster-modules-2.6-ixp4xx, unionfs-modules-2.6.18-3-amiga, redhat-cluster-modules-2.6-k7, unionfs-modules-2.6.18-3-mckinley, squashfs-modules-2.6.18-3-parisc64, redhat-cluster-modules-2.6-r5k-cobalt, squashfs-modules-2.6-powerpc, redhat-cluster-modules-2.6-footbridge, mol-modules-2.6-vserver-powerpc, squashfs-modules-2.6.18-3-amiga, squashfs-modules-2.6-sparc64-smp, redhat-cluster-modules-2.6-vserver-amd64, redhat-cluster-modules-2.6-xen-k7, squashfs-modules-2.6-xen-vserver-amd64, redhat-cluster-modules-2.6-qemu, redhat-cluster-modules-2.6-parisc64, unionfs-modules-2.6.18-3-amd64, squashfs-modules-2.6.18-3-686, spca5xx-modules-2.6.18-3-xen-amd64, spca5xx-modules-2.6-xen-vserver-686

Gotta run.... HTH.

-- 
Regards,
Andreas Henriksson



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Guus Sliepen <guus@debian.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #41 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Guus Sliepen <guus@debian.org>
To: 400874@bugs.debian.org
Subject: Re: Bug#400874: grave?
Date: Wed, 29 Nov 2006 16:52:11 +0100
[Message part 1 (text/plain, inline)]
I have this problem as well, I also have an amd64 system (unstable
though, not etch). Maybe it is not grave, but serious. You wouldn't want
to release etch with this bug.

-- 
Met vriendelijke groet / with kind regards,
      Guus Sliepen <guus@debian.org>
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to dann frazier <dannf@debian.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #46 received at 400874@bugs.debian.org (full text, mbox, reply):

From: dann frazier <dannf@debian.org>
To: 400874@bugs.debian.org
Subject: also on ia64
Date: Wed, 29 Nov 2006 16:15:41 -0700
fwiw, I'm seeing this on ia64, so its not amd64-specific.

-- 
dann frazier | HP Open Source and Linux Organization



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Henriksson <andreas@fatal.se>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #51 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Henriksson <andreas@fatal.se>
To: 400874@bugs.debian.org
Cc: control@bugs.debian.org
Subject: I hope this is the right fix...
Date: Thu, 30 Nov 2006 01:06:16 +0100
[Message part 1 (text/plain, inline)]
tags 400874 + patch
thanks

Here's the off-by-one fix for apt..... Now that it's solved it seems so
obvious... valgrind was right! (Could someone please rerun valgrind with
this patch applied?!)

Please verify for correctness, this patch "works for me" (and in my
current state seems to be the right fix, I'll try to have a closer look
at it tomorrow.... or maybe later...)

Problem described in:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=400874;msg=36

Workaround:
http://fatal.se/tmp/aptsource-workaround.diff


Probably/hopefully this is the "real" fix:
http://fatal.se/tmp/aptsource-fix.diff
(this one also attached)



Patch attached.


Regards,
Andreas Henriksson
[aptsource-fix.diff (text/x-patch, attachment)]

Tags added: patch Request was from Andreas Henriksson <andreas@fatal.se> to control@bugs.debian.org. (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Jens Seidel <jensseidel@users.sf.net>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #58 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Jens Seidel <jensseidel@users.sf.net>
To: Andreas Henriksson <andreas@fatal.se>, 400874@bugs.debian.org
Subject: Re: Bug#400874: I hope this is the right fix...
Date: Thu, 30 Nov 2006 08:49:26 +0100
On Thu, Nov 30, 2006 at 01:06:16AM +0100, Andreas Henriksson wrote:
> Patch attached.
> 
> 
> Regards,
> Andreas Henriksson

> diff -ur apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc apt-0.6.46.3.fix/apt-pkg/deb/debsrcrecords.cc
> --- apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc	2006-03-02 14:44:28.000000000 +0100
> +++ apt-0.6.46.3.fix/apt-pkg/deb/debsrcrecords.cc	2006-11-30 00:38:19.000000000 +0100
> @@ -40,7 +40,7 @@
>     char *Buf;
>     if (Bins.length() > sizeof(Buffer))
>     {
> -      BigBuf = new char[Bins.length()];
> +      BigBuf = new char[Bins.length()+1];
>        Buf = BigBuf;
>     }
>     else

If the buffer needs to be longer by one than Bins you probably also need
-if (Bins.length() > sizeof(Buffer))
+if (Bins.length() >= sizeof(Buffer))

Jens



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Henriksson <andreas@fatal.se>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #63 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Henriksson <andreas@fatal.se>
To: Jens Seidel <jensseidel@users.sf.net>
Cc: Andreas Henriksson <andreas@fatal.se>, 400874@bugs.debian.org
Subject: Re: Bug#400874: I hope this is the right fix...
Date: Thu, 30 Nov 2006 10:56:52 +0100
[Message part 1 (text/plain, inline)]
On Thu, Nov 30, 2006 at 08:49:26AM +0100, Jens Seidel wrote:
> If the buffer needs to be longer by one than Bins you probably also need
> +if (Bins.length() >= sizeof(Buffer))

Good catch, thanks!

Updated patch attached.


I wonder what the second part of this is good for:
		 
	if (Bins.empty() == true || Bins.length() >= 102400)
		return 0;

Oh, well.... that's a high enough number that it probably won't be(come)
a real world problem and if we're getting that nitpicky at fixing
surrounding issues we should probably start by checking if the BigBuf 
memory allocation failed first. :)

-- 
Regards,
Andreas Henriksson
[aptsource-fix2.diff (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Barth <aba@not.so.argh.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #68 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
To: Andreas Henriksson <andreas@fatal.se>
Cc: Jens Seidel <jensseidel@users.sf.net>, 400874@bugs.debian.org
Subject: Re: Bug#400874: I hope this is the right fix...
Date: Fri, 1 Dec 2006 11:49:37 +0100
* Andreas Henriksson (andreas@fatal.se) [061130 02:04]:
> Updated patch attached.
> 
> 
> I wonder what the second part of this is good for:
> 		 
> 	if (Bins.empty() == true || Bins.length() >= 102400)
> 		return 0;
> 
> Oh, well.... that's a high enough number that it probably won't be(come)
> a real world problem and if we're getting that nitpicky at fixing
> surrounding issues we should probably start by checking if the BigBuf 
> memory allocation failed first. :)

Thank you very much for this patch.  I can confirm that this patch works
for me (amd64).


In case it is helpful, I'm offering to NMU apt (well, unless someone
stops me or is faster, I'll do that as soon as apt appears on my regular
list of >= 10 days old RC bugs).


Cheers,
Andi
-- 
  http://home.arcor.de/andreas-barth/



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Nacho Barrientos Arias <chipi@criptonita.com>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #73 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Nacho Barrientos Arias <chipi@criptonita.com>
To: 400874@bugs.debian.org
Cc: jensseidel@users.sf.net, aba@not.so.argh.org, andreas@fatal.se
Subject: Re: Bug#400874: I hope this is the right fix...
Date: Fri, 1 Dec 2006 23:37:47 +0100
> Updated patch attached.
> 
> 
> I wonder what the second part of this is good for:
>                
>       if (Bins.empty() == true || Bins.length() >= 102400)
>               return 0;
> 
> Oh, well.... that's a high enough number that it probably won't be(come)
> a real world problem and if we're getting that nitpicky at fixing
> surrounding issues we should probably start by checking if the BigBuf 
> memory allocation failed first. :)

Aptsource-fix2.diff works for me as well (here amd64).

Hope it helps,

-- 
bye,
   - Nacho 
     http://criptonita.com/~nacho



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Michael Vogt <mvo@debian.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #78 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Michael Vogt <mvo@debian.org>
To: 400874@bugs.debian.org
Subject: [patch] proposed fix
Date: Mon, 4 Dec 2006 10:17:50 +0100
[Message part 1 (text/plain, inline)]
Hi,

sorry for being coming in so late. Here is a patch that should fix the
problem by making the buffer grow dynamically. Please give it testing.

Just to double the buffersize does only buy us time, the code that
deals with BigBuf is broken in serveral ways. 

Cheers,
 Michael
[debsrcrec.diff (text/plain, attachment)]

Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Michael Vogt <mvo@debian.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #83 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Michael Vogt <mvo@debian.org>
To: Andreas Henriksson <andreas@fatal.se>, 400874@bugs.debian.org
Cc: Jens Seidel <jensseidel@users.sf.net>
Subject: Re: Bug#400874: I hope this is the right fix...
Date: Mon, 4 Dec 2006 10:46:18 +0100
On Thu, Nov 30, 2006 at 10:56:52AM +0100, Andreas Henriksson wrote:
> On Thu, Nov 30, 2006 at 08:49:26AM +0100, Jens Seidel wrote:
> > If the buffer needs to be longer by one than Bins you probably also need
> > +if (Bins.length() >= sizeof(Buffer))
> 
> Good catch, thanks!
> 
> Updated patch attached.

Thanks for your patch.  
 
Unfortunately this patch is not enough because BigBuf is deleted
in the function but TokSplitString() does not make a copy of the
buffer it is passed but just modifies it. So we return already deleted
memory. I send a proposed patch that hopefully fixes this issue. I'm
currently at the lsb-meeting so I'm a bit limited in my resources
right now. But testing feedback would be great :)

Cheers,
 Michael



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Henriksson <andreas@fatal.se>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #88 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Henriksson <andreas@fatal.se>
To: Michael Vogt <mvo@debian.org>
Cc: 400874@bugs.debian.org, Jens Seidel <jensseidel@users.sf.net>
Subject: Re: Bug#400874: I hope this is the right fix...
Date: Mon, 4 Dec 2006 11:23:58 +0100
On Mon, Dec 04, 2006 at 10:46:18AM +0100, Michael Vogt wrote:
> Unfortunately this patch is not enough because BigBuf is deleted
[...]
> right now. But testing feedback would be great :)

I've verified that the problem still persists with the apt which is
currently in the archive. I've also tested apt with you patch
(debsrcrec.diff) and verified that it solves the problem.

Thanks for a proper patch! Hope to see this uploaded soon. :)

-- 
Regards,
Andreas Henriksson



Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Barth <aba@not.so.argh.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #93 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
To: 400874@bugs.debian.org, 401114@bugs.debian.org, 401017@bugs.debian.org
Subject: NMU uploaded
Date: Tue, 5 Dec 2006 12:17:16 +0100
Hi,

as agreed on IRC, I uploaded an NMU of your package.

Please find the used diff below.


Cheers,
Andi

diff -Nru /tmp/lF0wIU5S1h/apt-0.6.46.3/apt-pkg/acquire-item.cc /tmp/KFa23oVzhG/apt-0.6.46.3/apt-pkg/acquire-item.cc
--- /tmp/lF0wIU5S1h/apt-0.6.46.3/apt-pkg/acquire-item.cc	2006-07-26 22:30:51.000000000 +0000
+++ /tmp/KFa23oVzhG/apt-0.6.46.3/apt-pkg/acquire-item.cc	2006-12-05 10:40:42.000000000 +0000
@@ -276,7 +276,8 @@
 	 if(Debug)
 	    std::clog << "Can't find a patch in the index file" << std::endl;
 	 // Failed will queue a big package file
-	 Failed("", NULL);
+	 // don't queue anymore - we do that outside already - see #401017
+	 //Failed("", NULL);
       } 
       else 
       {
diff -Nru /tmp/lF0wIU5S1h/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc /tmp/KFa23oVzhG/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc
--- /tmp/lF0wIU5S1h/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc	2006-03-02 13:44:28.000000000 +0000
+++ /tmp/KFa23oVzhG/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc	2006-12-05 10:34:49.000000000 +0000
@@ -18,6 +18,8 @@
 #include <apt-pkg/error.h>
 #include <apt-pkg/strutl.h>
 #include <apt-pkg/configuration.h>
+
+using std::max;
 									/*}}}*/
 
 // SrcRecordParser::Binaries - Return the binaries field		/*{{{*/
@@ -34,31 +36,19 @@
    if (Bins.empty() == true || Bins.length() >= 102400)
       return 0;
    
-   // Workaround for #236688.  Only allocate a new buffer if the field
-   // is large, to avoid a performance penalty
-   char *BigBuf = NULL;
-   char *Buf;
-   if (Bins.length() > sizeof(Buffer))
-   {
-      BigBuf = new char[Bins.length()];
-      Buf = BigBuf;
-   }
-   else
+   if (Bins.length() >= BufSize)
    {
-      Buf = Buffer;
+      delete [] Buffer;
+      // allocate new size based on buffer (but never smaller than 4000)
+      BufSize = max((unsigned long)4000, max(Bins.length()+1,2*BufSize));
+      Buffer = new char[BufSize];
    }
 
-   strcpy(Buf,Bins.c_str());
-   if (TokSplitString(',',Buf,StaticBinList,
+   strcpy(Buffer,Bins.c_str());
+   if (TokSplitString(',',Buffer,StaticBinList,
 		      sizeof(StaticBinList)/sizeof(StaticBinList[0])) == false)
-   {
-      if (BigBuf != NULL)
-         delete BigBuf;
       return 0;
-   }
 
-   if (BigBuf != NULL)
-      delete BigBuf;
    return (const char **)StaticBinList;
 }
 									/*}}}*/
diff -Nru /tmp/lF0wIU5S1h/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.h /tmp/KFa23oVzhG/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.h
--- /tmp/lF0wIU5S1h/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.h	2006-03-02 13:44:28.000000000 +0000
+++ /tmp/KFa23oVzhG/apt-0.6.46.3/apt-pkg/deb/debsrcrecords.h	2006-12-05 10:34:49.000000000 +0000
@@ -24,9 +24,10 @@
    FileFd Fd;
    pkgTagFile Tags;
    pkgTagSection Sect;
-   char Buffer[10000];
    char *StaticBinList[400];
    unsigned long iOffset;
+   char *Buffer;
+   unsigned long BufSize;
    
    public:
 
@@ -49,10 +50,9 @@
    };
    virtual bool Files(vector<pkgSrcRecords::File> &F);
 
-   debSrcRecordParser(string File,pkgIndexFile const *Index) :
-                   Parser(Index),      
-                   Fd(File,FileFd::ReadOnly),
-                   Tags(&Fd,102400) {};
+   debSrcRecordParser(string File,pkgIndexFile const *Index) 
+      : Parser(Index), Fd(File,FileFd::ReadOnly), Tags(&Fd,102400), 
+        Buffer(0), BufSize(0) {}
 };
 
 #endif
diff -Nru /tmp/lF0wIU5S1h/apt-0.6.46.3/configure /tmp/KFa23oVzhG/apt-0.6.46.3/configure
--- /tmp/lF0wIU5S1h/apt-0.6.46.3/configure	2006-11-02 10:38:17.000000000 +0000
+++ /tmp/KFa23oVzhG/apt-0.6.46.3/configure	2006-12-05 10:51:52.000000000 +0000
@@ -1773,7 +1773,7 @@
 
 
 cat >>confdefs.h <<_ACEOF
-#define VERSION "0.6.46.3"
+#define VERSION "0.6.46.3-0.1"
 _ACEOF
 
 PACKAGE="apt"
diff -Nru /tmp/lF0wIU5S1h/apt-0.6.46.3/configure.in /tmp/KFa23oVzhG/apt-0.6.46.3/configure.in
--- /tmp/lF0wIU5S1h/apt-0.6.46.3/configure.in	2006-10-30 07:51:28.000000000 +0000
+++ /tmp/KFa23oVzhG/apt-0.6.46.3/configure.in	2006-12-05 10:43:32.000000000 +0000
@@ -18,7 +18,7 @@
 AC_CONFIG_HEADER(include/config.h:buildlib/config.h.in include/apti18n.h:buildlib/apti18n.h.in)
 
 dnl -- SET THIS TO THE RELEASE VERSION --
-AC_DEFINE_UNQUOTED(VERSION,"0.6.46.3")
+AC_DEFINE_UNQUOTED(VERSION,"0.6.46.3-0.1")
 PACKAGE="apt"
 AC_DEFINE_UNQUOTED(PACKAGE,"$PACKAGE")
 AC_SUBST(PACKAGE)
diff -Nru /tmp/lF0wIU5S1h/apt-0.6.46.3/debian/apt.postinst /tmp/KFa23oVzhG/apt-0.6.46.3/debian/apt.postinst
--- /tmp/lF0wIU5S1h/apt-0.6.46.3/debian/apt.postinst	2006-03-02 14:10:27.000000000 +0000
+++ /tmp/KFa23oVzhG/apt-0.6.46.3/debian/apt.postinst	2006-12-05 10:38:36.000000000 +0000
@@ -20,6 +20,8 @@
                 cp /usr/share/apt/debian-archive.gpg /etc/apt/trusted.gpg
         fi
 
+	apt-key update
+
     ;;
 
     abort-upgrade|abort-remove|abort-deconfigure)
diff -Nru /tmp/lF0wIU5S1h/apt-0.6.46.3/debian/changelog /tmp/KFa23oVzhG/apt-0.6.46.3/debian/changelog
--- /tmp/lF0wIU5S1h/apt-0.6.46.3/debian/changelog	2006-11-02 10:37:58.000000000 +0000
+++ /tmp/KFa23oVzhG/apt-0.6.46.3/debian/changelog	2006-12-05 10:43:00.000000000 +0000
@@ -1,3 +1,13 @@
+apt (0.6.46.3-0.1) unstable; urgency=high
+
+  * Non-maintainer upload with permission of Michael Vogt.
+  * Fix segfault at apt-get source. Closes: #400874
+  * Add apt-key update in postinst, so that debian-archive-keyring doesn't
+    need to depend on apt >= 0.6. Closes: #401114
+  * Don't double-queue pdiff files. Closes: #401017
+
+ -- Andreas Barth <aba@not.so.argh.org>  Tue,  5 Dec 2006 10:34:56 +0000
+
 apt (0.6.46.3) unstable; urgency=low
 
   * apt-pkg/deb/dpkgpm.cc:
-- 
  http://home.arcor.de/andreas-barth/



Reply sent to Andreas Barth <aba@not.so.argh.org>:
You have taken responsibility. (full text, mbox, link).


Notification sent to Andreas Barth <aba@not.so.argh.org>:
Bug acknowledged by developer. (full text, mbox, link).


Message #98 received at 400874-close@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
To: 400874-close@bugs.debian.org
Subject: Bug#400874: fixed in apt 0.6.46.3-0.1
Date: Tue, 05 Dec 2006 11:32:03 +0000
Source: apt
Source-Version: 0.6.46.3-0.1

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive:

apt-doc_0.6.46.3-0.1_all.deb
  to pool/main/a/apt/apt-doc_0.6.46.3-0.1_all.deb
apt_0.6.46.3-0.1.dsc
  to pool/main/a/apt/apt_0.6.46.3-0.1.dsc
apt_0.6.46.3-0.1.tar.gz
  to pool/main/a/apt/apt_0.6.46.3-0.1.tar.gz
libapt-pkg-doc_0.6.46.3-0.1_all.deb
  to pool/main/a/apt/libapt-pkg-doc_0.6.46.3-0.1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 400874@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Barth <aba@not.so.argh.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  5 Dec 2006 10:34:56 +0000
Source: apt
Binary: apt-utils libapt-pkg-doc libapt-pkg-dev apt-doc apt
Architecture: source all
Version: 0.6.46.3-0.1
Distribution: unstable
Urgency: high
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Andreas Barth <aba@not.so.argh.org>
Description: 
 apt        - Advanced front-end for dpkg
 apt-doc    - Documentation for APT
 apt-utils  - APT utility programs
 libapt-pkg-dev - Development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - Documentation for APT development
Closes: 400874 401017 401114
Changes: 
 apt (0.6.46.3-0.1) unstable; urgency=high
 .
   * Non-maintainer upload with permission of Michael Vogt.
   * Fix segfault at apt-get source. Closes: #400874
   * Add apt-key update in postinst, so that debian-archive-keyring doesn't
     need to depend on apt >= 0.6. Closes: #401114
   * Don't double-queue pdiff files. Closes: #401017
Files: 
 29db8a90c9c9a579693f5224189239df 796 admin important apt_0.6.46.3-0.1.dsc
 6884258841c3ef4294e441694fc26a2d 1793085 admin important apt_0.6.46.3-0.1.tar.gz
 704ace660caf4bc69adf670b8a9f3f5f 91384 doc optional apt-doc_0.6.46.3-0.1_all.deb
 5b88479ea37cf572fb224f5b4a1f52e4 112860 doc optional libapt-pkg-doc_0.6.46.3-0.1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFFdVS3mdOZoew2oYURAkvdAKCMaDOQ1Xa7+rZ4d4P1/kn541dCHACdF3d2
Wg9DzIhwvArv8BUuWFOeCYE=
=tt6b
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org, APT Development Team <deity@lists.debian.org>:
Bug#400874; Package apt. (full text, mbox, link).


Acknowledgement sent to Andreas Barth <aba@not.so.argh.org>:
Extra info received and forwarded to list. Copy sent to APT Development Team <deity@lists.debian.org>. (full text, mbox, link).


Message #103 received at 400874@bugs.debian.org (full text, mbox, reply):

From: Andreas Barth <aba@not.so.argh.org>
To: 400874@bugs.debian.org
Subject: NMU uploaded
Date: Tue, 5 Dec 2006 21:55:31 +0100
Hi,

this bug needed another patch to build on all arches, I just uploaded
it.

Please find the used diff below.


Cheers,
Andi

diff -Nur ../apt-0.6.46.3~~/apt-pkg/deb/debsrcrecords.cc ../apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc
--- ../apt-0.6.46.3~~/apt-pkg/deb/debsrcrecords.cc	2006-12-05 10:34:49.000000000 +0000
+++ ../apt-0.6.46.3/apt-pkg/deb/debsrcrecords.cc	2006-12-05 15:55:15.000000000 +0000
@@ -40,7 +40,7 @@
    {
       delete [] Buffer;
       // allocate new size based on buffer (but never smaller than 4000)
-      BufSize = max((unsigned long)4000, max(Bins.length()+1,2*BufSize));
+      BufSize = max((unsigned long)4000, max((long unsigned) Bins.length()+1,2*BufSize));
       Buffer = new char[BufSize];
    }
 
diff -Nur ../apt-0.6.46.3~~/configure ../apt-0.6.46.3/configure
--- ../apt-0.6.46.3~~/configure	2006-12-05 10:51:52.000000000 +0000
+++ ../apt-0.6.46.3/configure	2006-12-05 15:57:34.000000000 +0000
@@ -1773,7 +1773,7 @@
 
 
 cat >>confdefs.h <<_ACEOF
-#define VERSION "0.6.46.3-0.1"
+#define VERSION "0.6.46.3-0.2"
 _ACEOF
 
 PACKAGE="apt"
diff -Nur ../apt-0.6.46.3~~/configure.in ../apt-0.6.46.3/configure.in
--- ../apt-0.6.46.3~~/configure.in	2006-12-05 10:43:32.000000000 +0000
+++ ../apt-0.6.46.3/configure.in	2006-12-05 15:57:33.000000000 +0000
@@ -18,7 +18,7 @@
 AC_CONFIG_HEADER(include/config.h:buildlib/config.h.in include/apti18n.h:buildlib/apti18n.h.in)
 
 dnl -- SET THIS TO THE RELEASE VERSION --
-AC_DEFINE_UNQUOTED(VERSION,"0.6.46.3-0.1")
+AC_DEFINE_UNQUOTED(VERSION,"0.6.46.3-0.2")
 PACKAGE="apt"
 AC_DEFINE_UNQUOTED(PACKAGE,"$PACKAGE")
 AC_SUBST(PACKAGE)
diff -Nur ../apt-0.6.46.3~~/debian/changelog ../apt-0.6.46.3/debian/changelog
--- ../apt-0.6.46.3~~/debian/changelog	2006-12-05 10:43:00.000000000 +0000
+++ ../apt-0.6.46.3/debian/changelog	2006-12-05 15:52:18.000000000 +0000
@@ -1,3 +1,10 @@
+apt (0.6.46.3-0.2) unstable; urgency=high
+
+  * Non-maintainer upload with permission of Michael Vogt.
+  * Fix FTBFS on most arches (regression from the fix of #400874)
+
+ -- Andreas Barth <aba@not.so.argh.org>  Tue,  5 Dec 2006 15:51:22 +0000
+
 apt (0.6.46.3-0.1) unstable; urgency=high
 
   * Non-maintainer upload with permission of Michael Vogt.
-- 
  http://home.arcor.de/andreas-barth/



Reply sent to Michael Vogt <mvo@debian.org>:
You have taken responsibility. (full text, mbox, link).


Notification sent to Andreas Barth <aba@not.so.argh.org>:
Bug acknowledged by developer. (full text, mbox, link).


Message #108 received at 400874-close@bugs.debian.org (full text, mbox, reply):

From: Michael Vogt <mvo@debian.org>
To: 400874-close@bugs.debian.org
Subject: Bug#400874: fixed in apt 0.6.46.4
Date: Thu, 07 Dec 2006 16:17:02 +0000
Source: apt
Source-Version: 0.6.46.4

We believe that the bug you reported is fixed in the latest version of
apt, which is due to be installed in the Debian FTP archive:

apt-doc_0.6.46.4_all.deb
  to pool/main/a/apt/apt-doc_0.6.46.4_all.deb
apt-utils_0.6.46.4_i386.deb
  to pool/main/a/apt/apt-utils_0.6.46.4_i386.deb
apt_0.6.46.4.dsc
  to pool/main/a/apt/apt_0.6.46.4.dsc
apt_0.6.46.4.tar.gz
  to pool/main/a/apt/apt_0.6.46.4.tar.gz
apt_0.6.46.4_i386.deb
  to pool/main/a/apt/apt_0.6.46.4_i386.deb
libapt-pkg-dev_0.6.46.4_i386.deb
  to pool/main/a/apt/libapt-pkg-dev_0.6.46.4_i386.deb
libapt-pkg-doc_0.6.46.4_all.deb
  to pool/main/a/apt/libapt-pkg-doc_0.6.46.4_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 400874@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Vogt <mvo@debian.org> (supplier of updated apt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu,  7 Dec 2006 10:49:50 +0100
Source: apt
Binary: apt-utils libapt-pkg-doc libapt-pkg-dev apt-doc apt
Architecture: source all i386
Version: 0.6.46.4
Distribution: unstable
Urgency: high
Maintainer: APT Development Team <deity@lists.debian.org>
Changed-By: Michael Vogt <mvo@debian.org>
Description: 
 apt        - Advanced front-end for dpkg
 apt-doc    - Documentation for APT
 apt-utils  - APT utility programs
 libapt-pkg-dev - Development files for APT's libapt-pkg and libapt-inst
 libapt-pkg-doc - Documentation for APT development
Closes: 398381 400874 401017
Changes: 
 apt (0.6.46.4) unstable; urgency=high
 .
   * ack NMU (closes: #401017)
   * added apt-secure.8 to "See also" section
   * apt-pkg/deb/dpkgpm.cc:
     - added "Dpkg::StopOnError" variable that controls if apt
       will abort on errors from dpkg
   * apt-pkg/deb/debsrcrecords.{cc,h}:
     - make the Buffer grow dynmaically (closes: #400874)
   * Merged from Christian Perrier bzr branch:
     - uk.po: New Ukrainian translation: 483t28f3u
     - el.po: Update to 503t9f2u
     - de.po: Updates and corrections.
   * apt-pkg/contrib/progress.cc:
     - OpProgress::CheckChange optimized, thanks to Paul Brook
       (closes: #398381)
   * apt-pkg/contrib/sha256.cc:
     - fix building with noopt
Files: 
 22f6d1c960f5d57263487f6d57dfc57a 788 admin important apt_0.6.46.4.dsc
 82ec892fb9d389a4b6090cc2314e1714 1797347 admin important apt_0.6.46.4.tar.gz
 ab4bd0d33e5112129f4a6fddb30ef051 91468 doc optional apt-doc_0.6.46.4_all.deb
 8b24eafb11eb630306462f77a380b300 113052 doc optional libapt-pkg-doc_0.6.46.4_all.deb
 61aa2370fdd1dd47bdd9a9d4edcf0366 1445796 admin important apt_0.6.46.4_i386.deb
 c6a3bea824c613e787a1a500706a3f1b 84084 libdevel optional libapt-pkg-dev_0.6.46.4_i386.deb
 aedda4fa178a4a05a917cb1df54ceb67 199198 admin important apt-utils_0.6.46.4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFdGNQliSD4VZixzQRAkL1AJ9vw7rECsmRh3DpC+YH/9DHKzQfiwCglZN/
rOSnKrnTPdK5CCm9tuP7f1A=
=t/Se
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 26 Jun 2007 13:55:57 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jan 14 01:07:49 2024; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.