Debian Bug report logs - #391502
Incorrect dependency on pmount

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@teco.edu>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Incorrect dependency on pmount

Date: Sat, 07 Oct 2006 00:45:58 +0200

Package: kdebase
Version: 4:3.5.5-1
Severity: serious
Justification: violates policy

The latest package update introduced a strict dependency on hal and
pmount. While the hal dependency is correct, the pmount dependency is
not. KDE simply calls the hal Mount()/Unmount() methods, nowhere in the
KDE code, pmount is actually used. If hal would use pmount internally to
do the actual mounting[1], fine, let the hal package declare the correct
dependencies. Adding the pmount dependency to kdebase is simply wrong
and violates the policy, which states that strict dependencies have to
reflect that the "depended-on package is required for the depending
package to provide a significant amount of functionality" which is not
the case here.
Please see also #388341, the Recommends: pmount of kdebase-kio-plugins
does not directly violate the policy, still it should be removed for the
same reasons.


Cheers,
Michael



[1] Apparently with hal-0.5.8.x, pmount is not used anymore by hal to do
the mounting. So pmount is now installed on my system for no good
reason.



-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (300, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)

Versions of packages kdebase depends on:
ii  hal                          0.5.8.1-1   Hardware Abstraction Layer
ii  kappfinder                   4:3.5.5-1   non-KDE application finder for KDE
ii  kate                         4:3.5.5-1   advanced text editor for KDE
ii  kcontrol                     4:3.5.5-1   control center for KDE
ii  kdebase-bin                  4:3.5.5-1   core binaries for the KDE base mod
ii  kdebase-data                 4:3.5.5-1   shared data files for the KDE base
ii  kdebase-kio-plugins          4:3.5.5-1   core I/O slaves for KDE
ii  kdepasswd                    4:3.5.5-1   password changer for KDE
ii  kdeprint                     4:3.5.5-1   print system for KDE
ii  kdesktop                     4:3.5.5-1   miscellaneous binaries and files f
ii  kfind                        4:3.5.5-1   file-find utility for KDE
ii  khelpcenter                  4:3.5.5-1   help center for KDE
ii  kicker                       4:3.5.5-1   desktop panel for KDE
ii  klipper                      4:3.5.5-1   clipboard utility for KDE
ii  kmenuedit                    4:3.5.5-1   menu editor for KDE
ii  konqueror                    4:3.5.5-1   KDE's advanced file manager, web b
ii  konqueror-nsplugins          4:3.5.5-1   Netscape plugin support for Konque
ii  konsole                      4:3.5.5-1   X terminal emulator for KDE
ii  kpager                       4:3.5.5-1   desktop pager for KDE
ii  kpersonalizer                4:3.5.5-1   installation personalizer for KDE
ii  ksmserver                    4:3.5.5-1   session manager for KDE
ii  ksplash                      4:3.5.5-1   the KDE splash screen
ii  ksysguard                    4:3.5.5-1   system guard for KDE
ii  ktip                         4:3.5.5-1   useful tips for KDE
ii  kwin                         4:3.5.5-1   the KDE window manager
ii  libkonq4                     4:3.5.5-1   core libraries for Konqueror
ii  pmount                       0.9.13-1+b1 mount removable devices as normal 

Versions of packages kdebase recommends:
ii  kdm                           4:3.5.5-1  X display manager for KDE

-- no debconf information

Message #12 received at 391502-done@bugs.debian.org (full text, mbox, reply):

From: Christopher Martin <chrsmrtn@debian.org>

To: 391502-done@bugs.debian.org

Subject: Re: Bug#391502: Incorrect dependency on pmount

Date: Tue, 10 Oct 2006 17:28:47 -0400

[Message part 1 (text/plain, inline)]

On Friday 06 October 2006 18:45, Michael Biebl wrote:
> Package: kdebase
> Version: 4:3.5.5-1
> Severity: serious
> Justification: violates policy
>
> The latest package update introduced a strict dependency on hal and
> pmount. While the hal dependency is correct, the pmount dependency is
> not. KDE simply calls the hal Mount()/Unmount() methods, nowhere in
> the KDE code, pmount is actually used. If hal would use pmount
> internally to do the actual mounting[1], fine, let the hal package
> declare the correct dependencies. Adding the pmount dependency to
> kdebase is simply wrong and violates the policy, which states that
> strict dependencies have to reflect that the "depended-on package is
> required for the depending package to provide a significant amount of
> functionality" which is not the case here.
> Please see also #388341, the Recommends: pmount of
> kdebase-kio-plugins does not directly violate the policy, still it
> should be removed for the same reasons.

If the user does not have a line in /etc/fstab for a drive, then HAL 
will not be able to mount the drive in a way that works properly with 
KDE. Strange but true. That is, of course, unless pmount is installed, 
in which case HAL uses it to mount devices, in a way which works with 
KDE. Thus the depends/recommends on pmount makes perfect sense, and is 
by no means a policy violation.

Cheers,
Christopher Martin

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 391502@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@teco.edu>

To: 391502@bugs.debian.org

Cc: control@bugs.debian.org, Christopher Martin <chrsmrtn@debian.org>

Subject: Re: Bug#391502 closed by Christopher Martin <chrsmrtn@debian.org> (Re: Bug#391502: Incorrect dependency on pmount)

Date: Wed, 11 Oct 2006 00:05:04 +0200

[Message part 1 (text/plain, inline)]

reopen 391502
thanks

> On Friday 06 October 2006 18:45, Michael Biebl wrote:
>> Package: kdebase
>> Version: 4:3.5.5-1
>> Severity: serious
>> Justification: violates policy
>>
>> The latest package update introduced a strict dependency on hal and
>> pmount. While the hal dependency is correct, the pmount dependency is
>> not. KDE simply calls the hal Mount()/Unmount() methods, nowhere in
>> the KDE code, pmount is actually used. If hal would use pmount
>> internally to do the actual mounting[1], fine, let the hal package
>> declare the correct dependencies. Adding the pmount dependency to
>> kdebase is simply wrong and violates the policy, which states that
>> strict dependencies have to reflect that the "depended-on package is
>> required for the depending package to provide a significant amount of
>> functionality" which is not the case here.
>> Please see also #388341, the Recommends: pmount of
>> kdebase-kio-plugins does not directly violate the policy, still it
>> should be removed for the same reasons.
> 
> If the user does not have a line in /etc/fstab for a drive, then HAL 
> will not be able to mount the drive in a way that works properly with 
> KDE. Strange but true. That is, of course, unless pmount is installed, 
> in which case HAL uses it to mount devices, in a way which works with 
> KDE. Thus the depends/recommends on pmount makes perfect sense, and is 
> by no means a policy violation.
> 

Seems, you didn't read my email carefully. Since version 0.5.8, hal does
not use pmount anymore to do the mounting. Please check the source code,
if you don't believe me.
So now I have pmount installed, without any good reason.

And still, it's up to the hal package, to add the dependency on pmount
or not, because only the hal package knows, which tools it uses
internally to do the mounting.

Thanks,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #24 received at 391502@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@teco.edu>

To: 391502@bugs.debian.org

Subject: Re: Bug#391502 closed by Christopher Martin <chrsmrtn@debian.org> (Re: Bug#391502: Incorrect dependency on pmount)

Date: Wed, 11 Oct 2006 00:20:32 +0200

[Message part 1 (text/plain, inline)]

> If the user does not have a line in /etc/fstab for a drive, then HAL 
> will not be able to mount the drive in a way that works properly with 
> KDE. Strange but true. That is, of course, unless pmount is installed, 

This is btw not true anymore with hal-0.5.8.x.

> in which case HAL uses it to mount devices, in a way which works with 
> KDE. Thus the depends/recommends on pmount makes perfect sense, and is 
> by no means a policy violation.
> 
> Cheers,
> Christopher Martin


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #29 received at 391502@bugs.debian.org (full text, mbox, reply):

From: Christopher Martin <chrsmrtn@debian.org>

To: Michael Biebl <biebl@teco.edu>, 391502@bugs.debian.org

Subject: Re: Bug#391502: closed by Christopher Martin <chrsmrtn@debian.org> (Re: Bug#391502: Incorrect dependency on pmount)

Date: Tue, 10 Oct 2006 18:34:42 -0400

[Message part 1 (text/plain, inline)]

On Tuesday 10 October 2006 18:05, Michael Biebl wrote:
> reopen 391502
> thanks
>
> > On Friday 06 October 2006 18:45, Michael Biebl wrote:
> >> Package: kdebase
> >> Version: 4:3.5.5-1
> >> Severity: serious
> >> Justification: violates policy
> >>
> >> The latest package update introduced a strict dependency on hal
> >> and pmount. While the hal dependency is correct, the pmount
> >> dependency is not. KDE simply calls the hal Mount()/Unmount()
> >> methods, nowhere in the KDE code, pmount is actually used. If hal
> >> would use pmount internally to do the actual mounting[1], fine,
> >> let the hal package declare the correct dependencies. Adding the
> >> pmount dependency to kdebase is simply wrong and violates the
> >> policy, which states that strict dependencies have to reflect that
> >> the "depended-on package is required for the depending package to
> >> provide a significant amount of functionality" which is not the
> >> case here.
> >> Please see also #388341, the Recommends: pmount of
> >> kdebase-kio-plugins does not directly violate the policy, still it
> >> should be removed for the same reasons.
> >
> > If the user does not have a line in /etc/fstab for a drive, then
> > HAL will not be able to mount the drive in a way that works
> > properly with KDE. Strange but true. That is, of course, unless
> > pmount is installed, in which case HAL uses it to mount devices, in
> > a way which works with KDE. Thus the depends/recommends on pmount
> > makes perfect sense, and is by no means a policy violation.
>
> Seems, you didn't read my email carefully. Since version 0.5.8, hal
> does not use pmount anymore to do the mounting. Please check the
> source code, if you don't believe me.
> So now I have pmount installed, without any good reason.

Argh, you're right, I didn't read the last blurb. Thanks. That said, 
pmount is still used (_directly_ by KDE) in some code, so while I'll 
drop it from kdebase's Depends, it'll stay as a Recommends with 
kdebase-kio-plugins.

> And still, it's up to the hal package, to add the dependency on
> pmount or not, because only the hal package knows, which tools it
> uses internally to do the mounting.

I still disagree here, because this was an unusual case where the 
backend's choice of tool affected the frontend in an important way. But 
now it doesn't matter anyway.

Cheers,
Christopher Martin

[Message part 2 (application/pgp-signature, inline)]

Message #34 received at 391502-close@bugs.debian.org (full text, mbox, reply):

From: Christopher Martin <chrsmrtn@debian.org>

To: 391502-close@bugs.debian.org

Subject: Bug#391502: fixed in kdebase 4:3.5.5a-1

Date: Tue, 10 Oct 2006 17:21:14 -0700

Source: kdebase
Source-Version: 4:3.5.5a-1

We believe that the bug you reported is fixed in the latest version of
kdebase, which is due to be installed in the Debian FTP archive:

kappfinder_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kappfinder_3.5.5a-1_i386.deb
kate_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kate_3.5.5a-1_i386.deb
kcontrol_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kcontrol_3.5.5a-1_i386.deb
kdebase-bin_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdebase-bin_3.5.5a-1_i386.deb
kdebase-data_3.5.5a-1_all.deb
  to pool/main/k/kdebase/kdebase-data_3.5.5a-1_all.deb
kdebase-dbg_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdebase-dbg_3.5.5a-1_i386.deb
kdebase-dev_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdebase-dev_3.5.5a-1_i386.deb
kdebase-doc-html_3.5.5a-1_all.deb
  to pool/main/k/kdebase/kdebase-doc-html_3.5.5a-1_all.deb
kdebase-doc_3.5.5a-1_all.deb
  to pool/main/k/kdebase/kdebase-doc_3.5.5a-1_all.deb
kdebase-kio-plugins_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdebase-kio-plugins_3.5.5a-1_i386.deb
kdebase_3.5.5a-1.diff.gz
  to pool/main/k/kdebase/kdebase_3.5.5a-1.diff.gz
kdebase_3.5.5a-1.dsc
  to pool/main/k/kdebase/kdebase_3.5.5a-1.dsc
kdebase_3.5.5a-1_all.deb
  to pool/main/k/kdebase/kdebase_3.5.5a-1_all.deb
kdebase_3.5.5a.orig.tar.gz
  to pool/main/k/kdebase/kdebase_3.5.5a.orig.tar.gz
kdepasswd_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdepasswd_3.5.5a-1_i386.deb
kdeprint_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdeprint_3.5.5a-1_i386.deb
kdesktop_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdesktop_3.5.5a-1_i386.deb
kdm_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kdm_3.5.5a-1_i386.deb
kfind_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kfind_3.5.5a-1_i386.deb
khelpcenter_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/khelpcenter_3.5.5a-1_i386.deb
kicker_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kicker_3.5.5a-1_i386.deb
klipper_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/klipper_3.5.5a-1_i386.deb
kmenuedit_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kmenuedit_3.5.5a-1_i386.deb
konqueror-nsplugins_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/konqueror-nsplugins_3.5.5a-1_i386.deb
konqueror_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/konqueror_3.5.5a-1_i386.deb
konsole_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/konsole_3.5.5a-1_i386.deb
kpager_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kpager_3.5.5a-1_i386.deb
kpersonalizer_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kpersonalizer_3.5.5a-1_i386.deb
ksmserver_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/ksmserver_3.5.5a-1_i386.deb
ksplash_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/ksplash_3.5.5a-1_i386.deb
ksysguard_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/ksysguard_3.5.5a-1_i386.deb
ksysguardd_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/ksysguardd_3.5.5a-1_i386.deb
ktip_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/ktip_3.5.5a-1_i386.deb
kwin_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/kwin_3.5.5a-1_i386.deb
libkonq4-dev_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/libkonq4-dev_3.5.5a-1_i386.deb
libkonq4_3.5.5a-1_i386.deb
  to pool/main/k/kdebase/libkonq4_3.5.5a-1_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 391502@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christopher Martin <chrsmrtn@debian.org> (supplier of updated kdebase package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 10 Oct 2006 17:12:10 -0400
Source: kdebase
Binary: kdesktop kcontrol kpersonalizer kdm kdebase-doc-html kdebase-dbg klipper kappfinder kdebase-doc kdebase kmenuedit kicker libkonq4 konqueror-nsplugins kdebase-bin kdebase-dev ksplash kdeprint libkonq4-dev kwin kdepasswd ksmserver kfind kdebase-kio-plugins kpager khelpcenter kate ksysguard konqueror ktip ksysguardd kdebase-data konsole
Architecture: source i386 all
Version: 4:3.5.5a-1
Distribution: unstable
Urgency: high
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Christopher Martin <chrsmrtn@debian.org>
Description: 
 kappfinder - non-KDE application finder for KDE
 kate       - advanced text editor for KDE
 kcontrol   - control center for KDE
 kdebase    - base components from the official KDE release
 kdebase-bin - core binaries for the KDE base module
 kdebase-data - shared data files for the KDE base module
 kdebase-dbg - debugging symbols for kdebase
 kdebase-dev - development files for the KDE base module
 kdebase-doc - developer documentation for the KDE base module
 kdebase-doc-html - KDE base documentation in HTML format
 kdebase-kio-plugins - core I/O slaves for KDE
 kdepasswd  - password changer for KDE
 kdeprint   - print system for KDE
 kdesktop   - miscellaneous binaries and files for the KDE desktop
 kdm        - X display manager for KDE
 kfind      - file-find utility for KDE
 khelpcenter - help center for KDE
 kicker     - desktop panel for KDE
 klipper    - clipboard utility for KDE
 kmenuedit  - menu editor for KDE
 konqueror  - KDE's advanced file manager, web browser and document viewer
 konqueror-nsplugins - Netscape plugin support for Konqueror
 konsole    - X terminal emulator for KDE
 kpager     - desktop pager for KDE
 kpersonalizer - installation personalizer for KDE
 ksmserver  - session manager for KDE
 ksplash    - the KDE splash screen
 ksysguard  - system guard for KDE
 ksysguardd - system guard daemon for KDE
 ktip       - useful tips for KDE
 kwin       - the KDE window manager
 libkonq4   - core libraries for Konqueror
 libkonq4-dev - development files for Konqueror's core libraries
Closes: 391357 391361 391502
Changes: 
 kdebase (4:3.5.5a-1) unstable; urgency=high
 .
   * New upstream tarball, with a number of fixes. Also include several
     important patches that didn't make the tarball.
     + Fixes 'konsole flashes and is unusable' with some focus policies.
       (Closes: #391357, #391361)
     + This upload, and the last one, must make Etch with their RC fixes,
       so urgency=high.
 .
   * Drop the pmount Depends from the kdebase metapackage, since pmount isn't
     important with the latest HAL. (Closes: #391502)
Files: 
 4acc68a7c7e97f7404966fcffa699043 1988 kde optional kdebase_3.5.5a-1.dsc
 61d340d8bba19634c8b5b6c5f4aa8a68 28655867 kde optional kdebase_3.5.5a.orig.tar.gz
 215404c37f20d2c8e33f63342ed09b62 764054 kde optional kdebase_3.5.5a-1.diff.gz
 dace9eead319ec2c4105116ece909436 38800 kde optional kdebase_3.5.5a-1_all.deb
 ad8337ce25cc80375793521f461e28cc 9900394 kde optional kdebase-data_3.5.5a-1_all.deb
 d538cd63d357b7fccf0a904c3a01d997 2022430 doc optional kdebase-doc_3.5.5a-1_all.deb
 d4d889f9ed1b59d7caa5fa386a814fa0 389010 doc optional kdebase-doc-html_3.5.5a-1_all.deb
 901c6f2493fa38c61ea147e09c2ed7ae 284644 kde optional kappfinder_3.5.5a-1_i386.deb
 ff452b68e6d2cc0ca3a2ab4ba0dee287 786782 editors optional kate_3.5.5a-1_i386.deb
 db388525276c0a521982d99cf0b6684a 2972868 kde optional kcontrol_3.5.5a-1_i386.deb
 a5cde881cb0cde0a43d3764d93b2c8e3 1191954 kde optional kdebase-bin_3.5.5a-1_i386.deb
 1ef3214ed6650393c586ac9aa81bf03b 78450 devel optional kdebase-dev_3.5.5a-1_i386.deb
 089cad4a2526b6e90144f4ab766f378b 1103466 kde optional kdebase-kio-plugins_3.5.5a-1_i386.deb
 63412b0cbbfd5ea9e53387c1f50e272b 240432 utils optional kdepasswd_3.5.5a-1_i386.deb
 d62bdb9ac7a9b63ba0e554dc47ff92e3 1305490 utils optional kdeprint_3.5.5a-1_i386.deb
 b5a8e3fde349df9a1f88b6ae4805374a 776700 kde optional kdesktop_3.5.5a-1_i386.deb
 92537fe664e6fbfeed9d44e6a701060f 632792 kde optional kdm_3.5.5a-1_i386.deb
 5e89857f41b7ac4b4fa9056b2a802f33 200718 utils optional kfind_3.5.5a-1_i386.deb
 dab232d2c3da6acfde51770f85a529b7 2211422 kde optional khelpcenter_3.5.5a-1_i386.deb
 84f2c926cfe21062adf2ad224e8acca5 1998234 kde optional kicker_3.5.5a-1_i386.deb
 bc485cb7eabc044d94a10c436c63e41b 275098 kde optional klipper_3.5.5a-1_i386.deb
 e662b5f8773c818e1d31438876467bdd 377468 kde optional kmenuedit_3.5.5a-1_i386.deb
 d255a83fc9655666b864a5a4ffb34831 2012462 web optional konqueror_3.5.5a-1_i386.deb
 e4d629bf52519e265a722d1384d34100 141312 utils optional konqueror-nsplugins_3.5.5a-1_i386.deb
 413d76d602a77763984e09b9fa655b4f 727588 kde optional konsole_3.5.5a-1_i386.deb
 5ffe015b2da53a8f77419e2225b21d5b 114076 kde optional kpager_3.5.5a-1_i386.deb
 340ce58c037fb5d9f0d5f8d6f3ecb017 491902 kde optional kpersonalizer_3.5.5a-1_i386.deb
 6f786827cc617d8ce21b336c70b1e0ef 162210 kde optional ksmserver_3.5.5a-1_i386.deb
 4fd76935f25dbc9a4e9e640b363ce205 711288 kde optional ksplash_3.5.5a-1_i386.deb
 14171bc0064b85732230edbc20c69b9b 500772 utils optional ksysguard_3.5.5a-1_i386.deb
 4d1632e9e334c987aa7848d105cb099e 67832 utils optional ksysguardd_3.5.5a-1_i386.deb
 02d7a591670a390abeccca167775f42e 102922 kde optional ktip_3.5.5a-1_i386.deb
 932710608d9147b447f216ba5a1695e0 1032960 kde optional kwin_3.5.5a-1_i386.deb
 edfa7ff31becadf2e5cc0e308d12f854 267604 libs optional libkonq4_3.5.5a-1_i386.deb
 1d7d3b01a3f544d7fb341b3a76944ab2 63492 libdevel optional libkonq4-dev_3.5.5a-1_i386.deb
 d08bf2da67a22b69aca45ce600166099 33016848 libdevel extra kdebase-dbg_3.5.5a-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Signed by Christopher Martin <chrsmrtn@debian.org>

iD8DBQFFLCxRU+gWW+vtsysRAt15AJ4vJiDla+PK+TWpu2WK3QlBmjpqzQCggwLq
Kg+aj/HaQbqQ7X+sUr4n1fo=
=0udv
-----END PGP SIGNATURE-----

Message #39 received at 391502@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@teco.edu>

To: 391502@bugs.debian.org

Cc: Christopher Martin <chrsmrtn@debian.org>

Subject: Re: Bug#391502 closed by Christopher Martin <chrsmrtn@debian.org> (Re: Bug#391502: Incorrect dependency on pmount)

Date: Wed, 11 Oct 2006 17:01:30 +0200

[Message part 1 (text/plain, inline)]

>> The latest package update introduced a strict dependency on hal and
>> pmount. While the hal dependency is correct, the pmount dependency is
>> not. KDE simply calls the hal Mount()/Unmount() methods, nowhere in
>> the KDE code, pmount is actually used. If hal would use pmount
>> internally to do the actual mounting[1], fine, let the hal package
>> declare the correct dependencies. Adding the pmount dependency to
>> kdebase is simply wrong and violates the policy, which states that
>> strict dependencies have to reflect that the "depended-on package is
>> required for the depending package to provide a significant amount of
>> functionality" which is not the case here.
>> Please see also #388341, the Recommends: pmount of
>> kdebase-kio-plugins does not directly violate the policy, still it
>> should be removed for the same reasons.
> 
> If the user does not have a line in /etc/fstab for a drive, then HAL 
> will not be able to mount the drive in a way that works properly with 
> KDE. Strange but true. That is, of course, unless pmount is installed, 
> in which case HAL uses it to mount devices, in a way which works with 
> KDE. Thus the depends/recommends on pmount makes perfect sense, and is 
> by no means a policy violation.
> 
> Cheers,
> Christopher Martin

Oh dear, what a mess. Seems you were right, Christopher.

Being part of the Debian Utopia team (which amongst others maintains
hal), I knew, that the mount code (actually bash scripts) in 0.5.7 had
some problems and we used to patch them to make use of pmount.
Beginning with hal-0.5.8 we dropped these pmount patches from hal, as
the mount code in hal was more robust and better dealt with
non-removable/removable devices, or devices configured in /etc/fstab.

Before I filed this bug report, I grepped the sources of kdebase and
couldn't find a reference to pmount/pumount. I also did some tests with
my cdrom drive. I removed the pmount binaries, and mounting/unmounting
of the drive was still possible as an un-priviledged user (no matter if
the device was configured in /etc/fstab or not). Only ejecting without
having it unmounted first did not work without pmount.
I therefore thought kded media manager properly uses hal to
mount/unmount devices and it would be safe to remove the dependency on
pmount.
Today a friend of mine brought me an USB stick. I plugged it in, the
icon appeared on the desktop and I was able to mount the device without
problems. Unfortunately the option "Safely Remove" from the context menu
did not have any effect. Only after installing pmount, I was able to
unmount the USB stick. So, indeed, KDE seems to need pmount for
successfully mounting/unmounting devices, and I was wrong requesting the
removal of the dependency.
The real problem though seems to be, that KDE doesn't use hal properly,
to do the mounting/unmounting/ejecting.
Unfortunately the code in kioslave/media/mediamanager/ is quite complex
and large, so I couldn't easily spot the problem. Someone with more
knowledge of this code should take a look at this and fix the hal
support there.

To make a long story short, I think the hal related mount code in KDE is
somewhat broken atm and should be fixed in the long term. As a short
term solution it's probably better to add the pmount dependency back.


Cheers,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #44 received at 391502@bugs.debian.org (full text, mbox, reply):

From: Christopher Martin <chrsmrtn@debian.org>

To: Michael Biebl <biebl@teco.edu>

Cc: 391502@bugs.debian.org

Subject: Re: Bug#391502 closed by Christopher Martin <chrsmrtn@debian.org> (Re: Bug#391502: Incorrect dependency on pmount)

Date: Wed, 11 Oct 2006 17:41:57 -0400

[Message part 1 (text/plain, inline)]

On Wednesday 11 October 2006 11:01, Michael Biebl wrote:
> Oh dear, what a mess. Seems you were right, Christopher.
>
> Being part of the Debian Utopia team (which amongst others maintains
> hal), I knew, that the mount code (actually bash scripts) in 0.5.7
> had some problems and we used to patch them to make use of pmount.
> Beginning with hal-0.5.8 we dropped these pmount patches from hal, as
> the mount code in hal was more robust and better dealt with
> non-removable/removable devices, or devices configured in /etc/fstab.
>
> Before I filed this bug report, I grepped the sources of kdebase and
> couldn't find a reference to pmount/pumount. I also did some tests
> with my cdrom drive. I removed the pmount binaries, and
> mounting/unmounting of the drive was still possible as an
> un-priviledged user (no matter if the device was configured in
> /etc/fstab or not). Only ejecting without having it unmounted first
> did not work without pmount.
> I therefore thought kded media manager properly uses hal to
> mount/unmount devices and it would be safe to remove the dependency
> on pmount.
> Today a friend of mine brought me an USB stick. I plugged it in, the
> icon appeared on the desktop and I was able to mount the device
> without problems. Unfortunately the option "Safely Remove" from the
> context menu did not have any effect. Only after installing pmount, I
> was able to unmount the USB stick. So, indeed, KDE seems to need
> pmount for successfully mounting/unmounting devices, and I was wrong
> requesting the removal of the dependency.
> The real problem though seems to be, that KDE doesn't use hal
> properly, to do the mounting/unmounting/ejecting.
> Unfortunately the code in kioslave/media/mediamanager/ is quite
> complex and large, so I couldn't easily spot the problem. Someone
> with more knowledge of this code should take a look at this and fix
> the hal support there.
>
> To make a long story short, I think the hal related mount code in KDE
> is somewhat broken atm and should be fixed in the long term. As a
> short term solution it's probably better to add the pmount dependency
> back.

Will do.

Thanks for the information. And yes, the KDE code is almost certainly to 
blame here. Hopefully KDE4 will clean things up.

Cheers,
Christopher Martin

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.