Debian Bug report logs -
#390703
digikam: shouldn't depend on libgphoto2-2-dev
Toggle useless messages
Report forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Jan De Luyck <jan-bugs@kcore.org>:
New Bug report received and forwarded. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #5 received at submit@bugs.debian.org (full text, mbox, reply):
Package: digikam
Version: 1:0.8.2-2
Severity: normal
I have no idea why digikam depends on libgphoto2-2-dev, I've dug through
the contents of said development package, but couldn't really find a
reason.
Maybe this dependency can be removed?
Thanks,
Jan
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18
Locale: LANG=en_GB.ISO-8859-15, LC_CTYPE=en_GB.ISO-8859-15 (charmap=ISO-8859-15)
Versions of packages digikam depends on:
ii dcraw 8.38-1 decode raw digital camera images
ii kdelibs4c2a 4:3.5.4-3 core libraries and binaries for al
ii libacl1 2.2.41-1 Access control list shared library
ii libart-2.0-2 2.3.17-1 Library of functions for 2D graphi
ii libattr1 2.4.32-1 Extended attribute shared library
ii libaudio2 1.8-2 The Network Audio System (NAS). (s
ii libc6 2.3.6.ds1-5 GNU C Library: Shared libraries
ii libexif12 0.6.13-4 library to parse EXIF files
ii libfam0 2.7.0-10 Client library to control the FAM
ii libfontconfig1 2.4.1-2 generic font configuration library
ii libfreetype6 2.2.1-5 FreeType 2 font engine, shared lib
ii libgcc1 1:4.1.1-15 GCC support library
ii libgphoto2-2 2.2.1-5 gphoto2 digital camera library
ii libgphoto2-2-dev 2.2.1-5 gphoto2 digital camera library (de
ii libgphoto2-port0 2.2.1-5 gphoto2 digital camera port librar
ii libice6 1:1.0.1-2 X11 Inter-Client Exchange library
ii libidn11 0.6.5-1 GNU libidn library, implementation
ii libimlib2 1.2.1-2 powerful image loading and renderi
ii libjpeg62 6b-13 The Independent JPEG Group's JPEG
ii libkexif1 0.2.3-2 library for KDE to read/display/ed
ii libkipi0 0.1.4-1 library for apps that want to use
ii libpng12-0 1.2.8rel-5.2 PNG library - runtime
ii libqt3-mt 3:3.3.6-4 Qt GUI Library (Threaded runtime v
ii libsm6 1:1.0.1-3 X11 Session Management library
ii libsqlite3-0 3.3.7-1 SQLite 3 shared library
ii libstdc++6 4.1.1-15 The GNU Standard C++ Library v3
ii libtiff4 3.8.2-6 Tag Image File Format (TIFF) libra
ii libx11-6 2:1.0.0-9 X11 client-side library
ii libxcursor1 1.1.7-4 X cursor management library
ii libxext6 1:1.0.1-2 X11 miscellaneous extension librar
ii libxft2 2.1.8.2-8 FreeType-based font drawing librar
ii libxi6 1:1.0.1-3 X11 Input extension library
ii libxinerama1 1:1.0.1-4.1 X11 Xinerama extension library
ii libxrandr2 2:1.1.0.2-4 X11 RandR extension library
ii libxrender1 1:0.9.1-3 X Rendering Extension client libra
ii libxt6 1:1.0.2-2 X11 toolkit intrinsics library
ii zlib1g 1:1.2.3-13 compression library - runtime
Versions of packages digikam recommends:
ii digikamimageplugins 0.8.2-3 image editor plugins for digikam a
ii kdeprint 4:3.5.4-2+b2 print system for KDE
ii kipi-plugins 0.1.2-3 image manipulation/handling plugin
ii konqueror 4:3.5.4-2+b2 KDE's advanced file manager, web b
-- no debconf information
Message sent on to Jan De Luyck <jan-bugs@kcore.org>:
Bug#390703.
(full text, mbox, link).
Message #8 received at 390703-submitter@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
On Monday 02 October 2006 18:28, Jan De Luyck wrote:
> Package: digikam
> Version: 1:0.8.2-2
> Severity: normal
>
>
> I have no idea why digikam depends on libgphoto2-2-dev, I've dug through
> the contents of said development package, but couldn't really find a
> reason.
Please see this debian-bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=374460
You can try to do a dpkg --remove --force-depends libgphoto2-2-dev to test if
all works as expected withotu the -dev package
that temporarily 'hoses' apt, but apt-get -f install can fix it again.
If everything works after trying to remove that package, please report it
again. If not, then please close this bug by mailing
390703-done@bugs.debian.org
/Sune
--
How may I digit from a server of the memory over a proxy?
First of all you must doubleclick a wordprocessor to load to a RAM
application.
[Message part 2 (application/pgp-signature, inline)]
Acknowledgement sent to Jan De Luyck <jan-bugs@kcore.org>:
Extra info received and filed, but not forwarded.
(full text, mbox, link).
Message #13 received at 390703-quiet@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
On Monday 02 October 2006 19:35, Sune Vuorela wrote:
> You can try to do a dpkg --remove --force-depends libgphoto2-2-dev to test
> if all works as expected withotu the -dev package
I've just tried that, all works as it should with my Canon Powershot A95
camera.
> If everything works after trying to remove that package, please report it
> again.
Hereby, confirming that it seems this dependency is (no longer?) necessary.
Kind regards,
Jan
--
I guess you guys got BIG MUSCLES from doing too much STUDYING!
[Message part 2 (application/pgp-signature, inline)]
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Mark Purcell <msp@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #18 received at 390703@bugs.debian.org (full text, mbox, reply):
After having a look the dependency on libgphoto2-2-dev is still necessary.
Without it the list of cameras does not appear..
This is I guess really a libgphoto2-2-dev issue.
Mark
Message sent on to Jan De Luyck <jan-bugs@kcore.org>:
Bug#390703.
(full text, mbox, link).
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Frederic Peters <fpeters@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #26 received at 390703@bugs.debian.org (full text, mbox, reply):
Mark Purcell wrote:
> After having a look the dependency on libgphoto2-2-dev is still necessary.
>
> Without it the list of cameras does not appear..
>
> This is I guess really a libgphoto2-2-dev issue.
I don't have bandwidth right now to look at digikam but for the record
gthumb works fine listing cameras even with libgphoto2-2-dev not
installed (just tested again).
I really do believe it is in issue with digikam.
Woul you mind strace -e trace=file digikam and look for files from
libgphoto2-2-dev ?
Thanks,
Frederic
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Mark Purcell <msp@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #31 received at 390703@bugs.debian.org (full text, mbox, reply):
Thanks Federic,
On Friday 20 October 2006 21:38, Frederic Peters wrote:
> I don't have bandwidth right now to look at digikam but for the record
> gthumb works fine listing cameras even with libgphoto2-2-dev not
> installed (just tested again).
>
> I really do believe it is in issue with digikam.
Don't mind where the issue is, it would just be nice to get to the bottom and
fixup ;-)
>
> Woul you mind strace -e trace=file digikam and look for files from
> libgphoto2-2-dev ?
Looks like digikam is looking for a couple of .la files, which doesn't sound
right... Some examples are disk.la & usb.la which are only in
libgphoto2-2-dev.
Mark
open("/usr/lib/libgphoto2_port/0.6.1", O_RDONLY|O_NONBLOCK|O_LARGEFILE|
O_DIRECTORY) = 23
open("/usr/lib/libgphoto2_port/0.6.1/disk.la", O_RDONLY) = 23
open("/usr/lib/libgphoto2_port/0.6.1/usb.la", O_RDONLY) = 23
open("/etc/ld.so.cache", O_RDONLY) = 23
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or
directory)
open("/lib/tls/i686/cmov/usb.a", O_RDONLY) = -1 ENOENT (No such file or
directory)
open("/lib/tls/i686/usb.a", O_RDONLY) = -1 ENOENT (No such file or
directory)
open("/lib/tls/usb.a", O_RDONLY) = -1 ENOENT (No such file or
directory)
open("/lib/usb.a", O_RDONLY) = -1 ENOENT (No such file or
directory)
open("/usr/lib/i686/cmov/usb.a", O_RDONLY) = -1 ENOENT (No such file or
directory)
open("/usr/lib/i686/usb.a", O_RDONLY) = -1 ENOENT (No such file or
directory)
Disconnected #390703 from all other report(s).
Request was from Mark Purcell <msp@debian.org>
to control@bugs.debian.org.
(full text, mbox, link).
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Mark Purcell <msp@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #40 received at 390703@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Achim,
From the svn/experimental changelog you made the entry:
+ remove runtime dependency on libgpthoto2-2-dev. No longer necessary.
I think the runtime dependency on libgphoto is still required.
Without it installed, when I go into the Camera/Add Camera.../Add.., the 'Camera List' is totally empty.
With libgphoto2-2-dev installed the Camera List details cameras supported by libghoto.
http://bugs.debian.org/390703 refers.
Mark
[Message part 2 (application/pgp-signature, inline)]
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Mark Purcell <msp@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #47 received at 390703@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
clone 390703 -1
reassign -1 libgphoto2-2
retitle -1 libgphoto2: .la files for the camlibs and ports MUST be in the runtime package
severity -1 important
block 390703 by -1
thanks
Frederic,
One of the upstream devs for libgphoto, Marcus Meissner, has said that:
".la files for the camlibs and ports MUST be in the runtime package, as they are not development files but are used during runtime"
http://bugs.kde.org/show_bug.cgi?id=125696#c20
I have cloned the bug from the Debian BTS and assigned it to libgphoto2, noting it's blocking the fix for digikam.
Marcus, if you do reply, could I ask you to maintain the Cc: so your response is tracked in the Debian Bug Tracking System (BTS).
http://bugs.debian.org/390703
Thanks,
Mark
On Friday 20 October 2006 21:38, Frederic Peters wrote:
> I don't have bandwidth right now to look at digikam but for the record
> gthumb works fine listing cameras even with libgphoto2-2-dev not
> installed (just tested again).
>
> I really do believe it is in issue with digikam.
[Message part 2 (application/pgp-signature, inline)]
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Marcus Meissner <marcus@jet.franken.de>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #52 received at 390703@bugs.debian.org (full text, mbox, reply):
On Fri, Jan 19, 2007 at 06:29:04PM +0000, Mark Purcell wrote:
> clone 390703 -1
> reassign -1 libgphoto2-2
> retitle -1 libgphoto2: .la files for the camlibs and ports MUST be in the runtime package
> severity -1 important
> block 390703 by -1
> thanks
>
> Frederic,
>
> One of the upstream devs for libgphoto, Marcus Meissner, has said that:
> ".la files for the camlibs and ports MUST be in the runtime package, as they are not development files but are used during runtime"
>
> http://bugs.kde.org/show_bug.cgi?id=125696#c20
>
> I have cloned the bug from the Debian BTS and assigned it to libgphoto2, noting it's blocking the fix for digikam.
>
> Marcus, if you do reply, could I ask you to maintain the Cc: so your response is tracked in the Debian Bug Tracking System (BTS).
> http://bugs.debian.org/390703
Err, actually the .la files not necessary as I now know. ... Sorry for the confusion.
Ciao, Marcus
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Marcus Meissner <marcus@jet.franken.de>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #57 received at 390703@bugs.debian.org (full text, mbox, reply):
On Fri, Jan 19, 2007 at 10:48:14AM -0800, Debian Bug Tracking System wrote:
I am sorry, I was mistaken....
Further investigations shows a conflict between the KDE builtin libltdl
(in libkdecore) and the external ones and how libgphoto2 uses it.
This conflict needs to be resolved first ...
Until then please include the .la files.
Merged 390703 416123.
Request was from Mark Purcell <mark@purcell.id.au>
to control@bugs.debian.org.
(Sun, 29 Apr 2007 07:06:04 GMT) (full text, mbox, link).
Tags added: upstream
Request was from Mark Purcell <mark@purcell.id.au>
to control@bugs.debian.org.
(Sun, 29 Apr 2007 07:09:03 GMT) (full text, mbox, link).
Tags added: upstream
Request was from Mark Purcell <mark@purcell.id.au>
to control@bugs.debian.org.
(Sun, 29 Apr 2007 07:09:04 GMT) (full text, mbox, link).
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Mark Purcell <msp@debian.org>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #68 received at 390703@bugs.debian.org (full text, mbox, reply):
[Message part 1 (text/plain, inline)]
Luka,
I see from the ubuntu changelog for digikam that you claim that you no longer
need the libgphoto .la files due to the difference in the way the Kubuntu KDE
has been built.
I can confirm I am still having this problem in Debian with the 0.9.2 final
release package.
Can you provide some details so we can get this fixed in Debian?
Thanks,
Mark
+digikam (2:0.9.2~beta2-1ubuntu1) gutsy; urgency=low
+
+ * Merge from debian unstable, remaining changes:
+ - debian/control: don't depend on libgphoto2-2-dev.
+ Kubuntu's KDE finds the libgphoto plugins without the .la files.
+ - debian/patches/11-add-service-menu-translations.diff:
+ Rework patch to apply - French translation of .desktop file
+ * Added debian/patches/digikam-svn-r669532.diff:
+ Post-Beta2 fix from KDE SVN for preview bug. Closes: KDE #146072.
+
+ -- Luka Renko <lure@ubuntu.com> Wed, 30 May 2007 19:36:57 +0200
[signature.asc (application/pgp-signature, inline)]
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Achim Bohnet <ach@mpe.mpg.de>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #73 received at 390703@bugs.debian.org (full text, mbox, reply):
On Tuesday, 19. June 2007, Mark Purcell wrote:
> Luka,
>
> I see from the ubuntu changelog for digikam that you claim that you no longer
> need the libgphoto .la files due to the difference in the way the Kubuntu KDE
> has been built.
Kubuntu _never_ needed the libgphoto2-dev .la files. This
change is most of the time the only change in the digikam
kubuntu pkg.
> I can confirm I am still having this problem in Debian with the 0.9.2 final
> release package.
Damn :( Have you the time to try the fix described
http://bugs.kde.org/show_bug.cgi?id=125696#c28
and following comments?
>
> Can you provide some details so we can get this fixed in Debian?
Lure and me discussed it on #kubuntu-devel on freenode. Up to now
we found nothing that explains the difference.
Maybe, while at debconf, you can join #debian-qt-kde on oftc.
Lure and myself are usualy there too.
Achim
>
> Thanks,
> Mark
>
>
> +digikam (2:0.9.2~beta2-1ubuntu1) gutsy; urgency=low
> +
> + * Merge from debian unstable, remaining changes:
> + - debian/control: don't depend on libgphoto2-2-dev.
> + Kubuntu's KDE finds the libgphoto plugins without the .la files.
> + - debian/patches/11-add-service-menu-translations.diff:
> + Rework patch to apply - French translation of .desktop file
> + * Added debian/patches/digikam-svn-r669532.diff:
> + Post-Beta2 fix from KDE SVN for preview bug. Closes: KDE #146072.
> +
> + -- Luka Renko <lure@ubuntu.com> Wed, 30 May 2007 19:36:57 +0200
>
--
To me vi is Zen. To use vi is to practice zen. Every command is
a koan. Profound to the user, unintelligible to the uninitiated.
You discover truth everytime you use it.
-- reddy@lion.austin.ibm.com
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Jonathan Riddell <jriddell@ubuntu.com>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #78 received at 390703@bugs.debian.org (full text, mbox, reply):
On Tue, Jun 19, 2007 at 05:39:20PM +0100, Mark Purcell wrote:
> Luka,
>
> I see from the ubuntu changelog for digikam that you claim that you no longer
> need the libgphoto .la files due to the difference in the way the Kubuntu KDE
> has been built.
>
> I can confirm I am still having this problem in Debian with the 0.9.2 final
> release package.
>
> Can you provide some details so we can get this fixed in Debian?
I've not looked into this myself, but there's nothing I know of that
Ubuntu does which should make any difference. I asked Matthias Klose
who suggested Ubuntu might happen to have a reference to the gphoto.so
file which Debian doesn't. I can see in /usr/lib/libdigikam.la
dependency_libs='.../usr/lib/libgphoto2.la /usr/lib/libexif.la
/usr/lib/libgphoto2_port.la...' but I have neither of those files
installed so I'm at a bit of a loss what the difference could be.
Jonathan
Information forwarded to debian-bugs-dist@lists.debian.org, Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>:
Bug#390703; Package digikam.
(full text, mbox, link).
Acknowledgement sent to Achim Bohnet <ach@mpe.mpg.de>:
Extra info received and forwarded to list. Copy sent to Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>.
(full text, mbox, link).
Message #83 received at 390703@bugs.debian.org (full text, mbox, reply):
On Wednesday, 27. June 2007, Jonathan Riddell wrote:
> On Tue, Jun 19, 2007 at 05:39:20PM +0100, Mark Purcell wrote:
> > Luka,
> >
> > I see from the ubuntu changelog for digikam that you claim that you no longer
> > need the libgphoto .la files due to the difference in the way the Kubuntu KDE
> > has been built.
> >
> > I can confirm I am still having this problem in Debian with the 0.9.2 final
> > release package.
> >
> > Can you provide some details so we can get this fixed in Debian?
>
> I've not looked into this myself, but there's nothing I know of that
> Ubuntu does which should make any difference. I asked Matthias Klose
Best hint we have up to now is Marcus Meissners msg from 19 Jan
in this bug report thread:
...
Further investigations shows a conflict between the KDE builtin libltdl
(in libkdecore) and the external ones and how libgphoto2 uses it.
...
Marcus: can you elaborate how you found this out? Makes for us (or is it
only me?) 'glueless' hopefully easier to compare kubuntu and debian to find
out what needs to be changed in debian.
> who suggested Ubuntu might happen to have a reference to the gphoto.so
> file which Debian doesn't. I can see in /usr/lib/libdigikam.la
> dependency_libs='.../usr/lib/libgphoto2.la /usr/lib/libexif.la
> /usr/lib/libgphoto2_port.la...' but I have neither of those files
> installed so I'm at a bit of a loss what the difference could be.
Not the build-deps of digikam on disk? ;)
(0) ~ $ dpkg -L libgphoto2-2-dev | grep la
...
/usr/lib/libgphoto2_port.la
/usr/lib/libgphoto2_port/0.7.0/serial.la
/usr/lib/libgphoto2_port/0.7.0/usb.la
/usr/lib/libgphoto2_port/0.7.0/disk.la
/usr/lib/libgphoto2_port/0.7.0/ptpip.la
/usr/lib/libgphoto2.la
...
Achim
> Jonathan
--
To me vi is Zen. To use vi is to practice zen. Every command is
a koan. Profound to the user, unintelligible to the uninitiated.
You discover truth everytime you use it.
-- reddy@lion.austin.ibm.com
Tags added: pending
Request was from Mark Purcell <msp@debian.org>
to control@bugs.debian.org.
(Thu, 15 Nov 2007 08:06:04 GMT) (full text, mbox, link).
Bug archived.
Request was from Debbugs Internal Request <owner@bugs.debian.org>
to internal_control@bugs.debian.org.
(Sat, 19 Apr 2008 07:26:46 GMT) (full text, mbox, link).
Send a report that this bug log contains spam.
Debian bug tracking system administrator <owner@bugs.debian.org>.
Last modified:
Fri Jan 5 11:03:39 2018;
Machine Name:
buxtehude
Debian Bug tracking system
Debbugs is free software and licensed under the terms of the GNU
Public License version 2. The current version can be obtained
from https://bugs.debian.org/debbugs-source/.
Copyright © 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson,
2005-2017 Don Armstrong, and many other contributors.