Debian Bug report logs - #387808
initramfs-tools: scripts/nfs doesn't properly handle when server-ip is included in root-path

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant+bugs@freegeek.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: initramfs-tools: scripts/nfs doesn't properly handle when server-ip is included in root-path

Date: Sat, 16 Sep 2006 12:22:31 -0700

[Message part 1 (text/plain, inline)]

Package: initramfs-tools
Version: 0.79
Severity: normal

one more bugfix to the nfs handling. :)

it's a trivial fix, but when the dhcp server passes the server-ip as
part of root-path, it's not correctly handled in scripts/nfs. patch
attached which fixes this.

live well,
  vagrant

[initramfs-tools.nfs.handle-rootpath.diff (text/plain, attachment)]

Message #12 received at 387808-close@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>

To: 387808-close@bugs.debian.org

Subject: Bug#387808: fixed in initramfs-tools 0.80

Date: Tue, 19 Sep 2006 07:47:05 -0700

Source: initramfs-tools
Source-Version: 0.80

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.80.dsc
  to pool/main/i/initramfs-tools/initramfs-tools_0.80.dsc
initramfs-tools_0.80.tar.gz
  to pool/main/i/initramfs-tools/initramfs-tools_0.80.tar.gz
initramfs-tools_0.80_all.deb
  to pool/main/i/initramfs-tools/initramfs-tools_0.80_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 387808@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@sternwelten.at> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 19 Sep 2006 07:56:47 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.80
Distribution: unstable
Urgency: high
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@sternwelten.at>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 387808 387809 387841 387909
Changes: 
 initramfs-tools (0.80) unstable; urgency=high
 .
   Release "O partigiano, portami via, che mi sento di morir."
 .
   * update-initramfs: Test for lilo executable earlier otherwise an warning
     would be issued with grub installed and left over lilo config.
 .
   * hook-functions: Add lasi700 to the scsi modules. (closes: 387909) Thanks
     Nagilum <nagilum@nagilum.org>. Thus urgency high.
 .
   * scripts/nfs: Fix typo in ipconfig protocol handling, fix dhcp server
     passing ser-ip as part of root-path, retry every second to not hammer
     an FAI'ed nfs initramfs network.  Thanks for input and patches
     Vagrant Cascadian <vagrant+bugs@freegeek.org>. While we are there refactor
     the loop. (closes: 387841, 387808, 387809)
 .
   * update-initramfs: Check if /proc is mounted for ro_boot_check.
Files: 
 592233da42384cb4efebb6f9f6bdf088 623 utils optional initramfs-tools_0.80.dsc
 86b0d2f4b36f6ffdebd81d2b0d57446b 50245 utils optional initramfs-tools_0.80.tar.gz
 b48e40fe1e51328dd4b40097f6e6939a 56158 utils optional initramfs-tools_0.80_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFEAEy6n7So0GVSSARAkZmAJ9qBmwsmFRa2HYpRubkZ7pIhHljRACfWDbr
7OBrpE5vmws0mb9KPopI0RI=
=zq3e
-----END PGP SIGNATURE-----

Message #17 received at 387808@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant+bugs@freegeek.org>

To: Debian Bug Tracking System <387808@bugs.debian.org>

Cc: control@bugs.debian.org

Subject: initramfs-tools: patch for when root-path includes server-ip is bunk

Date: Fri, 22 Sep 2006 09:10:38 -0700

Package: initramfs-tools
Followup-For: Bug #387808
found 387808 0.80
thanks

i don't know what i was smoking.

as best i can tell, this wasn't a problem in 0.79, and the patch i filed
in this bug report actually *caused* the problem, rather than solving
it.

i suspect there may be some situations in which it still is a problem. i
will look into it further.

sorry for the bunk patch.  it should be reverted.

live well,
  vagrant

Message #24 received at 387808@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>

To: Vagrant Cascadian <vagrant+bugs@freegeek.org>, 387808@bugs.debian.org

Subject: Re: Bug#387808: initramfs-tools: patch for when root-path includes server-ip is bunk

Date: Wed, 27 Sep 2006 15:16:09 +0200

On Fri, 22 Sep 2006, Vagrant Cascadian wrote:

> i don't know what i was smoking.

i think you passed NFSROOT=":/org/foo/root"
instead of NFSROOT="/org/foo/root"

nfsroot=[<server-ip>:]<root-dir>[,<nfs-options>]
according to Documentation/nfsroot.txt 

so the previosu behaviour of 0.79 was right,
ill revert that small change.

-- 
maks

ps please bcc control@b.d.o, makes it easier to use an reply to all :)

Message #29 received at 387808-close@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>

To: 387808-close@bugs.debian.org

Subject: Bug#387808: fixed in initramfs-tools 0.81

Date: Wed, 27 Sep 2006 09:17:09 -0700

Source: initramfs-tools
Source-Version: 0.81

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.81.dsc
  to pool/main/i/initramfs-tools/initramfs-tools_0.81.dsc
initramfs-tools_0.81.tar.gz
  to pool/main/i/initramfs-tools/initramfs-tools_0.81.tar.gz
initramfs-tools_0.81_all.deb
  to pool/main/i/initramfs-tools/initramfs-tools_0.81_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 387808@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@sternwelten.at> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 27 Sep 2006 15:56:46 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.81
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@sternwelten.at>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 381677 387808 388241 389486 389726
Changes: 
 initramfs-tools (0.81) unstable; urgency=low
 .
   Release quick and happy spin j = l + s
 .
   * update-initramfs: Really check for mounted /proc on use. (closes: 388241)
     Thanks Alex Owen <r.alex.owen@gmail.com>. While beeing in this business,
     check for mounted proc in initramfs-tools.preinst too.
 .
   * hook-functions: Add new scsi drivers aic94xx and stex. Add new net drivers
     ehea, ep93xx_eth and qla3xxx. Thus urgency high.
 .
   * update-initramfs:  Use set ``--'' to change positional paramaters. Thanks
     Jörg Sommer <joerg@alea.gnuu.de>. (closes: 389726)
 .
   * scripts/nfs: Revert to previous handling of dhcp server passing server-ip.
     (closes: 387808)
 .
   * debian/initramfs-tools.preinst: Fix comment typo, thanks
     shaulka@012.net.il for the patch. (closes: 389486)
 .
   * mkinitramfs: Allow an hook script to set an paranoid umask, considered
     useful for shipping gpg keys inside of initramfs. Thanks Max Vozeler
     <max@nusquama.org> and Lionel Elie Mamane <lionel@mamane.lu> for the
     patch. (closes: 381677)
Files: 
 fab02ab520f22ee573a9f0339e1a0586 623 utils optional initramfs-tools_0.81.dsc
 e0feba54cbe98240928c60b990188ac5 50679 utils optional initramfs-tools_0.81.tar.gz
 e6cd8799e52553040b17de81775f01be 56602 utils optional initramfs-tools_0.81_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFGqBU6n7So0GVSSARAmjiAJ9cSbquTcGJwe3JOLtNFeF15NCNvwCglUQn
yPmykfQnyJdDPDvgrPOxyB0=
=GLJY
-----END PGP SIGNATURE-----

Message #34 received at 387808@bugs.debian.org (full text, mbox, reply):

From: vagrant+debianbugs@freegeek.org

To: 387808@bugs.debian.org

Cc: control@bugs.debian.org

Subject: fails to properly handle when server-ip is included in root-path

Date: Thu, 5 Oct 2006 12:25:55 -0700

found 387808 0.81
thanks

ok, i've figured out the failure case from my original bug report,
though i haven't yet figured out why.

when i specify a root-path of 192.168.111.65:/opt/ltsp/i386 in my dhcpd
server, initramfs-tools adds the server-ip received from dhcp, so
NFSROOT ends up being 192.168.111.64:192.168.111.65:/opt/ltsp/i386 when
it tries to mount it.

specifying nfsroot=192.168.111.65:/opt/ltsp/i386 at the boot prompt
works fine, as well as nfsroot=/opt/ltsp/i386. specifying a root-path of
/opt/ltsp/i386 in the dhcp server works as well.

i'm at a loss as to why, but at least i figured out when it happens.

live well,
  vagrant

Message #41 received at 387808@bugs.debian.org (full text, mbox, reply):

From: vagrant+bugs@freegeek.org

To: 387808@bugs.debian.org

Subject: initramfs-tools: scripts/nfs doesn't properly handle when server-ip is included in root-path

Date: Mon, 30 Oct 2006 12:37:54 -0800

Package: initramfs-tools
Followup-For: Bug #387808
found 387808 0.84
thanks

seems like this bug is still present in more recent versions of
initramfs-tools. :(

an ltsp user recently encountered it in bug #395145 

i've also confirmed that it's still broken in 0.84 of initramfs-tools.

live well,
  vagrant

Message #58 received at 387808@bugs.debian.org (full text, mbox, reply):

From: David Härdeman <david@hardeman.nu>

To: 387808@bugs.debian.org

Cc: vagrant+debianbugs@freegeek.org

Subject: Re: fails to properly handle when server-ip is included in root-path

Date: Sun, 15 Apr 2007 18:38:57 +0200

Hey,

after a quick look, it seems that perhaps this part of the nfs script 
could be causing problems:
	# source relevant ipconfig output
	. /tmp/net-${DEVICE}.conf

Could you please add some code to print the output of 
/tmp/net-${DEVICE}.conf and report it since it has the ability to change 
any variable which might cause the duplicated entries later (e.g. 
192.168.111.64:192.168.111.65:/opt/ltsp/i386).

-- 
David Härdeman

Message #63 received at 387808@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant+debianbugs@freegeek.org>

To: Debian Bug Tracking System <387808@bugs.debian.org>

Subject: initramfs-tools: patch to fix when root-path includes server-ip

Date: Mon, 16 Apr 2007 11:39:38 -0700

Package: initramfs-tools
Version: 0.85g
Followup-For: Bug #387808

think i've finally tracked this one down, unfortunately not in time for
etch... *sigh*

the problem was that when NFSROOT=auto, it assumed you always needed to
add the server ip. i grabbed the git branch:

git clone git://git.debian.org/git/kernel/initramfs-tools.git

and made this patch:

--- a/scripts/nfs
+++ b/scripts/nfs
@@ -41,7 +41,11 @@ do_nfsmount()
 
        # get nfs root from dhcp
        if [ "x${NFSROOT}" = "xauto" ]; then
-               NFSROOT=${ROOTSERVER}:${ROOTPATH}
+               if [ "${ROOTPATH#*:}" = "${ROOTPATH}" ]; then
+                       NFSROOT=${ROOTSERVER}:${ROOTPATH}
+               else
+                       NFSROOT=${ROOTPATH}
+               fi
        # nfsroot=[<server-ip>:]<root-dir>[,<nfs-options>]
        elif [ -n "${NFSROOT}" ]; then
                # nfs options are an optional arg


with it you can specify the server ip as part of root-path with dhcp, so:

  option root-path "192.168.1.101:/opt/ltsp/i386";

or:

  option root-path "/opt/ltsp/i386";

both work as expected with dhcp3-server (and presumably other dhcp
servers).

with this patch, or something similar applied, i think we can finally
close this bug for real :)

live well,
  vagrant

Message #68 received at 387808@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <max@stro.at>

To: Vagrant Cascadian <vagrant+debianbugs@freegeek.org>, 387808@bugs.debian.org

Subject: Re: Bug#387808: initramfs-tools: patch to fix when root-path includes server-ip

Date: Mon, 16 Apr 2007 20:53:04 +0200

On Mon, Apr 16, 2007 at 11:39:38AM -0700, Vagrant Cascadian wrote:
> Package: initramfs-tools
> Version: 0.85g
> Followup-For: Bug #387808
> 
> think i've finally tracked this one down, unfortunately not in time for
> etch... *sigh*
> 
> the problem was that when NFSROOT=auto, it assumed you always needed to
> add the server ip. i grabbed the git branch:
> 
> git clone git://git.debian.org/git/kernel/initramfs-tools.git
> 
> and made this patch:
> 
> --- a/scripts/nfs
> +++ b/scripts/nfs
> @@ -41,7 +41,11 @@ do_nfsmount()
>  
>         # get nfs root from dhcp
>         if [ "x${NFSROOT}" = "xauto" ]; then
> -               NFSROOT=${ROOTSERVER}:${ROOTPATH}
> +               if [ "${ROOTPATH#*:}" = "${ROOTPATH}" ]; then
> +                       NFSROOT=${ROOTSERVER}:${ROOTPATH}
> +               else
> +                       NFSROOT=${ROOTPATH}
> +               fi
>         # nfsroot=[<server-ip>:]<root-dir>[,<nfs-options>]
>         elif [ -n "${NFSROOT}" ]; then
>                 # nfs options are an optional arg
> 
> 
> with it you can specify the server ip as part of root-path with dhcp, so:
> 
>   option root-path "192.168.1.101:/opt/ltsp/i386";
> 
> or:
> 
>   option root-path "/opt/ltsp/i386";
> 
> both work as expected with dhcp3-server (and presumably other dhcp
> servers).

great looks fine for me,
i'll test in my qemu setup soonest will make the cut
for initramfs-tools 0.88
 
> with this patch, or something similar applied, i think we can finally
> close this bug for real :)

thanks a lot

--
maks

Message #75 received at 387808-close@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@debian.org>

To: 387808-close@bugs.debian.org

Subject: Bug#387808: fixed in initramfs-tools 0.88

Date: Sat, 26 May 2007 23:47:02 +0000

Source: initramfs-tools
Source-Version: 0.88

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.88.dsc
  to pool/main/i/initramfs-tools/initramfs-tools_0.88.dsc
initramfs-tools_0.88.tar.gz
  to pool/main/i/initramfs-tools/initramfs-tools_0.88.tar.gz
initramfs-tools_0.88_all.deb
  to pool/main/i/initramfs-tools/initramfs-tools_0.88_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 387808@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@debian.org> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 27 May 2007 00:52:38 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.88
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@debian.org>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 355881 387808 395526 423469
Changes: 
 initramfs-tools (0.88) unstable; urgency=low
 .
   [ maximilian attems ]
   * debian/changelog: Fix missing colons in closes.
   * hook-functions: Add a proper /sys walking dep_add_modules() for a minimal
     initramfs on MODULES=dep. (closes: #395526)
   * mkinitramfs.8: Add examples section, plus improve description of the
     low-level tool and how it fits with update-initramfs.
   * init: Ignore non-numerical panic and rootdelay bootarg.
   * scripts/init-premount/ps3: Fix typo. (closes: #423469)
   * scripts/nfs: Fix when root-path includes server-ip. (closes: #387808)
     Thanks Vagrant Cascadian <vagrant+debianbugs@freegeek.org> for patch.
 .
   [ David Härdeman ]
   * init: Remove cryptopts parsing, not official bootparam. cryptsetup scripts
     parse /proc/cmdline themselves (even in the Etch version).
   * hook-functions: Change copy_exec to use the same source and
     destination path if only one argument is given.
   * hook-functions: Document how copy_exec determines the target path.
   * hook-functions: Add firmware loading support to manual_add_modules().
     (closes: #355881)
   * scripts/local: Ubuntu merge
     - As well as waiting for the existance of the root device node, also check
       to see whether we have a filesystem of some kind on it.  Some devices
       nodes (devmapper/LVM/EVMS, mdadm) will exist before they can be safely
       used. Patch by Scott James Remnant <scott@ubuntu.com>. Changed to
       support both fstype and vol_id.
   * hook-functions: make version check in check_minkver more robust.
Files: 
 368d1d8e2fd9a380b286adb97467fb3e 656 utils optional initramfs-tools_0.88.dsc
 78b55028536079237a482fdbce601e10 59130 utils optional initramfs-tools_0.88.tar.gz
 09cc162babb10e631115e9bdd54892f9 66278 utils optional initramfs-tools_0.88_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGWLuBeW7Lc5tEHqgRAqL9AKCro0JQXbHMEko+1QaV9Rlhs0HirQCeIva/
EKHCIcMW8ZSfpOPy8y2n3DA=
=T9N7
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.