Debian Bug report logs - #386246
debhelper: scripts silently succeed on nonexisting package build dir

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: Debian BTS Submit <submit@bugs.debian.org>

Subject: debhelper: scripts silently succeed on nonexisting package build dir

Date: Wed, 6 Sep 2006 11:34:37 +0200

[Message part 1 (text/plain, inline)]

Package: debhelper
Version: 5.0.37.3

Hi!

While evaluating a curious kernel build failure in Ubuntu (where we
use a dh_strip wrapper to automatically generate debug symbol packages
for everything) I noticed a questionable behaviour: If the
package build directory does not exist, dh_* exits successfully rather
than failing (example in the built pmount source directory):

  $ ls -d debian/pmount debian/pmou
  ls: debian/pmou: No such file or directory
  debian/pmount

  $ dh_strip -ppmount --tmpdir=debian/pmou; echo $?
  Can't stat debian/pmou: No such file or directory
   at /usr/bin/dh_strip line 192
  0

This also happens without --tmpdir:
 
  $ dh_strip -ppmount; echo $?
  Can't stat debian/pmount: No such file or directory
   at /usr/bin/dh_strip line 192
  0

This also happens with dh_fixperms, so I guess dh_strip is not the
only affected script.

IMHO dh_* should really fail in that case. Otherwise packages with
typos or bugs debian/rules silently build and such failures might go
unnoticed. (in our kernel example, a make prerequisite was missing and
thus dh_strip did not have any effect; without our wrapper we would
never have noticed).

Thank you,

Martin

-- 
Martin Pitt        http://www.piware.de
Ubuntu Developer   http://www.ubuntu.com
Debian Developer   http://www.debian.org

In a world without walls and fences, who needs Windows and Gates?

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.