Debian Bug report logs - #385391
update-grub still uses /bin/sh as its interpreter, fails with dash

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Stefan Borggraefe <borggraefe@web.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: update-grub still uses /bin/sh as its interpreter, fails with dash

Date: Thu, 31 Aug 2006 01:24:17 +0200

Package: grub
Version: 0.97-14
Severity: serious
Justification: Policy 10.4

grub 0.97-14 had the following changelog enty:

  * update-grub:  Set interpreter to /bin/bash to cope with non-POSIX
    extensions.  (also mentioned in #361929)

But /usr/sbin/update-grub still has /bin/sh as its interpreter and
executing this file with dash fails:

root@rattle:~# /usr/sbin/update-grub
[: 25: ==: unexpected operator
exec: 25: -a: not found

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (9, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.17-2-k7
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)

Versions of packages grub depends on:
ii  libc6                        2.3.6.ds1-4 GNU C Library: Shared libraries
ii  libncurses5                  5.5-2       Shared libraries for terminal hand

grub recommends no packages.

-- no debconf information

Message #10 received at 385391@bugs.debian.org (full text, mbox, reply):

From: Rémi Denis-Courmont <rdenis@simphalempin.com>

To: 385391@bugs.debian.org

Cc: Stefan Borggraefe <borggraefe@web.de>

Subject: Re: update-grub still uses /bin/sh as its interpreter, fails with dash

Date: Thu, 31 Aug 2006 18:41:45 +0300

[Message part 1 (text/plain, inline)]

Le jeudi 31 août 2006 02:24, vous avez écrit :
> But /usr/sbin/update-grub still has /bin/sh as its interpreter and
> executing this file with dash fails:
>
> root@rattle:~# /usr/sbin/update-grub
> [: 25: ==: unexpected operator
> exec: 25: -a: not found

Is there any serious reason for using the non-standard '-a' option 
besides pure cosmetic if someone runs top or ps within the short 
lifespan of update-grub.real anyway ?

-- 
Rémi Denis-Courmont
http://www.remlab.net/

[Message part 2 (application/pgp-signature, inline)]

Message #15 received at 385391@bugs.debian.org (full text, mbox, reply):

From: Jason Thomas <jason@debian.org>

To: R??mi Denis-Courmont <rdenis@simphalempin.com>, 385391@bugs.debian.org

Cc: Stefan Borggraefe <borggraefe@web.de>

Subject: Re: Bug#385391: update-grub still uses /bin/sh as its interpreter, fails with dash

Date: Fri, 1 Sep 2006 08:41:50 +1000

Because the people that wrote it knew of no other way.  If you are
skilled in bash scripting we would love your input. Patch or Advice are
both welcome.

Thanks.

On Thu, Aug 31, 2006 at 06:41:45PM +0300, R??mi Denis-Courmont wrote:
> Le jeudi 31 ao?t 2006 02:24, vous avez ?crit :
> > But /usr/sbin/update-grub still has /bin/sh as its interpreter and
> > executing this file with dash fails:
> >
> > root@rattle:~# /usr/sbin/update-grub
> > [: 25: ==: unexpected operator
> > exec: 25: -a: not found
> 
> Is there any serious reason for using the non-standard '-a' option 
> besides pure cosmetic if someone runs top or ps within the short 
> lifespan of update-grub.real anyway ?
> 
> -- 
> R?mi Denis-Courmont
> http://www.remlab.net/



> _______________________________________________
> Pkg-grub-devel mailing list
> Pkg-grub-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-grub-devel

Message #20 received at 385391@bugs.debian.org (full text, mbox, reply):

From: Michal Čihař <michal@cihar.com>

To: Debian Bug Tracking System <385391@bugs.debian.org>

Subject: Fix bashism

Date: Fri, 01 Sep 2006 12:04:48 +0200

[Message part 1 (text/plain, inline)]

Package: grub
Version: 0.97-14
Followup-For: Bug #385391

Hi

Attached patch to fix bashisms in this script.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.17-2-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

-- no debconf information

[grub.patch (text/plain, attachment)]

Message #27 received at 385391@bugs.debian.org (full text, mbox, reply):

From: Rémi Denis-Courmont <rdenis@simphalempin.com>

To: Jason Thomas <jason@debian.org>

Cc: 385391@bugs.debian.org, Stefan Borggraefe <borggraefe@web.de>

Subject: Re: Bug#385391: update-grub still uses /bin/sh as its interpreter, fails with dash

Date: Fri, 1 Sep 2006 17:23:35 +0300

Le vendredi 1 septembre 2006 01:41, Jason Thomas a écrit :
> Because the people that wrote it knew of no other way.  If you are
> skilled in bash scripting we would love your input. Patch or Advice
> are both welcome.

Yeah right, come to look at it, I can hardly imagine rewriting 
update-grub.real to non-bash. So it makes little sense to do it for 
update-grub. So I guess you should put #!/bin/bash on the first line as 
Stefan requested in the bug report.

Sorry for bothering,

-- 
Rémi Denis-Courmont
http://www.remlab.net/

Message #32 received at 385391-done@bugs.debian.org (full text, mbox, reply):

From: Otavio Salvador <otavio@debian.org>

To: 385391-done@bugs.debian.org

Subject: Fixed in -15

Date: Sat, 02 Sep 2006 16:41:31 -0300

Version: 0.97-15

This bug was solve in our last upload to unstable. Keep us informated
if it's not solved for you.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://www.freedom.ind.br/otavio
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
 you the whole house."

Send a report that this bug log contains spam.