Debian Bug report logs - #377865
mldonkey-server: hdd_free checks cannot be switched off

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Dietrich Clauss <dc2@clauss.dyndns.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: mldonkey-server: hdd_free checks cannot be switched off

Date: Tue, 11 Jul 2006 20:12:10 +0200

Package: mldonkey-server
Severity: normal

With the last upstream update, checks for minimum free space in the
core/temp directory were introduced.  These checks use hard-coded
minimum values and they cannot be switched off.

This causes mldonkey-server to refuse to run on filesystems which do not
report the free space correctly, e.g. the cryptographic filesystem CFS.

Surely this is actually a bug in the filesystems, but mldonkey should be
able to work around it by not enforcing min-free checks.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-1-k7
Locale: LANG=de_DE@euro, LC_CTYPE=de_DE@euro (charmap=ISO-8859-15)

Message #10 received at 377865@bugs.debian.org (full text, mbox, reply):

From: Samuel Mimram <INVALID.NOREPLY@gnu.org>

To: 377865@bugs.debian.org, Samuel Mimram <samuel.mimram@ens-lyon.org>, mldonkey-bugs@nongnu.org

Subject: [bug #17085] hdd_free checks cannot be switched off

Date: Tue, 11 Jul 2006 21:14:56 +0200

URL:
  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=17085>

                 Summary: hdd_free checks cannot be switched off
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: smimram
            Submitted on: Tuesday 07/11/2006 at 21:14
                Category: Core
                Severity: 3 - Normal
              Item Group: Feature request
                  Status: None
             Assigned to: None
             Open/Closed: Open
                 Release: 
                 Release: 2.7.7
        Operating System: None
         Binaries Origin: Debian package
                CPU type: None

    _______________________________________________________

Details:

Hi,

With the last upstream update, checks for minimum free space in the
core/temp directory were introduced. These checks use hard-coded minimum
values and they cannot be switched off.

This causes mldonkey-server to refuse to run on filesystems which do not
report the free space correctly, e.g. the cryptographic filesystem CFS.

Surely this is actually a bug in the filesystems, but mldonkey should be able
to work around it by not enforcing min-free checks.

More info about the Debian bug report can be found at
http://bugs.debian.org/377865



    _______________________________________________________

Carbon-Copy List:

CC Address                          | Comment
------------------------------------+-----------------------------
377865@bugs.debian.org              | 




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=17085>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/

Message #15 received at 377865@bugs.debian.org (full text, mbox, reply):

From: Samuel Mimram <samuel.mimram@ens-lyon.org>

To: Dietrich Clauss <dc2@clauss.dyndns.org>, 377865@bugs.debian.org

Subject: Re: Bug#377865: mldonkey-server: hdd_free checks cannot be switched off

Date: Tue, 11 Jul 2006 21:16:54 +0200

Hi,

Dietrich Clauss wrote:
> Package: mldonkey-server
> Severity: normal
> 
> With the last upstream update, checks for minimum free space in the
> core/temp directory were introduced.  These checks use hard-coded
> minimum values and they cannot be switched off.
> 
> This causes mldonkey-server to refuse to run on filesystems which do not
> report the free space correctly, e.g. the cryptographic filesystem CFS.
> 
> Surely this is actually a bug in the filesystems, but mldonkey should be
> able to work around it by not enforcing min-free checks.

Ok, I've reported the issue upstream and I'll patch the Debian package
to remove this limitation (I'm not sure this is such a good idea to
disable that though).

Cheers,

Samuel.

Message #22 received at 377865@bugs.debian.org (full text, mbox, reply):

From: spiralvoice <INVALID.NOREPLY@gnu.org>

To: 377865@bugs.debian.org, Samuel Mimram <samuel.mimram@ens-lyon.org>, spiralvoice <spiralvoice@compuserve.de>, mldonkey-bugs@nongnu.org

Subject: [bug #17085] hdd_free checks cannot be switched off

Date: Wed, 12 Jul 2006 18:44:56 +0200

Follow-up Comment #1, bug #17085 (project mldonkey):

The hdd_space_check-patch has been introduced 2006/03/19,
this is the first bug report of this kind.
I set up a CFS partition here following
http://gentoo-wiki.com/HOWTO_Encrypt_Your_Home_Directory_Using_CFS#Introduction_to_CFS
and could reproduce the bug. Because of the sensitivity of
MLDonkeys ini file saving procedure IMHO its not a good idea
to create an option to disable DriverInteractive.hdd_check ().

Here is a patch which is a work-around for the CFS-freespace problem:

diff -a -x Root -x Repository -x Tag -x Entries -x Entries.Log -x .svn -x
'*.rej' -x '*.orig' -N -r -u ./src/daemon/driver/driv
--- ./src/daemon/driver/driverInteractive.ml    2006-06-27 23:20:28.000000000
+0200
+++ ./src/daemon/driver/driverInteractive.ml    2006-07-12 18:39:02.000000000
+0200
@@ -93,6 +93,7 @@
   let dir_full dir mb =
     match Unix32.diskfree dir with
     | None -> false
+    | Some v when ((Unix32.filesystem dir = "NFS_SUPER_MAGIC") && v = zero)
-> false
     | Some v -> v < megabytes mb
   in

CFS filesystems report themselves as NFS_SUPER_MAGIC, if the
freespace is reported as zero on such a partition its ignored
in the future during hdd_space_check. Attached you will find
a patch including the patch above + a cosmetic patch for
unix32 module to prevent a Division_by_zero error in debug_disk command.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=17085>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/

Message #27 received at 377865@bugs.debian.org (full text, mbox, reply):

From: Samuel Mimram <INVALID.NOREPLY@gnu.org>

To: 377865@bugs.debian.org, Samuel Mimram <samuel.mimram@ens-lyon.org>, spiralvoice <spiralvoice@compuserve.de>, mldonkey-bugs@nongnu.org

Subject: [bug #17085] hdd_free checks cannot be switched off

Date: Thu, 13 Jul 2006 00:29:15 +0200

Follow-up Comment #2, bug #17085 (project mldonkey):

Thanks a lot spiralvoice for your patch I'll integrate it in the Debian
package. Apparently you forgot to attach the other patch, didn't you?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=17085>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/

Message #32 received at 377865@bugs.debian.org (full text, mbox, reply):

From: spiralvoice <INVALID.NOREPLY@gnu.org>

To: 377865@bugs.debian.org, Samuel Mimram <samuel.mimram@ens-lyon.org>, spiralvoice <spiralvoice@compuserve.de>, mldonkey-bugs@nongnu.org

Subject: [bug #17085] hdd_free checks cannot be switched off

Date: Thu, 13 Jul 2006 01:46:30 +0200

Follow-up Comment #3, bug #17085 (project mldonkey):

Yes, I forgot the patch, here it is...
Please report if it fixes the bug, the patch can then go to CVS.
    _______________________________________________________

Additional Item Attachment:

File name: cfs.patch                      Size:1 KB

<http://savannah.nongnu.org/bugs/download.php?file_id=10338>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=17085>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/

Message #41 received at 377865@bugs.debian.org (full text, mbox, reply):

From: spiralvoice <INVALID.NOREPLY@gnu.org>

To: 377865@bugs.debian.org, Samuel Mimram <samuel.mimram@ens-lyon.org>, spiralvoice <spiralvoice@compuserve.de>, mldonkey-bugs@nongnu.org

Subject: [bug #17085] Fix HDD space checks on CFS mounts

Date: Fri, 14 Jul 2006 11:57:09 +0200

Update of bug #17085 (project mldonkey):

                 Summary: hdd_free checks cannot be switched off => Fix HDD
space checks on CFS mounts


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=17085>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/

Message #46 received at 377865@bugs.debian.org (full text, mbox, reply):

From: spiralvoice <INVALID.NOREPLY@gnu.org>

To: 377865@bugs.debian.org, Samuel Mimram <samuel.mimram@ens-lyon.org>, spiralvoice <spiralvoice@compuserve.de>, mldonkey-users@nongnu.org

Subject: [patch #5238] Fix HDD space checks on CFS mounts

Date: Fri, 14 Jul 2006 15:18:11 +0200

Update of patch #5238 (project mldonkey):

                  Status:                    None => Done                   
             Open/Closed:                    Open => Closed                 
                 Summary: Reassigned item: Fix HDD space checks on CFS mounts
=> Fix HDD space checks on CFS mounts

    _______________________________________________________

Follow-up Comment #5:

Applied to CVS 2006/07/14

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=5238>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/

Message #53 received at 377865-close@bugs.debian.org (full text, mbox, reply):

From: Samuel Mimram <smimram@debian.org>

To: 377865-close@bugs.debian.org

Subject: Bug#377865: fixed in mldonkey 2.7.7-4

Date: Sat, 15 Jul 2006 14:17:13 -0700

Source: mldonkey
Source-Version: 2.7.7-4

We believe that the bug you reported is fixed in the latest version of
mldonkey, which is due to be installed in the Debian FTP archive:

mldonkey-gui_2.7.7-4_i386.deb
  to pool/main/m/mldonkey/mldonkey-gui_2.7.7-4_i386.deb
mldonkey-server_2.7.7-4_i386.deb
  to pool/main/m/mldonkey/mldonkey-server_2.7.7-4_i386.deb
mldonkey_2.7.7-4.diff.gz
  to pool/main/m/mldonkey/mldonkey_2.7.7-4.diff.gz
mldonkey_2.7.7-4.dsc
  to pool/main/m/mldonkey/mldonkey_2.7.7-4.dsc



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 377865@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Mimram <smimram@debian.org> (supplier of updated mldonkey package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 13 Jul 2006 12:49:45 +0000
Source: mldonkey
Binary: mldonkey-gui mldonkey-server
Architecture: source i386
Version: 2.7.7-4
Distribution: unstable
Urgency: low
Maintainer: Debian OCaml Maintainers <debian-ocaml-maint@lists.debian.org>
Changed-By: Samuel Mimram <smimram@debian.org>
Description: 
 mldonkey-gui - Graphical frontend for mldonkey based on GTK
 mldonkey-server - Door to the 'donkey' network
Closes: 354701 377865 378150
Changes: 
 mldonkey (2.7.7-4) unstable; urgency=low
 .
   * Import patch from Ubuntu (thanks Reinhard Tartler) to handle systems where
     /var/run is cleaned on reboot, closes: #354701.
     - Introduce new config variable in /etc/default/mldonkey-server:
       MLDONKEY_USER. This variable is only used by the init script.
     - Mke the initscript create /var/run/mldonkey-server, setting correct
       owner and permissions.
   * Added 04_cfs.dpatch (thanks spiralvoice) to handle CFS filesystems which
     incorrectly report freespace, closes: #377865.
   * Added a build-dependency on libmagic-dev, closes: #378150.
   * Added a build-dependency on ocaml-best-compilers since mldonkey is a
     fairly big package to build.
   * We don't need to remove rpaths anymore.
Files: 
 1950e8ba5eb55bd4a9427fb57d011c11 986 net optional mldonkey_2.7.7-4.dsc
 f06b6a1c6f58c39bfaf5ac32fb568503 115940 net optional mldonkey_2.7.7-4.diff.gz
 bccf37c07d9e83a96398ff3ac6be05cd 2870464 net optional mldonkey-server_2.7.7-4_i386.deb
 6fb28ed2e20ac744eb9b490606a664fd 3338656 net optional mldonkey-gui_2.7.7-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEuVcRIae1O4AJae8RAr1kAJ4vyAb0k7ILsN4XGyhWjTUXImowlwCdG+d0
f5WSWPsIEcNOAFgoUIhFeKg=
=AtBq
-----END PGP SIGNATURE-----

Message #58 received at 377865@bugs.debian.org (full text, mbox, reply):

From: Dietrich Clauss <dc2@clauss.dyndns.org>

To: 377865@bugs.debian.org

Subject: Re: Bug#377865 closed by Samuel Mimram <smimram@debian.org> (Bug#377865: fixed in mldonkey 2.7.7-4)

Date: Wed, 19 Jul 2006 11:20:43 +0200

[Message part 1 (text/plain, inline)]

Thanks a lot Samuel and Spiralvoice for the fix.  I just upgraded and it
works fine.

best regards,
- Dietrich

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.