Debian Bug report logs - #367944
initscript: /etc/rc(0|6).d/S20sendsigs kills wpa daemon before umounting nfs mounts

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Elimar Riesebieter <riesebie@lxtec.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Cc: pkg-wpa-devel <pkg-wpa-devel@lists.alioth.debian.org>

Subject: initscript: /etc/rc(0|6).d/S20sendsigs kills wpa daemon before umounting nfs mounts

Date: Thu, 18 May 2006 20:59:51 +0200

Package: initscript
Severity: normal

Hi,

I am running a wpasuppclicant daemon for wireless networking. In my
home-lan I am sharing files via nfs. On Debian-systems the umount of
nfsfiles is via /etc/rc(0|6).d/S31umountnfs.sh which indeed starts
later than /etc/rc(0|6).d/S20sendsigs which kills the wpa daemon. So
if you have nfs entries in mtab umountnfs.sh hangs|freezes the
machine.  Hardresets aren't the best for the filesystems.

I manually fixed S31umountnfs.sh to S19umountnfs.sh but isn't really
reasonable for me.

Elimar

-- 
  Numeric stability is probably not all that 
  important when you're guessing;-)

Message #12 received at 367944-maintonly@bugs.debian.org (full text, mbox, reply):

From: Elimar Riesebieter <riesebie@lxtec.de>

To: 367944-maintonly@bugs.debian.org

Subject: initscripts: /etc/rc(0|6).d/S20sendsigs kills wpa daemon before umounting nfs mounts

Date: Tue, 23 May 2006 23:11:30 +0200

Package: initscript
Severity: normal

Hi,

I am running a wpasuppclicant daemon for wireless networking. In my
home-lan I am sharing files via nfs. On Debian-systems the umount of
nfsfiles is via /etc/rc(0|6).d/S31umountnfs.sh which indeed starts
later than /etc/rc(0|6).d/S20sendsigs which kills the wpa daemon. So
if you have nfs entries in mtab umountnfs.sh hangs|freezes the
machine.  Hardresets aren't the best for the filesystems.

I manually fixed S31umountnfs.sh to S19umountnfs.sh but isn't really
reasonable for me.

Elimar

-- 
  Numeric stability is probably not all that 
  important when you're guessing;-)

Message #19 received at 367944-submitter@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: 258420@bugs.debian.org, 258420-submitter@bugs.debian.org, 367944-submitter@bugs.debian.org

Subject: Avoid killing network-related services before umounting remove file systems

Date: Mon, 11 Sep 2006 09:48:27 +0200

I would like to implement the following fix for the problem with
network services being killed before remote file systems are taken
down.  Can you test it, and let me know if it work for you?

Index: debian/changelog
===================================================================
--- debian/changelog	(revisjon 906)
+++ debian/changelog	(arbeidskopi)
@@ -3,6 +3,11 @@
   * Correct status report handling in umountnfs.sh.  Based on patch
     from Markus Schoder. (Closes: #386893)
 
+  * Only kill processes using remote file systems before trying to
+    umount them, if fuser from the psmisc package is available, and
+    move sendsigs to a point between where remote and local file systems
+    are umounted.  Recommend psmisc.  (Closes: #258420, #367944)
+
  -- Petter Reinholdtsen <pere@debian.org>  Mon, 11 Sep 2006 00:44:44 +0200
 
 sysvinit (2.86.ds1-20) unstable; urgency=low
Index: debian/control
===================================================================
--- debian/control	(revisjon 881)
+++ debian/control	(arbeidskopi)
@@ -36,6 +36,7 @@
 Package: initscripts
 Architecture: any
 Depends: ${shlibs:Depends}, ${glibc:Depends}, ${mount:Depends}, e2fsprogs (>= 1.32+1.33-WIP-2003.04.14-1), debianutils (>= 2.13.1), lsb-base (>= 3.0-6)
+Recommends: psmisc
 Conflicts: mdutils, sysv-rc (<< 2.86.ds1-1.2), sysvinit (<< 2.86.ds1-12)
 Replaces: mdutils, sysvinit (<< 2.85-12), libc6, libc6.1, libc0.1, libc0.3
 Description: Scripts for initializing and shutting down the system
Index: debian/initscripts/postinst
===================================================================
--- debian/initscripts/postinst	(revisjon 900)
+++ debian/initscripts/postinst	(arbeidskopi)
@@ -93,6 +93,12 @@
 	update-rc.d -f hostname.sh remove >/dev/null 2>&1 || :
 fi
 
+# In 2.86.ds1-21, the sendsigs script were moved.
+if dpkg --compare-versions "$PREV_VER" lt "2.86.ds1-21"
+then
+	update-rc.d -f sendsigs remove >/dev/null 2>&1 || :
+fi
+
 #
 # Okay, we could do this with update-rc.d, but that would probably
 # be pretty slow. This way we win some speed.
@@ -122,8 +128,8 @@
 updatercd reboot                 start 90 6 .
 updatercd umountroot             start 60 0 6 .
 updatercd umountfs               start 40 0 6 .
+updatercd sendsigs               start 37 0 6 .
 updatercd umountnfs.sh           start 31 0 6 .
-updatercd sendsigs               start 20 0 6 .
 
 updatercd killprocs              start 30 1 .
 updatercd single                 start 90 1 .
Index: debian/initscripts/etc/init.d/umountnfs.sh
===================================================================
--- debian/initscripts/etc/init.d/umountnfs.sh	(revisjon 907)
+++ debian/initscripts/etc/init.d/umountnfs.sh	(arbeidskopi)
@@ -71,6 +71,25 @@
 
 	if [ "$DIRS" ]
 	then
+		# Kill all processes using the directories we try to umount
+		if [ -x /bin/fuser ] ; then
+			[ "$VERBOSE" = no ] || log_action_begin_msg "Asking non-system processes to terminate"
+			fuser -k INT -m $DIRS
+			[ "$VERBOSE" = no ] || log_action_end_msg 0
+
+			for count in 1 2 3 4 5; do # Wait up to 5 seconds
+			    sleep 1
+			    [ -z "`fuser -m $DIRS 2> /dev/null`" ] && break
+			done
+
+			pidsleft=`fuser -m $DIRS 2>/dev/null`
+			if [ "$pidsleft" ] ; then
+			    [ "$VERBOSE" = no ] || log_action_begin_msg "Killing non-system processes"
+			    fuser -k TERM -m $DIRS
+			    [ "$VERBOSE" = no ] || log_action_end_msg 0
+			fi
+		fi
+
 		[ "$VERBOSE" = no ] || log_action_begin_msg "Unmounting remote and non-toplevel virtual filesystems"
 		umount $FLAGS $DIRS
 		ES=$?

Message #24 received at 367944-quiet@bugs.debian.org (full text, mbox, reply):

From: Elimar Riesebieter <riesebie@lxtec.de>

To: Petter Reinholdtsen <pere@hungry.com>, 367944-quiet@bugs.debian.org

Cc: 258420@bugs.debian.org, 258420-submitter@bugs.debian.org, 367944-submitter@bugs.debian.org

Subject: Re: Bug#367944: Avoid killing network-related services before umounting remove file systems

Date: Mon, 11 Sep 2006 15:32:11 +0200

[Message part 1 (text/plain, inline)]

On Mon, 11 Sep 2006 the mental interface of
Petter Reinholdtsen told:

> 
> I would like to implement the following fix for the problem with
> network services being killed before remote file systems are taken
> down.  Can you test it, and let me know if it work for you?

Works perfect on my ppc.
[...]
> Index: debian/initscripts/etc/init.d/umountnfs.sh
> ===================================================================
> --- debian/initscripts/etc/init.d/umountnfs.sh	(revisjon 907)
> +++ debian/initscripts/etc/init.d/umountnfs.sh	(arbeidskopi)
[...]
>  		ES=$?
         ^^^^^
Patched against 2.86.ds1-20 has a fuzz. Please see attached patch. I
completed initsripts/lintian.overwrites with three additional
notes.

Thanks
Elimar

-- 
  It's a good thing we don't get all 
  the government we pay for.

[sysvinit_21.diff (text/plain, attachment)]

Message #32 received at 367944-quiet@bugs.debian.org (full text, mbox, reply):

From: Elimar Riesebieter <riesebie@lxtec.de>

To: Petter Reinholdtsen <pere@hungry.com>, 367944-quiet@bugs.debian.org

Cc: 258420@bugs.debian.org, 258420-submitter@bugs.debian.org, 367944-submitter@bugs.debian.org

Subject: Re: Bug#367944: Avoid killing network-related services before umounting remove file systems

Date: Mon, 11 Sep 2006 15:49:30 +0200

On Mon, 11 Sep 2006 the mental interface of
Elimar Riesebieter told:

[...] 
> diff -urNad sysvinit-2.86.ds1~/debian/control sysvinit-2.86.ds1/debian/control
> --- sysvinit-2.86.ds1~/debian/control	2006-09-11 14:50:23.000000000 +0200
> +++ sysvinit-2.86.ds1/debian/control	2006-09-11 15:10:40.000000000 +0200
> @@ -36,6 +36,7 @@
>  Package: initscripts
>  Architecture: any
>  Depends: ${shlibs:Depends}, ${glibc:Depends}, ${mount:Depends}, e2fsprogs (>= 1.32+1.33-WIP-2003.04.14-1), debianutils (>= 2.13.1), lsb-base (>= 3.0-6)
> +Recommends: psmisc

Hmm, shouldn't we add psmisc to "Depends:" instead of "Recommends:",
as we now need /bin/fuser anyway?

Elimar

-- 
  We all know Linux is great... it does infinite loops in 5 seconds.
        -- Linus Torvalds

Message #37 received at 367944-quiet@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@hungry.com>

To: Elimar Riesebieter <riesebie@lxtec.de>

Cc: 367944-quiet@bugs.debian.org, 258420@bugs.debian.org, 258420-submitter@bugs.debian.org, 367944-submitter@bugs.debian.org

Subject: Re: Bug#367944: Avoid killing network-related services before umounting remove file systems

Date: Mon, 11 Sep 2006 15:59:27 +0200

[Elimar Riesebieter]
> Hmm, shouldn't we add psmisc to "Depends:" instead of "Recommends:",
> as we now need /bin/fuser anyway?

For that to happen, psmisc would have to be converted into an
essential package, and I am not quite sure how to make that happen.
This is the reason why I made it conditional.  Systems using NFS
should install psmisc, while systems without NFS will continue just
fine without psmisc.

Friendly,
-- 
Petter Reinholdtsen

Message #54 received at 367944-close@bugs.debian.org (full text, mbox, reply):

From: Petter Reinholdtsen <pere@debian.org>

To: 367944-close@bugs.debian.org

Subject: Bug#367944: fixed in sysvinit 2.86.ds1-26

Date: Thu, 28 Sep 2006 11:02:14 -0700

Source: sysvinit
Source-Version: 2.86.ds1-26

We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive:

initscripts_2.86.ds1-26_i386.deb
  to pool/main/s/sysvinit/initscripts_2.86.ds1-26_i386.deb
sysv-rc_2.86.ds1-26_all.deb
  to pool/main/s/sysvinit/sysv-rc_2.86.ds1-26_all.deb
sysvinit-utils_2.86.ds1-26_i386.deb
  to pool/main/s/sysvinit/sysvinit-utils_2.86.ds1-26_i386.deb
sysvinit_2.86.ds1-26.diff.gz
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-26.diff.gz
sysvinit_2.86.ds1-26.dsc
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-26.dsc
sysvinit_2.86.ds1-26_i386.deb
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-26_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 367944@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated sysvinit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 28 Sep 2006 19:26:54 +0200
Source: sysvinit
Binary: sysv-rc sysvinit-utils sysvinit initscripts
Architecture: source i386 all
Version: 2.86.ds1-26
Distribution: unstable
Urgency: low
Maintainer: Debian sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description: 
 initscripts - Scripts for initializing and shutting down the system
 sysv-rc    - System-V-like runlevel change mechanism
 sysvinit   - System-V-like init utilities
 sysvinit-utils - System-V-like utilities
Closes: 258420 354163 359651 367944 383124 385722 386893 387216 387236 387308 388244 388417 389435
Changes: 
 sysvinit (2.86.ds1-26) unstable; urgency=low
 .
   * Change umountnfs to use /etc/mtab instead of /proc/mounts, to make
     sure it see the _netdev option.  umountfs still uses /proc/mounts
     to make every non-root file system is unmounted before halt or
     reboot. (Closes: #383124)
   * Correct exit code handling in init.d/rc.local. (Closes: #389435)
 .
 sysvinit (2.86.ds1-25) experimental; urgency=low
 .
   * Improve manual entry for RAMRUN and RAMLOCK run rcS(5).
   * Correct mtab.sh to make sure the mtab content matches the options used
     when mounting /var/run/.
   * New defaults/tmpfs options RUN_SIZE and LOCK_SIZE, controlling the
     tmpfs size.  Modified the mount code to also use TMPFS_SIZE if
     set as a fallback value.
 .
 sysvinit (2.86.ds1-24) experimental; urgency=low
 .
   * Make sure we do not umount /lib/init/rw/ during shutdown.
   * Make it easier to debug the splash progress bar in init.d/rc.
   * Correct mtab entry for /sys, to make sure its 'device' is sysfs.
   * Include vars.sh in mtab.sh, to make sure the RAMRUN and RAMLOCK
     options are available when used.
   * Add defaults/tmpfs option RW_SIZE to control the size of
     /lib/init/rw/, and change mountkernfs.sh to use TMPFS_SIZE too if
     it is set.
   * Rewrite post_mountall() function to avoid mounting /var/run/ and
     /var/lock/ on top of themselves when RAMRUN or RAMLOCK is enabled.
 .
 sysvinit (2.86.ds1-23) experimental; urgency=low
 .
   * Make the tmpfs on /var/run/ and /var/lock/ optional, and provide
     RAMRUN and RAMLOCK options in /etc/default/rcS to control this.
     Remove code to convert to this feature when the package is
     upgraded or installed.  It will take effect after a reboot if
     /etc/default/rcS is modified.  Keep them disabled for now.
     Create .ramfs files in the directories if tmpfs is used to make it
     easier for other scripts to know if they are safe to use early in
     the boot.
   * Create /lib/init/rw/, and mount a tmpfs there to garantee some
     writable area very early in the boot.  Use this in checkroot.sh if
     a device node need to be created.  Create .ramfs indicator when
     it is mounted.
   * Move sulogin to the sysvinit-utils package as well. (Closes: #388417)
   * Add new halt option NETDOWN to make it easier to enable
     wake-on-lan. (Closes: #388244)
   * Add a stop dependency for umountroot on kexec, to document the
     correct location for a kexec script.  Related to bug #387599.
   * Make sure update-rd.d-recover is not compressed to make it easier to run.
 .
 sysvinit (2.86.ds1-22) experimental; urgency=low
 .
   * Let mountdevsubfs provide mountvirtfs to work with init.d scripts
     with obsolete dependency information.
   * Change mounting of virtual file systems to specify the device name
     explicitly, to make sure /proc/mounts and /etc/mtab end up with
     the same device name.
   * Split killall5, last, lastb, mesg and pidof out of the sysvinit
     package into a new sysvinit-utils package to make it easier to
     replace sysvinit. (Closes: #385722)
   * Mount /var/run/ as tmpfs in mountkernfs.sh, to have some place to
     write state information very early in the boot, and thus avoid a
     lot of cludges in scripts running before partitions are checked
     and mounted.  Mount /var/lock/ as tmpfs to avoid having to clean
     it during boot, and to have some place to store locks for the
     things running before partitions are checked and mounted.
     Packages need to create the directories they expect to find in
     these directories from now on.  Patch from Scott James Remnant and
     Ubuntu.
   * Adjust checkroot.sh to create the root device node in /var/run/
     when needed, instead of mounting its own tmpfs.  Modified
     /var/run/ to allow devices and executables.
 .
 sysvinit (2.86.ds1-21) experimental; urgency=low
 .
   * Correct status report handling in umountnfs.sh.  Based on patch
     from Markus Schoder. (Closes: #386893)
   * Change mountnfs.sh, rc.local and skeleton to use /lib/init/vars.sh
     instead of sourcing /etc/default/rcS, to activate the INIT_VERBOSE
     variable for these scripts.
   * Add support in the init.d scripts for the 'quiet' kernel option.
     Keep support for the experiemental INIT_VERBOSE, to make it
     possible to override VERBOSE=no on the kernel command line.
   * New draft patch 68_init_quiet to make init less verbose when the
     'quiet' kernel option is used.  If it worked, it would solve bug
     #326677.
   * Add a few lintian overrides for things that are correct though strange.
   * Rewrite sendsigs to sleep up to 5 seconds (instead of always
     sleeping 5 seconds) during shutdown if there are no processes left
     to wait for.  Modify killall5 to make it report if it found any
     processes to kill to make this possible.
   * Modify mtab.sh to include /dev/.static/dev in /etc/mtab, to avoid
     message from umountfs during shutdown about it being missing in mtab.
   * Now that mtab is properly updated by mtab.sh before mountall.sh,
     there is no need to have special handling of proc file systems.
     Remove the code from mountall.sh. (Closes: #359651)
   * Only kill processes using remote file systems before trying to
     umount them, if fuser from the psmisc package is available, and
     move sendsigs to a point between where remote and local file systems
     are umounted.  Recommend psmisc for package initscripts.
     (Closes: #258420, #367944)
   * Add conditional dependency on glibc for hostname.sh and
     mountkernfs.sh, to allow the glibc warnings to show up without
     anything running in parallel.
   * Change default PATH in initscripts and init to prefer sbin/ over
     bin/, to avoid picking user visible replacement for system
     binaries.  This avoids shutdown problems on some
     machines. (Closes: #354163)
   * Fix typo in init.d/README. (Closes: #387236)
   * Add /usr/bin/ to the checkroot and checkfs PATH, to make sure
     on_ac_power is used if it is available. (Closes: #387308)
   * Modify mtab.sh to insert the device name used when mounting
     /dev/shm/ in /etc/mtab.  (Closes: #387216)
Files: 
 53f1bdb2310ea926cf1fffbbe3c6f055 910 admin required sysvinit_2.86.ds1-26.dsc
 657b5e606afb5853c63fd06322514da3 133869 admin required sysvinit_2.86.ds1-26.diff.gz
 ff4047a2293727fc77c2e0ee1bbb33fa 107882 admin required sysvinit_2.86.ds1-26_i386.deb
 123d0c2171934c12adf70ed4b6d7bd22 63746 admin required sysvinit-utils_2.86.ds1-26_i386.deb
 6715e1f9768a8dda664d74049040d10b 56886 admin required initscripts_2.86.ds1-26_i386.deb
 1249884b42f92dd8fad39f69325710d5 55200 admin required sysv-rc_2.86.ds1-26_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD4DBQFFHAxD20zMSyow1ykRAkdDAJdTtz0VfwWP9oT2uUX3mIYIWwmSAKDbsmQd
eci080F3HOSzfBBw1m92bg==
=1Bus
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.