Debian Bug report logs - #363815
mozilla-thunderbird: get-orig-source debian/rules target for Thunderbird

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Mikko Rapeli <mikko.rapeli@iki.fi>

To: submit@bugs.debian.org

Subject: get-orig-source debian/rules target for Thunderbird

Date: Tue, 09 Aug 2005 12:09:50 +0300

[Message part 1 (text/plain, inline)]

Package: mozilla-thunderbird
Version: 1.0.6-3
Severity: wishlist
Tags: patch

This patch automates the downloading and dfsg cleaning of the original upstream 
source package. I've verified that it produces an archive with the same
contents than that which ships in unstable now. It seems that the
bzip2 optimization is wrong though, since the files don't match.

The makefile dependencies could be better (i.e. get-orig-source
provides dfsg source and build depends on dfsg source etc).

-Mikko

[mtb_rules_get-orig-source-01.txt (text/plain, attachment)]

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack - Debian Bugmail <asac@debian.org>

To: Mikko Rapeli <mikko.rapeli@iki.fi>, 322134@bugs.debian.org

Cc: submit@bugs.debian.org

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Tue, 9 Aug 2005 14:22:32 +0200

[Message part 1 (text/plain, inline)]

On Tue, Aug 09, 2005 at 12:09:50PM +0300, Mikko Rapeli wrote:
> Package: mozilla-thunderbird
> Version: 1.0.6-3
> Severity: wishlist
> Tags: patch
> 
> This patch automates the downloading and dfsg cleaning of the original upstream 
> source package. I've verified that it produces an archive with the same
> contents than that which ships in unstable now. It seems that the
> bzip2 optimization is wrong though, since the files don't match.
> 
Thanks for the patch. I will include it, but would suggest some improvements.

Nevertheless, maybe we should define the upstream version in an external
file and add a target that upgrades the package to a user defined upstream
version. This would include to cp the whole source tree to a directory names
${pkgname}-${version} (e.g. cp -r mozilla-thunderbird-1.0.2 to
mozilla-thunderbird-1.0.6), upgrade the upstream tarball, remove the old
upstream tarball (e.g. rm
${pkgname}-${oldversion}/archives/${sourcetarball-prefix}-${version}-${sourcetarball-postfix}.
The final steps would be to produce a new orig.tar.gz (tar cvzf ${pkgname}_${uversion}.orig.tar.gz
${pkgname}-${version}/archives/) and prepend some boilerplate code to the
debian/changelog file (e.g. a valid entry, with an initial comment: new
upstream version ${version}).

What do you think? 

> The makefile dependencies could be better (i.e. get-orig-source
> provides dfsg source and build depends on dfsg source etc).
> 
please no dependencies. The upgrade tarball is a manual operation and should
not be done automatically ... in any case.

-- 
 GPG messages preferred.   |  .''`.  ** Debian GNU/Linux **
 Alexander Sack            | : :' :      The  universal
 asac@debian.org           | `. `'      Operating System
 http://www.asoftsite.org  |   `-    http://www.debian.org

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Mikko Rapeli <mikko.rapeli@iki.fi>

To: 322134@bugs.debian.org

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Mon, 15 Aug 2005 14:01:14 +0300

On Tue, Aug 09, 2005 at 02:22:32PM +0200, Alexander Sack - Debian Bugmail wrote:
> Thanks for the patch. I will include it, but would suggest some improvements.

Yes, and the patch also needs to not have current working directory in
the package source main, as per get-orig-source suggestion in
http://www.debian.org/doc/debian-policy/ch-source.html#s-debianrules

> Nevertheless, maybe we should define the upstream version in an external
> file and add a target that upgrades the package to a user defined upstream
> version. This would include to cp the whole source tree to a directory names
> ${pkgname}-${version} (e.g. cp -r mozilla-thunderbird-1.0.2 to
> mozilla-thunderbird-1.0.6), upgrade the upstream tarball, remove the old
> upstream tarball (e.g. rm
> ${pkgname}-${oldversion}/archives/${sourcetarball-prefix}-${version}-${sourcetarball-postfix}.
> The final steps would be to produce a new orig.tar.gz (tar cvzf ${pkgname}_${uversion}.orig.tar.gz
> ${pkgname}-${version}/archives/) and prepend some boilerplate code to the
> debian/changelog file (e.g. a valid entry, with an initial comment: new
> upstream version ${version}).
> 
> What do you think? 

It's a good idea. I've tried doing it manually bug so far I've failed.
One problem at least is that "clean" debian/rules target wants to do
"dounpatch", which of course fails if the whole build-dir is missing.

(For the other issues, I must re-read the policy and other manuals as
I don't seem to grasp the differences between dpkg-source et al --
a stupid developer error..)

> > The makefile dependencies could be better (i.e. get-orig-source
> > provides dfsg source and build depends on dfsg source etc).
> > 
> please no dependencies. The upgrade tarball is a manual operation and should
> not be done automatically ... in any case.

With dependency I mean "if archives/*dfsg.tar.gz does not exists, create
it through get-orig-source". The end result -- upgrade to new upstream
-- is the same as your suggestion above which I suppose you like better.
:)

-Mikko

Message #25 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack - Debian Bugmail <asac@debian.org>

To: Mikko Rapeli <mikko.rapeli@iki.fi>, 322134@bugs.debian.org

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Fri, 19 Aug 2005 02:24:01 +0200

On Mon, Aug 15, 2005 at 02:01:14PM +0300, Mikko Rapeli wrote:
> 
> > Nevertheless, maybe we should define the upstream version in an external
> > file and add a target that upgrades the package to a user defined upstream
> > version. This would include to cp the whole source tree to a directory names
> > ${pkgname}-${version} (e.g. cp -r mozilla-thunderbird-1.0.2 to
> > mozilla-thunderbird-1.0.6), upgrade the upstream tarball, remove the old
> > upstream tarball (e.g. rm
> > ${pkgname}-${oldversion}/archives/${sourcetarball-prefix}-${version}-${sourcetarball-postfix}.
> > The final steps would be to produce a new orig.tar.gz (tar cvzf ${pkgname}_${uversion}.orig.tar.gz
> > ${pkgname}-${version}/archives/) and prepend some boilerplate code to the
> > debian/changelog file (e.g. a valid entry, with an initial comment: new
> > upstream version ${version}).
> > 
> > What do you think? 
> 
> It's a good idea. I've tried doing it manually bug so far I've failed.
> One problem at least is that "clean" debian/rules target wants to do
> "dounpatch", which of course fails if the whole build-dir is missing.
> 
> (For the other issues, I must re-read the policy and other manuals as
> I don't seem to grasp the differences between dpkg-source et al --
> a stupid developer error..)
> 
> > > The makefile dependencies could be better (i.e. get-orig-source
> > > provides dfsg source and build depends on dfsg source etc).
> > > 
> > please no dependencies. The upgrade tarball is a manual operation and should
> > not be done automatically ... in any case.
> 
> With dependency I mean "if archives/*dfsg.tar.gz does not exists, create
> it through get-orig-source". The end result -- upgrade to new upstream
> -- is the same as your suggestion above which I suppose you like better.
> :)
> 

Mikko,

you want to update your patch to what we found?
I think prepending the changelog is not a good idea. Instead one should be 
able to use update-orig target to get the upstream version that is currently 
on top in the changelog :).

Maybe use the variable UPSTREAM_VERSION instead of VERSION in the rules
file. Further, please consider to make the upstream version detection
automatic. For instancce you could use:

expr  "$(cat debian/changelog | head -n1)" : '.*[(]\(.*\)-.*[)].*$'

to get the upstream version as currently documented in changelog. Of course repackaging
the orig.tar.gz would still be necessary.

 - Alexander

 p.s. please take care that the bug is listed as To: or CC: when 
      replying to this mail (e.g. /reply-all/). 
-- 
 GPG messages preferred.   |  .''`.  ** Debian GNU/Linux **
 Alexander Sack            | : :' :      The  universal
 asac@debian.org           | `. `'      Operating System
 http://www.asoftsite.org  |   `-    http://www.debian.org/

Message #32 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Mikko Rapeli <mikko.rapeli@iki.fi>

To: Alexander Sack - Debian Bugmail <asac@debian.org>

Cc: 322134@bugs.debian.org

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Fri, 19 Aug 2005 12:27:46 +0300

On Fri, Aug 19, 2005 at 02:24:01AM +0200, Alexander Sack - Debian Bugmail wrote:
> Mikko,
> 
> you want to update your patch to what we found?
> I think prepending the changelog is not a good idea. Instead one should be 
> able to use update-orig target to get the upstream version that is currently 
> on top in the changelog :).
>
> Maybe use the variable UPSTREAM_VERSION instead of VERSION in the rules
> file. Further, please consider to make the upstream version detection
> automatic. For instancce you could use:
> 
> expr  "$(cat debian/changelog | head -n1)" : '.*[(]\(.*\)-.*[)].*$'
> 
> to get the upstream version as currently documented in changelog. Of course repackaging
> the orig.tar.gz would still be necessary.

This seems like a good idea. I can give it an update, but since testing
this takes some time on slower machines it might take a while.

-Mikko

Message #37 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: Mikko Rapeli <mikko.rapeli@iki.fi>, 322134@bugs.debian.org

Cc: Alexander Sack - Debian Bugmail <asac@debian.org>

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Sun, 2 Oct 2005 20:46:31 +0200

On Fri, Aug 19, 2005 at 12:27:46PM +0300, Mikko Rapeli wrote:
> On Fri, Aug 19, 2005 at 02:24:01AM +0200, Alexander Sack - Debian Bugmail wrote:
> > Mikko,
> > 
> > you want to update your patch to what we found?
> > I think prepending the changelog is not a good idea. Instead one should be 
> > able to use update-orig target to get the upstream version that is currently 
> > on top in the changelog :).
> >
> > Maybe use the variable UPSTREAM_VERSION instead of VERSION in the rules
> > file. Further, please consider to make the upstream version detection
> > automatic. For instancce you could use:
> > 
> > expr  "$(cat debian/changelog | head -n1)" : '.*[(]\(.*\)-.*[)].*$'
> > 
> > to get the upstream version as currently documented in changelog. Of course repackaging
> > the orig.tar.gz would still be necessary.
> 
> This seems like a good idea. I can give it an update, but since testing
> this takes some time on slower machines it might take a while.
> 

You ever found time to do some work on this?

-- 
 GPG messages preferred.   |  .''`.  ** Debian GNU/Linux **
 Alexander Sack            | : :' :      The  universal
 asac@debian.org           | `. `'      Operating System
 http://www.asoftsite.org  |   `-    http://www.debian.org

Message #42 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Mikko Rapeli <mikko.rapeli@iki.fi>

To: Alexander Sack <asac@debian.org>

Cc: 322134@bugs.debian.org

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Mon, 3 Oct 2005 08:37:34 +0300

On Sun, Oct 02, 2005 at 08:46:31PM +0200, Alexander Sack wrote:
> You ever found time to do some work on this?

Sorry but no. Apartment move got to my way.

-Mikko

Message #47 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Mikko Rapeli <mikko.rapeli@iki.fi>

To: Alexander Sack <asac@debian.org>

Cc: 322134@bugs.debian.org

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Fri, 14 Oct 2005 08:45:47 +0300

[Message part 1 (text/plain, inline)]

How about this version?

-Mikko

[mtb_rules_get-orig-source-05.txt (text/plain, attachment)]

Message #52 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: Mikko Rapeli <mikko.rapeli@iki.fi>, 322134@bugs.debian.org

Cc: Alexander Sack <asac@debian.org>

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Tue, 8 Nov 2005 19:38:02 +0100

On Fri, Oct 14, 2005 at 08:45:47AM +0300, Mikko Rapeli wrote:
> How about this version?
> 
> -Mikko

Yes Mikko, looks good. I will include it with the first 1.5 upload. If
any issues pop up then, I will come back to you.

Thanks for the patch!

 - Alexander

-- 
 GPG messages preferred.   |  .''`.  ** Debian GNU/Linux **
 Alexander Sack            | : :' :      The  universal
 asac@debian.org           | `. `'      Operating System
 http://www.asoftsite.org  |   `-    http://www.debian.org

Message #57 received at 322134@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: control@bugs.debian.org, 322134@bugs.debian.org

Cc: Alexander Sack <asac@debian.org>

Subject: Re: Bug#322134: get-orig-source debian/rules target for Thunderbird

Date: Tue, 8 Nov 2005 19:39:03 +0100

tags 322134 + confirmed
thanks

-- 
 GPG messages preferred.   |  .''`.  ** Debian GNU/Linux **
 Alexander Sack            | : :' :      The  universal
 asac@debian.org           | `. `'      Operating System
 http://www.asoftsite.org  |   `-    http://www.debian.org

Message #68 received at 363815-done@bugs.debian.org (full text, mbox, reply):

From: "Michael Casadevall" <sonicmctails@gmail.com>

To: 363815-done@bugs.debian.org

Subject: Not needed.

Date: Mon, 20 Oct 2008 08:24:04 -0400

Since we have to repack each thunderbird tarball now, this rule is
unfortunately unneeded.
Michael

Message #73 received at 363815@bugs.debian.org (full text, mbox, reply):

From: Mikko Rapeli <mikko.rapeli@iki.fi>

To: 363815@bugs.debian.org

Subject: Re: Bug#363815 closed by "Michael Casadevall" <sonicmctails@gmail.com> (Not needed.)

Date: Mon, 20 Oct 2008 19:22:31 +0300

On Mon, Oct 20, 2008 at 12:27:05PM +0000, Debian Bug Tracking System wrote:
> From: Michael Casadevall <sonicmctails@gmail.com>
> To: 363815-done@bugs.debian.org
> Date: Mon, 20 Oct 2008 08:24:04 -0400
> Subject: Not needed.
> 
> Since we have to repack each thunderbird tarball now, this rule is
> unfortunately unneeded.

Umm, what exactly does this repacking mean?

-Mikko

Message #78 received at 363815@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack <asac@debian.org>

To: Mikko Rapeli <mikko.rapeli@iki.fi>, 363815@bugs.debian.org

Subject: Re: Bug#363815: closed by "Michael Casadevall" <sonicmctails@gmail.com> (Not needed.)

Date: Mon, 20 Oct 2008 19:40:31 +0200

On Mon, Oct 20, 2008 at 07:22:31PM +0300, Mikko Rapeli wrote:
> On Mon, Oct 20, 2008 at 12:27:05PM +0000, Debian Bug Tracking System wrote:
> > From: Michael Casadevall <sonicmctails@gmail.com>
> > To: 363815-done@bugs.debian.org
> > Date: Mon, 20 Oct 2008 08:24:04 -0400
> > Subject: Not needed.
> > 
> > Since we have to repack each thunderbird tarball now, this rule is
> > unfortunately unneeded.
> 
> Umm, what exactly does this repacking mean?
> 

the repack target in debian/rules ... we could consider to use that
for get-orig-source of course.

 - Alexander

Send a report that this bug log contains spam.