Debian Bug report logs - #345100
libxine1 makes pornview segfault on startup

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Wichert Akkerman <debian@extern.wiggy.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: segfaults on startup

Date: Thu, 29 Dec 2005 00:40:19 +0100

Package: pornview
Version: 0.2pre1-5
Severity: grave

pornview does nothing but segfault for me:

[snow;/local/rac]-16> pornview
xine_thread: init threads
xine_thread: open display
zsh: segmentation fault (core dumped)  pornview

The backtrace is:

#0  0xb7a11dc4 in pthread_mutex_lock () from /lib/tls/libpthread.so.0
#1  0xb785254e in _XUnregisterFilter () from /usr/X11R6/lib/libX11.so.6
#2  0xb783ec7d in XrmQGetResource () from /usr/X11R6/lib/libX11.so.6
#3  0xb781d2b4 in XGetDefault () from /usr/X11R6/lib/libX11.so.6
#4  0xb77af662 in cairo_xlib_surface_set_drawable ()
   from /usr/lib/libcairo.so.2
#5  0xb77af901 in cairo_xlib_surface_set_drawable ()
   from /usr/lib/libcairo.so.2
#6  0xb77ad7d5 in cairo_test_xlib_disable_render () from /usr/lib/libcairo.so.2
#7  0xb7c5b8f5 in _gdk_x11_convert_to_format ()
   from /usr/lib/libgdk-x11-2.0.so.0
#8  0xb7c35494 in _gdk_drawable_ref_cairo_surface ()
   from /usr/lib/libgdk-x11-2.0.so.0
#9  0xb7c3f49f in gdk_pixmap_get_type () from /usr/lib/libgdk-x11-2.0.so.0
#10 0xb7c35494 in _gdk_drawable_ref_cairo_surface ()
   from /usr/lib/libgdk-x11-2.0.so.0
#11 0xb7c4ad50 in gdk_window_begin_paint_region ()
   from /usr/lib/libgdk-x11-2.0.so.0
#12 0xb7db7da5 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#13 0xb7c4bc50 in gdk_window_clear_area_e () from /usr/lib/libgdk-x11-2.0.so.0
#14 0xb7c4c2c5 in gdk_window_process_updates ()
   from /usr/lib/libgdk-x11-2.0.so.0
#15 0xb7d17a90 in gtk_clist_get_selection_info ()
   from /usr/lib/libgtk-x11-2.0.so.0
#16 0xb7b5e67b in g_cclosure_marshal_VOID__VOID ()
   from /usr/lib/libgobject-2.0.so.0
#17 0xb7b5267b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#18 0xb7b61c6d in g_signal_stop_emission () from /usr/lib/libgobject-2.0.so.0
#19 0xb7b63047 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#20 0xb7b633fe in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#21 0xb7cf2a08 in gtk_adjustment_value_changed ()
   from /usr/lib/libgtk-x11-2.0.so.0
#22 0xb7cf2b3c in gtk_adjustment_set_value () from /usr/lib/libgtk-x11-2.0.so.0
#23 0x08061014 in dirview_scroll_center ()
#24 0x080599fa in browser_create ()
#25 0x0806a650 in main ()


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14.3
Locale: LANG=C, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages pornview depends on:
ii  libatk1.0-0              1.10.3-1        The ATK accessibility toolkit
ii  libc6                    2.3.5-9         GNU C Library: Shared libraries an
ii  libglib2.0-0             2.8.4-2         The GLib library of C routines
ii  libgtk2.0-0              2.8.9-2         The GTK+ graphical user interface 
ii  libpango1.0-0            1.10.1-2        Layout and rendering of internatio
ii  libpng12-0               1.2.8rel-5      PNG library - runtime
ii  libx11-6                 6.8.2.dfsg.1-11 X Window System protocol client li
ii  libxext6                 6.8.2.dfsg.1-11 X Window System miscellaneous exte
ii  libxine1                 1.0.1-1.4       the xine video/media player librar
ii  xlibs                    6.8.2.dfsg.1-11 X Window System client libraries m
ii  zlib1g                   1:1.2.3-9       compression library - runtime

pornview recommends no packages.

-- no debconf information

Message #12 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Sune Vuorela <debian@pusling.com>

To: 345100@bugs.debian.org

Subject: disabling xine will make pornview work

Date: Thu, 2 Feb 2006 00:32:06 +0100

[Message part 1 (text/plain, inline)]

A workaround for this bug would be disabling xine-support. The bug is caused 
by something xine-related.
It will disable pornviews ability to show videos, but that would be better 
than a not-working pornview.

This is what it takes: (probably easier to change manually than apply as a 
pacth)
~/src/pornview-0.2pre1$ diff debian/rules.orig debian/rules
22,23c22
<               --with-gtk2 \
<               --enable-xine
---
>               --with-gtk2


Somebody, please go ahead and fix this ;)

/Sune

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Justin Pryzby <justinpryzby@users.sourceforge.net>

To: Sune Vuorela <debian@pusling.com>, 345100@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Re: Bug#345100: disabling xine will make pornview work

Date: Wed, 1 Feb 2006 19:14:05 -0500

reassign 345100 pornview,libxine-dev
thanks

On Thu, Feb 02, 2006 at 12:32:06AM +0100, Sune Vuorela wrote:
> A workaround for this bug would be disabling xine-support. The bug is caused 
> by something xine-related.
> It will disable pornviews ability to show videos, but that would be better 
> than a not-working pornview.
> 
> This is what it takes: (probably easier to change manually than apply as a 
> pacth)
> ~/src/pornview-0.2pre1$ diff debian/rules.orig debian/rules
> 22,23c22
> <               --with-gtk2 \
> <               --enable-xine
> ---
> >               --with-gtk2
> 
> Somebody, please go ahead and fix this ;)
Or figure out wtf xine did to break it...xine guis, any ideas?

Also, if someone disables xine (temporarily, I hope) it is better to
explicitly specify --without-xine, otherwise a libxine-dev which
happens to be installed on the buildd will cause pornview to fail,
again.

Justin

Message #24 received at 345100-quiet@bugs.debian.org (full text, mbox, reply):

From: Reinhard Tartler <siretart@tauware.de>

To: 345100-quiet@bugs.debian.org

Subject: Not fixed in 1.1.1-1

Date: Sat, 25 Feb 2006 12:02:58 +0100

Just wanted to not that libxine version 1.1.1 does not fix this bug.
pornview still segfaults somewhere in libxine.so. 

pornview spawns 8 additional threads, each of them doing different tasks
in xine like loading alsa module, loading config and so on. I suspect
there is a race condition somewhere.

Message #31 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Robert Lemmen <robertle@semistable.com>

To: 345100@bugs.debian.org

Subject: fix works for me

Date: Mon, 6 Mar 2006 19:41:21 +0100

[Message part 1 (text/plain, inline)]

hi everyone,

i just did the "fix" above (--without-xine), changed the build-depends
line, bumped the revision, rebuilt and now my pornview is working again.
i just mail this in to confirm the fix above. please somebody upload
this!

cu  robert

-- 
Robert Lemmen                               http://www.semistable.com 

[signature.asc (application/pgp-signature, inline)]

Message #38 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Robert Collins <robertc@robertcollins.net>

To: 345100@bugs.debian.org

Cc: control <control@bugs.debian.org>

Subject: patch for segfault

Date: Sun, 26 Mar 2006 07:36:05 +1100

[Message part 1 (text/plain, inline)]

tags: patch
thanks

I applied this bugfix in Ubuntu. Other than the debian changelog and
version number this should apply cleanly and correct the problem.

It does not appear to be xines fault per se that a segfault was occuring
- rather its this xpm problem which sets up a triggerable condition that
for some people triggers immediately, for others only triggers with
xine. I haven't tracked down the why of that :[. Theres some very old
code in there from gthumb, it might be worth someone doing a bulk update
of those support widgets.	


Rob	


diff -u pornview-0.2pre1/debian/changelog
pornview-0.2pre1/debian/changelog
--- pornview-0.2pre1/debian/changelog
+++ pornview-0.2pre1/debian/changelog
@@ -1,3 +1,11 @@
+pornview (0.2pre1-5ubuntu1) dapper; urgency=low
+
+  * Fixed segfault bug on startup due to gtk needing the widget shown rather
+    than just realized to use xpm calls. (Closes lp: #2397)
+  * Disabled xine [temporarily] - the xine opengl plugin was killing X randomly.
+
+ -- Robert Collins <robertc@robertcollins.net>  Thu, 23 Mar 2006 18:26:10 +1100
+
 pornview (0.2pre1-5build1) dapper; urgency=low
 
   * Rebuild against new libxine-main1
diff -u pornview-0.2pre1/debian/rules pornview-0.2pre1/debian/rules
--- pornview-0.2pre1/debian/rules
+++ pornview-0.2pre1/debian/rules
@@ -19,8 +19,9 @@
 		--prefix=/usr \
 		--mandir=\$${prefix}/share/man \
 		--infodir=\$${prefix}/share/info \
-		--with-gtk2 \
-		--enable-xine
+		--with-gtk2
+#\
+#		--enable-xine
 
 build: build-stamp
 
only in patch2:
unchanged:
--- pornview-0.2pre1.orig/src/browser.c
+++ pornview-0.2pre1/src/browser.c
@@ -138,6 +138,7 @@
     browser->window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
     gtk_window_set_title (GTK_WINDOW (browser->window), "PornView");
     gtk_widget_realize (browser->window);
+    gtk_widget_show(browser->window);
 
     icon_pix =
 	gdk_pixmap_create_from_xpm_d (G_WINDOW (browser->window), &icon_mask,
@@ -207,7 +208,7 @@
 			     NULL);
 
     hpaned = gedo_hpaned_new ();
-    gtk_container_add (GTK_CONTAINER (vbox), hpaned);
+    gtk_box_pack_start (GTK_BOX (vbox), hpaned, TRUE, TRUE, 0);
     gtk_widget_show (hpaned);
 
     vpaned = gedo_vpaned_new ();
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[signature.asc (application/pgp-signature, inline)]

Message #43 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Justin Pryzby <justinpryzby@users.sourceforge.net>

To: 345100@bugs.debian.org

Subject: someone should make a pornview upload

Date: Sun, 26 Mar 2006 19:56:05 -0500

Since pornview seems to be completely broken (doesn't even start up),
I think someone should upload it with --disable-xine.  This isn't a
great fix, and imo this bug should stay opened (and perhaps RC), since
playing movies is probably what pornview is used for 80+% of the time.
Robert's patch does just this.

Justin

Message #48 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: Justin Pryzby <justinpryzby@users.sourceforge.net>, 345100@bugs.debian.org

Subject: Re: Bug#345100: someone should make a pornview upload

Date: Sun, 26 Mar 2006 18:21:07 -0800

[Message part 1 (text/plain, inline)]

On Sun, Mar 26, 2006 at 07:56:05PM -0500, Justin Pryzby wrote:
> and imo this bug should stay opened (and perhaps RC), since playing movies
> is probably what pornview is used for 80+% of the time.

Huh?  When pornview was introduced to the archive, it was billed as an image
viewer.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/

[signature.asc (application/pgp-signature, inline)]

Message #53 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Justin Pryzby <justinpryzby@users.sourceforge.net>

To: Steve Langasek <vorlon@debian.org>

Cc: 345100@bugs.debian.org

Subject: Re: Bug#345100: someone should make a pornview upload

Date: Sun, 26 Mar 2006 21:25:48 -0500

On Sun, Mar 26, 2006 at 06:21:07PM -0800, Steve Langasek wrote:
> On Sun, Mar 26, 2006 at 07:56:05PM -0500, Justin Pryzby wrote:
> > and imo this bug should stay opened (and perhaps RC), since
> > playing movies is probably what pornview is used for 80+% of the
> > time.
> 
> Huh?  When pornview was introduced to the archive, it was billed as
> an image viewer.
pornview - Image and movie viewer/manager

pornview plays movies that I've had trouble playing with other
programs, so I use it for that, but I would never consider to use it
just for displaying images..just my opinion.

Message #58 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Russ Allbery <rra@debian.org>

To: Justin Pryzby <justinpryzby@users.sourceforge.net>

Cc: 345100@bugs.debian.org, Steve Langasek <vorlon@debian.org>

Subject: Re: Bug#345100: someone should make a pornview upload

Date: Sun, 26 Mar 2006 21:22:16 -0800

Justin Pryzby <justinpryzby@users.sourceforge.net> writes:

> pornview plays movies that I've had trouble playing with other programs,
> so I use it for that, but I would never consider to use it just for
> displaying images..just my opinion.

I thought it was actually a pretty nice image viewer except for the
hanging problems.  So for what it's worth, I do think there are other
takes on that.

There are probably lots of other good ones as well, but it did a good job
with thumbnails and was reasonably fast.

-- 
Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>

Message #63 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Stuart Anderson <anderson@netsweng.com>

To: 288202@bugs.debian.org, 345100@bugs.debian.org, 356736@bugs.debian.org

Cc: tbm@cyrius.com

Subject: potential fixes

Date: Fri, 26 May 2006 11:09:42 -0400 (EDT)

I have prepared fixes for all 3 of these grave bugs. Support for libxine
is still enabled.

The hanging on open problem turned out to be caused by multiple threads using
XLockDisplay(). In addition to the main thread which is opening the video
plugins, the OpenGL video plugin also starts up a new thread that then tries
to lock the displsy.  I suspect this was an ehancement in libxine that caught
pornview off guard.

The fix for the crash is the patch which was already contained in 345100.

The hang on close problem was cause by things not getting destroyed in
the reverse order in which they were created. Keeping the threads properly
in sync seems to work better when cleaning up in reverse order.

I've verified these fixes on the systems I have available, but would appreciate
it if some of the folks contributing to the threads in these bugs could also
confirm that it works for them. Packages are available at

 	http://www4.netsweng.com/~anderson/video/

or

 	deb http://www.netsweng.com/~anderson/video/ binary/



                                 Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                  BD03 0A62 E534 37A7 9149

Message #68 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Stuart Anderson <anderson@netsweng.com>

To: 288202@bugs.debian.org, 345100@bugs.debian.org, 356736@bugs.debian.org

Cc: tbm@cyrius.com

Subject: The patch for the fixes

Date: Fri, 26 May 2006 11:16:58 -0400 (EDT)

[Message part 1 (text/plain, inline)]

Ooops. I meant to attach the patch to my previous message. Here are the
changes I made.


                                Stuart

Stuart R. Anderson                               anderson@netsweng.com
Network & Software Engineering                   http://www.netsweng.com/
1024D/37A79149:                                  0791 D3B8 9A4C 2CDC A31F
                                                 BD03 0A62 E534 37A7 9149

[fixes (text/plain, attachment)]

Message #73 received at 345100@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>

To: Stuart Anderson <anderson@netsweng.com>

Cc: 288202@bugs.debian.org, 345100@bugs.debian.org, 356736@bugs.debian.org

Subject: Re: potential fixes

Date: Tue, 30 May 2006 12:33:36 +0200

* Stuart Anderson <anderson@netsweng.com> [2006-05-26 11:09]:
> I have prepared fixes for all 3 of these grave bugs. Support for libxine
> is still enabled.

Ok, I've uploaded this now, thanks.
-- 
Martin Michlmayr
http://www.cyrius.com/

Message #78 received at 345100-close@bugs.debian.org (full text, mbox, reply):

From: anderson@netsweng.com (Stuart R. Anderson)

To: 345100-close@bugs.debian.org

Subject: Bug#345100: fixed in pornview 0.2pre1-6

Date: Tue, 30 May 2006 03:47:11 -0700

Source: pornview
Source-Version: 0.2pre1-6

We believe that the bug you reported is fixed in the latest version of
pornview, which is due to be installed in the Debian FTP archive:

pornview_0.2pre1-6.diff.gz
  to pool/main/p/pornview/pornview_0.2pre1-6.diff.gz
pornview_0.2pre1-6.dsc
  to pool/main/p/pornview/pornview_0.2pre1-6.dsc
pornview_0.2pre1-6_i386.deb
  to pool/main/p/pornview/pornview_0.2pre1-6_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 345100@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Stuart R. Anderson <anderson@netsweng.com> (supplier of updated pornview package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 26 May 2006 08:17:31 -0400
Source: pornview
Binary: pornview
Architecture: source i386
Version: 0.2pre1-6
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Stuart R. Anderson <anderson@netsweng.com>
Description: 
 pornview   - Image and movie viewer/manager
Closes: 288202 345100 356736
Changes: 
 pornview (0.2pre1-6) unstable; urgency=low
 .
   * Fix a segv when starting up (Closes: #345100)
   * Tear down the xine instance in the reverse order that it was built to keep
     thread managment sane. (Closes: #288202)
   * The opengl xine plugin starts upa thread and uses XLockDisplay(). Avoid
     locking it in gtk_xine_realize() to prevent the hang on startup. This
     should be OK since the xine thread isn't created until after the display
     was unlocked anyway. If this ends up just moving the problem, a higher
     level lock may be needed. (Closes: #356736)
Files: 
 45b372be333ff70d5e8286555f8e6ad1 639 utils optional pornview_0.2pre1-6.dsc
 aa22b09f8553528d5c69392db412d5e2 5228 utils optional pornview_0.2pre1-6.diff.gz
 19323b68dacb6418d6a15dcba6d58e3e 235628 utils optional pornview_0.2pre1-6_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEfB9jKb5dImj9VJ8RAqucAJ9Vbf6RpUsjB7tP/Y4C24XtPhryMQCfWl6f
+FotHB7+MSq5ohwLNshoUNE=
=WIXL
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.