Debian Bug report logs - #335655
libncurses5: redundant test in init_pair

version graph

Package: libncurses5; Maintainer for libncurses5 is Craig Small <csmall@debian.org>; Source for libncurses5 is src:ncurses.

Reported by: Ron <ron@debian.org>

Date: Tue, 25 Oct 2005 08:19:11 UTC

Severity: minor

Found in version libncurses5/5.5-1

Done: Daniel Baumann <daniel@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Daniel Jacobowitz <ncurses-maint@debian.org>:
Bug#335655; Package libncurses5. Full text and rfc822 format available.

Acknowledgement sent to Ron <ron@debian.org>:
New Bug report received and forwarded. Copy sent to Daniel Jacobowitz <ncurses-maint@debian.org>. Full text and rfc822 format available.

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Ron <ron@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: libncurses5: redundant test in init_pair
Date: Tue, 25 Oct 2005 17:31:01 +0930
Package: libncurses5
Version: 5.5-1
Severity: minor

Hi,

While still poking about re the other bug I just reported,
I noticed this (also in init_pair):

    if (initialize_pair) {
        const color_t *tp = hue_lightness_saturation ? hls_palette : cga_palette;

        T(("initializing pair: pair = %d, fg=(%d,%d,%d), bg=(%d,%d,%d)",
           pair,
           tp[f].red, tp[f].green, tp[f].blue,
           tp[b].red, tp[b].green, tp[b].blue));

        if (initialize_pair) {
            TPUTS_TRACE("initialize_pair");
            putp(tparm(initialize_pair,
                       pair,
                       tp[f].red, tp[f].green, tp[f].blue,
                       tp[b].red, tp[b].green, tp[b].blue));
        }
    }

surely nothing changes the value of initialize_pair (anymore?)
between the first test and the second...

 Ron


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages libncurses5 depends on:
ii  libc6                         2.3.5-7    GNU C Library: Shared libraries an

Versions of packages libncurses5 recommends:
ii  libgpmg1                     1.19.6-21.1 General Purpose Mouse - shared lib

-- no debconf information



Reply sent to daniel@debian.org:
You have taken responsibility. Full text and rfc822 format available.

Notification sent to Ron <ron@debian.org>:
Bug acknowledged by developer. Full text and rfc822 format available.

Message #10 received at 335655-done@bugs.debian.org (full text, mbox):

From: Daniel Baumann <daniel@debian.org>
To: 335655-done@bugs.debian.org
Date: Mon, 23 Jun 2008 14:48:16 +0200
the mentioned redundant check is not present anymore, closing.

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 22 Jul 2008 07:34:42 GMT) Full text and rfc822 format available.

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Thu Apr 17 04:17:33 2014; Machine Name: buxtehude.debian.org

Debian Bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.