Debian Bug report logs - #335528
subversion: svn+ssh breaks will automatic ssh connection caching

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Paul Brook <paul@nowt.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: subversion: svn+ssh breaks will automatic ssh connection caching

Date: Mon, 24 Oct 2005 14:49:44 +0100

Package: subversion
Version: 1.2.3a-1
Severity: normal


The combination of svn+ssh and automatic ssh connection caching is
broken.

In my ~/.ssh/config I have 

ControlPath /tmp/.ssh-%h-%p-%r
ControlMaster auto

The first svn command succeeds, the second fails with

Control socket connect(/tmp/.ssh-jay-22-paul): Connection refused
ControlSocket /tmp/.ssh-jay-22-paul already exists
svn: Connection closed unexpectedly

Looking at strace output it appears that svn very rudely terminates its
child processes with SIGKILL.  This makes ssh leave stray connection
state files lying around.

Arguably this is a ssh bug (separate bug filed), but svn really should
give the child process chance to exit gracefully.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13.4-w64
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)

Versions of packages subversion depends on:
ii  db4.2-util                 4.2.52-20     Berkeley v4.2 Database Utilities
ii  libapr0                    2.0.54-5      the Apache Portable Runtime
ii  libc6                      2.3.5-7       GNU C Library: Shared libraries an
ii  libdb4.2                   4.2.52-20     Berkeley v4.2 Database Libraries [
ii  libexpat1                  1.95.8-3      XML parsing C library - runtime li
ii  libldap2                   2.1.30-12     OpenLDAP libraries
ii  libneon24                  0.24.7.dfsg-2 An HTTP and WebDAV client library
ii  libssl0.9.7                0.9.7g-5      SSL shared libraries
ii  libsvn0                    1.2.3a-1      shared libraries used by Subversio
ii  libxml2                    2.6.22-1      GNOME XML library
ii  patch                      2.5.9-2       Apply a diff file to an original
ii  zlib1g                     1:1.2.3-6     compression library - runtime

subversion recommends no packages.

-- no debconf information

Message #10 received at 335528@bugs.debian.org (full text, mbox, reply):

From: Vincent Lefevre <vincent@vinc17.org>

To: 335528@bugs.debian.org

Subject: Re: subversion: svn+ssh breaks will automatic ssh connection caching

Date: Fri, 4 Nov 2005 18:14:01 +0100

On 2005-10-24 14:49:44 +0100, Paul Brook wrote:
> The combination of svn+ssh and automatic ssh connection caching is
> broken.
> 
> In my ~/.ssh/config I have 
> 
> ControlPath /tmp/.ssh-%h-%p-%r
> ControlMaster auto

You're not allowed to do that as the master connection will close
any slave connection. More precisely, the following behavior may
happen with a single svn command:

1. The subversion client does a first ssh connection.
   A master ssh connection is automatically opened.

2. The subversion client does a second ssh connection.
   A slave connection is opened.

3. The subversion client closes the first ssh connection.
   This closes the master *and* the slave connections.

So, svn fails. This is definitely not a Subversion bug here.
Of course, ssh should be improved. See

  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=335697

(this is unrelated to the ssh bug you filled).

> Looking at strace output it appears that svn very rudely terminates its
> child processes with SIGKILL.  This makes ssh leave stray connection
> state files lying around.

This part may be a bug in Subversion, though. But if you start the
master connection manually (svn -fMN ...), there are no problems.

> Arguably this is a ssh bug (separate bug filed), but svn really should
> give the child process chance to exit gracefully.

I don't think this (bug 335531) is a ssh bug. Overwriting the files
could lead to a race condition in a "normal" use.

Anyway, "fixing" this bug only won't solve your problem, as I've
explained above.

-- 
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / SPACES project at LORIA

Message #17 received at 335528-close@bugs.debian.org (full text, mbox, reply):

From: Troy Heber <troyh@debian.org>

To: 335528-close@bugs.debian.org

Subject: Bug#335528: fixed in subversion 1.3.1-3

Date: Sat, 06 May 2006 11:34:01 -0700

Source: subversion
Source-Version: 1.3.1-3

We believe that the bug you reported is fixed in the latest version of
subversion, which is due to be installed in the Debian FTP archive:

libapache2-svn_1.3.1-3_i386.deb
  to pool/main/s/subversion/libapache2-svn_1.3.1-3_i386.deb
libsvn-core-perl_1.3.1-3_i386.deb
  to pool/main/s/subversion/libsvn-core-perl_1.3.1-3_i386.deb
libsvn-doc_1.3.1-3_all.deb
  to pool/main/s/subversion/libsvn-doc_1.3.1-3_all.deb
libsvn-javahl_1.3.1-3_i386.deb
  to pool/main/s/subversion/libsvn-javahl_1.3.1-3_i386.deb
libsvn-ruby1.8_1.3.1-3_i386.deb
  to pool/main/s/subversion/libsvn-ruby1.8_1.3.1-3_i386.deb
libsvn-ruby_1.3.1-3_all.deb
  to pool/main/s/subversion/libsvn-ruby_1.3.1-3_all.deb
libsvn0-dev_1.3.1-3_i386.deb
  to pool/main/s/subversion/libsvn0-dev_1.3.1-3_i386.deb
libsvn0_1.3.1-3_i386.deb
  to pool/main/s/subversion/libsvn0_1.3.1-3_i386.deb
python-subversion_1.3.1-3_i386.deb
  to pool/main/s/subversion/python-subversion_1.3.1-3_i386.deb
subversion-tools_1.3.1-3_all.deb
  to pool/main/s/subversion/subversion-tools_1.3.1-3_all.deb
subversion_1.3.1-3.diff.gz
  to pool/main/s/subversion/subversion_1.3.1-3.diff.gz
subversion_1.3.1-3.dsc
  to pool/main/s/subversion/subversion_1.3.1-3.dsc
subversion_1.3.1-3_i386.deb
  to pool/main/s/subversion/subversion_1.3.1-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 335528@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Troy Heber <troyh@debian.org> (supplier of updated subversion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri, 05 May 2006 18:14:57 -0600
Source: subversion
Binary: libsvn-core-perl libsvn0 libsvn-javahl libsvn-doc libsvn-ruby libapache2-svn libsvn-ruby1.8 python-subversion subversion-tools subversion libsvn0-dev
Architecture: source all i386
Version: 1.3.1-3
Distribution: unstable
Urgency: medium
Maintainer: Guilherme de S. Pastore <guilherme.pastore@terra.com.br>
Changed-By: Troy Heber <troyh@debian.org>
Description: 
 libapache2-svn - apache modules for Subversion (aka. svn)
 libsvn-core-perl - perl bindings for Subversion (aka. svn)
 libsvn-doc - development documentation for Subversion (aka. svn) libraries
 libsvn-javahl - java bindings for Subversion (aka. svn)
 libsvn-ruby - ruby modules for interfacing with Subversion (aka. svn)
 libsvn-ruby1.8 - ruby modules for interfacing with Subversion (aka. svn)
 libsvn0    - shared libraries used by Subversion (aka. svn)
 libsvn0-dev - development files for Subversion (aka. svn) libraries
 python-subversion - python modules for interfacing with Subversion (aka. svn)
 subversion - advanced version control system (aka. svn)
 subversion-tools - assorted tools related to Subversion (aka. svn)
Closes: 242368 259226 282468 290774 292358 335528 359315 363983
Changes: 
 subversion (1.3.1-3) unstable; urgency=medium
 .
   [ Peter Samuelson ]
   * Tighten dependency between subversion and libsvn0, to reduce user
     confusion.  It is almost always the library version that matters, as
     far as bugs and features are concerned.  (Closes: #359315)
   * Disable java bindings on hppa and ia64, since kaffe is broken on
     those architectures.  It's been broken on ia64 for a long time, and it
     looks as though hppa may remain broken for awhile too (see #364819).
   * ssh-no-sigkill.patch: new patch to SIGTERM (instead of SIGKILL) the
     tunnel agent, which is usually ssh.  We can do this now that #313371
     is fixed.  (Closes: #335528)
   * rules: add -V'libsvn0 (>= 1.3.0)' to dh_makeshlibs to loosen the
     shlibs file a bit.  Upstream guarantees that the library ABI won't be
     augmented during any single x.y.* cycle.
   * svnwrap.sh, man/svnwrap.1: new script for subversion-tools package to
     optionally wrap subversion client commands with 'umask 002'.
     (Closes: #242368, #259226, #282468, #292358)
   * lc_ctype.patch: new patch to make locale errors non-fatal, suggested
     by upstream developer Peter Lundblad.  (Closes: #363983)
   * last-changed-date-charset.patch: new patch: convert $LastChangedDate$
     keyword from UTF-8 to local character set.  (Closes: #290774)
   * apache-crash-fix.patch: new patch to fix a crash in mod_dav_svn.
   * swig-warning-124.patch: new patch to disable swig typemap warning,
     drastically shrinking the build log.
 .
   [ Troy Heber ]
   * changing from UNRELEASED to unstable and uploading
Files: 
 c82812dbc41e41c0013573a2d51b688d 1409 devel optional subversion_1.3.1-3.dsc
 8c877d2e6cb5d62edc48eacbafd0587c 48387 devel optional subversion_1.3.1-3.diff.gz
 9decc67c0625a35a1129e6f2b291a1da 987698 doc extra libsvn-doc_1.3.1-3_all.deb
 edde96e2cbb10b5617f2a488dc97c016 121810 admin extra subversion-tools_1.3.1-3_all.deb
 10992a701c77babd2086f883c0801844 954 devel optional libsvn-ruby_1.3.1-3_all.deb
 33db1f6f62a1c332292c5afd2231f92c 942688 devel optional subversion_1.3.1-3_i386.deb
 9359893f7d9a599cf740ec53a4d22166 544718 libs optional libsvn0_1.3.1-3_i386.deb
 452ce01394fe3973b87224bdea4e9c0a 758478 libdevel extra libsvn0-dev_1.3.1-3_i386.deb
 26050770e184eb67132effa7b00c1c35 114908 net optional libapache2-svn_1.3.1-3_i386.deb
 bb2420d602ff78442981cc8746ac8c73 518120 python optional python-subversion_1.3.1-3_i386.deb
 501e17972bf7b459b687d9a8dff3dde7 192402 devel optional libsvn-javahl_1.3.1-3_i386.deb
 26e0717244e2157e8494a3e194a02c1f 735826 perl optional libsvn-core-perl_1.3.1-3_i386.deb
 493db82cdd177f4d93d5d04167769141 345006 devel optional libsvn-ruby1.8_1.3.1-3_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEXMIjQOr9C+GfGI4RAkPjAKCEx0IgC3XMDLLQNs733YToVdXxygCfQtGX
Td9fv8Y8KKbKxYPczHNKyMg=
=sLHT
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.