Debian Bug report logs - #334917
klibc barfs on m68k syscall interface

version graph

Package: klibc; Maintainer for klibc is maximilian attems <maks@debian.org>;

Reported by: Stephen R Marenka <stephen@marenka.net>

Date: Thu, 20 Oct 2005 19:04:22 UTC

Severity: important

Tags: upstream

Found in versions 1.5.20-1, klibc/1.1.1-2, klibc/1.5.15-1

Fixed in version klibc/2.0~rc2-0.1

Done: Thorsten Glaser <tg@mirbsd.de>

Bug is archived. No further changes may be made.

Forwarded to http://www.zytor.com/pipermail/klibc/2011-January/002821.html

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@sternwelten.at>:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to Stephen R Marenka <stephen@marenka.net>:
New Bug report received and forwarded. Copy sent to maximilian attems <maks@sternwelten.at>. (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Stephen R Marenka <stephen@marenka.net>
To: submit@bugs.debian.org
Subject: klibc_1.1.1-2(m68k/unstable/vault13): FTBFS on m68k
Date: Thu, 20 Oct 2005 13:45:19 -0500
Package: klibc
Version: 1.1.1-2
Severity: important


klibc fails to build from source on m68k.

Here are selected excerpts from the buildd log.


| Automatic build of klibc_1.1.1-2 on amiga1200.jt7336.tky.hut.fi by sbuild/m68k 69
| Build started at 20051020-2053
| ******************************************************************************

 [...]

| ** Using build dependencies supplied by package:
| Build-Depends: cdbs, debhelper (>= 4.0.0), linux-headers-2.6.12-1, bison, flex

 [...]

| Checking correctness of source dependencies...
| Toolchain package versions: libc6-dev_2.3.5-6 linux-kernel-headers_2.6.13+0rc3-2 gcc-4.0_4.0.2-2 g++-4.0_4.0.2-2 binutils_2.16.1-2 libstdc++6-4.0-dev_4.0.2-2 libstdc++6_4.0.2-2

 [...]

| gcc -Wp,-MT,siglongjmp.o,-MD,./.siglongjmp.o.d -Os -fomit-frame-pointer  -D__KLIBC__=1 -D__KLIBC_MINOR__=1 -nostdlib -nostdinc -iwithprefix include -I../include/arch/m68k -I../include/bits32 -I../include -I../linux/include -I../linux/include2 -I../linux/include -I./zlib -I./zlib -DWITH_ERRLIST -W -Wall -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Winline -DDYNAMIC_CRC_TABLE -c -o siglongjmp.o siglongjmp.c
| In file included from siglongjmp.c:8:
| ../include/setjmp.h:13:30: error: klibc/archsetjmp.h: No such file or directory
| In file included from siglongjmp.c:8:
| ../include/setjmp.h:15: warning: parameter names (without types) in function declaration
| ../include/setjmp.h:16: error: syntax error before 'int'
| ../include/setjmp.h:16: warning: function declaration isn't a prototype
| ../include/setjmp.h:28: error: syntax error before 'jmp_buf'
| ../include/setjmp.h:28: warning: no semicolon at end of struct or union
| ../include/setjmp.h:30: error: syntax error before '}' token
| ../include/setjmp.h:32: error: array type has incomplete element type
| ../include/setjmp.h:41: warning: type defaults to 'int' in declaration of 'type name'
| siglongjmp.c:11: warning: type defaults to 'int' in declaration of 'buf'
| siglongjmp.c: In function 'siglongjmp':
| siglongjmp.c:13: error: invalid type argument of '->'
| siglongjmp.c:14: error: invalid type argument of '->'
| make[2]: *** [siglongjmp.o] Error 1
| make[2]: Leaving directory `/build/buildd/klibc-1.1.1/klibc'
| make[1]: *** [all] Error 2
| make[1]: Leaving directory `/build/buildd/klibc-1.1.1'
| make: *** [debian/stamp-makefile-build] Error 2
| ******************************************************************************
| Build finished at 20051020-2106
| FAILED [dpkg-buildpackage died]


A full buildd log is available at 
<http://buildd.debian.org/build.php?pkg=klibc&ver=1.1.1-2&arch=m68k>

Other buildd logs may be available at 
<http://buildd.debian.org/build.php?arch=&pkg=klibc>

--
Stephen R. Marenka     If life's not fun, you're not doing it right!
<stephen@marenka.net>



Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to maximilian attems <maks@sternwelten.at>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #10 received at 334917@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>
To: Stephen R Marenka <stephen@marenka.net>, 334917@bugs.debian.org
Subject: Re: Bug#334917: klibc_1.1.1-2(m68k/unstable/vault13): FTBFS on m68k
Date: Wed, 26 Oct 2005 14:34:20 +0200
On Thu, 20 Oct 2005, Stephen R Marenka wrote:

> Package: klibc
> Version: 1.1.1-2
> Severity: important

next Version 1.1.1-3 will list the archs klibc currently supports.
thanks for the current moderate Severity, will leave as is.

 
> klibc fails to build from source on m68k.

this is somehow expected.
as klibc/README states m68k is not supported atm.

will need some porter work to get it building and working.

--
maks



Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to maximilian attems <maks@sternwelten.at>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #15 received at 334917@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>
To: Stephen R Marenka <stephen@marenka.net>
Cc: 334917@bugs.debian.org
Subject: Re: Bug#334917: klibc_1.1.1-2(m68k/unstable/vault13): FTBFS on m68k
Date: Wed, 19 Apr 2006 10:09:38 +0200
On Thu, 20 Oct 2005, Stephen R Marenka wrote:

> klibc fails to build from source on m68k.
> 
> Here are selected excerpts from the buildd log.

snipp from 1.2.2-1 release:
  * Add m68k-syscall.patch thanks to Kyle McMartin <kyle@parisc-linux.org>.
    Still needs setjmp/longjmp, crt0, and sysstub.ph to be usefull.

so there are still missing parts for m68k porters to jump in.
as m68k linux-2.6 uses build-in ide, i guess klibc is not a current priority.
please note that klibc is on the way to be merged in linux-2.6.18.

regards
 
-- 
maks



Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to maximilian attems <maks@sternwelten.at>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #20 received at 334917@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>
To: 334917@bugs.debian.org, Stephen R Marenka <stephen@marenka.net>
Cc: debian-kernel@lists.debian.org, debian-68k@lists.debian.org
Subject: klibc m68k state
Date: Fri, 5 May 2006 16:41:11 +0200
tags 334917 moreinfo
thanks

hello stephen,

i guess you have been busy. i have some good news for new,
upstream ported klibc to m68k with 1.3.11 and added fixes since,
although it is marked as not yet tested.
just uploaded 1.3.16-2 to unstable.

hmmm, atm i don't see an build of m68k listed here:
http://buildd.debian.org/build.php?pkg=klibc

you need build-dep linux-headers-2.6.16-1 for m68k.
hope to get some feedback if it's working, a good first test is the fstype
binary:  /usr/lib/klibc/bin/fstype < /dev/sda1
an even cooler test would be an initramfs-tools boot which uses run-init.

regards

-- 
maks



Tags added: moreinfo Request was from maximilian attems <maks@sternwelten.at> to control@bugs.debian.org. (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to maximilian attems <maks@sternwelten.at>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #27 received at 334917@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>
To: 334917@bugs.debian.org, Stephen R Marenka <stephen@marenka.net>, debian-kernel@lists.debian.org, debian-68k@lists.debian.org
Subject: Re: klibc m68k state
Date: Mon, 8 May 2006 19:01:26 +0200
thanks to cts klibc got more build fixes and 1.3.19 should
just build fine on m68k.

On Fri, 05 May 2006, maximilian attems wrote:

> you need build-dep linux-headers-2.6.16-1 for m68k.
> hope to get some feedback if it's working, a good first test is the fstype
> binary:  /usr/lib/klibc/bin/fstype < /dev/sda1
> an even cooler test would be an initramfs-tools boot which uses run-init.

i'm eager to hear of one of the aboves tests.

regards

-- 
maks



Information forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@sternwelten.at>:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to Stephen R Marenka <stephen@marenka.net>:
Extra info received and forwarded to list. Copy sent to maximilian attems <maks@sternwelten.at>. (full text, mbox, link).


Message #32 received at 334917@bugs.debian.org (full text, mbox, reply):

From: Stephen R Marenka <stephen@marenka.net>
To: 334917@bugs.debian.org, debian-kernel@lists.debian.org, debian-68k@lists.debian.org
Subject: Re: klibc m68k state
Date: Wed, 10 May 2006 09:30:08 -0500
[Message part 1 (text/plain, inline)]
On Mon, May 08, 2006 at 07:01:26PM +0200, maximilian attems wrote:
> thanks to cts klibc got more build fixes and 1.3.19 should
> just build fine on m68k.

Successful build.

> On Fri, 05 May 2006, maximilian attems wrote:
> 
> > you need build-dep linux-headers-2.6.16-1 for m68k.
> > hope to get some feedback if it's working, a good first test is the fstype
> > binary:  /usr/lib/klibc/bin/fstype < /dev/sda1
> > an even cooler test would be an initramfs-tools boot which uses run-init.
> 
> i'm eager to hear of one of the aboves tests.

(sid-di)root@zeus:~# /usr/lib/klibc/bin/fstype < /dev/sda1
stdin: error 4294966272

(sid-di)root@zeus:~# /usr/lib/klibc/bin/fstype < /dev/sda9
stdin: error 4294966272

It builds initrd's for the latest kernels just fine, which means they
can at least now be installed on systems with running kernels < 2.6.
Yeah!  Unfortunately, my hardware doesn't work with 2.6 yet, so I'll 
have to leave that test for someone else.

Thanks,

Stephen

-- 
Stephen R. Marenka     If life's not fun, you're not doing it right!
<stephen@marenka.net>
[signature.asc (application/pgp-signature, inline)]

Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to maximilian attems <maks@sternwelten.at>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #37 received at 334917@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <maks@sternwelten.at>
To: 334917@bugs.debian.org, debian-kernel@lists.debian.org, debian-68k@lists.debian.org
Subject: Re: klibc m68k state
Date: Wed, 10 May 2006 17:00:17 +0200
retitle 334917 klibc barfs on m68k syscall interface 
thanks

On Wed, May 10, 2006 at 09:30:08AM -0500, Stephen R Marenka wrote:
> > thanks to cts klibc got more build fixes and 1.3.19 should
> > just build fine on m68k.
> 
> Successful build.

cool, good news.
 
> > On Fri, 05 May 2006, maximilian attems wrote:
> > 
> > > you need build-dep linux-headers-2.6.16-1 for m68k.
> > > hope to get some feedback if it's working, a good first test is the fstype
> > > binary:  /usr/lib/klibc/bin/fstype < /dev/sda1
> > > an even cooler test would be an initramfs-tools boot which uses run-init.
> > 
> > i'm eager to hear of one of the aboves tests.
> 
> (sid-di)root@zeus:~# /usr/lib/klibc/bin/fstype < /dev/sda1
> stdin: error 4294966272
> 
> (sid-di)root@zeus:~# /usr/lib/klibc/bin/fstype < /dev/sda9
> stdin: error 4294966272

hmm i need an strace of aboves error,
also an access to an m68k porter box to try to get the syscall
interface right would be cool.
 
> It builds initrd's for the latest kernels just fine, which means they
> can at least now be installed on systems with running kernels < 2.6.
> Yeah!  Unfortunately, my hardware doesn't work with 2.6 yet, so I'll 
> have to leave that test for someone else.

nice indeed, but won't boot with aboves error yet ;)

thanks for feedback + regards

-- 
maks



Changed Bug title. Request was from maximilian attems <maks@sternwelten.at> to control@bugs.debian.org. (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@sternwelten.at>:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to Ingo Juergensmann <ij@2006.bluespice.org>:
Extra info received and forwarded to list. Copy sent to maximilian attems <maks@sternwelten.at>. (full text, mbox, link).


Message #44 received at 334917@bugs.debian.org (full text, mbox, reply):

From: Ingo Juergensmann <ij@2006.bluespice.org>
To: 334917@bugs.debian.org, debian-kernel@lists.debian.org, debian-68k@lists.debian.org
Subject: Re: klibc m68k state
Date: Wed, 10 May 2006 17:08:45 +0200
On Wed, May 10, 2006 at 09:30:08AM -0500, Stephen R Marenka wrote:

> > i'm eager to hear of one of the aboves tests.
> (sid-di)root@zeus:~# /usr/lib/klibc/bin/fstype < /dev/sda1
> stdin: error 4294966272
> (sid-di)root@zeus:~# /usr/lib/klibc/bin/fstype < /dev/sda9
> stdin: error 4294966272
> It builds initrd's for the latest kernels just fine, which means they
> can at least now be installed on systems with running kernels < 2.6.
> Yeah!  Unfortunately, my hardware doesn't work with 2.6 yet, so I'll 
> have to leave that test for someone else.

You could copy that over to spice or vivaldi. Both are running 2.6. 

-- 
Ciao...                //        Fon: 0381-2744150 
      Ingo           \X/         SIP: 2744150@sipgate.de

gpg pubkey: http://www.juergensmann.de/ij/public_key.asc



Information forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@sternwelten.at>:
Bug#334917; Package klibc. (full text, mbox, link).


Acknowledgement sent to Martin Michlmayr <tbm@cyrius.com>:
Extra info received and forwarded to list. Copy sent to maximilian attems <maks@sternwelten.at>. (full text, mbox, link).


Message #49 received at 334917@bugs.debian.org (full text, mbox, reply):

From: Martin Michlmayr <tbm@cyrius.com>
To: 334917@bugs.debian.org, debian-kernel@lists.debian.org, debian-68k@lists.debian.org
Subject: Re: klibc m68k state
Date: Wed, 10 May 2006 17:19:35 +0200
* Stephen R Marenka <stephen@marenka.net> [2006-05-10 09:30]:
> It builds initrd's for the latest kernels just fine, which means they
> can at least now be installed on systems with running kernels < 2.6.
> Yeah!  Unfortunately, my hardware doesn't work with 2.6 yet, so I'll 
> have to leave that test for someone else.

But m68k isn't actually using the initramfs that is generated?  If so,
you can simply turn off initrd/initramfs on m68 -- see mips for an
example.
-- 
Martin Michlmayr
http://www.cyrius.com/



Bug Marked as found in versions klibc/1.5.15-1. Request was from Thorsten Glaser <tg@mirbsd.de> to control@bugs.debian.org. (Wed, 14 Apr 2010 19:27:02 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@debian.org>:
Bug#334917; Package klibc. (Wed, 14 Apr 2010 19:36:03 GMT) (full text, mbox, link).


Acknowledgement sent to Thorsten Glaser <tg@mirbsd.de>:
Extra info received and forwarded to list. Copy sent to maximilian attems <maks@debian.org>. (Wed, 14 Apr 2010 19:36:03 GMT) (full text, mbox, link).


Message #56 received at 334917@bugs.debian.org (full text, mbox, reply):

From: Thorsten Glaser <tg@mirbsd.de>
To: 334917@bugs.debian.org
Cc: control@bugs.debian.org
Subject: Re: klibc m68k state
Date: Wed, 14 Apr 2010 19:22:27 +0000 (UTC)
found 334917 klibc/1.5.15-1
thanks

Hi maks,

you could try using http://wiki.debian.org/Aranym/Quick to get your
own m68k system – I’m running three of them at the moment (trying to
get recent binutils, gcc and texlive to build to get the buildds to
work again).

bye,
//mirabilos
-- 
FWIW, I'm quite impressed with mksh interactively. I thought it was much
*much* more bare bones. But it turns out it beats the living hell out of
ksh93 in that respect. I'd even consider it for my daily use if I hadn't
wasted half my life on my zsh setup. :-) -- Frank Terbeck in #!/bin/mksh




Bug Marked as found in versions 1.5.20-1. Request was from Thorsten Glaser <tg@mirbsd.de> to control@bugs.debian.org. (Mon, 22 Nov 2010 23:06:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@debian.org>:
Bug#334917; Package klibc. (Sat, 29 Jan 2011 16:21:06 GMT) (full text, mbox, link).


Acknowledgement sent to Thorsten Glaser <tg@mirbsd.de>:
Extra info received and forwarded to list. Copy sent to maximilian attems <maks@debian.org>. (Sat, 29 Jan 2011 16:21:06 GMT) (full text, mbox, link).


Message #63 received at 334917@bugs.debian.org (full text, mbox, reply):

From: Thorsten Glaser <tg@mirbsd.de>
To: 334917@bugs.debian.org
Cc: control@bugs.debian.org, debian-68k@lists.debian.org, klibc@zytor.com
Subject: [PATCH] Re: klibc barfs on m68k syscall interface
Date: Sat, 29 Jan 2011 16:18:21 +0000 (UTC)
[Message part 1 (text/plain, inline)]
tag 334917 = patch
thanks

Hi,

I’ve fixed the m68k syscall of klibc and made it able to use
six-argument syscalls like mmap2. However, I could not yet
fully test it (only mostly; opendir() specifically fails) due
to: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47533

@m68k porters: Please have a look at the gcc bug as well.

@klibc: Please apply the patch, it’s better than what we have,
and (@packagers) with a binNMU it can be fixed once gcc works.

bye,
//mirabilos
-- 
22:20⎜<asarch> The crazy that persists in his craziness becomes a master
22:21⎜<asarch> And the distance between the craziness and geniality is
only measured by the success                       22:21⎜<mksh> it’s a
very thin line anyway… with some, you don’t know which side they’re on
[klibc_1.5.21-1+tg.2.debdiff (text/plain, attachment)]

Added tag(s) patch; removed tag(s) moreinfo. Request was from Thorsten Glaser <tg@mirbsd.de> to control@bugs.debian.org. (Sat, 29 Jan 2011 16:21:08 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@debian.org>:
Bug#334917; Package klibc. (Sat, 29 Jan 2011 16:39:06 GMT) (full text, mbox, link).


Acknowledgement sent to maximilian attems <max@stro.at>:
Extra info received and forwarded to list. Copy sent to maximilian attems <maks@debian.org>. (Sat, 29 Jan 2011 16:39:06 GMT) (full text, mbox, link).


Message #70 received at 334917@bugs.debian.org (full text, mbox, reply):

From: maximilian attems <max@stro.at>
To: Thorsten Glaser <tg@mirbsd.de>, 334917@bugs.debian.org
Cc: debian-68k@lists.debian.org, klibc@zytor.com
Subject: Re: Bug#334917: [PATCH] Re: klibc barfs on m68k syscall interface
Date: Sat, 29 Jan 2011 16:38:10 +0000
On Sat, Jan 29, 2011 at 04:18:21PM +0000, Thorsten Glaser wrote:
> 
> I’ve fixed the m68k syscall of klibc and made it able to use
> six-argument syscalls like mmap2. However, I could not yet
> fully test it (only mostly; opendir() specifically fails) due
> to: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47533
 
well ok thanks for the effort, but please really do use git.
The klibc git repo is at 
http://git.kernel.org/?p=libs/klibc/klibc.git;a=summary

git clone it and work away.
 
> +--- klibc-1.5.21.orig/usr/klibc/arch/m68k/syscall.S	2011-01-29 13:28:39.000000000 +0100
> ++++ klibc-1.5.21/usr/klibc/arch/m68k/syscall.S	2011-01-29 15:47:09.000000000 +0100
> +@@ -11,17 +11,47 @@
> + 	.globl	__syscall_common
> + 	.type	__syscall_common, @function
> + __syscall_common:
> +-	movem.l %d2-%d6, -(%sp)	/* 5 registers saved */
> +-	movem.l	24(%sp), %d1-%d6
> ++#if 0
> ++	/* debugging: define "int32_t last_syscall;" in your code... */
> ++	move.l	%d0, (last_syscall)	/* to see which is actually run */
> ++#endif
please no no ugly ifdefs.
> ++	/*
> ++	 * According to eglibc, separate moves are faster than movem;
> ++	 * speed is important and this code is not duplicated anyway,
> ++	 * so we do the same here. We use %a1 as scratch register for
> ++	 * saving; syscall arguments are to be in %d1 to %d5 and %a0.
> ++	 */
> ++	move.l	24(%sp), %a0		/* orig.sp+24: arg 6 */
> ++	move.l	%d5, -(%sp)		/* push d5 (callee saved) */
> ++	move.l	24(%sp), %d5		/* orig.sp+20: arg 5 */
> ++	move.l	%d4, -(%sp)		/* push d4 (callee saved) */
> ++	move.l	24(%sp), %d4		/* orig.sp+16: arg 4 */
> ++	move.l	%d3, -(%sp)		/* push d3 (callee saved) */
> ++	move.l	24(%sp), %d3		/* orig.sp+12: arg 3 */
> ++	move.l	%d2, %a1		/* save d2 (callee saved) in a1 */
> ++	move.l	20(%sp), %d2		/* orig.sp+8:  arg 2 */
> ++	move.l	16(%sp), %d1		/* orig.sp+4:  arg 1 */
> + 	trap	#0
> +-	cmpi.l	#-4095, %d0
> +-	blt.l	1f
> ++	move.l	%a1, %d2		/* restore d2 from a1 (scratch) */
> ++	move.l	(%sp)+, %d3		/* pop d3..d5, see above */
> ++	move.l	(%sp)+, %d4
> ++	move.l	(%sp)+, %d5
> ++
> ++	/* syscall is done, result in %d0, registers are restored */
> ++	.globl	__syscall_checkandout
> ++__syscall_checkandout:
> ++	/* now check for error */
> ++	cmp.l	#-4095, %d0
> ++	bcs.l	1f			/* jmp short if _not_ error */
> ++
> ++	/* prepare for error return */
> + 	neg.l	%d0
> + 	move.l	%d0, (errno)
> +-	moveq	#-1, %d0
> +-1:
> +-	movea.l	%d0, %a0	/* Redundant return */
> +-	movem.l (%sp)+, %d2-%d6 /* Restore registers */
> ++	move.l	#-1, %d0
> ++	/* fallthrough to common return path */
> ++
> ++1:	/* copy return value to %a0 for syscalls returning pointers */
> ++	move.l	%d0, %a0
> + 	rts
> + 
> + 	.size	__syscall_common,.-__syscall_common

sorry but impossible to review as a patch in a patch,
please use format-patch.
> +Index: klibc-1.5.21/usr/klibc/README.klibc
> +===================================================================
> +--- klibc-1.5.21.orig/usr/klibc/README.klibc	2011-01-29 14:49:53.000000000 +0100
> ++++ klibc-1.5.21/usr/klibc/README.klibc	2011-01-29 14:53:57.000000000 +0100
> +@@ -44,7 +44,7 @@
> +    i386:	 Working
> +    ia64:	 Working static, shared untested
> +    m32r:	 Untested
> +-   m68k:	 Untested
> ++   m68k:	 Working
> +    m68knommu:	 Not yet ported
> +    mips:	 Working
> +    mips64:	 Not yet ported

not according your message and up to the maintainer, please.

> +Index: klibc-1.5.21/usr/klibc/arch/m68k/vfork.S
> +===================================================================
> +--- klibc-1.5.21.orig/usr/klibc/arch/m68k/vfork.S	2011-01-29 14:47:11.000000000 +0100
> ++++ klibc-1.5.21/usr/klibc/arch/m68k/vfork.S	2011-01-29 15:28:51.000000000 +0100
> +@@ -15,14 +15,9 @@
> + 	move.l	(%sp)+, %d1		/* Return address */
> + 	move.l	# __NR_vfork, %d0
> + 	trap	#0
> +-	move.l	%d1, -(%sp)
> +-	cmpi.l	#-4095, %d0
> +-	blt.l	1f
> +-	neg.l	%d0
> +-	move.l	%d0, (errno)
> +-	moveq	#-1, %d0
> +-1:
> +-	movea.l	%d0, %a0
> +-	rts
> ++	move.l	%d1, -(%sp)		/* restore stack */
> ++
> ++	/* common code from syscall.S */
> ++	bra	__syscall_checkandout
> + 
> + 	.size	vfork, .-vfork

same critique here, please work against git.

I don't take arch specific patches in Debian unless there
is no way around, so please repost the patches considering
aboves critiques.

thanks.

-- 
maks




Information forwarded to debian-bugs-dist@lists.debian.org, maximilian attems <maks@debian.org>:
Bug#334917; Package klibc. (Sat, 29 Jan 2011 17:00:03 GMT) (full text, mbox, link).


Acknowledgement sent to Thorsten Glaser <tg@mirbsd.de>:
Extra info received and forwarded to list. Copy sent to maximilian attems <maks@debian.org>. (Sat, 29 Jan 2011 17:00:03 GMT) (full text, mbox, link).


Message #75 received at 334917@bugs.debian.org (full text, mbox, reply):

From: Thorsten Glaser <tg@mirbsd.de>
To: 334917@bugs.debian.org
Cc: debian-68k@lists.debian.org, klibc@zytor.com
Subject: Re: Bug#334917: [PATCH] Re: klibc barfs on m68k syscall interface
Date: Sat, 29 Jan 2011 16:51:29 +0000 (UTC)
maximilian attems dixit:

>well ok thanks for the effort, but please really do use git.

Ah okay. I worked against the Debian package, because that is
what I can test and install.

>The klibc git repo is at 
>http://git.kernel.org/?p=libs/klibc/klibc.git;a=summary
>
>git clone it and work away.

Will do.

>> ++#if 0
>> ++	/* debugging: define "int32_t last_syscall;" in your code... */
>> ++	move.l	%d0, (last_syscall)	/* to see which is actually run */
>> ++#endif
>please no no ugly ifdefs.

OK. I used that one to see whether the correct syscalls were run
for mmap and select, but don’t really need it any more. Will drop.

>sorry but impossible to review as a patch in a patch,
>please use format-patch.

Yes, I see.

>I don't take arch specific patches in Debian unless there
>is no way around, so please repost the patches considering
>aboves critiques.

Noted. Thanks for the response anyway.

bye,
//mirabilos
-- 
22:20⎜<asarch> The crazy that persists in his craziness becomes a master
22:21⎜<asarch> And the distance between the craziness and geniality is
only measured by the success                       22:21⎜<mksh> it’s a
very thin line anyway… with some, you don’t know which side they’re on




Added tag(s) upstream; removed tag(s) patch. Request was from Thorsten Glaser <tg@mirbsd.de> to control@bugs.debian.org. (Sat, 29 Jan 2011 17:39:08 GMT) (full text, mbox, link).


Set Bug forwarded-to-address to 'http://www.zytor.com/pipermail/klibc/2011-January/002821.html'. Request was from Thorsten Glaser <tg@mirbsd.de> to control@bugs.debian.org. (Sat, 29 Jan 2011 17:39:08 GMT) (full text, mbox, link).


Reply sent to Thorsten Glaser <tg@mirbsd.de>:
You have taken responsibility. (Sat, 11 Feb 2012 21:09:17 GMT) (full text, mbox, link).


Notification sent to Stephen R Marenka <stephen@marenka.net>:
Bug acknowledged by developer. (Sat, 11 Feb 2012 21:09:28 GMT) (full text, mbox, link).


Message #84 received at 334917-close@bugs.debian.org (full text, mbox, reply):

From: Thorsten Glaser <tg@mirbsd.de>
To: 334917-close@bugs.debian.org
Subject: Bug#334917: fixed in klibc 2.0~rc2-0.1
Date: Sat, 11 Feb 2012 21:07:52 +0000
Source: klibc
Source-Version: 2.0~rc2-0.1

We believe that the bug you reported is fixed in the latest version of
klibc, which is due to be installed in the Debian FTP archive:

klibc-utils-floppy-udeb_2.0~rc2-0.1_amd64.udeb
  to main/k/klibc/klibc-utils-floppy-udeb_2.0~rc2-0.1_amd64.udeb
klibc-utils-udeb_2.0~rc2-0.1_amd64.udeb
  to main/k/klibc/klibc-utils-udeb_2.0~rc2-0.1_amd64.udeb
klibc-utils_2.0~rc2-0.1_amd64.deb
  to main/k/klibc/klibc-utils_2.0~rc2-0.1_amd64.deb
klibc_2.0~rc2-0.1.debian.tar.gz
  to main/k/klibc/klibc_2.0~rc2-0.1.debian.tar.gz
klibc_2.0~rc2-0.1.dsc
  to main/k/klibc/klibc_2.0~rc2-0.1.dsc
klibc_2.0~rc2.orig.tar.gz
  to main/k/klibc/klibc_2.0~rc2.orig.tar.gz
libklibc-dev_2.0~rc2-0.1_amd64.deb
  to main/k/klibc/libklibc-dev_2.0~rc2-0.1_amd64.deb
libklibc-udeb_2.0~rc2-0.1_amd64.udeb
  to main/k/klibc/libklibc-udeb_2.0~rc2-0.1_amd64.udeb
libklibc_2.0~rc2-0.1_amd64.deb
  to main/k/klibc/libklibc_2.0~rc2-0.1_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 334917@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thorsten Glaser <tg@mirbsd.de> (supplier of updated klibc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA384

Format: 1.8
Date: Sat, 11 Feb 2012 19:25:23 +0000
Source: klibc
Binary: libklibc-dev libklibc klibc-utils klibc-utils-udeb klibc-utils-floppy-udeb libklibc-udeb
Architecture: source amd64
Version: 2.0~rc2-0.1
Distribution: unstable
Urgency: low
Maintainer: maximilian attems <maks@debian.org>
Changed-By: Thorsten Glaser <tg@mirbsd.de>
Description: 
 klibc-utils - small utilities built with klibc for early boot
 klibc-utils-floppy-udeb - small utilities built with klibc for the boot floppy (udeb)
 klibc-utils-udeb - small utilities built with klibc for early boot (d-i) (udeb)
 libklibc   - minimal libc subset for use with initramfs
 libklibc-dev - kernel headers used during the build of klibc
 libklibc-udeb - minimal libc subset for use with initramfs (d-i) (udeb)
Closes: 334917
Changes: 
 klibc (2.0~rc2-0.1) unstable; urgency=low
 .
   * Non-maintainer upload with consent of maintainer.
   * Upload to unstable (maks says we target 2.0 for wheezy)
   * New upstream snapshot (fixes FTBFS)
   * Update Vcs-* for (temporary) move to collab-maint
   * Refresh all patches
   * Add m68k patch submitted upstream, for testing (Closes: #334917)
   * Shut up lintian
Checksums-Sha1: 
 02401b3e1ac83bc86612f0411e0afbea13debffa 2191 klibc_2.0~rc2-0.1.dsc
 61064eac6f8255354f10d070eb742dfd8b8cb7a5 612830 klibc_2.0~rc2.orig.tar.gz
 11e8a4f31e50c453df9b1d0507c7c7128e60b961 22559 klibc_2.0~rc2-0.1.debian.tar.gz
 7511239af0a06978b5fe1c75c97d8712895c50d6 234242 libklibc-dev_2.0~rc2-0.1_amd64.deb
 007e50998d65712b5cf1632ee3c8497473bdf849 56332 libklibc_2.0~rc2-0.1_amd64.deb
 ee68d2baeff35c1349a3ae9c5b5563e638c2d013 184690 klibc-utils_2.0~rc2-0.1_amd64.deb
 310c7150783cf091ca2a46500ad114d22be87380 183358 klibc-utils-udeb_2.0~rc2-0.1_amd64.udeb
 db01823a1e71a5632a3ad28b9f2e4fabf79f011a 25282 klibc-utils-floppy-udeb_2.0~rc2-0.1_amd64.udeb
 97e9f871d7550865a60bc1ffb083a9d91104fa2d 38098 libklibc-udeb_2.0~rc2-0.1_amd64.udeb
Checksums-Sha256: 
 085a806e308628e9e0517848833ef6c6a8c9ac34a2fa93dc8cd12d0b41fb4b13 2191 klibc_2.0~rc2-0.1.dsc
 c6b01bd9c8715ad21399307bc9f5fe9183d65bfde8d4bc97d8ed25d205a71e22 612830 klibc_2.0~rc2.orig.tar.gz
 068e807103cfad67ae680fa9d2861c6d8307e769b491a62fcf5fb316fffb1586 22559 klibc_2.0~rc2-0.1.debian.tar.gz
 23f1d5f8c7b9de1f31c8b2885f8e1e467466b2e1c0d7cf533507fb3fb96018f1 234242 libklibc-dev_2.0~rc2-0.1_amd64.deb
 c53201871a7f8f687d0693774b57867f183d858e6e0d5ac6a6719416ed970647 56332 libklibc_2.0~rc2-0.1_amd64.deb
 dab732a1a5770a588e91ad36cb258d370951a37338177d03ca45332c590405bb 184690 klibc-utils_2.0~rc2-0.1_amd64.deb
 b98b5e464c0c979ca861c9c99a7684107e2e3e0ce5b4f6d5ed49aaf36ea84df0 183358 klibc-utils-udeb_2.0~rc2-0.1_amd64.udeb
 dfcf58cf4a3cefe1d92d129ccbebbdca6ab8c5dd97ebb127c14588b16706396a 25282 klibc-utils-floppy-udeb_2.0~rc2-0.1_amd64.udeb
 3796757d0a594e4617466ed62866b115a14cfa4e70e00425d7caa03fce44a940 38098 libklibc-udeb_2.0~rc2-0.1_amd64.udeb
Files: 
 c591a3e29662a055cd8a9fcc501f84b1 2191 libs optional klibc_2.0~rc2-0.1.dsc
 bfed2f545897ea163c619c188d51f28c 612830 libs optional klibc_2.0~rc2.orig.tar.gz
 f722547ac9c91f5dfbb08c0d914984ba 22559 libs optional klibc_2.0~rc2-0.1.debian.tar.gz
 d2533e151e78413265d63be7e3f1e039 234242 libdevel optional libklibc-dev_2.0~rc2-0.1_amd64.deb
 59c0eb6eee1b5275d957be0d31a14469 56332 libs optional libklibc_2.0~rc2-0.1_amd64.deb
 7699b7d12d2df4fcd9b08e20f032c75d 184690 libs optional klibc-utils_2.0~rc2-0.1_amd64.deb
 40eea027417ba041fbdf787d4d1b4114 183358 debian-installer optional klibc-utils-udeb_2.0~rc2-0.1_amd64.udeb
 a2aeb8cb19ff31c98498a223752b3a97 25282 debian-installer optional klibc-utils-floppy-udeb_2.0~rc2-0.1_amd64.udeb
 72836d6e48a598bfa92a1f925c8aff5f 38098 debian-installer optional libklibc-udeb_2.0~rc2-0.1_amd64.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MirBSD)

iQIcBAEBCQAGBQJPNsm2AAoJEHa1NLLpkAfgz18P/RUNCN8eAHXvM+Go1ZrX/Ss2
DptUxHRW3kaOcl5GKOHQlQ+JSDHQtvwSv2yXWZklOnnV2W1YItFr1RaNaay5IRud
ziK962E83+AWuuBrQRW+27OMZMEGaV8h443s8ngD6s3T1k0Gh8oBlWRrHHf4TIIc
pUPvrkhmGaA0D1EPdmT/nBSfIKSyAflVMiBPy+5VgABA6PHZ3+nGLzu3+g+s888e
5ssiNuzOKHGi043UH7sGFPPhWUYxjVLkK/awx9dn83AfoAkd9SOZdC2ryy+vBMkX
BXay00v6GxP9DIVcorHW4FObZ3S+RIBkX0L+NIgRuQRDzLakkvLTckISmObiBPV6
ou9FWnjIbdtr2zzgfedobPbKAI9ow4tcMmX2BO6jMbSi+QSlqi3LDjXzfh0Hbu0p
gyUsr7e4T7H2g3W2IoY8YlTk8KyaFr7p4qPPHZRapaak/S4PLQ+/BgjPmhr+BnQd
A43L+GPUdL3uIKTGGhxd5SrasAzfYivp8T/xn7IFCw8qG9mHbQGaa6v15QjvEYox
UqnM6m62wdpHcYdRSMExnoGyzKmlJK6vpsaBIGTLPKKw2QdCUXK1LbiurlnsWFbq
utkDSh91SSmzdND/sBfQWR8XkcK63y+kc0nFmE+x3ZEPtCUa6YHFy8lOjnX8gqwt
qbToKrzblRcbE8k81mHK
=31IU
-----END PGP SIGNATURE-----





Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Tue, 10 Apr 2012 07:34:43 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Sun Jan 7 16:41:08 2018; Machine Name: beach

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.