Debian Bug report logs - #325535
mozilla: FTBFS: change in behavior of __attribute__((unused))

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: submit@bugs.debian.org

Subject: mozilla: FTBFS: change in behavior of __attribute__((unused))

Date: Mon, 29 Aug 2005 02:07:51 -0700

[Message part 1 (text/plain, inline)]

Package: mozilla
Severity: serious

The current mozilla package fails to build on alpha, arm, and ia64
because it uses __attribute__((unused)) to mark static functions that
are called only from assembly routines.  As of gcc 3.1,
__attribute__((used)) exists for marking static functions that are used;
as of gcc 4.0, __attribute__((unused)) still suppresses compiler
warnings about unused static functions, but it does *not* prevent the
compiler from optimizing them away.

The attached patch should fix this failure for all three architectures.
It has only been tested on alpha, and each architecture has its own
implementation for this bit of code, but this patch fixes all uses of
__attribute__((unused)), so it should be sufficient.  (FWIW, one other
architecture -- i386 -- already uses ((used)) in the code...)

Since this bug is in the XPCOM code, it also affects other packages that
build copies of XPCOM.  I'll clone this bug off to them as soon as I
have a bug number back.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/

[mozilla-unused.diff (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 325535-close@bugs.debian.org (full text, mbox, reply):

From: Eric Dorland <eric@debian.org>

To: 325535-close@bugs.debian.org

Subject: Bug#325535: fixed in mozilla-firefox 1.0.6-4

Date: Tue, 06 Sep 2005 07:17:17 -0700

Source: mozilla-firefox
Source-Version: 1.0.6-4

We believe that the bug you reported is fixed in the latest version of
mozilla-firefox, which is due to be installed in the Debian FTP archive:

mozilla-firefox-dom-inspector_1.0.6-4_i386.deb
  to pool/main/m/mozilla-firefox/mozilla-firefox-dom-inspector_1.0.6-4_i386.deb
mozilla-firefox-gnome-support_1.0.6-4_i386.deb
  to pool/main/m/mozilla-firefox/mozilla-firefox-gnome-support_1.0.6-4_i386.deb
mozilla-firefox_1.0.6-4.diff.gz
  to pool/main/m/mozilla-firefox/mozilla-firefox_1.0.6-4.diff.gz
mozilla-firefox_1.0.6-4.dsc
  to pool/main/m/mozilla-firefox/mozilla-firefox_1.0.6-4.dsc
mozilla-firefox_1.0.6-4_i386.deb
  to pool/main/m/mozilla-firefox/mozilla-firefox_1.0.6-4_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 325535@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Eric Dorland <eric@debian.org> (supplier of updated mozilla-firefox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  6 Sep 2005 02:10:07 -0400
Source: mozilla-firefox
Binary: mozilla-firefox mozilla-firefox-gnome-support mozilla-firefox-dom-inspector
Architecture: source i386
Version: 1.0.6-4
Distribution: unstable
Urgency: low
Maintainer: Eric Dorland <eric@debian.org>
Changed-By: Eric Dorland <eric@debian.org>
Description: 
 mozilla-firefox - lightweight web browser based on Mozilla
 mozilla-firefox-dom-inspector - tool for inspecting the DOM of pages in Mozilla Firefox
 mozilla-firefox-gnome-support - Support for Gnome in Mozilla Firefox
Closes: 325535
Changes: 
 mozilla-firefox (1.0.6-4) unstable; urgency=low
 .
   * xpcom/reflect/xptcall/src/md/unix/xptcinvoke_linux_alpha.cpp,
     xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp,
     xpcom/reflect/xptcall/src/md/unix/xptcstubs_linux_alpha.cpp: Patch
     from Steve Langasek to fix unused vs. used gcc attribute on alpha and
     arm. (Closes: #325535)
   * browser/app/profile/firefox.js: Revert patch to remove the "I'm
     feeling lucky" search. Some like it, some hate it, so upstream
     behaviour wins. If you still feel strongly about it, make your case
     upstream.
   * gfx/src/gtk/nsFontMetricsXft.cpp: Apply patch from bz#252033 to work
     around a bug in XRender that might be causing #319349.
Files: 
 8839bb6675686041c4a334f31bce1202 972 web optional mozilla-firefox_1.0.6-4.dsc
 d104870cb5e6169b4a0aa65b4fdee64d 232704 web optional mozilla-firefox_1.0.6-4.diff.gz
 192d4ffa0eab064218ecda1abee630ee 7620900 web optional mozilla-firefox_1.0.6-4_i386.deb
 02b5eb72e5e103062163f8058ddc2b75 155238 web optional mozilla-firefox-dom-inspector_1.0.6-4_i386.deb
 565f0d151ce1b8d5f0f6cc213622ef65 53066 web optional mozilla-firefox-gnome-support_1.0.6-4_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDHaK1YemOzxbZcMYRAhLrAKCOPtKmma6WzYWV2ZD6PrP9DrwldACfQVLv
bVcqVEFApu8NahUEoI3ol2s=
=PQbf
-----END PGP SIGNATURE-----

Message #21 received at 325535@bugs.debian.org (full text, mbox, reply):

From: Steve Langasek <vorlon@debian.org>

To: 325535@bugs.debian.org

Cc: 325536@bugs.debian.org, 325532@bugs.debian.org

Subject: Re: mozilla: FTBFS: change in behavior of __attribute__((unused))

Date: Wed, 7 Sep 2005 04:46:03 -0700

[Message part 1 (text/plain, inline)]

reopen 325535
thanks

Sorry, the arm build of mozilla-firefox still fails, because the patch
for arm is on drugs:

+static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 methodIndex, PRUint32* args) asm("_PrepareAndDispatch")
+__attribute((used))__;

This last line should be

+__attribute__((used));

I have no idea why I wrote something that broken. :)

Good news is, alpha built fine. :)

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 325535@bugs.debian.org (full text, mbox, reply):

From: Mike Hommey <mh@glandium.org>

To: Steve Langasek <vorlon@debian.org>, 325535@bugs.debian.org

Cc: 325536@bugs.debian.org, 325532@bugs.debian.org

Subject: Re: Bug#325535: mozilla: FTBFS: change in behavior of __attribute__((unused))

Date: Wed, 7 Sep 2005 18:07:02 +0200

On Wed, Sep 07, 2005 at 04:46:03AM -0700, Steve Langasek <vorlon@debian.org> wrote:
> reopen 325535
> thanks
> 
> Sorry, the arm build of mozilla-firefox still fails, because the patch
> for arm is on drugs:
> 
> +static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 methodIndex, PRUint32* args) asm("_PrepareAndDispatch")
> +__attribute((used))__;
> 
> This last line should be
> 
> +__attribute__((used));
> 
> I have no idea why I wrote something that broken. :)
> 
> Good news is, alpha built fine. :)

Note that, except for the arm one (the one who got b0rked ;) ), these
are fixed upstream in upcoming Firefox 1.5 beta, and is fixed on mozilla
1.8 branch, meaning next mozilla and thunderbird upstream releases will
also benefit from the fix. I will file this arm fix upstream.

Mike

Message #33 received at 325535@bugs.debian.org (full text, mbox, reply):

From: Alexander Sack - Debian Bugmail <asac@debian.org>

To: Mike Hommey <mh@glandium.org>, 325536@bugs.debian.org

Cc: Steve Langasek <vorlon@debian.org>, 325535@bugs.debian.org, 325532@bugs.debian.org

Subject: Re: Bug#325536: Bug#325535: mozilla: FTBFS: change in behavior of __attribute__((unused))

Date: Wed, 7 Sep 2005 20:25:13 +0200

On Wed, Sep 07, 2005 at 06:07:02PM +0200, Mike Hommey wrote:
> 1.8 branch, meaning next mozilla and thunderbird upstream releases will
> also benefit from the fix. I will file this arm fix upstream.

Great, but don't forget to ask for review.

 - Alexander

 p.s. please take care that the bug is listed as To: or CC: when 
      replying to this mail (e.g. /reply-all/). 
-- 
 GPG messages preferred.   |  .''`.  ** Debian GNU/Linux **
 Alexander Sack            | : :' :      The  universal
 asac@debian.org           | `. `'      Operating System
 http://www.asoftsite.org  |   `-    http://www.debian.org/

Message #38 received at 325535@bugs.debian.org (full text, mbox, reply):

From: Eric Dorland <eric@debian.org>

To: Steve Langasek <vorlon@debian.org>, 325535@bugs.debian.org

Subject: Re: Bug#325535: mozilla: FTBFS: change in behavior of __attribute__((unused))

Date: Thu, 8 Sep 2005 01:11:12 -0400

[Message part 1 (text/plain, inline)]

* Steve Langasek (vorlon@debian.org) wrote:
> reopen 325535
> thanks
> 
> Sorry, the arm build of mozilla-firefox still fails, because the patch
> for arm is on drugs:
> 
> +static nsresult PrepareAndDispatch(nsXPTCStubBase* self, uint32 methodIndex, PRUint32* args) asm("_PrepareAndDispatch")
> +__attribute((used))__;
> 
> This last line should be
> 
> +__attribute__((used));
> 
> I have no idea why I wrote something that broken. :)
> 
> Good news is, alpha built fine. :)

Thanks again Steve, now lay off the nose candy :)

-- 
Eric Dorland <eric.dorland@mail.mcgill.ca>
ICQ: #61138586, Jabber: hooty@jabber.com
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ 
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ 
G e h! r- y+ 
------END GEEK CODE BLOCK------

[signature.asc (application/pgp-signature, inline)]

Message #45 received at 325535-close@bugs.debian.org (full text, mbox, reply):

From: Eric Dorland <eric@debian.org>

To: 325535-close@bugs.debian.org

Subject: Bug#325535: fixed in mozilla-firefox 1.0.6-5

Date: Sat, 10 Sep 2005 22:02:13 -0700

Source: mozilla-firefox
Source-Version: 1.0.6-5

We believe that the bug you reported is fixed in the latest version of
mozilla-firefox, which is due to be installed in the Debian FTP archive:

mozilla-firefox-dom-inspector_1.0.6-5_i386.deb
  to pool/main/m/mozilla-firefox/mozilla-firefox-dom-inspector_1.0.6-5_i386.deb
mozilla-firefox-gnome-support_1.0.6-5_i386.deb
  to pool/main/m/mozilla-firefox/mozilla-firefox-gnome-support_1.0.6-5_i386.deb
mozilla-firefox_1.0.6-5.diff.gz
  to pool/main/m/mozilla-firefox/mozilla-firefox_1.0.6-5.diff.gz
mozilla-firefox_1.0.6-5.dsc
  to pool/main/m/mozilla-firefox/mozilla-firefox_1.0.6-5.dsc
mozilla-firefox_1.0.6-5_i386.deb
  to pool/main/m/mozilla-firefox/mozilla-firefox_1.0.6-5_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 325535@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Eric Dorland <eric@debian.org> (supplier of updated mozilla-firefox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 10 Sep 2005 23:03:26 -0400
Source: mozilla-firefox
Binary: mozilla-firefox mozilla-firefox-gnome-support mozilla-firefox-dom-inspector
Architecture: source i386
Version: 1.0.6-5
Distribution: unstable
Urgency: critical
Maintainer: Eric Dorland <eric@debian.org>
Changed-By: Eric Dorland <eric@debian.org>
Description: 
 mozilla-firefox - lightweight web browser based on Mozilla
 mozilla-firefox-dom-inspector - tool for inspecting the DOM of pages in Mozilla Firefox
 mozilla-firefox-gnome-support - Support for Gnome in Mozilla Firefox
Closes: 325535 327452
Changes: 
 mozilla-firefox (1.0.6-5) unstable; urgency=critical
 .
   * xpcom/reflect/xptcall/src/md/unix/xptcstubs_arm.cpp: Fix for previous
     arm fix. Thanks Steve. (Closes: #325535)
   * netwerk/base/src/nsStandardURL.cpp: Patch from bz#307259 to fix
     CAN-2005-2871, a buffer overflow vulnerability in IDN
     processing. (Closes: #327452)
Files: 
 56a1477e9f18f99f5a7a62246860b8b8 972 web optional mozilla-firefox_1.0.6-5.dsc
 1f52ba9cd95c548771d8d21c28a7f0d3 233388 web optional mozilla-firefox_1.0.6-5.diff.gz
 562b0e559e4cf88bb049882be50157b3 7621334 web optional mozilla-firefox_1.0.6-5_i386.deb
 adccd0ee8960fc29846d7342ca8c72bc 155300 web optional mozilla-firefox-dom-inspector_1.0.6-5_i386.deb
 fee07215fd81b41dbee83b849485e6a8 53148 web optional mozilla-firefox-gnome-support_1.0.6-5_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDI7XQYemOzxbZcMYRAtz+AJ0Uxby8FVyZpfyUlEf/nrZuYhsrTgCgpkZj
E/+JV4frnQbUMHfI7XbKNSQ=
=91jz
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.