Debian Bug report logs - #323425
implicitly converted pointers

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: dann frazier <dannf@hp.com>

To: submit@bugs.debian.org

Cc: David Mosberger <David.Mosberger@acm.org>

Subject: implicitly converted pointers

Date: Tue, 16 Aug 2005 11:14:24 -0600

Package: cronolog
Version: 1.6.2-5
Severity: important
Tags: patch

Our automated buildd log filter[1] detected a problem[2] that will cause
your package to segfault on architectures where the size of a pointer is
greater than the size of an integer, such as ia64.

_XOPEN_SOURCE must be defined when using the strptime() function.  See
strptime(3) for details.  There might be a more autoconfy patch, but
this one works.

[1]http://people.debian.org/~dannf/check-implicit-pointer-functions
[2]Function `strptime' implicitly converted to pointer at cronoutils.c:673

--- cronolog-1.6.2/src/Makefile.in~	2001-05-04 03:02:03.000000000 -0600
+++ cronolog-1.6.2/src/Makefile.in	2005-08-16 11:11:19.000000000 -0600
@@ -95,7 +95,7 @@
 cronolog_LDFLAGS = 
 SCRIPTS =  $(sbin_SCRIPTS)
 
-CFLAGS = @CFLAGS@
+CFLAGS = @CFLAGS@ -D_XOPEN_SOURCE
 COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)
 CCLD = $(CC)
 LINK = $(CCLD) $(AM_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $@

Message #10 received at 323425@bugs.debian.org (full text, mbox, reply):

From: dann frazier <dannf@hp.com>

To: 321837@bugs.debian.org, 323425@bugs.debian.org, 323421@bugs.debian.org

Subject: Intent to NMU

Date: Fri, 16 Sep 2005 16:31:57 -0600

As these bugs have been open for a month without a response from the
maintainers, I plan to NMU these packages in 1 week (or sooner, at the
maintainers' request).

Message #17 received at 323425@bugs.debian.org (full text, mbox, reply):

From: Joel Aelwyn <fenton@debian.org>

To: dann frazier <dannf@hp.com>, 323425@bugs.debian.org

Cc: control@bugs.debian.org, David Mosberger <David.Mosberger@acm.org>

Subject: Re: Bug#323425: implicitly converted pointers

Date: Mon, 14 Nov 2005 23:28:17 -0700

[Message part 1 (text/plain, inline)]

tags 323425 -patch
done

dann frazier wrote:
> Package: cronolog
> Version: 1.6.2-5
> Severity: important
> Tags: patch
> 
> Our automated buildd log filter[1] detected a problem[2] that will cause
> your package to segfault on architectures where the size of a pointer is
> greater than the size of an integer, such as ia64.
> 
> _XOPEN_SOURCE must be defined when using the strptime() function.  See
> strptime(3) for details.  There might be a more autoconfy patch, but
> this one works.
> 
> [1]http://people.debian.org/~dannf/check-implicit-pointer-functions
> [2]Function `strptime' implicitly converted to pointer at cronoutils.c:673

I have applied a fix to the package, and stand duly chastized for having 
failed to follow up on it in a more useful fashion. Mea culpa. However, the 
patch provided is not the most appropriate way to fix the problem; since it 
involves adding a -D flag to CFLAGS, this is perfectly capable of happening in 
the debian/rules file, rather than requiring a source patch (I guess you could 
call that 'more autoconfy'; certainly, it seems cleaner).

However, since I have changed the behavior, it would be helpful if I could 
arrange to validate that the -6 package will, in fact, correctly solve this 
problem on a 64-bit architecture. Since I don't particularly trust that I can 
verify this sufficiently, myself, would it be possible to get a test build 
verified in some fashion?
-- 
Joel Aelwyn <fenton@debian.org>                                       ,''`.
                                                                     : :' :
                                                                     `. `'
                                                                       `-

[signature.asc (application/pgp-signature, attachment)]

Message #24 received at 323425@bugs.debian.org (full text, mbox, reply):

From: dann frazier <dannf@hp.com>

To: Joel Aelwyn <fenton@debian.org>

Cc: 323425@bugs.debian.org, David Mosberger <David.Mosberger@acm.org>

Subject: Re: Bug#323425: implicitly converted pointers

Date: Tue, 15 Nov 2005 00:31:43 -0700

On Mon, 2005-11-14 at 23:28 -0700, Joel Aelwyn wrote:
> tags 323425 -patch
> done
> 
> dann frazier wrote:
> > Package: cronolog
> > Version: 1.6.2-5
> > Severity: important
> > Tags: patch
> > 
> > Our automated buildd log filter[1] detected a problem[2] that will cause
> > your package to segfault on architectures where the size of a pointer is
> > greater than the size of an integer, such as ia64.
> > 
> > _XOPEN_SOURCE must be defined when using the strptime() function.  See
> > strptime(3) for details.  There might be a more autoconfy patch, but
> > this one works.
> > 
> > [1]http://people.debian.org/~dannf/check-implicit-pointer-functions
> > [2]Function `strptime' implicitly converted to pointer at cronoutils.c:673
> 
> I have applied a fix to the package, and stand duly chastized for having 
> failed to follow up on it in a more useful fashion. Mea culpa. However, the 
> patch provided is not the most appropriate way to fix the problem; since it 
> involves adding a -D flag to CFLAGS, this is perfectly capable of happening in 
> the debian/rules file, rather than requiring a source patch (I guess you could 
> call that 'more autoconfy'; certainly, it seems cleaner).
> 
> However, since I have changed the behavior, it would be helpful if I could 
> arrange to validate that the -6 package will, in fact, correctly solve this 
> problem on a 64-bit architecture. Since I don't particularly trust that I can 
> verify this sufficiently, myself, would it be possible to get a test build 
> verified in some fashion?

Of course - you could either post a source package for me, or log into
merulo and perform a build and run the log through the above script.
-- 
dann frazier <dannf@hp.com>

Send a report that this bug log contains spam.