Debian Bug report logs - #309515
postgrey: Allow easier setting of greylist-text (related to #298832 a little bit)

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Sven Mueller <debian@incase.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: postgrey: Allow easier setting of greylist-text (related to #298832 a little bit)

Date: Tue, 17 May 2005 19:54:57 +0200

[Message part 1 (text/plain, inline)]

Package: postgrey
Version: 1.21-1
Tags: patch
Severity: wishlist

I patched /etc/default/postgrey and /etc/init.d/postgrey a little bit to
allow easier setting of the --greylist-text parameter (which almost
always contains spaces). Attached is the patch I made for this.

Would be nice IMHO if this could be included in a future version.

cu,
sven

[postgrey-set-greylist-text.patch (text/plain, inline)]

diff -ur postgrey-1.21.orig/debian/postgrey.default postgrey-1.21/debian/postgrey.default
--- postgrey-1.21.orig/debian/postgrey.default	2005-05-17 18:47:20.000000000 +0200
+++ postgrey-1.21/debian/postgrey.default	2005-05-17 19:06:55.000000000 +0200
@@ -8,3 +8,8 @@
 # see also the postgrey(8) manpage
 
 POSTGREY_OPTS="--inet=127.0.0.1:60000"
+
+# To set the text the server returns while the client is
+# greylisted, use this setting. please refer to postgrey(8)
+# for details
+#POSTGREY_TEXT="You are greylisted for %s seconds. If you have trouble delivering mail to incase.de, please contact postmaster@%r"
diff -ur postgrey-1.21.orig/debian/postgrey.init postgrey-1.21/debian/postgrey.init
--- postgrey-1.21.orig/debian/postgrey.init	2005-05-17 18:47:20.000000000 +0200
+++ postgrey-1.21/debian/postgrey.init	2005-05-17 19:04:34.000000000 +0200
@@ -30,12 +30,14 @@
 fi
 
 POSTGREY_OPTS="--pidfile=$PIDFILE --daemonize $POSTGREY_OPTS"
+POSTGREY_TEXT_OPT=""
+[[ "$POSTGREY_TEXT" = "" ]] || POSTGREY_TEXT_OPT="--greylist-text=$POSTGREY_TEXT"
 
 case "$1" in
   start)
 	echo -n "Starting $DESC: $NAME"
 	start-stop-daemon --start --quiet --pidfile $PIDFILE \
-		--exec $DAEMON -- $POSTGREY_OPTS
+		--exec $DAEMON -- $POSTGREY_OPTS "${POSTGREY_TEXT_OPT}"
 	echo "."
 	;;
   stop)
@@ -55,7 +57,7 @@
         rm -f $PIDFILE
 	sleep 1
 	start-stop-daemon --start --quiet --pidfile $PIDFILE \
-                --exec $DAEMON -- $POSTGREY_OPTS
+		--exec $DAEMON -- $POSTGREY_OPTS "${POSTGREY_TEXT_OPT}"
 	echo "."
 	;;
   *)

Message #10 received at 309515@bugs.debian.org (full text, mbox, reply):

From: Adrian von Bidder <avbidder@fortytwo.ch>

To: Sven Mueller <debian@incase.de>, control@bugs.debian.org, 309515@bugs.debian.org

Subject: Re: Bug#309515: postgrey: Allow easier setting of greylist-text (related to #298832 a little bit)

Date: Tue, 17 May 2005 21:56:38 +0200

[Message part 1 (text/plain, inline)]

merge 298832 309515
thanks

On Tuesday 17 May 2005 19.54, Sven Mueller wrote:
> Package: postgrey
> Version: 1.21-1
> Tags: patch
> Severity: wishlist
>
> I patched /etc/default/postgrey and /etc/init.d/postgrey a little bit to
> allow easier setting of the --greylist-text parameter (which almost
> always contains spaces). Attached is the patch I made for this.

Please don't file duplicate bug reports - you saw 298832 and this bug is 
really a subset of that one.

cheers
-- vbi

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 309515-quiet@bugs.debian.org (full text, mbox, reply):

From: Sven Mueller <debian@incase.de>

To: Adrian von Bidder <avbidder@fortytwo.ch>

Cc: 309515-quiet@bugs.debian.org

Subject: Re: Bug#309515: postgrey: Allow easier setting of greylist-text (related to #298832 a little bit)

Date: Tue, 17 May 2005 23:06:51 +0200

[Message part 1 (text/plain, inline)]

Adrian von Bidder wrote on 17/05/2005 21:56:
>>Package: postgrey
>>Version: 1.21-1
>>Tags: patch
>>Severity: wishlist
>>
>>I patched /etc/default/postgrey and /etc/init.d/postgrey a little bit to
>>allow easier setting of the --greylist-text parameter (which almost
>>always contains spaces). Attached is the patch I made for this.
> 
> Please don't file duplicate bug reports - you saw 298832 and this bug is 
> really a subset of that one.

In a way it is, but the "solution" presented in 298832 is far more
complicated than necessary to only set the greylist-text parameter in an
easier way.

Anyway, I found it to be your choice wether this is a duplicate or not.
In my opinion (since it is, like you said, a subset), it didn't really
qualify as a solution to #298832, even though my patch makes the main
problem named in there go away. In other words: I only solved a small
(though probably often used) part of #298832.

Oh well, it's your package, so it's your decision wether you will apply
my patch or not. If my patch qualifies as sufficiently solving #298832,
too, is also your decision. Though, after thinking about it, I don't see
any other parameter which would likely include spaces, so probably it does.

regards,
sven

PS: Auch wenn ich heute drei bugs reported/erzeugt habe, Dein Paket ist
gut, und ich Danke Dir dafür.

[signature.asc (application/pgp-signature, attachment)]

Message #22 received at 309515-close@bugs.debian.org (full text, mbox, reply):

From: Adrian von Bidder <cmot@debian.org>

To: 309515-close@bugs.debian.org

Subject: Bug#309515: fixed in postgrey 1.21-2

Date: Sun, 12 Jun 2005 08:02:27 -0400

Source: postgrey
Source-Version: 1.21-2

We believe that the bug you reported is fixed in the latest version of
postgrey, which is due to be installed in the Debian FTP archive:

postgrey_1.21-2.diff.gz
  to pool/main/p/postgrey/postgrey_1.21-2.diff.gz
postgrey_1.21-2.dsc
  to pool/main/p/postgrey/postgrey_1.21-2.dsc
postgrey_1.21-2_all.deb
  to pool/main/p/postgrey/postgrey_1.21-2_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 309515@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Adrian von Bidder <cmot@debian.org> (supplier of updated postgrey package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 12 Jun 2005 13:42:15 +0200
Source: postgrey
Binary: postgrey
Architecture: source all
Version: 1.21-2
Distribution: unstable
Urgency: low
Maintainer: Adrian von Bidder <cmot@debian.org>
Changed-By: Adrian von Bidder <cmot@debian.org>
Description: 
 postgrey   - greylisting implementation for Postfix
Closes: 265856 308381 309515 313140
Changes: 
 postgrey (1.21-2) unstable; urgency=low
 .
   * Debconf translations:
     * cz, thanks to Miroslav Kure (closes: #308381)
     * ru, thanks to Yuriy Talakan (closes: #313140)
   * sarge has postfix 2.1, and Conflicts: wasn't strictly necessary anyway
     (closes: #265856)
   * allow passing --greylist-text with spaces (closes: #309515)
     thanks to Sven Müller for providing an easy solution
Files: 
 11270262b87381cfb3aeec24be33decb 681 mail optional postgrey_1.21-2.dsc
 714083753ad5918735dde641d696d546 13958 mail optional postgrey_1.21-2.diff.gz
 5b63ec7546b6bca19923a62c404fc76d 43002 mail optional postgrey_1.21-2_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: get my key from http://fortytwo.ch/gpg/92082481

iEYEARECAAYFAkKsIGUACgkQi6Qxi+Wn99aDxQCgo1r0FXJdsutrcww8aQfVOhVe
nygAoJuWvoU7C2lwUplUor7LHYyBcAa3
=PSF2
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.