Debian Bug report logs - #300150
SEGFAULT when running on 64bit platforms.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Alan Woodland <ajw2@aber.ac.uk>

To: submit@bugs.debian.org

Subject: SEGFAULT when running on 64bit platforms.

Date: Thu, 17 Mar 2005 23:54:47 +0000

[Message part 1 (text/plain, inline)]

Package: chromium
Version: 0.9.12-5
Tags: patch
Severity: minor

I have several different machines all of which share the same home
directories. When I start chromium on a 64bit platform it segfaults in
HiScore::print(int skill). The reason this happens is because the
highscores file was first written by a 32bit platform. The precise cause
of the segfault is the failure of the call to localtime() on line 308,
which returns NULL (and sets errno). Currently chromium does not check
the return value of this call, and continues regardless, which clearly
is not appropriate behaviour for an application. I've attached a very
simple fix to this email, but it won't make the highscores portable,
just prevents it from crashing if localtime() fails.

Alan

[chromium-patch.diff (text/plain, inline)]

--- src/HiScore.cpp.orig	2005-03-17 23:41:17.798546920 +0000
+++ src/HiScore.cpp	2005-03-17 23:41:37.522548416 +0000
@@ -306,6 +306,8 @@
 	for(int j = 0; j < HI_SCORE_HIST; j++)
 	{
 		tmptr = localtime(&hiScoreDate[skill][j]);
+		if (!tmptr)
+			break;
 		fprintf(stderr, "%02d/%02d/%04d %16s %d\n", 1+tmptr->tm_mon, tmptr->tm_mday, 1900+tmptr->tm_year,
 				hiScoreName[skill][j], (int)(hiScore[skill][j]));
 	}

[signature.asc (application/pgp-signature, attachment)]

Message #10 received at 300150-close@bugs.debian.org (full text, mbox, reply):

From: Mike Furr <mfurr@debian.org>

To: 300150-close@bugs.debian.org

Subject: Bug#300150: fixed in chromium 0.9.12-7

Date: Tue, 05 Apr 2005 00:33:00 -0400

Source: chromium
Source-Version: 0.9.12-7

We believe that the bug you reported is fixed in the latest version of
chromium, which is due to be installed in the Debian FTP archive:

chromium_0.9.12-7.diff.gz
  to pool/main/c/chromium/chromium_0.9.12-7.diff.gz
chromium_0.9.12-7.dsc
  to pool/main/c/chromium/chromium_0.9.12-7.dsc
chromium_0.9.12-7_i386.deb
  to pool/main/c/chromium/chromium_0.9.12-7_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 300150@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mike Furr <mfurr@debian.org> (supplier of updated chromium package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue,  5 Apr 2005 00:11:18 -0400
Source: chromium
Binary: chromium
Architecture: source i386
Version: 0.9.12-7
Distribution: unstable
Urgency: low
Maintainer: Mike Furr <mfurr@debian.org>
Changed-By: Mike Furr <mfurr@debian.org>
Description: 
 chromium   - Fast paced, arcade-style, scrolling space shooter
Closes: 300150
Changes: 
 chromium (0.9.12-7) unstable; urgency=low
 .
   * Fixed segv when reading highscore file(Closes: 300150)
     Thanks to Alan Woodland
Files: 
 3ae3fdaf46925d2df97ed501aab8f333 653 games optional chromium_0.9.12-7.dsc
 342c963e030d4c95d337d615df3f8d1c 12572 games optional chromium_0.9.12-7.diff.gz
 ee42c5b844e0815aae7a8c7deb7363bf 115940 games optional chromium_0.9.12-7_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCUhCS7ZPKKRJLJvMRAixtAJ9+AYXa+58oCrqmS/kJw9689EUqpwCeODsT
UmwMOIUj2kMSqiZ/Qo7HlOo=
=zBes
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.