Debian Bug report logs - #299881
avr-libc: ADC register define stomps on instruction of same name

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Terran Melconian <terran@consistent.org>

To: submit@bugs.debian.org

Subject: avr-libc: ADC register define stomps on instruction of same name

Date: Wed, 16 Mar 2005 21:59:12 -0500

Package: avr-libc
Version: 1.2.3-2
Severity: minor

The Analog to Digital Converter registers are defined like so:

#define ADC      _SFR_IO16(0x04)
#define ADCL     _SFR_IO8(0x04)
#define ADCH     _SFR_IO8(0x05)

This is somewhat unfortunate, because "ADC" is also the ADd with Carry
instruction in assembly.  This breaks preprocessed assembly files
which use capital instruction mnemonics.  (ADCL and ADCH do not
conflict with anything).

Perhaps the 16-bit ADC register could be renamed, or simply not
defined when __ASSEMBLY__ is defined.  Whatever solution is
implemented should probably be tested with a C program with inline
assembly as well.

I filed this as "minor" because it's easy to work around by undefining
ADC again after including the header.

Message #10 received at 299881@bugs.debian.org (full text, mbox, reply):

From: Hakan Ardo <hakan@debian.org>

To: Terran Melconian <terran@consistent.org>, 299881@bugs.debian.org

Subject: Re: Bug#299881: avr-libc: ADC register define stomps on instruction of same name

Date: Thu, 17 Mar 2005 08:33:14 +0100

Hi,
thanx for you repport. I've forwarded your comments to the upstream bug
#12134:

http://savannah.nongnu.org/bugs/index.php?func=detailitem&item_id=12134

On Wed, Mar 16, 2005 at 09:59:12PM -0500, Terran Melconian wrote:
> Package: avr-libc
> Version: 1.2.3-2
> Severity: minor
> 
> The Analog to Digital Converter registers are defined like so:
> 
> #define ADC      _SFR_IO16(0x04)
> #define ADCL     _SFR_IO8(0x04)
> #define ADCH     _SFR_IO8(0x05)
> 
> This is somewhat unfortunate, because "ADC" is also the ADd with Carry
> instruction in assembly.  This breaks preprocessed assembly files
> which use capital instruction mnemonics.  (ADCL and ADCH do not
> conflict with anything).
> 
> Perhaps the 16-bit ADC register could be renamed, or simply not
> defined when __ASSEMBLY__ is defined.  Whatever solution is
> implemented should probably be tested with a C program with inline
> assembly as well.
> 
> I filed this as "minor" because it's easy to work around by undefining
> ADC again after including the header.
> 

-- 
Hakan Ardo

Message #15 received at 299881-close@bugs.debian.org (full text, mbox, reply):

From: Hakan Ardo <hakan@debian.org>

To: 299881-close@bugs.debian.org

Subject: Bug#299881: fixed in avr-libc 1:1.4.3-1

Date: Wed, 15 Feb 2006 11:17:08 -0800

Source: avr-libc
Source-Version: 1:1.4.3-1

We believe that the bug you reported is fixed in the latest version of
avr-libc, which is due to be installed in the Debian FTP archive:

avr-libc_1.4.3-1.diff.gz
  to pool/main/a/avr-libc/avr-libc_1.4.3-1.diff.gz
avr-libc_1.4.3-1.dsc
  to pool/main/a/avr-libc/avr-libc_1.4.3-1.dsc
avr-libc_1.4.3-1_all.deb
  to pool/main/a/avr-libc/avr-libc_1.4.3-1_all.deb
avr-libc_1.4.3.orig.tar.gz
  to pool/main/a/avr-libc/avr-libc_1.4.3.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 299881@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hakan Ardo <hakan@debian.org> (supplier of updated avr-libc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  5 Feb 2006 11:29:51 +0100
Source: avr-libc
Binary: avr-libc
Architecture: source all
Version: 1:1.4.3-1
Distribution: unstable
Urgency: low
Maintainer: Hakan Ardo <hakan@debian.org>
Changed-By: Hakan Ardo <hakan@debian.org>
Description: 
 avr-libc   - Standard C library for Atmel AVR development
Closes: 299881 350536
Changes: 
 avr-libc (1:1.4.3-1) unstable; urgency=low
 .
   * New upstream release (closes: #350536,#299881). Older versions of avr-libc
     are avalible as avr-libc-1.2 and avr-libc-1.0.
Files: 
 e72e3a07dc440649da5778195102b9f9 647 otherosfs extra avr-libc_1.4.3-1.dsc
 c042630554be22a7aa85cb2411ca1a4f 1011449 otherosfs extra avr-libc_1.4.3.orig.tar.gz
 62eddb79831843351aedcf688b706086 6190 otherosfs extra avr-libc_1.4.3-1.diff.gz
 fd2586550a484aac47ac36957bfdfcc9 2189234 otherosfs extra avr-libc_1.4.3-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFD5e1zAbtddT3jfcARAvKqAJ98fxjmfkhFzLwmoRfOIO0pL0KMGgCeNqQG
/e7cBEejZlO5ENIeBWNDi2k=
=r31B
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.