Debian Bug report logs - #281734
parted: doesn't calculate partition paths correctly when using udev with devfs rules

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: submit@bugs.debian.org

Subject: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Wed, 17 Nov 2004 15:00:04 +0000

Package: parted
Version: 1.6.11-8
Severity: normal

When you're using a system running udev with the devfs compatibility
rules (as d-i probably will at least for a while once it switches to
udev, assuming Debian takes the same route as I'm taking for Ubuntu),
parted fails to calculate partition paths correctly because its /disc ->
/partN substitution is only used when /dev/.devfsd is present.

I've fixed this in Ubuntu by simply looking for /disc at the end of the
path and always doing the /partN substitution if it's found. Here's the
patch:

  http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch

Cheers,

-- 
Colin Watson                                       [cjwatson@debian.org]

Message #10 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Sven Luther <sven.luther@wanadoo.fr>

To: Colin Watson <cjwatson@debian.org>, 281734@bugs.debian.org

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Wed, 17 Nov 2004 16:15:18 +0100

On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> Package: parted
> Version: 1.6.11-8
> Severity: normal
> 
> When you're using a system running udev with the devfs compatibility
> rules (as d-i probably will at least for a while once it switches to
> udev, assuming Debian takes the same route as I'm taking for Ubuntu),
> parted fails to calculate partition paths correctly because its /disc ->
> /partN substitution is only used when /dev/.devfsd is present.
> 
> I've fixed this in Ubuntu by simply looking for /disc at the end of the
> path and always doing the /partN substitution if it's found. Here's the
> patch:
> 
>   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch

Thanks, i will have a look. Do you really think this may break something for
sarge ? After all many will like to run udev outside of d-i, and also use
parted in this case ?

Friendly,

Sven Luther

Message #15 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: Sven Luther <sven.luther@wanadoo.fr>

Cc: 281734@bugs.debian.org

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Wed, 17 Nov 2004 15:21:04 +0000

On Wed, Nov 17, 2004 at 04:15:18PM +0100, Sven Luther wrote:
> On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> > When you're using a system running udev with the devfs compatibility
> > rules (as d-i probably will at least for a while once it switches to
> > udev, assuming Debian takes the same route as I'm taking for Ubuntu),
> > parted fails to calculate partition paths correctly because its /disc ->
> > /partN substitution is only used when /dev/.devfsd is present.
> > 
> > I've fixed this in Ubuntu by simply looking for /disc at the end of the
> > path and always doing the /partN substitution if it's found. Here's the
> > patch:
> > 
> >   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch
> 
> Thanks, i will have a look. Do you really think this may break something for
> sarge ?

I haven't tested the patch heavily; so far, it's been tested to the
extent of a single working installation. I haven't tested it with devfs,
with ordinary udev, or with static /dev.

> After all many will like to run udev outside of d-i, and also use
> parted in this case ?

Most people using udev outside of d-i will be using the traditional /dev
layout rather than the devfs layout. My patch only helps if you're using
the devfs layout; for the traditional layout, parted already works fine.

Cheers,

-- 
Colin Watson                                       [cjwatson@debian.org]

Message #20 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Sven Luther <sven.luther@wanadoo.fr>

To: Colin Watson <cjwatson@debian.org>

Cc: Sven Luther <sven.luther@wanadoo.fr>, 281734@bugs.debian.org

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Wed, 17 Nov 2004 16:33:57 +0100

On Wed, Nov 17, 2004 at 03:21:04PM +0000, Colin Watson wrote:
> On Wed, Nov 17, 2004 at 04:15:18PM +0100, Sven Luther wrote:
> > On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> > > When you're using a system running udev with the devfs compatibility
> > > rules (as d-i probably will at least for a while once it switches to
> > > udev, assuming Debian takes the same route as I'm taking for Ubuntu),
> > > parted fails to calculate partition paths correctly because its /disc ->
> > > /partN substitution is only used when /dev/.devfsd is present.
> > > 
> > > I've fixed this in Ubuntu by simply looking for /disc at the end of the
> > > path and always doing the /partN substitution if it's found. Here's the
> > > patch:
> > > 
> > >   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch
> > 
> > Thanks, i will have a look. Do you really think this may break something for
> > sarge ?
> 
> I haven't tested the patch heavily; so far, it's been tested to the
> extent of a single working installation. I haven't tested it with devfs,
> with ordinary udev, or with static /dev.
> 
> > After all many will like to run udev outside of d-i, and also use
> > parted in this case ?
> 
> Most people using udev outside of d-i will be using the traditional /dev
> layout rather than the devfs layout. My patch only helps if you're using
> the devfs layout; for the traditional layout, parted already works fine.

Oh ...

Well, i have some stuff complaining about missing disc at the end in the LVM
over RAID case, may this be related ? 

Friendly,

Sven Luther

Message #25 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Sven Luther <sven.luther@wanadoo.fr>

To: Colin Watson <cjwatson@debian.org>

Cc: Sven Luther <sven.luther@wanadoo.fr>, 281734@bugs.debian.org

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Sun, 30 Jan 2005 07:35:03 +0100

On Wed, Nov 17, 2004 at 03:21:04PM +0000, Colin Watson wrote:
> On Wed, Nov 17, 2004 at 04:15:18PM +0100, Sven Luther wrote:
> > On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> > > When you're using a system running udev with the devfs compatibility
> > > rules (as d-i probably will at least for a while once it switches to
> > > udev, assuming Debian takes the same route as I'm taking for Ubuntu),
> > > parted fails to calculate partition paths correctly because its /disc ->
> > > /partN substitution is only used when /dev/.devfsd is present.
> > > 
> > > I've fixed this in Ubuntu by simply looking for /disc at the end of the
> > > path and always doing the /partN substitution if it's found. Here's the
> > > patch:
> > > 
> > >   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch

Arg, this patch has dissapeared from there, i suppose i could find it in the
ubuntu parted packages, but it is non-obvious to me yet how to find it.

Friendly,

Sven Luther

Message #30 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: Sven Luther <sven.luther@wanadoo.fr>

Cc: 281734@bugs.debian.org

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Sun, 30 Jan 2005 12:42:04 +0000

On Sun, Jan 30, 2005 at 07:35:03AM +0100, Sven Luther wrote:
> On Wed, Nov 17, 2004 at 03:21:04PM +0000, Colin Watson wrote:
> > On Wed, Nov 17, 2004 at 04:15:18PM +0100, Sven Luther wrote:
> > > On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> > > >   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch
> 
> Arg, this patch has dissapeared from there, i suppose i could find it in the
> ubuntu parted packages, but it is non-obvious to me yet how to find it.

  http://patches.ubuntulinux.org/patches/parted-udev-devfs-rules.patch

Sorry about that.

-- 
Colin Watson                                       [cjwatson@debian.org]

Message #35 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Sven Luther <sven.luther@wanadoo.fr>

To: Colin Watson <cjwatson@debian.org>, 281734@bugs.debian.org

Cc: Sven Luther <sven.luther@wanadoo.fr>

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Sun, 30 Jan 2005 14:32:55 +0100

On Sun, Jan 30, 2005 at 12:42:04PM +0000, Colin Watson wrote:
> On Sun, Jan 30, 2005 at 07:35:03AM +0100, Sven Luther wrote:
> > On Wed, Nov 17, 2004 at 03:21:04PM +0000, Colin Watson wrote:
> > > On Wed, Nov 17, 2004 at 04:15:18PM +0100, Sven Luther wrote:
> > > > On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> > > > >   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch
> > 
> > Arg, this patch has dissapeared from there, i suppose i could find it in the
> > ubuntu parted packages, but it is non-obvious to me yet how to find it.
> 
>   http://patches.ubuntulinux.org/patches/parted-udev-devfs-rules.patch

Thanks. 

In future, i would greatly appreciate that you add the patch directly as
attachement to the bug report, which is how a propper bug report should look
like, not containing vanishing attachements to random web pages.

But i know you know that already, but if this is indeed ubuntu policy for
giving back code to debian, it sucks bigtime.

Thanks for the patch anyway, too bad i missed it yesterday when i had time to
do the fix though.

Friendly,

Sven Luther

Message #40 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Sven Luther <sven.luther@wanadoo.fr>

To: Colin Watson <cjwatson@debian.org>, 281734@bugs.debian.org

Cc: Sven Luther <sven.luther@wanadoo.fr>

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Sun, 30 Jan 2005 14:34:07 +0100

[Message part 1 (text/plain, inline)]

On Sun, Jan 30, 2005 at 12:42:04PM +0000, Colin Watson wrote:
> On Sun, Jan 30, 2005 at 07:35:03AM +0100, Sven Luther wrote:
> > On Wed, Nov 17, 2004 at 03:21:04PM +0000, Colin Watson wrote:
> > > On Wed, Nov 17, 2004 at 04:15:18PM +0100, Sven Luther wrote:
> > > > On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> > > > >   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch
> > 
> > Arg, this patch has dissapeared from there, i suppose i could find it in the
> > ubuntu parted packages, but it is non-obvious to me yet how to find it.
> 
>   http://patches.ubuntulinux.org/patches/parted-udev-devfs-rules.patch
> 
> Sorry about that.

And here is the real patch for completeness sake.

Friendly,

Sven Luther

[parted-udev-devfs-rules.patch (text/plain, attachment)]

Message #45 received at 281734@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: Sven Luther <sven.luther@wanadoo.fr>

Cc: 281734@bugs.debian.org

Subject: Re: Bug#281734: parted: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Sun, 30 Jan 2005 14:34:44 +0000

On Sun, Jan 30, 2005 at 12:42:04PM +0000, Colin Watson wrote:
> On Sun, Jan 30, 2005 at 07:35:03AM +0100, Sven Luther wrote:
> > On Wed, Nov 17, 2004 at 03:21:04PM +0000, Colin Watson wrote:
> > > On Wed, Nov 17, 2004 at 04:15:18PM +0100, Sven Luther wrote:
> > > > On Wed, Nov 17, 2004 at 03:00:04PM +0000, Colin Watson wrote:
> > > > >   http://people.ubuntulinux.org/patches/parted-udev-devfs-rules.patch
> > 
> > Arg, this patch has dissapeared from there, i suppose i could find it in the
> > ubuntu parted packages, but it is non-obvious to me yet how to find it.
> 
>   http://patches.ubuntulinux.org/patches/parted-udev-devfs-rules.patch

The old URL has been fixed now, too.

-- 
Colin Watson                                       [cjwatson@debian.org]

Message #50 received at 281734-done@bugs.debian.org (full text, mbox, reply):

From: "K.G." <k_guillaume@libertysurf.fr>

To: 281734-done@bugs.debian.org

Subject: doesn't calculate partition paths correctly when using udev with devfs rules

Date: Sat, 8 Oct 2005 20:02:38 +0200

Package: parted
Version: 1.6.24-1

The proposed patch has been added, then in 1.6.24-1
another one has been applied which corrects its
behavior in some conditions.

Guillaume Knispel

Send a report that this bug log contains spam.