Debian Bug report logs - #281292
libid3-3.8.3: Missing function in C wrapper

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Javier Kohen <jkohen@users.sourceforge.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: libid3-3.8.3: Missing function in C wrapper

Date: Sun, 14 Nov 2004 18:40:28 -0500

[Message part 1 (text/plain, inline)]

Package: libid3-3.8.3
Version: 3.8.3-4.1
Severity: wishlist

I'm trying to fix bug #281255 in easytag but I can't because there seems
to be a function missing in the wrapper. Namely, I'm trying to set a new frame's encoding to Unicode, so I set the ID3FN_TEXTENC field to the appropriate constant, but when I get the ID3FN_TEXT field it doesn't reflect the previous change.

The C++ interface provides an encoding property in the frame class (with the corresponding
getter and setter), but there's no way to access to it from the C
wrappers.

Could you add the two wrapper functions for that property?

Thanks,


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.9
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)

Versions of packages libid3-3.8.3 depends on:
ii  libc6                       2.3.2.ds1-16 GNU C Library: Shared libraries an
hi  libgcc1                     1:3.4.2-2    GCC support library
ii  libstdc++5                  1:3.3.5-1    The GNU Standard C++ Library v3
ii  zlib1g                      1:1.2.2-1    compression library - runtime

-- no debconf information

-- 
Javier Kohen <jkohen@users.sourceforge.net>
ICQ: blashyrkh #2361802
Jabber: jkohen@jabber.org

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 281292@bugs.debian.org (full text, mbox, reply):

From: Javier Kohen <jkohen@users.sourceforge.net>

To: Debian Bug Tracking System <281292@bugs.debian.org>

Subject: id3lib3.8.3: Fixed

Date: Fri, 26 Nov 2004 15:02:38 -0500

[Message part 1 (text/plain, inline)]

Package: id3lib3.8.3
Followup-For: Bug #281292

Hi, here is a patch that addresses my report.

For what it's worth, I still couldn't fix the easytag bug...


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.9
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)

-- 
Javier Kohen <jkohen@users.sourceforge.net>
ICQ: blashyrkh #2361802
Jabber: jkohen@jabber.org

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 281292@bugs.debian.org (full text, mbox, reply):

From: Javier Kohen <jkohen@users.sourceforge.net>

To: Debian Bug Tracking System <281292@bugs.debian.org>

Subject: id3lib3.8.3: Sorry, the patch

Date: Fri, 26 Nov 2004 15:05:34 -0500

[Message part 1 (text/plain, inline)]

Package: id3lib3.8.3
Followup-For: Bug #281292

I thought reportbug would ask me for the patch or something.

diff -ur id3lib3.8.3-3.8.3.old/debian/changelog id3lib3.8.3-3.8.3/debian/changelog
--- id3lib3.8.3-3.8.3.old/debian/changelog	2004-11-26 14:12:09.000000000 -0500
+++ id3lib3.8.3-3.8.3/debian/changelog	2004-11-26 14:08:38.000000000 -0500
@@ -1,3 +1,9 @@
+id3lib3.8.3 (3.8.3-4.2) unstable; urgency=low
+
+  * Added wrappers for Field encoding functions to C wrapper.
+
+ -- Javier Kohen <jkohen@nada>  Fri, 26 Nov 2004 14:07:58 -0500
+
 id3lib3.8.3 (3.8.3-4.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -ur id3lib3.8.3-3.8.3.old/include/id3.h id3lib3.8.3-3.8.3/include/id3.h
--- id3lib3.8.3-3.8.3.old/include/id3.h	2003-03-01 19:23:00.000000000 -0500
+++ id3lib3.8.3-3.8.3/include/id3.h	2004-11-26 14:03:40.000000000 -0500
@@ -104,6 +104,9 @@
   ID3_C_EXPORT void                 CCONV ID3Field_GetBINARY          (const ID3Field *field, uchar *buffer, size_t buffLength);
   ID3_C_EXPORT void                 CCONV ID3Field_FromFile           (ID3Field *field, const char *fileName);
   ID3_C_EXPORT void                 CCONV ID3Field_ToFile             (const ID3Field *field, const char *fileName);
+  ID3_C_EXPORT bool                 CCONV ID3Field_SetEncoding        (ID3Field *field, ID3_TextEnc enc);
+  ID3_C_EXPORT ID3_TextEnc          CCONV ID3Field_GetEncoding        (const ID3Field *field);
+  ID3_C_EXPORT bool                 CCONV ID3Field_IsEncodable        (const ID3Field *field);
 
   /* field-info wrappers */
   ID3_C_EXPORT char*                CCONV ID3FrameInfo_ShortName     (ID3_FrameID frameid);
diff -ur id3lib3.8.3-3.8.3.old/src/c_wrapper.cpp id3lib3.8.3-3.8.3/src/c_wrapper.cpp
--- id3lib3.8.3-3.8.3.old/src/c_wrapper.cpp	2003-03-01 19:23:00.000000000 -0500
+++ id3lib3.8.3-3.8.3/src/c_wrapper.cpp	2004-11-26 14:04:38.000000000 -0500
@@ -681,6 +681,39 @@
     }
   }
 
+  ID3_C_EXPORT bool CCONV
+  ID3Field_SetEncoding(ID3Field *field, ID3_TextEnc enc)
+  {
+    bool changed = false;
+    if (field)
+    {
+      ID3_CATCH(changed = reinterpret_cast<ID3_Field *>(field)->SetEncoding(enc));
+    }
+    return changed;
+  }
+
+  ID3_C_EXPORT ID3_TextEnc CCONV
+  ID3Field_GetEncoding(const ID3Field *field)
+  {
+    ID3_TextEnc enc = ID3TE_NONE;
+    if (field)
+    {
+      ID3_CATCH(enc = reinterpret_cast<const ID3_Field *>(field)->GetEncoding());
+    }
+    return enc;
+  }
+
+  ID3_C_EXPORT bool CCONV
+  ID3Field_IsEncodable(const ID3Field *field)
+  {
+    bool isEncodable = false;
+    if (field)
+    {
+      ID3_CATCH(isEncodable = reinterpret_cast<const ID3_Field *>(field)->IsEncodable());
+    }
+    return isEncodable;
+  }
+
 #ifdef __cplusplus
 }
 #endif /* __cplusplus */


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.9
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)

-- 
Javier Kohen <jkohen@users.sourceforge.net>
ICQ: blashyrkh #2361802
Jabber: jkohen@jabber.org

[id3lib+c_wrapper_encoding.diff (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 281292@bugs.debian.org (full text, mbox, reply):

From: Jérôme COUDERC <easytag@gmail.com>

To: 281292@bugs.debian.org, Robert Woodcock <rcw@debian.org>

Cc: Javier Kohen <jkohen@users.sourceforge.net>, Sebastien Bacher <seb128@debian.org>

Subject: Bug#281292 - libid3-3.8.3: Missing function in C wrapper

Date: Wed, 14 Sep 2005 23:17:40 +0200

Hi Robert,

   As in the next version of EasyTAG, I will include the patch from 
Javier to enable/fix UTF-16 reading with C wrapper, I wanted to know if 
you intend to apply to patch "id3lib+c_wrapper_encoding.diff" 
<http://bugs.debian.org/cgi-bin/bugreport.cgi/id3lib%252Bc_wrapper_encoding.diff?bug=281292;msg=15;att=1> 
supplied by Javier?

This patch couldn't "break" the library as it adds only some C wrappers. 
So there is no risk.
Moreover it will be necessary to allow compilation of future EasyTAG 
versions...

Thanks in advance,
Jerome

-- 
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC <easytag@gmail.com>

Message #25 received at 281292@bugs.debian.org (full text, mbox, reply):

From: Robert Woodcock <rcw@debian.org>

To: J?r?me COUDERC <easytag@gmail.com>

Cc: 281292@bugs.debian.org, Javier Kohen <jkohen@users.sourceforge.net>, Sebastien Bacher <seb128@debian.org>

Subject: Re: Bug#281292 - libid3-3.8.3: Missing function in C wrapper

Date: Wed, 14 Sep 2005 17:56:35 -0700

On Wed, Sep 14, 2005 at 11:17:40PM +0200, J?r?me COUDERC wrote:
> Hi Robert,
> 
>    As in the next version of EasyTAG, I will include the patch from 
> Javier to enable/fix UTF-16 reading with C wrapper, I wanted to know if 
> you intend to apply to patch "id3lib+c_wrapper_encoding.diff" 
> <http://bugs.debian.org/cgi-bin/bugreport.cgi/id3lib%252Bc_wrapper_encoding.diff?bug=281292;msg=15;att=1> 
> supplied by Javier?

*IF* there is a general concensus that this patch as it exists will be
accepted into id3lib upstream. I am not interested in maintaining and
porting debian-specific things to new versions. If you are, then we can
certainly talk about that.

> This patch couldn't "break" the library as it adds only some C wrappers. 
> So there is no risk.
> Moreover it will be necessary to allow compilation of future EasyTAG 
> versions...

Let me get this straight. EasyTAG will expect users of other distributions
(or people who wish to compile it themselves) to compile id3lib themselves,
with their patch, to be able to compile and use EasyTAG?
-- 
Robert Woodcock - rcw@debian.org 
perl -e '$a-=($_%4-2)*4/$_++while++$_<2e6;print"$a\n"'

Message #30 received at 281292@bugs.debian.org (full text, mbox, reply):

From: Javier Kohen <jkohen@users.sourceforge.net>

To: Robert Woodcock <rcw@debian.org>

Cc: J?r?me COUDERC <easytag@gmail.com>, 281292@bugs.debian.org, Sebastien Bacher <seb128@debian.org>

Subject: Re: Bug#281292 - libid3-3.8.3: Missing function in C wrapper

Date: Thu, 15 Sep 2005 02:45:29 -0300

[Message part 1 (text/plain, inline)]

Hello Robert, Jérôme

El mié, 14-09-2005 a las 17:56 -0700, Robert Woodcock escribió:
> On Wed, Sep 14, 2005 at 11:17:40PM +0200, J?r?me COUDERC wrote:
> > Hi Robert,
> > 
> >    As in the next version of EasyTAG, I will include the patch from 
> > Javier to enable/fix UTF-16 reading with C wrapper, I wanted to know if 
> > you intend to apply to patch "id3lib+c_wrapper_encoding.diff" 
> > <http://bugs.debian.org/cgi-bin/bugreport.cgi/id3lib%252Bc_wrapper_encoding.diff?bug=281292;msg=15;att=1> 
> > supplied by Javier?
> 
> *IF* there is a general concensus that this patch as it exists will be
> accepted into id3lib upstream. I am not interested in maintaining and
> porting debian-specific things to new versions. If you are, then we can
> certainly talk about that.

I pushed the patch upstream about on November 2004 (see
http://sourceforge.net/tracker/index.php?func=detail&aid=1073951&group_id=979&atid=300979), but unfortunately the project seems to have been dead since at least a year before that.

> > This patch couldn't "break" the library as it adds only some C wrappers. 
> > So there is no risk.
> > Moreover it will be necessary to allow compilation of future EasyTAG 
> > versions...
> 
> Let me get this straight. EasyTAG will expect users of other distributions
> (or people who wish to compile it themselves) to compile id3lib themselves,
> with their patch, to be able to compile and use EasyTAG?

Although I can't answer that, is it possible that you are in contact
with somebody upstream? The patch is trivial, it just adds three wrapper
functions to the already existing bunch, and it doesn't remove or change
anything else.

Thanks,
-- 
Javier Kohen <jkohen@users.sourceforge.net>
ICQ: blashyrkh #2361802
Jabber: jkohen@jabber.org

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 281292@bugs.debian.org (full text, mbox, reply):

From: Jérôme COUDERC <easytag@gmail.com>

To: Robert Woodcock <rcw@debian.org>

Cc: 281292@bugs.debian.org, Javier Kohen <jkohen@users.sourceforge.net>, Sebastien Bacher <seb128@debian.org>

Subject: Re: Bug#281292 - libid3-3.8.3: Missing function in C wrapper

Date: Thu, 15 Sep 2005 08:22:25 +0200

Robert Woodcock wrote, the 15/09/2005 02:56 :

>Let me get this straight. EasyTAG will expect users of other distributions
>(or people who wish to compile it themselves) to compile id3lib themselves,
>with their patch, to be able to compile and use EasyTAG?
>  
>

Of course, this will be an ideal world ;-)
Don't worry, EasyTAG will be compatible with the current id3lib version, 
but without Unicode support, as presently (it is a real shame)... We are 
waiting for this patch since one year, but it seems that there is no 
activity on this project...

Regards,
Jerome

-- 
EasyTAG - Tag editor for MP3 and Ogg Vorbis files
http://easytag.sourceforge.net
--
Jerome COUDERC <easytag@gmail.com>

Message #42 received at 281292-close@bugs.debian.org (full text, mbox, reply):

From: Rogério Brito <rbrito@ime.usp.br>

To: 281292-close@bugs.debian.org

Subject: Bug#281292: fixed in id3lib3.8.3 3.8.3-8

Date: Sat, 28 Nov 2009 17:04:12 +0000

Source: id3lib3.8.3
Source-Version: 3.8.3-8

We believe that the bug you reported is fixed in the latest version of
id3lib3.8.3, which is due to be installed in the Debian FTP archive:

id3lib3.8.3_3.8.3-8.debian.tar.gz
  to main/i/id3lib3.8.3/id3lib3.8.3_3.8.3-8.debian.tar.gz
id3lib3.8.3_3.8.3-8.dsc
  to main/i/id3lib3.8.3/id3lib3.8.3_3.8.3-8.dsc
libid3-3.8.3-dev_3.8.3-8_amd64.deb
  to main/i/id3lib3.8.3/libid3-3.8.3-dev_3.8.3-8_amd64.deb
libid3-3.8.3c2a_3.8.3-8_amd64.deb
  to main/i/id3lib3.8.3/libid3-3.8.3c2a_3.8.3-8_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 281292@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rogério Brito <rbrito@ime.usp.br> (supplier of updated id3lib3.8.3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 28 Nov 2009 05:36:53 -0200
Source: id3lib3.8.3
Binary: libid3-3.8.3-dev libid3-3.8.3c2a
Architecture: source amd64
Version: 3.8.3-8
Distribution: unstable
Urgency: low
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Rogério Brito <rbrito@ime.usp.br>
Description: 
 libid3-3.8.3-dev - ID3 Tag Library: Development Libraries and Header Files.
 libid3-3.8.3c2a - Library for manipulating ID3v1 and ID3v2 tags.
Closes: 276673 281292 340365 377308 446320 497991 528509 540548
Changes: 
 id3lib3.8.3 (3.8.3-8) unstable; urgency=low
 .
   * QA upload.
   * Setting maintainers to the QA group.
   * Build-depend on unversioned automake.
   * Change to source "3.0 (quilt)".
   * Avoid FTBFS with a fresh autotools run. (Closes: #340365, #528509).
   * debian/rules:
     + remove commented lines.
     + include a configure target and separate it from the build target.
     + wrap the configure call.
     + removed some auto-generated files.
   * debian/control:
     + add misc-depends to control files.
     + make debhelper dependency versioned.
     + remove duplication of section field.
   * include watch file.
   * Update Standards-Version to 3.8.3, with no extra changes needed (really).
   * Fix crashes in ID3_TagHeader::Size(). Tks Brian Murray, Thomas Eschenbacher.
     (Closes: #540548, LP: #399423).
   * Move the utilities from the -dev package to the library package.
     (Closes: #377308)
   * Include the list of cli in the long description of the non -dev package.
     (Closes: #497991, #446320).
   * Also move their manpages.
   * Add patch from Javier Kohen to provide C wrapper functions to the library.
     (Closes: #281292)
   * A previous patch (from 3.8.3-6) already Closes: #276673.
Checksums-Sha1: 
 9ad6c013ec42ae0dacf1a1c133fb1d4d6729ed43 1719 id3lib3.8.3_3.8.3-8.dsc
 1e03ed74c23e9eaefe188ba906c8f1db58dc9495 8740 id3lib3.8.3_3.8.3-8.debian.tar.gz
 b243a8bad204c63f24b2d07d001bb0e5fc37389c 249108 libid3-3.8.3-dev_3.8.3-8_amd64.deb
 d135b89b4a98e2a1d3a1ec7efd2114ec34f62559 195300 libid3-3.8.3c2a_3.8.3-8_amd64.deb
Checksums-Sha256: 
 37468f8b5841eabda0bbfae241423fe1ff737172792a1edbf54655f288fbe04a 1719 id3lib3.8.3_3.8.3-8.dsc
 b68a637c78d9fdb146c4f01e95e2ae9eb74ee3992e4f8f6bf6996f62f2439f1f 8740 id3lib3.8.3_3.8.3-8.debian.tar.gz
 f70b07aca07a47fab6ed35994eec28cb3c15da6d2f3b503f26dd720820bd5e07 249108 libid3-3.8.3-dev_3.8.3-8_amd64.deb
 27fba26648a4caef39c8bea1d43b2eb8a0d1b70995cb1c52bcb58b1b2eb8a7d7 195300 libid3-3.8.3c2a_3.8.3-8_amd64.deb
Files: 
 ec06693f8cc58cf632d887b6f4296665 1719 libs optional id3lib3.8.3_3.8.3-8.dsc
 93888899419b5957050065dceeb55312 8740 libs optional id3lib3.8.3_3.8.3-8.debian.tar.gz
 5dbf8d0b60e2ab7bbc96eb662bca65a8 249108 libdevel optional libid3-3.8.3-dev_3.8.3-8_amd64.deb
 8d6f12a35d356939366a2c30307333b1 195300 libs optional libid3-3.8.3c2a_3.8.3-8_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJLEVQDAAoJEOtw/vPN/G5PY+QQALFo+9Kk55UgnaHgvwUyyPuA
LPAPYLY23bviAslsrv2JWbKxfZvA8U0BtKin565lUEpVoEqwU9y99uWYPm6GMHBk
4+eOTjiZH2OskTheBeRGo7RFBYekR73LOV/E1x4TdsQGW6YLCXw8oJUuIXEuNiYX
DFw3b7qNJexn4HAaXxkXDO68h3rmLkr6+HZdbB/goqNuiT4FZn685OeOuHkzwKX0
kYyAYkcU/jCMkYkG1N7dVO+WV3oHIDol5pQUjuXtM43vIeqAUHJpkS4qwHh/7DFv
bp6ZYlKdtRj371wQYe4tE8rRGcO/EuSdjKnLptCUMvD+JBXnGizH1NPdia4DXa5i
s+TSTpOyxGSj/konLvUxKQlSuwKSe57xV2+w/ZVNYBPZeah66HBjCXAzMYCNqbtD
Zh5OYWuFXPouUghhAg10mDYJs3YHFt6MS42nWrF5qM1nUplTt2Islmg2aQm6XlX5
KHsyM5wDDFLPvlTPKa/4zGUI5v88R+ZqGqQs5RXJiWzE8nO3FgZhHD0DvKN3eMYb
q+ZKFLdIMaqE06TKD3YCMRLN7kxxW1CQZRA/ulHaK35PBP7gY97N1HwA0tHS8tYH
sPvwRyLQ8Y20ZUmGVtL7NUkqxHEyZLuYvwUZ1ILHbU+7IY4wSupJpgjCZBaUqUud
0VlKtAga7FCETKOT5tod
=In6S
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.