Debian Bug report logs - #272864
raidtools2: lsraid -R -p does not set parity-algorithm

version graph

Package: raidtools2; Maintainer for raidtools2 is (unknown);

Reported by: Wolfram Tomalla <w.tomalla@gmx.de>

Date: Wed, 22 Sep 2004 13:03:03 UTC

Severity: critical

Tags: patch

Found in versions 1.00.3-14, 1.00.3-15

Fixed in versions raidtools2/1.00.3-15, raidtools2/1.00.3-17

Done: Matthijs Mohlmann <matthijs@cacholong.nl>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, Matthijs Mohlmann <matthijs@cacholong.nl>:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Wolfram Tomalla <w.tomalla@gmx.de>:
New Bug report received and forwarded. Copy sent to Matthijs Mohlmann <matthijs@cacholong.nl>. (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Wolfram Tomalla <w.tomalla@gmx.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: raidtools2: lsraid -R -p does not set parity-algorithm
Date: Wed, 22 Sep 2004 14:47:22 +0200
Package: raidtools2
Version: 1.00.3-14
Severity: critical
Justification: causes serious data loss


lsraid -R -p does not include the parity-algorithm option in the 
generated /etc/raidtab file. So restoring from a dubble Disk error like 
described in the Software Raid Howto leads to datacorruption on the 
array if you did not initially set it up using parity-algorithm 
left-asymetric.

As the manpage of raidtab(5) suggests to use parity-algorithm 
left-symmetric: "left-symmetric is the one that offers maximum  
performance on typical disks with rotating platters." I guess I will not 
be the only one who will corrupt his data on a software raid by 
following this Howto procedure.

e.g:
output from lsraid -R -p
[..]
# md device [dev 9, 0] /dev/md0 queried online
raiddev /dev/md0
        raid-level              5
        nr-raid-disks           3
        nr-spare-disks          0
        persistent-superblock   1
        chunk-size              16

        device          /dev/hda1
        raid-disk               0
        device          /dev/hdb1
        raid-disk               1
        device          /dev/hdc1
        raid-disk               2
[..]

correct would habe been :

raiddev /dev/md0
        raid-level              5
        nr-raid-disks           3
        nr-spare-disks          0
        persistent-superblock   1
        parity-algorithm        left-symmetric
        chunk-size              16

        device          /dev/hda1
        raid-disk               0
        device          /dev/hdb1
        raid-disk               1
        device          /dev/hdc1
        raid-disk               2


Greetings,

Wolfram


-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-1-k7
Locale: LANG=C, LC_CTYPE=C

Versions of packages raidtools2 depends on:
ii  debconf                     1.4.30.5     Debian configuration management sy
ii  libc6                       2.3.2.ds1-16 GNU C Library: Shared libraries an
ii  makedev                     2.3.1-75     Creates device files in /dev

-- debconf information:
  raidtools2/oldraid:
  raidtools2/nosupport:
  raidtools2/autostart: false



Information forwarded to debian-bugs-dist@lists.debian.org, Matthijs Mohlmann <matthijs@cacholong.nl>:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Fabio Massimo Di Nitto <fabbione@canonical.com>:
Extra info received and forwarded to list. Copy sent to Matthijs Mohlmann <matthijs@cacholong.nl>. (full text, mbox, link).


Message #10 received at 272864@bugs.debian.org (full text, mbox, reply):

From: Fabio Massimo Di Nitto <fabbione@canonical.com>
To: 272864@bugs.debian.org
Cc: control@bugs.debian.org
Subject: patch
Date: Thu, 23 Sep 2004 11:08:15 +0200
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

tag 272864 patch
stop

Hi,
~    I just finished to prepare a patch to fix this bug.
You can grab it here:

http://people.no-name-yet.com/patches/raidtools2.272864.dpatch

It is a dpatch that you can just add to the list and:
- - it prints parity-algorithm for raid5 and raid6
- - it prints "linear" instead of "-1" for linear raids

The latter is a pure cosmetic change since raidtab accepts both names or
values.

Fabio

- --
<user> fajita: step one
<fajita> Whatever the problem, step one is always to look in the error log.
<user> fajita: step two
<fajita> When in danger or in doubt, step two is to scream and shout.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQIVAwUBQVKSfFA6oBJjVJ+OAQLWXg//e1OohRhNWx+GAkMAIfHJMk+bWzNMhCq0
8WsyZn52VG3ToZMNvRRCVkWYiG6PUlP3CNo10bI/vroHJnZPRyPxfCNgPGmFCDEg
+G6JLme1jnxGi5r53js30a0kCp4hQjudnYvxIQZ7Wv3+GXVhN3HYXpnlnhWB3ayI
QZM/SMeQ39HQtTPsY+TU7KkXPEbFx1GAwcaWSiVeislwlvGD9vAjXM3doOnnAOJK
yXi6TM1vvB6hk0x6Z3M8AmNMXn1hT5qgCVUFX3vXasBNJ6GSxY0raYEwV2xKEf5m
mls3wj71MUfE0uY8RrT/Qctk2g0Ep1ftCZk8dwS8uogIPZh1MFMaTDiWMkqIV1Rn
ITGh4uzMOb3xDJgT8d5HSvqKHe5lj4CQlRmIG08L/VWalNn+vThqqa4x7TqpYrYZ
fe5JhMYDa6Jl1fxq5dJ3yKTb1/wrn8xKNYSnd5oXzcN2mI/fylrH22uKBwf68yBV
jCDAh33YIm+X+Nbtbc21i+2WMqY9cxMshVQZgyeVmGTFIlQYfTAUqZX723RHwwdt
Bey6454Mh4lHi1Ow+XGe/5PZ7OTjCQ4wbEd9hIs1CyIQU1Md1fF0DhwPb3c30ms8
URXxkoUM0RSTGIyl9yln0v59e+SQvCIe7sHcom687dy8vRtE5yRY0boMu/lVJyOG
lYKvmraSclo=
=PhLN
-----END PGP SIGNATURE-----



Tags added: patch Request was from Fabio Massimo Di Nitto <fabbione@canonical.com> to control@bugs.debian.org. (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Matthijs Mohlmann <matthijs@cacholong.nl>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #17 received at 272864@bugs.debian.org (full text, mbox, reply):

From: Matthijs Mohlmann <matthijs@cacholong.nl>
To: Fabio Massimo Di Nitto <fabbione@canonical.com>, 272864@bugs.debian.org
Cc: control@bugs.debian.org
Subject: Re: Bug#272864: patch
Date: Thu, 23 Sep 2004 12:12:39 +0200
On Thu, 2004-09-23 at 11:08, Fabio Massimo Di Nitto wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> tag 272864 patch
> stop
> 
> Hi,
> ~    I just finished to prepare a patch to fix this bug.
> You can grab it here:
> 
> http://people.no-name-yet.com/patches/raidtools2.272864.dpatch
> 
> It is a dpatch that you can just add to the list and:
> - - it prints parity-algorithm for raid5 and raid6
> - - it prints "linear" instead of "-1" for linear raids
> 
> The latter is a pure cosmetic change since raidtab accepts both names or
> values.
> 

Thanks for the patch. I didn't have yet the time for it but i'll fix it
today. :)

Thanks again

> Fabio
> 
> - --
> <user> fajita: step one
> <fajita> Whatever the problem, step one is always to look in the error log.
> <user> fajita: step two
> <fajita> When in danger or in doubt, step two is to scream and shout.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
> 
> iQIVAwUBQVKSfFA6oBJjVJ+OAQLWXg//e1OohRhNWx+GAkMAIfHJMk+bWzNMhCq0
> 8WsyZn52VG3ToZMNvRRCVkWYiG6PUlP3CNo10bI/vroHJnZPRyPxfCNgPGmFCDEg
> +G6JLme1jnxGi5r53js30a0kCp4hQjudnYvxIQZ7Wv3+GXVhN3HYXpnlnhWB3ayI
> QZM/SMeQ39HQtTPsY+TU7KkXPEbFx1GAwcaWSiVeislwlvGD9vAjXM3doOnnAOJK
> yXi6TM1vvB6hk0x6Z3M8AmNMXn1hT5qgCVUFX3vXasBNJ6GSxY0raYEwV2xKEf5m
> mls3wj71MUfE0uY8RrT/Qctk2g0Ep1ftCZk8dwS8uogIPZh1MFMaTDiWMkqIV1Rn
> ITGh4uzMOb3xDJgT8d5HSvqKHe5lj4CQlRmIG08L/VWalNn+vThqqa4x7TqpYrYZ
> fe5JhMYDa6Jl1fxq5dJ3yKTb1/wrn8xKNYSnd5oXzcN2mI/fylrH22uKBwf68yBV
> jCDAh33YIm+X+Nbtbc21i+2WMqY9cxMshVQZgyeVmGTFIlQYfTAUqZX723RHwwdt
> Bey6454Mh4lHi1Ow+XGe/5PZ7OTjCQ4wbEd9hIs1CyIQU1Md1fF0DhwPb3c30ms8
> URXxkoUM0RSTGIyl9yln0v59e+SQvCIe7sHcom687dy8vRtE5yRY0boMu/lVJyOG
> lYKvmraSclo=
> =PhLN
> -----END PGP SIGNATURE-----
> 




Reply sent to Matthijs Mohlmann <matthijs@cacholong.nl>:
You have taken responsibility. (full text, mbox, link).


Notification sent to Wolfram Tomalla <w.tomalla@gmx.de>:
Bug acknowledged by developer. (full text, mbox, link).


Message #22 received at 272864-close@bugs.debian.org (full text, mbox, reply):

From: Matthijs Mohlmann <matthijs@cacholong.nl>
To: 272864-close@bugs.debian.org
Subject: Bug#272864: fixed in raidtools2 1.00.3-15
Date: Mon, 27 Sep 2004 10:47:05 -0400
Source: raidtools2
Source-Version: 1.00.3-15

We believe that the bug you reported is fixed in the latest version of
raidtools2, which is due to be installed in the Debian FTP archive:

raidtools2-udeb_1.00.3-15_i386.udeb
  to pool/main/r/raidtools2/raidtools2-udeb_1.00.3-15_i386.udeb
raidtools2_1.00.3-15.diff.gz
  to pool/main/r/raidtools2/raidtools2_1.00.3-15.diff.gz
raidtools2_1.00.3-15.dsc
  to pool/main/r/raidtools2/raidtools2_1.00.3-15.dsc
raidtools2_1.00.3-15_i386.deb
  to pool/main/r/raidtools2/raidtools2_1.00.3-15_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 272864@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthijs Mohlmann <matthijs@cacholong.nl> (supplier of updated raidtools2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 23 Sep 2004 14:38:17 +0200
Source: raidtools2
Binary: raidtools2-udeb raidtools2
Architecture: source i386
Version: 1.00.3-15
Distribution: unstable
Urgency: medium
Maintainer: Matthijs Mohlmann <matthijs@cacholong.nl>
Changed-By: Matthijs Mohlmann <matthijs@cacholong.nl>
Description: 
 raidtools2 - Utilities to support 'new-style' RAID disks
 raidtools2-udeb - Utilities to support 'new-style' RAID disks (udeb) (udeb)
Closes: 272864
Changes: 
 raidtools2 (1.00.3-15) unstable; urgency=medium
 .
   * Added a patch for not setting the parity-algorithm. (Closes: #272864)
     Thanks to Fabio M. Di Nitto who made the patch
Files: 
 a1fc14382b665abc0c4f11b367446427 656 admin extra raidtools2_1.00.3-15.dsc
 568169c69107d8370d00d7464c81aa2d 98679 admin extra raidtools2_1.00.3-15.diff.gz
 bb0bd585736a25fee5c36ec3f6adaf73 264356 admin optional raidtools2_1.00.3-15_i386.deb
 07108d5f31c4760801d4d4ec65e2c75e 147788 debian-installer extra raidtools2-udeb_1.00.3-15_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBWCZLKb5dImj9VJ8RAs2lAJsHMmu3A0cyS0J9rg8B9kkn6Q5Y4wCgn6xd
MxLbSJ5QB+7w5to4V/vBbiI=
=NRwj
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org, Matthijs Mohlmann <matthijs@cacholong.nl>:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Wolfram Tomalla <w.tomalla@gmx.de>:
Extra info received and forwarded to list. Copy sent to Matthijs Mohlmann <matthijs@cacholong.nl>. (full text, mbox, link).


Message #27 received at 272864@bugs.debian.org (full text, mbox, reply):

From: Wolfram Tomalla <w.tomalla@gmx.de>
To: Debian Bug Tracking System <272864@bugs.debian.org>
Subject: raidtools2: Fix does not work if device is queried offline
Date: Mon, 25 Oct 2004 11:54:24 +0200
Package: raidtools2
Version: 1.00.3-15
Followup-For: Bug #272864



Hi!

The fix works fine als long as the array is queried online.
However if it is queried offline the display of parity-algorithm is
skipped.

Please see below


wasserstoff:~# lsraid -R -p
# This raidtab was generated by lsraid version 0.7.0.
# It was created from a query on the following devices:
[..]

# md device [dev 9, 0] /dev/md0 queried offline
# Authoritative device is [dev 3, 1] /dev/hda1
raiddev /dev/md0
        raid-level              5
        nr-raid-disks           3
        nr-spare-disks          0
        persistent-superblock   1
        chunk-size              16

        device          /dev/hda1
        raid-disk               0
        device          /dev/hdb1
        raid-disk               1
        device          /dev/hdc1
        raid-disk               2

[..]

wasserstoff:~# raidstart /dev/md0
wasserstoff:~# lsraid -R -p
# This raidtab was generated by lsraid version 0.7.0.
# It was created from a query on the following devices:
[..]

# md device [dev 9, 0] /dev/md0 queried online
raiddev /dev/md0
        raid-level              5
        nr-raid-disks           3
        nr-spare-disks          0
        persistent-superblock   1
        chunk-size              16
        parity-algorithm        left-symmetric

        device          /dev/hda1
        raid-disk               0
        device          /dev/hdb1
        raid-disk               1
        device          /dev/hdc1
        raid-disk               2

[..]

Please contact me, if you need more details.

CU

Wolfram


-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.8-1-k7
Locale: LANG=C, LC_CTYPE=C

Versions of packages raidtools2 depends on:
ii  debconf                     1.4.30.8     Debian configuration management sy
ii  libc6                       2.3.2.ds1-18 GNU C Library: Shared libraries an
ii  makedev                     2.3.1-75     Creates device files in /dev

-- debconf information:
  raidtools2/oldraid:
  raidtools2/nosupport:
  raidtools2/autostart: true



Bug reopened, originator not changed. Request was from "Wolfram Tomalla" <W.Tomalla@gmx.de> to control@bugs.debian.org. (full text, mbox, link).


Tags removed: patch Request was from Frank Lichtenheld <djpig@debian.org> to control@bugs.debian.org. (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Matthijs Mohlmann <matthijs@cacholong.nl>:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Frank Lichtenheld <djpig@debian.org>:
Extra info received and forwarded to list. Copy sent to Matthijs Mohlmann <matthijs@cacholong.nl>. (full text, mbox, link).


Message #36 received at 272864@bugs.debian.org (full text, mbox, reply):

From: Frank Lichtenheld <djpig@debian.org>
To: Wolfram Tomalla <w.tomalla@gmx.de>, 272864@bugs.debian.org
Cc: Fabio Massimo Di Nitto <fabbione@canonical.com>
Subject: Re: Bug#272864: raidtools2: Fix does not work if device is queried offline
Date: Thu, 11 Nov 2004 23:30:07 +0100
[Message part 1 (text/plain, inline)]
tags 272864 patch
thanks

[CCed Fabio who provided the original patch]

On Mon, Oct 25, 2004 at 11:54:24AM +0200, Wolfram Tomalla wrote:
> The fix works fine als long as the array is queried online.
> However if it is queried offline the display of parity-algorithm is
> skipped.

This is because two separate (but similar) functions are used to output
the information for online respective offline arrays. One can nearly
copy the patch by Fabio for the second function.

Attached is a try to do this. As I have no raid array available (at
least none that I'm willing to take offline ;) I can't really test it.
I attached both the patch against the raidtools package and the plain
modified dpatch.

(of course it would be better to move some of the code to a third
function which can then be called from both...)

Gruesse,
-- 
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
[raidtools2.272864.patch (text/plain, attachment)]
[print_raid5_raid6_parity_and_linear.dpatch (text/plain, attachment)]

Tags added: patch Request was from Frank Lichtenheld <djpig@debian.org> to control@bugs.debian.org. (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Matthijs Mohlmann <matthijs@cacholong.nl>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #43 received at 272864@bugs.debian.org (full text, mbox, reply):

From: Matthijs Mohlmann <matthijs@cacholong.nl>
To: Frank Lichtenheld <djpig@debian.org>, 272864@bugs.debian.org, fabbione@canonical.com
Subject: Re: Bug#272864: raidtools2: Fix does not work if device is queried offline
Date: Fri, 12 Nov 2004 09:19:59 +0100
On Thu, 2004-11-11 at 23:30 +0100, Frank Lichtenheld wrote:
> tags 272864 patch
> thanks
> 
> [CCed Fabio who provided the original patch]
> 
> On Mon, Oct 25, 2004 at 11:54:24AM +0200, Wolfram Tomalla wrote:
> > The fix works fine als long as the array is queried online.
> > However if it is queried offline the display of parity-algorithm is
> > skipped.
> 
> This is because two separate (but similar) functions are used to output
> the information for online respective offline arrays. One can nearly
> copy the patch by Fabio for the second function.
> 
> Attached is a try to do this. As I have no raid array available (at
> least none that I'm willing to take offline ;) I can't really test it.
> I attached both the patch against the raidtools package and the plain
> modified dpatch.
> 
> (of course it would be better to move some of the code to a third
> function which can then be called from both...)
> 
> Gruesse,

Well if someone can try this patch and can prove this is now working i
am appreciating that. At the moment i don't have a raid array to test
this on.

Thanks for providing the patch

Regards,
-- 
Matthijs Mohlmann <matthijs@cacholong.nl>




Information forwarded to debian-bugs-dist@lists.debian.org, Matthijs Mohlmann <matthijs@cacholong.nl>:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Fabio Massimo Di Nitto <fabbione@canonical.com>:
Extra info received and forwarded to list. Copy sent to Matthijs Mohlmann <matthijs@cacholong.nl>. (full text, mbox, link).


Message #48 received at 272864@bugs.debian.org (full text, mbox, reply):

From: Fabio Massimo Di Nitto <fabbione@canonical.com>
To: Matthijs Mohlmann <matthijs@cacholong.nl>
Cc: Frank Lichtenheld <djpig@debian.org>, 272864@bugs.debian.org
Subject: Re: Bug#272864: raidtools2: Fix does not work if device is queried offline
Date: Fri, 12 Nov 2004 09:29:22 +0100
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthijs Mohlmann wrote:

|
| Well if someone can try this patch and can prove this is now
| working i am appreciating that. At the moment i don't have a raid
| array to test this on.
|
| Thanks for providing the patch
|
| Regards,


I will try to give it a shot sometime during the next week, but
i don't promise.

Fabio

- --
Self-Service law:
The last available dish of the food you have decided to eat, will be
inevitably taken from the person in front of you.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iQIVAwUBQZR0YFA6oBJjVJ+OAQIgJQ//fRx6AniuDBjYkRmcShBgPJJLe2wDjXpd
gk0SC7mvcajNyjd7LNZTPpeTNH2onAPBp9NSNZaZeNDk68cNIzWKp52Cc3KVY/fA
NuDHB1mfj8wPZYyntVI+U00Dbsr7m8CN6uWxiwhcBbyUOxEAgULY1KsvjmiO5qUz
+M0u01pto8PL+5/gwNFQOflXyflw313b+NbooXMdApSBKd5SZCTzAf8ozM+bVPbK
EjuF1t+f1BHgGqMSDorK+BMPy0SZt+R+jloe4cd8iqc9QgGmc9z23ow/g8yo67Kd
elzhyleGOywREM+bLrqGSt6G2zhnn7n8J8AZZiP87XIRpEa1U9v/0jbWk8fQV5y+
z1Itw1JlgBi+N21JLsu4Fa9JoTgQ44U4TcVCLJKUhr7ZLxi/peoBwxoZ95W4AStT
aiOK8sgx4umqto/BeV2Db1ydqb3YLabvKwZGEOi7vImf/dyr5y1zFWKzFHS4dnjJ
+m9pm16A0XlUdP7Wfy7/kYd9vbkrjhe4rHDlnmAd3tLh7bnpB12BIr37Dpcy1+iE
dDfhlx/lJaiXbL3VqhdXXvCUVbX44NXHSW1J/QKVLbNNx2xDNwpoaFEHb2XQdZbj
oMu1LNvkvMH3FbN9Z7Yxy6KgVFNwL+GPdMPYOxbl/JKfm29M/u6ZWk5nklWkrOqR
zS9GFGHXgmM=
=4HYD
-----END PGP SIGNATURE-----




Information forwarded to debian-bugs-dist@lists.debian.org, Matthijs Mohlmann <matthijs@cacholong.nl>:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to "Wolfram Tomalla" <W.Tomalla@gmx.de>:
Extra info received and forwarded to list. Copy sent to Matthijs Mohlmann <matthijs@cacholong.nl>. (full text, mbox, link).


Message #53 received at 272864@bugs.debian.org (full text, mbox, reply):

From: "Wolfram Tomalla" <W.Tomalla@gmx.de>
To: "'Frank Lichtenheld'" <djpig@debian.org>, <272864@bugs.debian.org>
Cc: "'Fabio Massimo Di Nitto'" <fabbione@canonical.com>
Subject: AW: Bug#272864: raidtools2: Fix does not work if device is queried offline
Date: Fri, 12 Nov 2004 13:42:08 +0100
Hi Frank and Fabio,

I can test the patch. Will the package appear in sid, or do i have to build
it on my own? Or do you allready have a package for i386 an alpha? (Yes I
can test both architectures) Or can you send me a source package?

CU

Wolfram

-----Ursprüngliche Nachricht-----
Von: Frank Lichtenheld [mailto:frank@lichtenheld.de] Im Auftrag von Frank
Lichtenheld
Gesendet: Donnerstag, 11. November 2004 23:30
An: Wolfram Tomalla; 272864@bugs.debian.org
Cc: Fabio Massimo Di Nitto
Betreff: Re: Bug#272864: raidtools2: Fix does not work if device is queried
offline

tags 272864 patch
thanks

[CCed Fabio who provided the original patch]

On Mon, Oct 25, 2004 at 11:54:24AM +0200, Wolfram Tomalla wrote:
> The fix works fine als long as the array is queried online.
> However if it is queried offline the display of parity-algorithm is 
> skipped.

This is because two separate (but similar) functions are used to output the
information for online respective offline arrays. One can nearly copy the
patch by Fabio for the second function.

Attached is a try to do this. As I have no raid array available (at least
none that I'm willing to take offline ;) I can't really test it.
I attached both the patch against the raidtools package and the plain
modified dpatch.

(of course it would be better to move some of the code to a third function
which can then be called from both...)

Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/





Information forwarded to debian-bugs-dist@lists.debian.org:
Bug#272864; Package raidtools2. (full text, mbox, link).


Acknowledgement sent to Matthijs Mohlmann <matthijs@cacholong.nl>:
Extra info received and forwarded to list. (full text, mbox, link).


Message #58 received at 272864@bugs.debian.org (full text, mbox, reply):

From: Matthijs Mohlmann <matthijs@cacholong.nl>
To: Wolfram Tomalla <W.Tomalla@gmx.de>, 272864@bugs.debian.org
Subject: Re: Bug#272864: AW: Bug#272864: raidtools2: Fix does not work if device is queried offline
Date: Fri, 12 Nov 2004 15:20:49 +0100
On Fri, 2004-11-12 at 13:42 +0100, Wolfram Tomalla wrote:
> Hi Frank and Fabio,
> 
> I can test the patch. Will the package appear in sid, or do i have to build
> it on my own? Or do you allready have a package for i386 an alpha? (Yes I
> can test both architectures) Or can you send me a source package?
> 
> CU
> 
> Wolfram

Can you do it yourself ?

Thanks,

-- 
Matthijs Mohlmann <matthijs@cacholong.nl>




Reply sent to Matthijs Mohlmann <matthijs@cacholong.nl>:
You have taken responsibility. (full text, mbox, link).


Notification sent to Wolfram Tomalla <w.tomalla@gmx.de>:
Bug acknowledged by developer. (full text, mbox, link).


Message #63 received at 272864-close@bugs.debian.org (full text, mbox, reply):

From: Matthijs Mohlmann <matthijs@cacholong.nl>
To: 272864-close@bugs.debian.org
Subject: Bug#272864: fixed in raidtools2 1.00.3-17
Date: Mon, 15 Nov 2004 08:32:06 -0500
Source: raidtools2
Source-Version: 1.00.3-17

We believe that the bug you reported is fixed in the latest version of
raidtools2, which is due to be installed in the Debian FTP archive:

raidtools2-udeb_1.00.3-17_i386.udeb
  to pool/main/r/raidtools2/raidtools2-udeb_1.00.3-17_i386.udeb
raidtools2_1.00.3-17.diff.gz
  to pool/main/r/raidtools2/raidtools2_1.00.3-17.diff.gz
raidtools2_1.00.3-17.dsc
  to pool/main/r/raidtools2/raidtools2_1.00.3-17.dsc
raidtools2_1.00.3-17_i386.deb
  to pool/main/r/raidtools2/raidtools2_1.00.3-17_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 272864@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthijs Mohlmann <matthijs@cacholong.nl> (supplier of updated raidtools2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 11 Nov 2004 23:09:47 +0100
Source: raidtools2
Binary: raidtools2-udeb raidtools2
Architecture: source i386
Version: 1.00.3-17
Distribution: unstable
Urgency: low
Maintainer: Matthijs Mohlmann <matthijs@cacholong.nl>
Changed-By: Matthijs Mohlmann <matthijs@cacholong.nl>
Description: 
 raidtools2 - Utilities to support 'new-style' RAID disks
 raidtools2-udeb - Utilities to support 'new-style' RAID disks (udeb) (udeb)
Closes: 272864
Changes: 
 raidtools2 (1.00.3-17) unstable; urgency=low
 .
   * Admend patch by Fabio M. Di Nitto so that the same
     information is output if the array is offline, too
     (Closes: #272864).  Thanks, Frank Lichtenheld.
   *  Fix the description of the dpatch while I'm at it.
Files: 
 94472a9fe8d853f17a4d805767042a7c 656 admin extra raidtools2_1.00.3-17.dsc
 60e120c252b34e287a8bc88ce7668b0d 99709 admin extra raidtools2_1.00.3-17.diff.gz
 f46a3c779d54386ae4771362163fecd0 265254 admin optional raidtools2_1.00.3-17_i386.deb
 e88c14a866e1b1d8ac03129fe4dd4d3c 147878 debian-installer extra raidtools2-udeb_1.00.3-17_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBmK2pKb5dImj9VJ8RAh0AAJ9oFlmofYNwFijIfrCerezJuV8iXQCfb2Vz
KDecbP0SRhfJ4rqlGWMPha4=
=VtbB
-----END PGP SIGNATURE-----




Bug unarchived. Request was from Stefano Zacchiroli <zack@debian.org> to control@bugs.debian.org. (Sun, 10 Apr 2011 08:44:05 GMT) (full text, mbox, link).


Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Mon, 09 May 2011 07:45:17 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed Oct 11 12:08:03 2017; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.