Debian Bug report logs - #259733
lvm2 - uses internal kernel header

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Bastian Blank <waldi@debian.org>

To: submit@bugs.debian.org

Subject: lvm2 - uses internal kernel header

Date: Fri, 16 Jul 2004 15:02:43 +0200

[Message part 1 (text/plain, inline)]

Package: lvm2
Version: 2.00.19-2
Severity: grave

lvm2 uses a internal kernel header, asm/byteorder.h. This makes the lvm2
metadata format unusable on s390, as the headers are not correct,
exactly: __cpu_to_le64 is broken.

DON'T raise this issue to linux-kernel-headers, including this headers
in userspace programs is a no-no.

Bastian

-- 
No one can guarantee the actions of another.
		-- Spock, "Day of the Dove", stardate unknown

[signature.asc (application/pgp-signature, inline)]

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Patrick Caulfield <patrick@debian.org>

To: Bastian Blank <waldi@debian.org>, 259733@bugs.debian.org

Cc: submit@bugs.debian.org

Subject: Re: Bug#259733: lvm2 - uses internal kernel header

Date: Fri, 16 Jul 2004 16:13:43 +0100

On Fri, Jul 16, 2004 at 03:02:43PM +0200, Bastian Blank wrote:
> Package: lvm2
> Version: 2.00.19-2
> Severity: grave
> 
> lvm2 uses a internal kernel header, asm/byteorder.h. This makes the lvm2
> metadata format unusable on s390, as the headers are not correct,
> exactly: __cpu_to_le64 is broken.
> 
> DON'T raise this issue to linux-kernel-headers, including this headers
> in userspace programs is a no-no.
> 

So lets get this straight.

lvm is using a package that's installed on the system but that no-one is allowed
to use. And this package has a bug in it that no-one is allowed to report.

Is that correct ?

-- 

patrick

Message #20 received at 259733@bugs.debian.org (full text, mbox, reply):

From: Matt Zimmerman <mdz@debian.org>

To: 259733@bugs.debian.org

Subject: Re: Bug#259733: lvm2 - uses internal kernel header

Date: Fri, 16 Jul 2004 10:56:43 -0700

tags 259733 patch
thanks

The kernel headers are present for glibc's use.  lvm2 should not include
them.  The fact that it does is a bug.

If there is a problem with the kernel headers which only affects a userland
program trying to include them, then that is not a bug in
linux-kernel-headers, since they are being used incorrectly.

Here's a patch:

http://www.no-name-yet.com/patches/lvm2.259733.diff

-- 
 - mdz

Message #27 received at 259733@bugs.debian.org (full text, mbox, reply):

From: Bastian Blank <waldi@debian.org>

To: Patrick Caulfield <patrick@debian.org>

Cc: 259733@bugs.debian.org

Subject: Re: Bug#259733: lvm2 - uses internal kernel header

Date: Sat, 17 Jul 2004 14:19:49 +0200

[Message part 1 (text/plain, inline)]

On Fri, Jul 16, 2004 at 08:02:22PM +0100, Patrick Caulfield wrote:
> Could I ask you to try Matt's patch (I knew he'd respond, if I rattled his cage
> hard enough!) please. And also see if it fixes the other s390-related LVM bugs
> you have outstanding in the BTS.

I attached a patch which uses the optimized routines provided by
byteswap.h. It seems to fix any of the remaining issues.

Another problem: names which begins with an underscore and a capital
letter are reserved for the implementation. Many of the includes defines
a name which begins with "_LVM_".

Bastian

-- 
I'm a soldier, not a diplomat.  I can only tell the truth.
		-- Kirk, "Errand of Mercy", stardate 3198.9

[diff (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 259733@bugs.debian.org (full text, mbox, reply):

From: Patrick Caulfield <patrick@debian.org>

To: Bastian Blank <waldi@debian.org>, 259733@bugs.debian.org

Subject: Re: Bug#259733: lvm2 - uses internal kernel header

Date: Sat, 17 Jul 2004 15:24:00 +0100

On Sat, Jul 17, 2004 at 02:19:49PM +0200, Bastian Blank wrote:
> On Fri, Jul 16, 2004 at 08:02:22PM +0100, Patrick Caulfield wrote:
> > Could I ask you to try Matt's patch (I knew he'd respond, if I rattled his cage
> > hard enough!) please. And also see if it fixes the other s390-related LVM bugs
> > you have outstanding in the BTS.
> 
> I attached a patch which uses the optimized routines provided by
> byteswap.h. It seems to fix any of the remaining issues.

That's great thanks a lot. I'll see what I can get pushed upstream, though
Alasdair is away at OLS for a week now.

patrick

Message #37 received at 259733-close@bugs.debian.org (full text, mbox, reply):

From: Patrick Caulfield <patrick@debian.org>

To: 259733-close@bugs.debian.org

Subject: Bug#259733: fixed in lvm2 2.00.19-3

Date: Mon, 02 Aug 2004 07:47:27 -0400

Source: lvm2
Source-Version: 2.00.19-3

We believe that the bug you reported is fixed in the latest version of
lvm2, which is due to be installed in the Debian FTP archive:

lvm2-udeb_2.00.19-3_i386.udeb
  to pool/main/l/lvm2/lvm2-udeb_2.00.19-3_i386.udeb
lvm2_2.00.19-3.diff.gz
  to pool/main/l/lvm2/lvm2_2.00.19-3.diff.gz
lvm2_2.00.19-3.dsc
  to pool/main/l/lvm2/lvm2_2.00.19-3.dsc
lvm2_2.00.19-3_i386.deb
  to pool/main/l/lvm2/lvm2_2.00.19-3_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 259733@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Patrick Caulfield <patrick@debian.org> (supplier of updated lvm2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon,  2 Aug 2004 11:37:15 +0100
Source: lvm2
Binary: lvm2-udeb lvm2
Architecture: source i386
Version: 2.00.19-3
Distribution: unstable
Urgency: low
Maintainer: Patrick Caulfield <patrick@debian.org>
Changed-By: Patrick Caulfield <patrick@debian.org>
Description: 
 lvm2       - The Linux Logical Volume Manager
 lvm2-udeb  - The Linux Logical Volume Manager (udeb)
Closes: 259733 260700
Changes: 
 lvm2 (2.00.19-3) unstable; urgency=low
 .
   * Use libc byteswap functions.
     Closes: #259733
   * Add French debconfg translation
     Closes: #260700
Files: 
 7569b681d309e649cd88dc5631d29c50 658 admin optional lvm2_2.00.19-3.dsc
 d2847517f3f113fd3fc64d9c4ad49a6c 7941 admin optional lvm2_2.00.19-3.diff.gz
 7f0f4b583abfebc9a5f7cadf6e3cb667 243324 admin optional lvm2_2.00.19-3_i386.deb
 79da0f130993a0dc85ea73e6bd852244 192862 debian-installer optional lvm2-udeb_2.00.19-3_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBDhndhej7/PCycRMRAu+MAJsE3zZoSFUm0GLeRL+jXiLFVaKU0ACeLjme
AltUf1sXLRoJK1s0hTPH8vM=
=Crox
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.