Debian Bug report logs - #255078
wrong path for config files

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Marco d'Itri <md@Linux.IT>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: wrong path for config files

Date: Fri, 18 Jun 2004 19:04:03 +0200

Package: quagga
Version: 0.96.5-6
Severity: grave

Config files are opened in the current directory:

ittrn01:/tmp#  strace -e open /usr/lib/quagga/zebra
[...]
open("zebra.conf", O_RDONLY)            = -1 ENOENT (No such file or directory)

-- 
ciao, |
Marco | [6831 arMZk/L9a/Y7g]

Message #10 received at 255078@bugs.debian.org (full text, mbox, reply):

From: Fabio Massimo Di Nitto <fabbione@fabbione.net>

To: 255078@bugs.debian.org

Cc: control@bugs.debian.org

Date: Mon, 5 Jul 2004 12:47:14 +0200 (CEST)

tag 255078 patch
stop

Hi,
	the following patch fix this bug forcing the default and system
config path to /etc/quagga/.

At the same time the patch avoid an unnecessary lookup in the filesystem
for ./

http://we.give.back.to.debian.even.if.we.have.no-name-yet.com/patches/quagga.255078.diff

Thanks
Fabio

-- 
<user> fajita: step one
<fajita> Whatever the problem, step one is always to look in the error log.
<user> fajita: step two
<fajita> When in danger or in doubt, step two is to scream and shout.

Message #17 received at 255078@bugs.debian.org (full text, mbox, reply):

From: Christian Hammers <ch@debian.org>

To: Fabio Massimo Di Nitto <fabbione@fabbione.net>, 255078@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#255078: (no subject)

Date: Thu, 8 Jul 2004 22:23:56 +0200

[Message part 1 (text/plain, inline)]

tag 255078 + patch
thanks

Hello Fabio

On 2004-07-05 Fabio Massimo Di Nitto wrote:
> tag 255078 patch
A "+" is missing here.

I reported your request to the Quagga but tracking system and currently fixed 
this by doing a "cd /etc/quagga" in the init script. I added the URL to your
patch to the bug report.

bye,

-chritian-

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 255078@bugs.debian.org (full text, mbox, reply):

From: Fabio Massimo Di Nitto <fabbione@fabbione.net>

To: Christian Hammers <ch@debian.org>

Cc: 255078@bugs.debian.org

Subject: Re: Bug#255078: (no subject)

Date: Thu, 8 Jul 2004 22:30:01 +0200 (CEST)

On Thu, 8 Jul 2004, Christian Hammers wrote:

> tag 255078 + patch
> thanks
>
> Hello Fabio
>
> On 2004-07-05 Fabio Massimo Di Nitto wrote:
> > tag 255078 patch
> A "+" is missing here.
>
> I reported your request to the Quagga but tracking system and currently fixed
> this by doing a "cd /etc/quagga" in the init script. I added the URL to your
> patch to the bug report.
>

No, the cd in the init script is not enough to avoid a ./ lookup. An admin
can still run /usr/lib/quagga/* manually without using the init script.

Actually i don't see any reason for upstream to do that lookup but that's
only my opinion.

Fabio

-- 
<user> fajita: step one
<fajita> Whatever the problem, step one is always to look in the error log.
<user> fajita: step two
<fajita> When in danger or in doubt, step two is to scream and shout.

Message #31 received at 255078@bugs.debian.org (full text, mbox, reply):

From: Matt Zimmerman <mdz@debian.org>

To: Christian Hammers <ch@debian.org>, 255078@bugs.debian.org

Subject: Re: Bug#255078: (no subject)

Date: Thu, 8 Jul 2004 14:03:08 -0700

On Thu, Jul 08, 2004 at 10:23:56PM +0200, Christian Hammers wrote:

> Hello Fabio
> 
> On 2004-07-05 Fabio Massimo Di Nitto wrote:
> > tag 255078 patch
> A "+" is missing here.

The "+" is optional; Fabio's command worked fine:

Tags added: patch Request was from Fabio Massimo Di Nitto
<fabbione@fabbione.net> to control@bugs.debian.org. Full text available.

-- 
 - mdz

Message #36 received at 255078@bugs.debian.org (full text, mbox, reply):

From: Jochen Friedrich <jochen@scram.de>

To: Fabio Massimo Di Nitto <fabbione@fabbione.net>, 255078@bugs.debian.org

Cc: Christian Hammers <ch@debian.org>

Subject: Re: Bug#255078: (no subject)

Date: Thu, 8 Jul 2004 23:16:45 +0200 (CEST)

Hi Fabio,

> Actually i don't see any reason for upstream to do that lookup but that's
> only my opinion.

Obviously, upstream is the same opinion, as well. At least Hasso Tapper
is :-)

Thanks,
Jochen

------------------------------------------------------------------------------
Date: Sun, 20 Jun 2004 09:46:07 +0300
From: Hasso Tepper <hasso@estpak.ee>
To: quagga-dev@lists.quagga.net
Subject: [quagga-dev 1298] Some patches

Pending patches section in http://hasso.linux.ee/quagga/patches.en.php
contains two patches I'd like to commit if noone objects.

First removes HAVE_NSSA ifdef's. There is no need for them IMHO, nssa
is stable already.

Second one removes code which looked at current directory for config
file. There is really no need for that (we have -f) and it might be
very confusing.


-- 
Hasso Tepper
Elion Enterprises Ltd.
WAN administrator
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
http://lists.quagga.net/mailman/listinfo/quagga-dev

Message #41 received at 255078@bugs.debian.org (full text, mbox, reply):

From: Fabio Massimo Di Nitto <fabbione@fabbione.net>

To: Jochen Friedrich <jochen@scram.de>

Cc: 255078@bugs.debian.org, Christian Hammers <ch@debian.org>, Hasso Tepper <hasso@estpak.ee>

Subject: Re: Bug#255078: (no subject)

Date: Fri, 9 Jul 2004 06:39:44 +0200 (CEST)

Hey Jochen and Hasso,

This is good also because i can smell some possible security issues in
doing an arbitrary lookup in ./.

Thanks
Fabio

On Thu, 8 Jul 2004, Jochen Friedrich wrote:

> Hi Fabio,
>
> > Actually i don't see any reason for upstream to do that lookup but that's
> > only my opinion.
>
> Obviously, upstream is the same opinion, as well. At least Hasso Tapper
> is :-)
>
> Thanks,
> Jochen
>
> ------------------------------------------------------------------------------
> Date: Sun, 20 Jun 2004 09:46:07 +0300
> From: Hasso Tepper <hasso@estpak.ee>
> To: quagga-dev@lists.quagga.net
> Subject: [quagga-dev 1298] Some patches
>
> Pending patches section in http://hasso.linux.ee/quagga/patches.en.php
> contains two patches I'd like to commit if noone objects.
>
> First removes HAVE_NSSA ifdef's. There is no need for them IMHO, nssa
> is stable already.
>
> Second one removes code which looked at current directory for config
> file. There is really no need for that (we have -f) and it might be
> very confusing.
>
>
>

-- 
<user> fajita: step one
<fajita> Whatever the problem, step one is always to look in the error log.
<user> fajita: step two
<fajita> When in danger or in doubt, step two is to scream and shout.

Message #46 received at 255078-close@bugs.debian.org (full text, mbox, reply):

From: Christian Hammers <ch@debian.org>

To: 255078-close@bugs.debian.org

Subject: Bug#255078: fixed in quagga 0.96.5-7

Date: Thu, 15 Jul 2004 15:48:51 -0400

Source: quagga
Source-Version: 0.96.5-7

We believe that the bug you reported is fixed in the latest version of
quagga, which is due to be installed in the Debian FTP archive:

quagga-doc_0.96.5-7_all.deb
  to pool/main/q/quagga/quagga-doc_0.96.5-7_all.deb
quagga_0.96.5-7.diff.gz
  to pool/main/q/quagga/quagga_0.96.5-7.diff.gz
quagga_0.96.5-7.dsc
  to pool/main/q/quagga/quagga_0.96.5-7.dsc
quagga_0.96.5-7_i386.deb
  to pool/main/q/quagga/quagga_0.96.5-7_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 255078@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Hammers <ch@debian.org> (supplier of updated quagga package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu,  8 Jul 2004 21:53:21 +0200
Source: quagga
Binary: quagga quagga-doc
Architecture: source i386 all
Version: 0.96.5-7
Distribution: unstable
Urgency: low
Maintainer: Christian Hammers <ch@debian.org>
Changed-By: Christian Hammers <ch@debian.org>
Description: 
 quagga     - Unoff. successor of the Zebra BGP/OSPF/RIP routing daemon
 quagga-doc - Documentation files for quagga
Closes: 252579 255078 257580
Changes: 
 quagga (0.96.5-7) unstable; urgency=low
 .
   * Added a "cd /etc/quagga/" to the init script as quagga tries to load
     the config file first from the current working dir and then from the
     config dir which could lead to confusion (thanks to Marco d'Itri).
     Closes: #255078
   * Removed warning regarding problems with the Debian kernels from
     README.Debian as they are no longer valid (thanks to Raphael Hertzog).
     Closes: #257580
   * Added patch from Hasso Tepper that makes "terminal length 0" work
     in vtysh (thanks to Matthias Wamser). Closes: #252579
Files: 
 9387b86b0f715ffd2d3bf8d171aea3d6 705 net optional quagga_0.96.5-7.dsc
 00068099af3e5fdd38a29844a1ae374b 111003 net optional quagga_0.96.5-7.diff.gz
 74bc027f1629992954894623e998ffc3 387872 net optional quagga-doc_0.96.5-7_all.deb
 313340c098bf466138defc5f1fd0bc8b 1793770 net optional quagga_0.96.5-7_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iEYEARECAAYFAkD23YEACgkQkR9K5oahGOadIwCg4PssJeKVcnQZzEt0+MWUXUaz
lG4AnilzH0cK63/Ss1Z8I9OoIMgcYRNr
=HwDs
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.