Debian Bug report logs - #247538
sshd: logout not recorded in utmp

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Nicolas George <nicolas.george@ens.fr>

To: submit@bugs.debian.org

Cc: jriou@clipper.ens.fr, root@quatramaran.ens.fr

Subject: sshd: logout not recorded in utmp

Date: Wed, 5 May 2004 20:24:44 +0200

[Message part 1 (text/plain, inline)]

Package: ssh
Version: 1:3.8p1-3
Severity: important

When ssh creates a tty with a number greater than 999, it does not
remove it correctly from utmp. The problem is that ssh uses at one place
a 8-chars buffer while everywhere else it uses larger buffers: since
"pts/1234\0" is more than 8 chars long, it is truncated.

The problem shows probably on *very* loaded login servers, but it shows
also on 2.6.4+ kernels, where the tty numbers are never reused.

If the line

	char line[8];

in loginrec.c:1357 becomes

	char line[UT_LINESIZE];

that fixes the problem.

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 247538@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: Nicolas George <nicolas.george@ens.fr>, 247538@bugs.debian.org

Cc: jriou@clipper.ens.fr, root@quatramaran.ens.fr, control@bugs.debian.org

Subject: Re: Bug#247538: sshd: logout not recorded in utmp

Date: Wed, 5 May 2004 19:45:41 +0100

tags 247538 fixed-upstream
thanks

On Wed, May 05, 2004 at 08:24:44PM +0200, Nicolas George wrote:
> Package: ssh
> Version: 1:3.8p1-3
> Severity: important
> 
> When ssh creates a tty with a number greater than 999, it does not
> remove it correctly from utmp. The problem is that ssh uses at one place
> a 8-chars buffer while everywhere else it uses larger buffers: since
> "pts/1234\0" is more than 8 chars long, it is truncated.
> 
> The problem shows probably on *very* loaded login servers, but it shows
> also on 2.6.4+ kernels, where the tty numbers are never reused.
> 
> If the line
> 
> 	char line[8];
> 
> in loginrec.c:1357 becomes
> 
> 	char line[UT_LINESIZE];
> 
> that fixes the problem.

This has been fixed in OpenSSH 3.8.1p1, which I'll be uploading to
unstable shortly.

Thanks,

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]

Message #19 received at 247538-close@bugs.debian.org (full text, mbox, reply):

From: Colin Watson <cjwatson@debian.org>

To: 247538-close@bugs.debian.org

Subject: Bug#247538: fixed in openssh 1:3.8.1p1-1

Date: Mon, 17 May 2004 02:03:40 -0400

Source: openssh
Source-Version: 1:3.8.1p1-1

We believe that the bug you reported is fixed in the latest version of
openssh, which is due to be installed in the Debian FTP archive:

openssh-client-udeb_3.8.1p1-1_powerpc.udeb
  to pool/main/o/openssh/openssh-client-udeb_3.8.1p1-1_powerpc.udeb
openssh-server-udeb_3.8.1p1-1_powerpc.udeb
  to pool/main/o/openssh/openssh-server-udeb_3.8.1p1-1_powerpc.udeb
openssh_3.8.1p1-1.diff.gz
  to pool/main/o/openssh/openssh_3.8.1p1-1.diff.gz
openssh_3.8.1p1-1.dsc
  to pool/main/o/openssh/openssh_3.8.1p1-1.dsc
openssh_3.8.1p1.orig.tar.gz
  to pool/main/o/openssh/openssh_3.8.1p1.orig.tar.gz
ssh_3.8.1p1-1_powerpc.deb
  to pool/main/o/openssh/ssh_3.8.1p1-1_powerpc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 247538@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated openssh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Tue, 11 May 2004 23:38:10 +0100
Source: openssh
Binary: ssh-askpass-gnome openssh-client-udeb ssh openssh-server-udeb
Architecture: source powerpc
Version: 1:3.8.1p1-1
Distribution: unstable
Urgency: low
Maintainer: Matthew Vernon <matthew@debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description: 
 openssh-client-udeb - Secure shell client for the Debian installer (udeb)
 openssh-server-udeb - Secure shell server for the Debian installer (udeb)
 ssh        - Secure rlogin/rsh/rcp replacement (OpenSSH)
Closes: 211640 232333 238753 242808 244829 246068 247538
Changes: 
 openssh (1:3.8.1p1-1) unstable; urgency=low
 .
   * New upstream release.
     - Use a longer buffer for tty names in utmp (closes: #247538).
   * Make sure there's a newline at the end of sshd_config before adding
     'UsePAM yes' (closes: #244829).
   * Generate a new .orig.tar.gz without RFC.nroff, and remove
     /usr/share/doc/ssh/RFC.gz (closes: #211640). It isn't DFSG-free and only
     documents the obsolete SSH1 protocol, not to mention that it was never a
     real RFC but only an Internet-Draft. It's available from
     http://www.free.lp.se/bamse/draft-ylonen-ssh-protocol-00.txt if you want
     it for some reason.
   * Add openssh-client-udeb and openssh-server-udeb binary packages for use
     in debian-installer. They still need libnss_files to be supplied in udeb
     form by glibc.
   * Work around lack of res_query weak alias in libresolv on amd64 (see
     #242462, awaiting real fix upstream).
   * Fix grammar in sshd(8) (closes: #238753).
   * Add .desktop file and icon for ssh-askpass-gnome (closes: #232333).
   * Update Polish debconf template translation (thanks, Emil Nowak;
     closes: #242808).
   * Add Turkish debconf template translation (thanks, Recai Oktaş;
     closes: #246068).
Files: 
 48e979343fe79fdddcce81a877b7113f 890 net standard openssh_3.8.1p1-1.dsc
 9ce6f2fa5b2931ce2c4c25f3af9ad50d 795948 net standard openssh_3.8.1p1.orig.tar.gz
 79f711efd181e7f6a67925ecc406cabe 139831 net standard openssh_3.8.1p1-1.diff.gz
 3984248fed7479a4bf15f8776dad3f75 728470 net standard ssh_3.8.1p1-1_powerpc.deb
 5c26dc3f63f3b174608e9080069e1cf6 100740 debian-installer optional openssh-client-udeb_3.8.1p1-1_powerpc.udeb
 481d209ae63d29cf32a7630140775786 120712 debian-installer optional openssh-server-udeb_3.8.1p1-1_powerpc.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iD8DBQFAoWRb9t0zAhD6TNERAnMiAJ94XBkqt8SReHjhwfIzPsawQUhiMgCdGUzK
vWUuAKi6g37QFrBzXlNOKaM=
=Qits
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.