Debian Bug report logs - #246040
findutils: find -printf %H segfaults

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Timo Lindfors <lindi@kurp.hut.fi>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: findutils: find -printf %H segfaults

Date: Tue, 27 Apr 2004 01:05:52 +0300

Package: findutils
Version: 4.1.20-3
Severity: normal

$ find . -printf %H
.
$ find -printf %H
Segmentation fault (core dumped)

[ Next I did apt-get --build source findutils without stripping
  debugging symbols and used
  deb-src http://ftp.fi.debian.org/debian unstable main 
  in sources.list. ]

$ gdb find core
GNU gdb 2002-04-01-cvs
Copyright 2002 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i386-linux"...
Core was generated by `find -printf %H'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /lib/libc.so.6...done.
Loaded symbols for /lib/libc.so.6
Reading symbols from /lib/ld-linux.so.2...done.
Loaded symbols for /lib/ld-linux.so.2
#0  0x0804df22 in pred_fprintf (pathname=0x8054520 ".", stat_buf=0xbffff9cc, pred_ptr=0x80577d0) at pred.c:612
612                 pathname[path_length] = '\0';
(gdb) bt
#0  0x0804df22 in pred_fprintf (pathname=0x8054520 ".", stat_buf=0xbffff9cc, pred_ptr=0x80577d0) at pred.c:612
#1  0x0804d4e6 in pred_and (pathname=0x8054520 ".", stat_buf=0xbffff9cc, pred_ptr=0x8057790) at pred.c:287
#2  0x0804a15b in process_path (pathname=0x8054520 ".", name=0x8054520 ".", leaf=0, parent=0x8054520 ".") at find.c:446
#3  0x08049ed8 in process_top_path (pathname=0x8054520 ".") at find.c:346
#4  0x08049c46 in main (argc=3, argv=0xbffffbc4) at find.c:288
(gdb)

[ from find.c ]

/* If no paths are given, default to ".".  */
  for (i = 1; i < argc && strchr ("-!(),", argv[i][0]) == NULL; i++)
    process_top_path (argv[i]);
  if (i == 1)
    process_top_path (".");

It seems that some parts of pred.c assume that what initially was
given as an argument to process_top_path() can be modified.  This
works if process_top_path is given a pointer to argv but segfaults in
the default "." case.

The following patch fixes the problem for me.

diff -ur debian-findutils/findutils-4.1.20/find/find.c debian-findutils.new/findutils-4.1.20/find/find.c
--- debian-findutils/findutils-4.1.20/find/find.c       Sat May 24 21:36:25 2003
+++ debian-findutils.new/findutils-4.1.20/find/find.c   Thu Apr 22 11:18:14 2004
@@ -285,7 +285,7 @@
   for (i = 1; i < argc && strchr ("-!(),", argv[i][0]) == NULL; i++)
     process_top_path (argv[i]);
   if (i == 1)
-    process_top_path (".");
+    process_top_path (xstrdup("."));

   exit (exit_status);
 }

best regards,
Timo Lindfors

-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux kurp 2.4.18-1-386 #1 Wed Apr 14 17:34:59 UTC 2004 i686
Locale: LANG=C

Versions of packages findutils depends on:
ii  libc6                         2.2.5-11.5 GNU C Library: Shared libraries an

Message #10 received at 246040@bugs.debian.org (full text, mbox, reply):

From: James Youngman <jay@gnu.org>

To: 246040@bugs.debian.org

Subject: fixed upstream

Date: Sun, 31 Oct 2004 13:24:05 +0000

This bug is fixed upstream, in a slightly different way (without using
xstrdup).

James.

Message #21 received at 246040-close@bugs.debian.org (full text, mbox, reply):

From: Andreas Metzler <ametzler@debian.org>

To: 246040-close@bugs.debian.org

Subject: Bug#246040: fixed in findutils 4.2.20-2

Date: Thu, 09 Jun 2005 14:32:18 -0400

Source: findutils
Source-Version: 4.2.20-2

We believe that the bug you reported is fixed in the latest version of
findutils, which is due to be installed in the Debian FTP archive:

findutils_4.2.20-2.diff.gz
  to pool/main/f/findutils/findutils_4.2.20-2.diff.gz
findutils_4.2.20-2.dsc
  to pool/main/f/findutils/findutils_4.2.20-2.dsc
findutils_4.2.20-2_i386.deb
  to pool/main/f/findutils/findutils_4.2.20-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 246040@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andreas Metzler <ametzler@debian.org> (supplier of updated findutils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu,  9 Jun 2005 20:07:37 +0200
Source: findutils
Binary: findutils
Architecture: source i386
Version: 4.2.20-2
Distribution: unstable
Urgency: low
Maintainer: Andreas Metzler <ametzler@debian.org>
Changed-By: Andreas Metzler <ametzler@debian.org>
Description: 
 findutils  - utilities for finding files--find, xargs, and locate
Closes: 5956 31858 67782 102914 111143 111578 159221 162838 169730 175372 176201 185202 185203 192330 202512 219855 244766 246040 254676 256367 260780 261598 262476 286977 295399 300323 300429 300631
Changes: 
 findutils (4.2.20-2) unstable; urgency=low
 .
   * Upload to unstable.
 .
 findutils (4.2.20-1) experimental; urgency=low
 .
   * [locate] Do not index cifs (Closes: #295399) lustre (Closes: #300323) and
     nfs4 (Closes: #300631) filesystems by default.
   * [locate] Ignore /media by default. (Closes: #300429)
   * New upstream version 4.2.20
     - includes up-to-date Italian translation. (Closes: #286977)
 .
 findutils (4.2.14-1) experimental; urgency=low
 .
   * New upstream version
     - includes patch to fix savannah #11495.
     - locate: New options  -L, --follow|-P, -H, --nofollow for ignoring
       dangling symlinks (or not). (Closes: #159221)
     - find supports -exec ... {} +.
     - locate support for FreeBSD options (Sclms, m and s are ignored, but
       undocumented, I've already opened upstream report #11730 on that.)
       (Closes: #102914)
     - find built with --enable-d_type-optimisation, for using
       readdir/getdents. (Closes: #202512)
 .
 findutils (4.2.11-2) experimental; urgency=low
 .
   * find -printf '%n' (hard link count) was broken (savannah #11495).
 .
 findutils (4.2.11-1) experimental; urgency=low
 .
   * New upstream version.
 .
 findutils (4.2.10.CVS20041219-1) experimental; urgency=low
 .
   * New upstream, CVS from CVS20041219 (pre- 4.2.11).
     * -printf '%P' works correctly again.
   * Run testsuite.
 .
 findutils (4.2.9-1) experimental; urgency=low
 .
   * New upstream source
 .
 findutils (4.2.8-1) experimental; urgency=low
 .
   * New upstream version
     - New option --arg-file=file and extended documentation about
       stdin-handling (short in manpage, more extensive in info).
       (Closes: #5956)
     - improved behavior on automounted directories.
 .
 findutils (4.2.5-1) experimental; urgency=low
 .
   * New upstream version
     - includes 25_destdir_localstatedir.dpatch, our last remaining patch, we
       are vanilla now.
   * Add minimal debian/README.source.
   * Chuan-kai Lin <cklin@debian.org> has offered to serve as backup
     maintainer. Thanks. Add him to Uploaders.
 .
 findutils (4.2.4-1) experimental; urgency=low
 .
   * New upstream version
     - Closes: #175372: findutils: man pages have L's on references
     - includes 10_updatedb-findopts patch.
     - does not print warning about listing options after non-options unless
       connected to a tty.
     - xargs now uses 128Kb instead of 20Kb of command line by default, as
       ARG_MAX is 131072 on linux this Closes: #261598.
 .
 findutils (4.2.3.CVS20041106-1) experimental; urgency=low
 .
   * New upstream version (pre-4.2.4, CVS 2004-11-06).
     - Closes: #176201: findutils: xargs enviroment size limited to 20k
     - Closes: #254676: xargs: environment is too large for exec
     - Closes: #219855: -printf: accepts C octal escapes, contrary to the
       documentation.
     - Closes: #246040: findutils: find -printf %H segfaults
     - Closes: #185202: findutils: extra ")" not caught
     - Closes: #185203: findutils: overflow causes -mtime to succeed
     - Closes: #244766: /usr/bin/locate: locate should have equivalent of
       -print0 option
     - documents type of supported regular expressions for -regex
       (Closes: #162838)
     - Closes: #256367: Deprecated usage of trap in locate/updatedb.sh
     - includes some examples in find.1 manpage. (Closes: #111578)
     - new option -ignore_readdir_race to selectively suppress the obnoxious
       race-condition caused errormessages. (Closes: #67782)
     - -print0/-0 issues explained in more detail. (Closes: #111143)
     - includes supplied patch for GNU/FreeBSD. (Closes: #192330)
     - updatedb invokes "cd /" before running commands as unprivileged user.
       (Closes: #262476)
     - 'xargs -n 1 -i' works. (Closes: #31858). Please note that it is no bug
       that -i changes xargs to pass a whole line of input as a single argument
       instead of splitting on any blank characters as without -i. - Other
       implementations behave the same and the -I XSI extension documented in
       SUSv3/POSIX works like this, too.
 .
    * Removed unnecessary patches: 10_missing_includes 20_missing_newlines
      30_locate_nologinsh 35_updatedb-location 36_savannah-8623 40_direntry
      50_install_info
   * Add shfs to PRUNFS (Closes: #260780)
   * New patch: 10_updatedb-findopts: Add --findoptions option to updatedb to
     pass global options to find.
   * Set FINDOPTIONS='-ignore_readdir_race' for updatedb.sh's cron-job.
     (Closes: #169730)
   * standards-version 3.6.1 (no changes required).
Files: 
 d8131ceadf2d1c15b52622c533021e9f 663 base required findutils_4.2.20-2.dsc
 3be936480966e5d4c165047efe0f0b4b 12033 base required findutils_4.2.20-2.diff.gz
 652a8b1a819cacd6fff1cc0033a11032 306194 base required findutils_4.2.20-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCqIguHTOcZYuNdmMRAiVzAJ9SXQUwkrX+XJpMXqozjAJW4b2/eQCfVmHn
9PgyJmTGtS+ww4AI2JuJi4o=
=fOpd
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.