Debian Bug report logs - #229932
Apply device-mapper patch

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Christophe Boyanique <debian+bug@raceme.org>

To: "mailto:submit"@bugs.debian.org

Subject: Apply device-mapper patch

Date: Tue, 27 Jan 2004 16:35:47 +0100

Package: lilo
Version: 22.5.8-8

The device-mapper patch available at http://www.saout.de/misc/ will let
lilo understand device-mapper block devices (LVM2 and EVMS).

Application of this path in the current 22.5.8-8 is trivial:

- grab the patch (http://www.saout.de/misc/lilo-22.5.8-devmapper.patch)
- insert it in the debian/patches directory
- add it at the end of the debian/patches/00list file
- add a build dependency to libdevmapper-dev

My own package can be found at
http://khemmis.raceme.org/tof/lilo-devmapper/

See file lilo_22.5.8-8_22.5.8-8.0devmapper.patch for differences between
orig and patched package.

-- 
Christophe.

Message #14 received at 229932@bugs.debian.org (full text, mbox, reply):

From: Andrés Roldán <aroldan@debian.org>

To: Christophe Boyanique <debian+bug@raceme.org>

Cc: 229932@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#229932: Apply device-mapper patch

Date: Tue, 27 Jan 2004 11:34:32 -0500

[Message part 1 (text/plain, inline)]

severity 229932 wishlist
tag 229932 patch pending
thanks

I will test this patch and make some (cosmetic) changes
before make an upload.

Thanks.

Christophe Boyanique <debian+bug@raceme.org> writes:

> Package: lilo
> Version: 22.5.8-8
>
> The device-mapper patch available at http://www.saout.de/misc/ will let
> lilo understand device-mapper block devices (LVM2 and EVMS).
>
> Application of this path in the current 22.5.8-8 is trivial:
>
> - grab the patch (http://www.saout.de/misc/lilo-22.5.8-devmapper.patch)
> - insert it in the debian/patches directory
> - add it at the end of the debian/patches/00list file
> - add a build dependency to libdevmapper-dev
>
> My own package can be found at
> http://khemmis.raceme.org/tof/lilo-devmapper/
>
> See file lilo_22.5.8-8_22.5.8-8.0devmapper.patch for differences between
> orig and patched package.
>
> -- 
> Christophe.
>

-- 
Andrés Roldán <aroldan@debian.org>
GPG Key-ID: 0xB29396EB
http://people.fluidsignal.com/~aroldan

[Message part 2 (application/pgp-signature, inline)]

Message #23 received at 229932@bugs.debian.org (full text, mbox, reply):

From: Andrés Roldán <aroldan@debian.org>

To: Christophe Boyanique <debian+bug@raceme.org>

Cc: 229932@bugs.debian.org

Subject: Re: Bug#229932: Apply device-mapper patch

Date: Tue, 27 Jan 2004 18:58:27 -0500

[Message part 1 (text/plain, inline)]

How can I avoid the following:

aroldan@volatile:~$ sudo lilo
/dev/mapper/control: open failed: No such file or directory
Is device-mapper driver missing from kernel?
/dev/mapper/control: open failed: No such file or directory
Is device-mapper driver missing from kernel?
Incompatible libdevmapper 1.00.07-ioctl (2003-11-21)(compat) and kernel driver 
Added DEB 2.6.0 *
aroldan@volatile:~$ 

The error message is kind of cryptic for someone (me) who does not
use this feature.

I was thinking on something like:

if (verbose >= 2)
{
   print_that_cryptic_message ();
}

Christophe Boyanique <debian+bug@raceme.org> writes:

> Package: lilo
> Version: 22.5.8-8
>
> The device-mapper patch available at http://www.saout.de/misc/ will let
> lilo understand device-mapper block devices (LVM2 and EVMS).
>
> Application of this path in the current 22.5.8-8 is trivial:
>
> - grab the patch (http://www.saout.de/misc/lilo-22.5.8-devmapper.patch)
> - insert it in the debian/patches directory
> - add it at the end of the debian/patches/00list file
> - add a build dependency to libdevmapper-dev
>
> My own package can be found at
> http://khemmis.raceme.org/tof/lilo-devmapper/
>
> See file lilo_22.5.8-8_22.5.8-8.0devmapper.patch for differences between
> orig and patched package.
>
> -- 
> Christophe.
>

-- 
Andrés Roldán <aroldan@debian.org>
GPG Key-ID: 0xB29396EB
http://people.fluidsignal.com/~aroldan

[Message part 2 (application/pgp-signature, inline)]

Message #28 received at 229932@bugs.debian.org (full text, mbox, reply):

From: Matt Zimmerman <mdz@debian.org>

To: Andr?s Rold?n <aroldan@debian.org>, 229932@bugs.debian.org

Subject: Re: Bug#229932: Apply device-mapper patch

Date: Tue, 27 Jan 2004 17:42:18 -0800

On Tue, Jan 27, 2004 at 06:58:27PM -0500, Andr?s Rold?n wrote:

> How can I avoid the following:
> 
> aroldan@volatile:~$ sudo lilo
> /dev/mapper/control: open failed: No such file or directory
> Is device-mapper driver missing from kernel?
> /dev/mapper/control: open failed: No such file or directory
> Is device-mapper driver missing from kernel?
> Incompatible libdevmapper 1.00.07-ioctl (2003-11-21)(compat) and kernel driver 
> Added DEB 2.6.0 *
> aroldan@volatile:~$ 
> 
> The error message is kind of cryptic for someone (me) who does not
> use this feature.
> 
> I was thinking on something like:
> 
> if (verbose >= 2)
> {
>    print_that_cryptic_message ();
> }

Shouldn't it only print that message if it finds that it needs to query
devmapper to find the blocks?  In that case, it would be a fatal error, no?

-- 
 - mdz

Message #33 received at 229932@bugs.debian.org (full text, mbox, reply):

From: Christophe Boyanique <debian+bug@raceme.org>

To: 229932@bugs.debian.org

Subject: Re: Bug#229932: Apply device-mapper patch

Date: Wed, 28 Jan 2004 12:52:04 +0100

On Tue, Jan 27, 2004 at 06:58:27PM -0500, Andrés Roldán wrote:

> How can I avoid the following:
> 
> aroldan@volatile:~$ sudo lilo
> /dev/mapper/control: open failed: No such file or directory
> Is device-mapper driver missing from kernel?
> /dev/mapper/control: open failed: No such file or directory
> Is device-mapper driver missing from kernel?
> Incompatible libdevmapper 1.00.07-ioctl (2003-11-21)(compat) and kernel driver 
> Added DEB 2.6.0 *
> aroldan@volatile:~$ 

This is a problem I didn't see yesterday. In fact there is a small
design problem for the package: building with the patch adds a
dependency to libdevmapper1.00 package and optionnaly to the
device-mapper support in the kernel for using device-mapper devices but
this is obvious.

The message says that lilo can't access de device-mapper in your kernel
because it is not compiled in? It doesn't seem to be a fatal error as
the kernel image installs anyway but it is not very cosmetic.

> I was thinking on something like:
> 
> if (verbose >= 2)
> {
>    print_that_cryptic_message ();
> }

I think this is the solution as this is more a warning than an error;
and I suppose that lilo will fail if you try to install an image on a
device-mapper device (with something like that: Fatal: Sorry, don't know
how to handle device 0xfe00).

The only potential problem I see is the dependency to the
libdevmapper1.00 package for the lilo package. Is it ok for you ?

If it is not, is it possible to create a new package for a device-mapper
enabled lilo, for example a dmlilo one ?

-- 
Christophe.

Message #38 received at 229932@bugs.debian.org (full text, mbox, reply):

From: Andrés Roldán <aroldan@debian.org>

To: Matt Zimmerman <mdz@debian.org>

Cc: Christophe Boyanique <debian+bug@raceme.org>, 229932@bugs.debian.org

Subject: Re: Bug#229932: Apply device-mapper patch

Date: Wed, 28 Jan 2004 08:48:10 -0500

[Message part 1 (text/plain, inline)]

Matt Zimmerman <mdz@debian.org> writes:

> On Tue, Jan 27, 2004 at 06:58:27PM -0500, Andr?s Rold?n wrote:
>
>> How can I avoid the following:
>> 
>> aroldan@volatile:~$ sudo lilo
>> /dev/mapper/control: open failed: No such file or directory
>> Is device-mapper driver missing from kernel?
>> /dev/mapper/control: open failed: No such file or directory
>> Is device-mapper driver missing from kernel?
>> Incompatible libdevmapper 1.00.07-ioctl (2003-11-21)(compat) and kernel driver 
>> Added DEB 2.6.0 *
>> aroldan@volatile:~$ 
>> 
>> The error message is kind of cryptic for someone (me) who does not
>> use this feature.
>> 
>> I was thinking on something like:
>> 
>> if (verbose >= 2)
>> {
>>    print_that_cryptic_message ();
>> }
>
> Shouldn't it only print that message if it finds that it needs to query
> devmapper to find the blocks?  In that case, it would be a fatal error, no?

How could LILO check that?

This is a good enhance but I think this error message should be suppressed to
avoid confusion among the users that don't need this and should be clear enough
for the users that do use device-mapper.

Matt, what do you think about creating a separate package? As Christophe said,
there is a potential problem in the dependency to the libdevmapper1.00 package.

>
> -- 
>  - mdz

-- 
Andrés Roldán <aroldan@debian.org>
GPG Key-ID: 0xB29396EB
http://people.fluidsignal.com/~aroldan

[Message part 2 (application/pgp-signature, inline)]

Message #43 received at 229932@bugs.debian.org (full text, mbox, reply):

From: Matt Zimmerman <mdz@debian.org>

To: Andr?s Rold?n <aroldan@debian.org>

Cc: Christophe Boyanique <debian+bug@raceme.org>, 229932@bugs.debian.org

Subject: Re: Bug#229932: Apply device-mapper patch

Date: Wed, 28 Jan 2004 08:27:44 -0800

On Wed, Jan 28, 2004 at 08:48:10AM -0500, Andr?s Rold?n wrote:

> Matt Zimmerman <mdz@debian.org> writes:
> 
> > Shouldn't it only print that message if it finds that it needs to query
> > devmapper to find the blocks?  In that case, it would be a fatal error, no?
> 
> How could LILO check that?

stat() the file that it needs to map, and check st_dev against the major
number listed in /proc/devices for device-mapper.  Looking at the patch, it
seems it already uses this information.

> This is a good enhance but I think this error message should be suppressed
> to avoid confusion among the users that don't need this and should be
> clear enough for the users that do use device-mapper.

So at this time, that error message is displayed any time that
device-mapper is not usable, correct?  So if it is suppressed, and a user
who is expecting device-mapper to be used, what is the result?  Is there a
later error which is still meaningful?

> Matt, what do you think about creating a separate package? As Christophe
> said, there is a potential problem in the dependency to the
> libdevmapper1.00 package.

I think that a separate package is probably overkill.  I can think of a few
other solutions:

- statically link libdevmapper
- provide two binaries, one linked with libdevmapper, and one not (and
  suggest it)
- use dlopen(3)

Since device-mapper is in Linux 2.6.x, and so its use will become more and
more common (especially with boot loaders), probably at some point, the
library's priority will need to be raised, so perhaps the first solution
will result in the least changes.

-- 
 - mdz

Message #48 received at 229932-close@bugs.debian.org (full text, mbox, reply):

From: Andrés Roldán <aroldan@debian.org>

To: 229932-close@bugs.debian.org

Subject: Bug#229932: fixed in lilo 1:22.5.8-10

Date: Sun, 01 Feb 2004 16:32:17 -0500

Source: lilo
Source-Version: 1:22.5.8-10

We believe that the bug you reported is fixed in the latest version of
lilo, which is due to be installed in the Debian FTP archive:

lilo-doc_22.5.8-10_i386.deb
  to pool/main/l/lilo/lilo-doc_22.5.8-10_i386.deb
lilo_22.5.8-10.diff.gz
  to pool/main/l/lilo/lilo_22.5.8-10.diff.gz
lilo_22.5.8-10.dsc
  to pool/main/l/lilo/lilo_22.5.8-10.dsc
lilo_22.5.8-10_i386.deb
  to pool/main/l/lilo/lilo_22.5.8-10_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 229932@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrés Roldán <aroldan@debian.org> (supplier of updated lilo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun,  1 Feb 2004 20:06:59 +0000
Source: lilo
Binary: lilo-doc lilo
Architecture: source i386
Version: 1:22.5.8-10
Distribution: unstable
Urgency: low
Maintainer: Andrés Roldán <aroldan@debian.org>
Changed-By: Andrés Roldán <aroldan@debian.org>
Description: 
 lilo       - LInux LOader - The Classic OS loader can load Linux and others
 lilo-doc   - Documentation for LILO (LInux LOader)
Closes: 229932 230371 230632
Changes: 
 lilo (1:22.5.8-10) unstable; urgency=low
 .
   * Added patch to make lilo understand device-mapper block devices (LVM2 and
     EVMS). Thanks to Christophe Boyanique. (closes: #229932)
   * Build-Depends on libdevmapper1.00-dev.
   * Added simplifed chinese translation. Thanks to Carlos Z.F. Liu.
     (closes: #230371)
   * Make LILO compile with -DAUTOAUTO. (closes: #230632)
Files: 
 be1d34999a1b099cef04d6427c2e1b66 739 base important lilo_22.5.8-10.dsc
 4d3cfffea7c5f98f3cce9a0055f06228 131311 base important lilo_22.5.8-10.diff.gz
 140052d607a55ffac82dd82df43e6ba4 268444 base important lilo_22.5.8-10_i386.deb
 19916501beaa71ea3948daa4751ee61d 241882 doc optional lilo-doc_22.5.8-10_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAHVzU2OByS7KTlusRAqsNAJ428QhrH71xwVTBPnpwxzAYsd/VqQCg1WYt
YBK+7Gx5vs/hGTp1DYXSTps=
=YnUu
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.