Debian Bug report logs - #214086
greed: Really quit quits always

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Helge Kreutzmann <kreutzm@itp.uni-hannover.de>

To: submit@bugs.debian.org

Subject: greed: Really quit quits always

Date: Sat, 4 Oct 2003 16:24:07 +0200

[Message part 1 (text/plain, inline)]

Package: greed
Version: 3.4-1
Severity: normal

Pressing "q" in the game returns the question:
Really quit?
Independent of the key I press, the game quits however. This includes
"n" which I assumed to resume the game. 

-- System Information
Debian Release: testing/unstable
Architecture: alpha
Kernel: Linux sixtyfor 2.4.21-pre1 #1 Don Okt 2 18:27:25 CEST 2003 alpha
Locale: LANG=de_DE@euro, LC_CTYPE=de_DE@euro

Versions of packages greed depends on:
ii  libc6.1                  2.2.5-11.5      GNU C Library: Shared libraries an
ii  libncurses5              5.2.20020112a-7 Shared libraries for terminal hand
-- 
Helge Kreutzmann, Dipl.-Phys.               Helge.Kreutzmann@itp.uni-hannover.de
  gpg signed mail preferred    gpg-key: finger kreutzm@rigel.itp.uni-hannover.de
    64bit GNU powered                  http://www.itp.uni-hannover.de/~kreutzm
       Help keep free software "libre": http://www.freepatents.org/

[Message part 2 (application/pgp-signature, inline)]

Message #10 received at 214086@bugs.debian.org (full text, mbox, reply):

From: Helge Kreutzmann <kreutzm@itp.uni-hannover.de>

To: 214086@bugs.debian.org

Subject: Ping and fix

Date: Thu, 1 Apr 2004 10:56:33 +0200

[Message part 1 (text/plain, inline)]

Hello,
my bug is now almost 4 month old and I just checked -- I can reproduce
this on i386 as well. It would be great if you could have kept me up
to date on this bug (i.e. what you did to investigate, if you
contacted upstream, ...).

Anyhow, the following fixed the bug on my alpha under testing:

--- greed.c.orig	2002-07-31 00:03:43.000000000 +0200
+++ greed.c	2004-03-31 21:34:00.000000000 +0200
@@ -383,7 +383,7 @@
 		return (1);
 	case 'q': case 'Q':
 		quit();
-		return(-1);
+		return(1);
 	case '?':
 		help();
 		return (1);


It is surprisingly simple, so please double check if that works and is
the proper fix, i.e. that the "-" wasn't there on purpose.

Also I have seen some (but probably unrelated) 64bit problems when
compiling greed on my alpha:

http://buildd.debian.org/fetch.php?&pkg=greed&ver=3.4-1&arch=alpha&stamp=1062950101&file=log&as=raw

search for "cast". Should I put this as a seperate wishlist report?

Greetings

          Helge
-- 
Helge Kreutzmann, Dipl.-Phys.               Helge.Kreutzmann@itp.uni-hannover.de
  gpg signed mail preferred    gpg-key: finger kreutzm@zibal.itp.uni-hannover.de
    64bit GNU powered                  http://www.itp.uni-hannover.de/~kreutzm
       Help keep free software "libre": http://www.freepatents.org/

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 214086@bugs.debian.org (full text, mbox, reply):

From: Pierre Machard <pmachard@debian.org>

To: Helge Kreutzmann <kreutzm@itp.uni-hannover.de>, 214086@bugs.debian.org

Subject: Re: Bug#214086: Ping and fix

Date: Sun, 23 May 2004 21:11:03 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Thu, Apr 01, 2004 at 10:56:33AM +0200, Helge Kreutzmann wrote:
> Hello,
> my bug is now almost 4 month old and I just checked -- I can reproduce
> this on i386 as well. It would be great if you could have kept me up
> to date on this bug (i.e. what you did to investigate, if you
> contacted upstream, ...).
> 
> Anyhow, the following fixed the bug on my alpha under testing:
> 
> --- greed.c.orig	2002-07-31 00:03:43.000000000 +0200
> +++ greed.c	2004-03-31 21:34:00.000000000 +0200
> @@ -383,7 +383,7 @@
>  		return (1);
>  	case 'q': case 'Q':
>  		quit();
> -		return(-1);
> +		return(1);
>  	case '?':
>  		help();
>  		return (1);
> 
> 
> It is surprisingly simple, so please double check if that works and is
> the proper fix, i.e. that the "-" wasn't there on purpose.

Ok, fixed, thanks.

> Also I have seen some (but probably unrelated) 64bit problems when
> compiling greed on my alpha:
> 
> http://buildd.debian.org/fetch.php?&pkg=greed&ver=3.4-1&arch=alpha&stamp=1062950101&file=log&as=raw
> 
> search for "cast". Should I put this as a seperate wishlist report?


It seems that for arch=alpha the line #include <stdlib.h> in missing,
but I don't understand yet, why the preprocessor is nice on i386 and not
on alpha.

I do not have time now to investigate on it.

Cheers,
-- 
                                Pierre Machard
<pmachard@debian.org>                                 http://debian.org
GPG: 1024D/23706F87 : B906 A53F 84E0 49B6 6CF7 82C2 B3A0 2D66 2370 6F87

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 214086-close@bugs.debian.org (full text, mbox, reply):

From: Pierre Machard <pmachard@debian.org>

To: 214086-close@bugs.debian.org

Subject: Bug#214086: fixed in greed 3.4-2

Date: Sun, 23 May 2004 15:47:34 -0400

Source: greed
Source-Version: 3.4-2

We believe that the bug you reported is fixed in the latest version of
greed, which is due to be installed in the Debian FTP archive:

greed_3.4-2.diff.gz
  to pool/main/g/greed/greed_3.4-2.diff.gz
greed_3.4-2.dsc
  to pool/main/g/greed/greed_3.4-2.dsc
greed_3.4-2_i386.deb
  to pool/main/g/greed/greed_3.4-2_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 214086@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pierre Machard <pmachard@debian.org> (supplier of updated greed package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 23 May 2004 21:11:29 +0200
Source: greed
Binary: greed
Architecture: source i386
Version: 3.4-2
Distribution: unstable
Urgency: low
Maintainer: Pierre Machard <pmachard@debian.org>
Changed-By: Pierre Machard <pmachard@debian.org>
Description: 
 greed      - curses-based clone of the DOS freeware game Greed
Closes: 214086
Changes: 
 greed (3.4-2) unstable; urgency=low
 .
   * Fix call to quit() in greed.c thanks to Helge Kreutzmann
     (closes: #214086)
Files: 
 81ef2084ef2c00456e2424699687beb1 573 games optional greed_3.4-2.dsc
 7b3b9345781b3b81ce4012d61b430231 3360 games optional greed_3.4-2.diff.gz
 277f07e1d35663500fa5ecb917baa762 11422 games optional greed_3.4-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAsPqys6AtZiNwb4cRAv+nAJ0cDlTkwNNyrko9wR26MUTmKTZoeACgyji9
BUMroboKoU/uV3TnbL1CVoM=
=i6D/
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.