Debian Bug report logs - #178885
Second dhclient3 for same interface should not start

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Martin Buck <martin.buck@ascom.ch>

To: submit@bugs.debian.org

Subject: ifup should kill running dhclients

Date: Wed, 29 Jan 2003 10:50:33 +0100

Package: ifupdown
Version: 0.6.4-4.4

If you bring up an interface which uses dhclient and which already is up 
 again using "ifup --force", ifup will start a 2nd copy of dhclient for 
the same interface.

IMHO, ifup should kill already running dhclients for a specific 
interface before trying to start a new one. Please note that this isn't 
necessary with pump, because pump is already clever enough not to start 
a 2nd copy if it detects a running pump for an interface.

Martin

Message #10 received at 178885-submitter@bugs.debian.org (full text, mbox, reply):

From: Thomas Hood <jdthood@yahoo.co.uk>

To: 178885-submitter@bugs.debian.org

Subject: #178885 wontfix?

Date: 01 Feb 2003 16:12:31 +0100

#178885 complains that if --force is used to force ifup
to "up" an interface a second time, then two instances
of dhcp-client may end up running.

I think that it is reasonable to ask the user instead
to run ifdown first -- before he overrides ifupdown's
state tracking mechanism with --force.

Is this a "wontfix"?
-- 
Thomas Hood <jdthood@yahoo.co.uk>

Message #15 received at 178885-quiet@bugs.debian.org (full text, mbox, reply):

From: Martin Buck <martin.buck@ascom.ch>

To: Thomas Hood <jdthood@yahoo.co.uk>, 178885-quiet@bugs.debian.org

Subject: Re: Bug#178885: #178885 wontfix?

Date: Mon, 03 Feb 2003 09:44:58 +0100

Thomas Hood wrote:
> #178885 complains that if --force is used to force ifup
> to "up" an interface a second time, then two instances
> of dhcp-client may end up running.
> 
> I think that it is reasonable to ask the user instead
> to run ifdown first

Then what's the purpose of having the --force option at all?

BTW, the reason I'm using ifup --force instead of ifdown/ifup is that 
ifdown somehow manages to unload the kernel module responsible for my 
PCMCIA WLAN card. And reloading this just with ifup is not possible.

One could probably argue whether starting several dhclients is a bug in 
ifupdown or in dhcp-client since pump is clever enough not to start a 
2nd copy if it detects that it's already running. And I just noticed 
that dhclient can't be killed realiably because it doesn't remove its 
PID file when it terminates, so you never know whether the PID in the 
PID file still refers to dhclient or whether another process happend to 
reuse the PID in the meantime. So feel free to reassign this to 
dhcp-client if you think this is appropriate.

Martin

Message #20 received at 178885-quiet@bugs.debian.org (full text, mbox, reply):

From: Thomas Hood <jdthood@yahoo.co.uk>

To: Martin Buck <martin.buck@ascom.ch>

Cc: 178885-quiet@bugs.debian.org

Subject: Re: Bug#178885: #178885 wontfix?

Date: 03 Feb 2003 18:52:40 +0100

On Mon, 2003-02-03 at 09:44, Martin Buck wrote:
> BTW, the reason I'm using ifup --force instead of ifdown/ifup is that 
> ifdown somehow manages to unload the kernel module responsible for my 
> PCMCIA WLAN card. And reloading this just with ifup is not possible.

We should get to the bottom of that problem.

> One could probably argue whether starting several dhclients is a bug in 
> ifupdown or in dhcp-client since pump is clever enough not to start a 
> 2nd copy if it detects that it's already running. And I just noticed 
> that dhclient can't be killed realiably because it doesn't remove its 
> PID file when it terminates, so you never know whether the PID in the 
> PID file still refers to dhclient or whether another process happend to 
> reuse the PID in the meantime. So feel free to reassign this to 
> dhcp-client if you think this is appropriate.

Are you running the most recent version of dhclient
from dhcp3-client?  I don't use it, but I have heard
that some bugs like the ones you describe have been
fixed recently.

-- 
Thomas Hood <jdthood@yahoo.co.uk>

Message #33 received at 178885@bugs.debian.org (full text, mbox, reply):

From: Martin Pitt <mpitt@debian.org>

To: 178885@bugs.debian.org

Cc: control@bugs.debian.org

Subject: Ubuntu patch

Date: Mon, 30 May 2005 12:11:22 +0200

[Message part 1 (text/plain, inline)]

tag 178885 patch
thanks

Hi Eloy!

Since some users and also I often end up with multiple instances of
dhclient at the same interface, I took a stab at it:

 dhcp3 (3.0.1-2ubuntu7) breezy; urgency=low
 .
   [...]
   * Added debian/patches/dhclient-running_stale_pids.patch:
     - Always check for an already existing PID file, not only in release mode.
     - Remove the PID also if the previous process does not exist any more
       (stale PID file).
     - Added some log_info() statements.
     - This should now make it really hard to get multiple clients for the same
       interface at the same time. (related to Debian #178885)

The patch  is at 

  http://patches.ubuntu.com/patches/dhcp3.client-running_stale_pids.diff

(Not a debdiff this time, but a proper patch for debian/patches.)

Now the client is much more robust. Can you please forward this
upstream? This problem seems to be rather non-distribution specific.

Thanks for considering and have a nice day!

Martin

-- 
Martin Pitt              http://www.piware.de
Ubuntu Developer   http://www.ubuntulinux.org
Debian Developer        http://www.debian.org

[signature.asc (application/pgp-signature, inline)]

Message #42 received at 178885-close@bugs.debian.org (full text, mbox, reply):

From: Andrew Pollock <apollock@debian.org>

To: 178885-close@bugs.debian.org

Subject: Bug#178885: fixed in dhcp3 3.0.2-1

Date: Fri, 17 Jun 2005 23:02:26 -0400

Source: dhcp3
Source-Version: 3.0.2-1

We believe that the bug you reported is fixed in the latest version of
dhcp3, which is due to be installed in the Debian FTP archive:

dhcp3-client-udeb_3.0.2-1_i386.udeb
  to pool/main/d/dhcp3/dhcp3-client-udeb_3.0.2-1_i386.udeb
dhcp3-client_3.0.2-1_i386.deb
  to pool/main/d/dhcp3/dhcp3-client_3.0.2-1_i386.deb
dhcp3-common_3.0.2-1_i386.deb
  to pool/main/d/dhcp3/dhcp3-common_3.0.2-1_i386.deb
dhcp3-dev_3.0.2-1_i386.deb
  to pool/main/d/dhcp3/dhcp3-dev_3.0.2-1_i386.deb
dhcp3-relay_3.0.2-1_i386.deb
  to pool/main/d/dhcp3/dhcp3-relay_3.0.2-1_i386.deb
dhcp3-server_3.0.2-1_i386.deb
  to pool/main/d/dhcp3/dhcp3-server_3.0.2-1_i386.deb
dhcp3_3.0.2-1.diff.gz
  to pool/main/d/dhcp3/dhcp3_3.0.2-1.diff.gz
dhcp3_3.0.2-1.dsc
  to pool/main/d/dhcp3/dhcp3_3.0.2-1.dsc
dhcp3_3.0.2.orig.tar.gz
  to pool/main/d/dhcp3/dhcp3_3.0.2.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 178885@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Andrew Pollock <apollock@debian.org> (supplier of updated dhcp3 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 16 Jun 2005 20:50:34 +1000
Source: dhcp3
Binary: dhcp3-client-udeb dhcp3-common dhcp3-relay dhcp3-dev dhcp3-client dhcp3-server
Architecture: source i386
Version: 3.0.2-1
Distribution: unstable
Urgency: low
Maintainer: Eloy A. Paris <peloy@debian.org>
Changed-By: Andrew Pollock <apollock@debian.org>
Description: 
 dhcp3-client - DHCP Client
 dhcp3-client-udeb - DHCP Client for debian-installer (udeb)
 dhcp3-common - Common files used by all the dhcp3* packages
 dhcp3-dev  - API for accessing and modifying the DHCP server and client state
 dhcp3-relay - DHCP Relay
 dhcp3-server - DHCP server for automatic IP address assignment
Closes: 178885 220525 266574 279338 281989 283388 290431 292357 300513 310074 310224 310225 311723
Changes: 
 dhcp3 (3.0.2-1) unstable; urgency=low
 .
   * The "Look Mum, it's nearly Lintian clean!" release
   * New upstream release
   * debian/dhcp3-server.postinst: Applied patch from Robert Millan to handle
     interface names with slashes in them (closes: #290431)
   * debian/dhcp3-server.postinst: move startup to 40 instead of 20 so as to
     allow PCMCIA interfaces to exist (closes: #292357)
   * debian/dhcp3-server.init.d: explictly define a $PATH (closes: #311723)
   * Added Russian debconf templates translation (спасибо Yuriy Talakan)
     (closes: #310074)
   * debian/dhcp3-server.templates: fixed typo (closes: #310225)
   * debian/dhcp3-server.init.d: only restart if the config file is sane
     (closes: #300513)
   * Added Vietnamese debconf templates translation (Cám ón ông Clytie Siddall)
     (closes: #310224)
   * Added Czech debconf templates translation (dêkuji Jan Outrata) (closes:
     #266574)
   * Added Brazilian Portuguese debconf templates translation (Obrigado!,
     Obrigada! Andre Luis Lopez) (closes: #281989)
   * debian/rules: use dh_link to make a policy compliant dhclient -> dhclient3
     symlink
   * debian/control: Add dpatch to build-dependencies
   * debian/rules: rejig to use dpatch
   * redo all patches for dpatch.
   * debian/changelog: fixed a dodgey email address that made Lintian cry
   * debian/dhclient-script: applied patch from Faidon Liambotis to support
     point-to-point Ethernet links (netmask of 255.255.255.255) (closes:
     #283388)
   * Don't install the omshell.1 manpage incorrectly into section 3 in
     dhcp3-server as well as correctly in section 1 in dhcp3-common
   * Applied patch from Martin Pitt to prevent multiple dhclients starting on
     the same interface (closes: #178885)
   * Applied patch from Olivier Houchard to add libdst.a to dhcp3-dev (closes:
     #220525)
   * debian/control: [dhcp3-client] make conflict with dhcp-client versioned
     (closes: #279338)
   * debian/control: [dhcp3-client-udeb] Added XC-Package-Type: udeb
   * debian/rules: Removed all the special-case handling for dhcp3-client-udeb
Files: 
 67ebb0c547faa45785cb3c3cefcecd30 751 net optional dhcp3_3.0.2-1.dsc
 04800a111521e7442749b2ce883f962b 853313 net optional dhcp3_3.0.2.orig.tar.gz
 e00f7b9fb0f81164273af84f46873633 43732 net optional dhcp3_3.0.2-1.diff.gz
 55796487ebdf25f6237764b3d7fdf70a 511262 net optional dhcp3-server_3.0.2-1_i386.deb
 5c917ddfa1f41bf68b1f9e8aa8e73423 175714 net optional dhcp3-common_3.0.2-1_i386.deb
 0344b3184d36d515ad9c1ce10416fc84 97330 devel optional dhcp3-dev_3.0.2-1_i386.deb
 a8ca1aa3165912421cd7a48b49f2be4c 420286 net optional dhcp3-client_3.0.2-1_i386.deb
 35662604075fe0c2c000639a73feaec3 147752 debian-installer optional dhcp3-client-udeb_3.0.2-1_i386.udeb
 091a09a3fd1eed65dd5fd82436c7645b 320990 net optional dhcp3-relay_3.0.2-1_i386.deb
package-type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCs4guIblXXKfZFgIRAk1EAKCC0TVKqee5gv3KHffSuYN4fjHmQwCfa3X1
6uC5TMa0LSq52WuATOoEbKA=
=rBoV
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.