Debian Bug report logs - #111278
icewm: don't add a fontpath at the top of the system's fontpath

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Tomohiro KUBOTA <tkubota@riken.go.jp>

To: submit@bugs.debian.org

Subject: icewm: don't add a fontpath at the top of the system's fontpath

Date: Wed, 05 Sep 2001 13:26:25 +0900

Package: icewm
Version: 1.0.8.6-2
Tags: patch

Themes of IceWM can add custom fonts for the themes, like
Infadel2 theme (in icewm-themes package) adds -artwiz-* font.
IceWM adds the fontpath for these fonts at the top of the
system's fontpath.  This causes other softwares which specify
fonts with wildcards to use these fonts.  Then these softwares
will have funny fonts.

An example is the menubar of emacs20.  Since it is completely
legal to specify fonts with wildcards (especially for i18n-ed
softwares with XFontSet), fontpath should not be modified in
such a way.

The solution is easy: instead of adding the fontpath at the
top of the system's fontpath, add it at the end of the system's
fontpath.  This doesn't affect the look&feel of the IceWM themes.

The following is the patch.  I will send the same patch to
the upstream.

----------
--- icewm-1.0.8/src/wmapp.cc	Fri Apr 27 10:32:22 2001
+++ icewm-1.0.8.new/src/wmapp.cc	Wed Sep  5 08:35:21 2001
@@ -185,10 +185,10 @@
 	    char ** fontPath(XGetFontPath(app->display(), &ndirs));
 
 	    char * newFontPath[ndirs + 1];
-	    newFontPath[0] = fontsdir;
+	    newFontPath[ndirs] = fontsdir;
 
 	    if (fontPath)
-		memcpy(newFontPath + 1, fontPath, ndirs * sizeof (char *));
+		memcpy(newFontPath, fontPath, ndirs * sizeof (char *));
 	    else
 		warn(_("Unable to get current font path."));
 
@@ -210,11 +210,10 @@
 				   (unsigned char **) &icewmFontPath) ==
 				   Success && icewmFontPath) {
 		if (r_type == XA_STRING && r_format == 8) {
-		    for (int n(ndirs); n > 0; --n) // ---- remove death paths ---
+		    for (int n(ndirs - 1); n >= 0; --n) // ---- remove death paths ---
 			if (!strcmp(icewmFontPath, newFontPath[n])) {
-			    if (n != ndirs)
-				memmove(newFontPath + n, newFontPath + n + 1,
-					(ndirs - n) * sizeof(char *));
+			    memmove(newFontPath + n, newFontPath + n + 1,
+				    (ndirs - n) * sizeof(char *));
 			    --ndirs;
 			}
 		} else
----------

Message #10 received at 111278-close@bugs.debian.org (full text, mbox, reply):

From: Jerome Marant <jerome@debian.org>

To: 111278-close@bugs.debian.org

Subject: Bug#111278: fixed in icewm 1.0.9.2-2

Date: Tue, 06 Nov 2001 14:57:24 -0500

We believe that the bug you reported is fixed in the latest version of
icewm, which has been installed in the Debian FTP archive:

icewm-experimental_1.0.9.2-2_i386.deb
  to pool/main/i/icewm/icewm-experimental_1.0.9.2-2_i386.deb
icewm_1.0.9.2-2_i386.deb
  to pool/main/i/icewm/icewm_1.0.9.2-2_i386.deb
icewm_1.0.9.2-2.dsc
  to pool/main/i/icewm/icewm_1.0.9.2-2.dsc
icewm-gnome_1.0.9.2-2_i386.deb
  to pool/main/i/icewm/icewm-gnome_1.0.9.2-2_i386.deb
icewm-common_1.0.9.2-2_i386.deb
  to pool/main/i/icewm/icewm-common_1.0.9.2-2_i386.deb
icewm-lite_1.0.9.2-2_i386.deb
  to pool/main/i/icewm/icewm-lite_1.0.9.2-2_i386.deb
icewm_1.0.9.2-2.diff.gz
  to pool/main/i/icewm/icewm_1.0.9.2-2.diff.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 111278@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jerome Marant <jerome@debian.org> (supplier of updated icewm package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon,  5 Nov 2001 22:02:03 +0100
Source: icewm
Binary: icewm-common icewm-gnome icewm-lite icewm icewm-experimental
Architecture: source i386
Version: 1.0.9.2-2
Distribution: unstable
Urgency: low
Maintainer: Jerome Marant <jerome@debian.org>
Changed-By: Jerome Marant <jerome@debian.org>
Description: 
 icewm      - A wonderful Win95-OS/2-Motif-like window manager
 icewm-common - A wonderful Win95-OS/2-Motif-like window manager
 icewm-experimental - A wonderful Win95-OS/2-Motif-like window manager
 icewm-gnome - A wonderful Win95-OS/2-Motif-like window manager
 icewm-lite - A wonderful Win95-OS/2-Motif-like window manager
Closes: 111278 115775 118228
Changes: 
 icewm (1.0.9.2-2) unstable; urgency=low
 .
   * debian/control: fixed typo in icewm-experimental description.
     Closes: Bug#115775.
   * Modified package_build_fixes patch in order to include back some
     missing conffiles. Closes: Bug#118228.
   * Applied fontpath patch from Tomohiro Kubota. Closes: Bug#111278.
Files: 
 92fef2fdbc35f86ffcdaae887949edbd 724 x11 optional icewm_1.0.9.2-2.dsc
 d487aa51b6d3c7d28b425c4e1c5e81d9 34138 x11 optional icewm_1.0.9.2-2.diff.gz
 e2e2ebf447318cda83a99c1848537610 207014 x11 optional icewm-common_1.0.9.2-2_i386.deb
 cc41a954a608f02544d8b33e55e9ef20 254968 x11 optional icewm_1.0.9.2-2_i386.deb
 ae8b491cee6ad02586fbf3a0db7ac530 260400 x11 optional icewm-gnome_1.0.9.2-2_i386.deb
 2118559250cfda03d395df667e6bc0a0 137278 x11 optional icewm-lite_1.0.9.2-2_i386.deb
 f974fc4bf1f9724fa0baa8e8ef15ad25 287012 x11 optional icewm-experimental_1.0.9.2-2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Pour information voir http://www.gnupg.org

iD8DBQE75wPc3JE9mF3wMWcRAsIJAJ9B3KPqAuNKmZTvqdENQq8WvxgGSQCggDH+
tzZz15OO9uGihO1f6kbrp0k=
=cfGS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.