Debian Bug report logs - #1054644
xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Philip Hands <phil@hands.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Fri, 27 Oct 2023 10:23:01 +0200

Package: xfsprogs-udeb
Version: 6.5.0-1
Severity: serious
User: debian-qa@lists.debian.org
Usertags: openqa

While doing openQA testing of Debian-Installer, I notice that XFS installs
started failing a few days ago, and comparing the versions of udebs that changed
between success and failure, the only likely candidate is xfsprogs-udeb, which
has a version of 6.4.0-1 in the last working test, and 6.5.0-1 in the first
failing one.

I've also built the latest D-I with 6.4.0-1, and that restores it to a working
condition.

I note that if one runs e.g.:  grub-probe -d /dev/vda1
at the moment of failure, the XFS filesystem is not recognised
(despite being mounted as XFS at that moment).

Could this be related to #1051543?

I'll try testing D-I while using the patch from that bug, to see if that helps.

Cheers, Phil.

Message #10 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Bastian Germann <bage@debian.org>

To: Philip Hands <phil@hands.com>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Fri, 27 Oct 2023 16:39:23 +0200

Hi Phil,

Am 27.10.23 um 10:23 schrieb Philip Hands:
> Could this be related to #1051543?
> 
> I'll try testing D-I while using the patch from that bug, to see if that helps.

Okay. I am going to wait for more info from you. If that does not help,
can you please explain which of xfsprogs-udeb's programs are used that lead to the fail?

Thanks for the report,
Bastian

Message #15 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Philip Hands <phil@hands.com>

To: 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Fri, 27 Oct 2023 17:20:42 +0200

Philip Hands <phil@hands.com> writes:
...
> Could this be related to #1051543?
>
> I'll try testing D-I while using the patch from that bug, to see if that helps.

It seems (to me at least) that the patch there does not apply usefully
to the version we're talking about, so I'll leave it to people that know
more about grub & XFS to look further.

=-=-=

BTW the jobs where this failure first occured are:

(BIOS)  https://openqa.debian.net/tests/198911
(UEFI)  https://openqa.debian.net/tests/198912

and the immediately previous working jobs are these:

(BIOS)  https://openqa.debian.net/tests/198840
(UEFI)  https://openqa.debian.net/tests/198841

In the jobs you can see a 'Logs & Assets' tab, where you can find e.g.
the syslog from the D-I run.

Here's the one from the first BIOS failure:

  https://openqa.debian.net/tests/198911/logfile?filename=DI_syslog.txt

One thing I notice when comparing that to the matching successful log:

  https://openqa.debian.net/tests/198840/logfile?filename=complete_install-DI_syslog.txt

is that they both include a block of lines like:

   grub-installer: Unknown device "/dev/vda1": No such device

so that's just noise by the looks of it, since it was also saying that
when it was working.

I've since slightly reorganised the openQA jobs, to have a job that only
differs from the normal minimal install by the selection of XFS, so if
you want to see currently failing jobs, they will be the ones called
nonGUI_XFS@64bit & nonGUI_XFS (for BIOS & UEFI installs, respectively)
in this overview:

  https://openqa.debian.net/tests/overview?distri=debian&groupid=10

HTH

Cheers, Phil.
-- 
Philip Hands -- https://hands.com/~phil

Message #20 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: "Darrick J. Wong" <djwong@kernel.org>

To: Philip Hands <phil@hands.com>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Fri, 27 Oct 2023 08:45:05 -0700

On Fri, Oct 27, 2023 at 05:20:42PM +0200, Philip Hands wrote:
> Philip Hands <phil@hands.com> writes:
> ...
> > Could this be related to #1051543?
> >
> > I'll try testing D-I while using the patch from that bug, to see if that helps.
> 
> It seems (to me at least) that the patch there does not apply usefully
> to the version we're talking about, so I'll leave it to people that know
> more about grub & XFS to look further.

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054644#5:

> > I note that if one runs e.g.:  grub-probe -d /dev/vda1
> > at the moment of failure, the XFS filesystem is not recognised
> > (despite being mounted as XFS at that moment).
> > 
> > Could this be related to #1051543?
> > 
> > I'll try testing D-I while using the patch from that bug, to see if that
> > helps.

I noticed this too while migrating to Debian 12 -- if you mkfs.xfs a
/boot with feature flags that grub doesn't know about, grub-install
unhelpfully refuses to recognize that there's a filesystem there at all.

mkfs.xfs in xfsprogs 6.5 turned on both the large extent counts and
reverse mapping btree features by default.  My guess is that grub hasn't
caught up with those changes to the ondisk format yet.

Ah, yeah, upstream grub hasn't picked up large extent counts (internally
called nrext64) yet.
https://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/fs/xfs.c#n83

If you can manually reformat the filesystem from within the installer
with

mkfs.xfs -c /usr/share/xfsprogs/mkfs/lts_6.1.conf

Does grub start to recognize the filesystem again?

> 
> =-=-=
> 
> BTW the jobs where this failure first occured are:
> 
> (BIOS)  https://openqa.debian.net/tests/198911
> (UEFI)  https://openqa.debian.net/tests/198912
> 
> and the immediately previous working jobs are these:
> 
> (BIOS)  https://openqa.debian.net/tests/198840
> (UEFI)  https://openqa.debian.net/tests/198841
> 
> In the jobs you can see a 'Logs & Assets' tab, where you can find e.g.
> the syslog from the D-I run.
> 
> Here's the one from the first BIOS failure:
> 
>   https://openqa.debian.net/tests/198911/logfile?filename=DI_syslog.txt

Curiously, this log says:

Oct 24 05:35:32 in-target: Setting up xfsprogs (6.4.0-1) ...^M

So ... is it running 6.4 and not 6.5?

--D

> 
> One thing I notice when comparing that to the matching successful log:
> 
>   https://openqa.debian.net/tests/198840/logfile?filename=complete_install-DI_syslog.txt
> 
> is that they both include a block of lines like:
> 
>    grub-installer: Unknown device "/dev/vda1": No such device
> 
> so that's just noise by the looks of it, since it was also saying that
> when it was working.
> 
> I've since slightly reorganised the openQA jobs, to have a job that only
> differs from the normal minimal install by the selection of XFS, so if
> you want to see currently failing jobs, they will be the ones called
> nonGUI_XFS@64bit & nonGUI_XFS (for BIOS & UEFI installs, respectively)
> in this overview:
> 
>   https://openqa.debian.net/tests/overview?distri=debian&groupid=10
> 
> HTH
> 
> Cheers, Phil.
> -- 
> Philip Hands -- https://hands.com/~phil

Message #25 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Anthony Iliopoulos <ailiop@suse.com>

To: "Darrick J. Wong" <djwong@kernel.org>, 1054644@bugs.debian.org

Cc: Philip Hands <phil@hands.com>

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Fri, 27 Oct 2023 18:19:33 +0200

On Fri, Oct 27, 2023 at 08:45:05AM -0700, Darrick J. Wong wrote:
> 
> mkfs.xfs in xfsprogs 6.5 turned on both the large extent counts and
> reverse mapping btree features by default.  My guess is that grub hasn't
> caught up with those changes to the ondisk format yet.
> 
> Ah, yeah, upstream grub hasn't picked up large extent counts (internally
> called nrext64) yet.
> https://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/fs/xfs.c#n83

Yeap it is due to nrext64, I've submitted a patch to grub (should have
cc'ed linux-xfs..)

https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/

Regards,
Anthony

Message #30 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: "Darrick J. Wong" <djwong@kernel.org>

To: Anthony Iliopoulos <ailiop@suse.com>

Cc: 1054644@bugs.debian.org, Philip Hands <phil@hands.com>

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Fri, 27 Oct 2023 09:25:42 -0700

On Fri, Oct 27, 2023 at 06:19:33PM +0200, Anthony Iliopoulos wrote:
> On Fri, Oct 27, 2023 at 08:45:05AM -0700, Darrick J. Wong wrote:
> > 
> > mkfs.xfs in xfsprogs 6.5 turned on both the large extent counts and
> > reverse mapping btree features by default.  My guess is that grub hasn't
> > caught up with those changes to the ondisk format yet.
> > 
> > Ah, yeah, upstream grub hasn't picked up large extent counts (internally
> > called nrext64) yet.
> > https://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/fs/xfs.c#n83
> 
> Yeap it is due to nrext64, I've submitted a patch to grub (should have
> cc'ed linux-xfs..)
> 
> https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/

FWIW the patch turning on nrext64 by default was intended for xfsprogs
6.6, but the maintainer decided to merge it early.  No complaints here,
but that was a little sooner than I had intended.

--D

> Regards,
> Anthony

Message #35 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Philip Hands <phil@hands.com>

To: "Darrick J. Wong" <djwong@kernel.org>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Fri, 27 Oct 2023 21:18:47 +0200

"Darrick J. Wong" <djwong@kernel.org> writes:
...
> Curiously, this log says:
>
> Oct 24 05:35:32 in-target: Setting up xfsprogs (6.4.0-1) ...^M
>
> So ... is it running 6.4 and not 6.5?

The daily test versions of Debian-Installer draw components from
"unstable", which is where the 6.5 version is at present, which then
creates the file system with problematic flags.

However, the test images normally install "testing" onto the target, to
avoid pointless breakage caused by the potential for "unstable" to be,
well ... unstable, hence the 6.4 version that gets put in-target.

Having 6.4 in the target system doesn't help in this case, because the
damage has already been done while creating the file system, by the 6.5
version of the udeb.

One can confirm that this is the case by looking for xfsprogs in here:

  https://openqa.debian.net/tests/198911/logfile?filename=complete_install-DI-installed-pkgs.txt

which lists the installed components (udebs) of the installer that's running:

  xfsprogs-udeb                            6.5.0-1

Cheers, Phil.
-- 
Philip Hands -- https://hands.com/~phil

Message #40 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Philip Hands <phil@hands.com>

To: Anthony Iliopoulos <ailiop@suse.com>, "Darrick J. Wong" <djwong@kernel.org>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Sat, 28 Oct 2023 00:27:31 +0200

Anthony Iliopoulos <ailiop@suse.com> writes:
...
> Yeap it is due to nrext64, I've submitted a patch to grub (should have
> cc'ed linux-xfs..)
>
> https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/

That certainly seems to fix this bug.

I tested it by applying that patch to grub, and then getting that
version of grub installed into the target just after the initial attempt
to run grub had failed, which then allows a retry of the grub install
step to succeed.

Also, with the patched version: `grub-probe -d /dev/vda1` produces 'xfs'

Cheers, Phil.
-- 
Philip Hands -- https://hands.com/~phil

Message #45 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Bastian Germann <bage@debian.org>

To: 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Sat, 28 Oct 2023 00:38:07 +0200

Control: reassign -1 grub2

Please consider applying the identified patch so that debian installer does not break installing on XFS.

Message #54 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Philip Hands <phil@hands.com>

To: Anthony Iliopoulos <ailiop@suse.com>, "Darrick J. Wong" <djwong@kernel.org>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Sun, 29 Oct 2023 21:02:01 +0100

[Message part 1 (text/plain, inline)]

Philip Hands <phil@hands.com> writes:

> Anthony Iliopoulos <ailiop@suse.com> writes:
> ...
>> Yeap it is due to nrext64, I've submitted a patch to grub (should have
>> cc'ed linux-xfs..)
>>
>> https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/
>
> That certainly seems to fix this bug.

... but sadly that may not be the end of the story.

I've persuaded D-I to use the patched grub version, and when testing it,
it now gets past the previous failure to complete the install, but then
fails to boot after the first reboot, as seen here:

  https://openqa.debian.net/tests/200160#step/_console_wait_login/7

where it drops to the 'grub rescue>' prompt, complaining that:

  error: file `/boot/grub/i386-pc/normal.mod' not found.

if one types `ls (hd0,msdos1)/boot/grub/i386-pc` at that rescue prompt,
it lists the files up to msdospart.mod and then says:

  error: invalid XFS directory entry.

(BTW the directory seemed fine before the reboot, because I listed it)

This makes me wonder: Could it be that the code within the grub
components that get installed onto the disk also needs to be patched to
understand the newer directory structure, and without that it is unable
to read the whole directory, and thus fails to boot it?

Cheers, Phil.

P.S. If you want to try this for yourself, the test image used (that pulls in
the patched grub) is to be found here:

https://salsa.debian.org/philh/grub2/-/jobs/4865564/artifacts/file/debian/output/debian-202306XX+ABI~6.5.0~3+salsaci+20231029+21-amd64-gtkmini.iso

and adding `partman/default_filesystem=xfs` on the kernel command line
before booting into D-I will get it to default to using XFS.
-- 
Philip Hands -- https://hands.com/~phil

[signature.asc (application/pgp-signature, inline)]

Message #59 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Anthony Iliopoulos <ailiop@suse.com>

To: Philip Hands <phil@hands.com>

Cc: "Darrick J. Wong" <djwong@kernel.org>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Mon, 30 Oct 2023 01:15:33 +0100

On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:
> Philip Hands <phil@hands.com> writes:
> 
> > Anthony Iliopoulos <ailiop@suse.com> writes:
> > ...
> >> Yeap it is due to nrext64, I've submitted a patch to grub (should have
> >> cc'ed linux-xfs..)
> >>
> >> https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/
> >
> > That certainly seems to fix this bug.
> 
> ... but sadly that may not be the end of the story.
> 
> I've persuaded D-I to use the patched grub version, and when testing it,
> it now gets past the previous failure to complete the install, but then
> fails to boot after the first reboot, as seen here:
> 
>   https://openqa.debian.net/tests/200160#step/_console_wait_login/7
> 
> where it drops to the 'grub rescue>' prompt, complaining that:
> 
>   error: file `/boot/grub/i386-pc/normal.mod' not found.
> 
> if one types `ls (hd0,msdos1)/boot/grub/i386-pc` at that rescue prompt,
> it lists the files up to msdospart.mod and then says:
> 
>   error: invalid XFS directory entry.
> 
> (BTW the directory seemed fine before the reboot, because I listed it)

This issue exists independently of the large extent counter, and it is
related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
fuzzing the XFS filesystem"). That's actually the issue described in
#1051543.

There's a proposed fix at [1], and it works as expected with that patch
applied.

Regards,
Anthony

[1] https://lore.kernel.org/grub-devel/20231018030347.36174-1-nuxi@vault24.org/

Message #64 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Philip Hands <phil@hands.com>

To: Anthony Iliopoulos <ailiop@suse.com>

Cc: "Darrick J. Wong" <djwong@kernel.org>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Mon, 30 Oct 2023 16:19:32 +0100

[Message part 1 (text/plain, inline)]

Anthony Iliopoulos <ailiop@suse.com> writes:

> On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:
...
>>   error: invalid XFS directory entry.
...
> This issue exists independently of the large extent counter, and it is
> related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
> fuzzing the XFS filesystem"). That's actually the issue described in
> #1051543.

Ah, yes -- good point.

> There's a proposed fix at [1], and it works as expected with that patch
> applied.
...
> [1] https://lore.kernel.org/grub-devel/20231018030347.36174-1-nuxi@vault24.org/

I can confirm that having applied both patches:

  https://salsa.debian.org/philh/grub2/-/pipelines/596346

it now succeeds at both installing grub, and then booting the system:

  https://openqa.debian.net/tests/200503#details

Cheers, Phil.
-- 
Philip Hands -- https://hands.com/~phil

[signature.asc (application/pgp-signature, inline)]

Message #69 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Anthony Iliopoulos <ailiop@suse.com>

To: Philip Hands <phil@hands.com>

Cc: "Darrick J. Wong" <djwong@kernel.org>, 1054644@bugs.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Mon, 30 Oct 2023 19:50:58 +0100

On Mon, Oct 30, 2023 at 04:19:32PM +0100, Philip Hands wrote:
> Anthony Iliopoulos <ailiop@suse.com> writes:
> 
> > On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:
> ...
> >>   error: invalid XFS directory entry.
> ...
> > This issue exists independently of the large extent counter, and it is
> > related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
> > fuzzing the XFS filesystem"). That's actually the issue described in
> > #1051543.
> 
> Ah, yes -- good point.
> 
> > There's a proposed fix at [1], and it works as expected with that patch
> > applied.
> ...
> > [1] https://lore.kernel.org/grub-devel/20231018030347.36174-1-nuxi@vault24.org/
> 
> I can confirm that having applied both patches:
> 
>   https://salsa.debian.org/philh/grub2/-/pipelines/596346
> 
> it now succeeds at both installing grub, and then booting the system:
> 
>   https://openqa.debian.net/tests/200503#details

Thanks for confirming, perhaps then you can add your tested-by in the
respective patches upstream.

BTW, another handy way to test if this works is via grub-mount.

Regards,
Anthony

Message #74 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Anthony Iliopoulos <ailiop@suse.com>, 1054644@bugs.debian.org

Cc: Philip Hands <phil@hands.com>, "Darrick J. Wong" <djwong@kernel.org>, debian-boot@lists.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Sat, 23 Dec 2023 23:11:53 +0100

[Message part 1 (text/plain, inline)]

Hi,

Anthony Iliopoulos <ailiop@suse.com> (2023-10-30):
> On Mon, Oct 30, 2023 at 04:19:32PM +0100, Philip Hands wrote:
> > Anthony Iliopoulos <ailiop@suse.com> writes:
> > 
> > > On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:
> > ...
> > >>   error: invalid XFS directory entry.
> > ...
> > > This issue exists independently of the large extent counter, and it is
> > > related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
> > > fuzzing the XFS filesystem"). That's actually the issue described in
> > > #1051543.
> > 
> > Ah, yes -- good point.
> > 
> > > There's a proposed fix at [1], and it works as expected with that patch
> > > applied.
> > ...
> > > [1] https://lore.kernel.org/grub-devel/20231018030347.36174-1-nuxi@vault24.org/
> > 
> > I can confirm that having applied both patches:
> > 
> >   https://salsa.debian.org/philh/grub2/-/pipelines/596346
> > 
> > it now succeeds at both installing grub, and then booting the system:
> > 
> >   https://openqa.debian.net/tests/200503#details
> 
> Thanks for confirming, perhaps then you can add your tested-by in the
> respective patches upstream.
> 
> BTW, another handy way to test if this works is via grub-mount.

Any chance we could have an updated grub2 package to fix this?


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #79 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Julian Andres Klode <julian.klode@canonical.com>

To: Cyril Brulebois <kibi@debian.org>, 1054644@bugs.debian.org

Cc: Anthony Iliopoulos <ailiop@suse.com>, Philip Hands <phil@hands.com>, "Darrick J. Wong" <djwong@kernel.org>, debian-boot@lists.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Mon, 25 Dec 2023 09:15:59 +0100

Control: clone -1 -2
Control: reassign -2 xfsprogs

On Sat, Dec 23, 2023 at 11:11:53PM +0100, Cyril Brulebois wrote:
> Hi,
> 
> Anthony Iliopoulos <ailiop@suse.com> (2023-10-30):
> > On Mon, Oct 30, 2023 at 04:19:32PM +0100, Philip Hands wrote:
> > > Anthony Iliopoulos <ailiop@suse.com> writes:
> > > 
> > > > On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:
> > > ...
> > > >>   error: invalid XFS directory entry.
> > > ...
> > > > This issue exists independently of the large extent counter, and it is
> > > > related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
> > > > fuzzing the XFS filesystem"). That's actually the issue described in
> > > > #1051543.
> > > 
> > > Ah, yes -- good point.
> > > 
> > > > There's a proposed fix at [1], and it works as expected with that patch
> > > > applied.
> > > ...
> > > > [1] https://lore.kernel.org/grub-devel/20231018030347.36174-1-nuxi@vault24.org/
> > > 
> > > I can confirm that having applied both patches:
> > > 
> > >   https://salsa.debian.org/philh/grub2/-/pipelines/596346
> > > 
> > > it now succeeds at both installing grub, and then booting the system:
> > > 
> > >   https://openqa.debian.net/tests/200503#details
> > 
> > Thanks for confirming, perhaps then you can add your tested-by in the
> > respective patches upstream.
> > 
> > BTW, another handy way to test if this works is via grub-mount.
> 
> Any chance we could have an updated grub2 package to fix this?

The final grub 2.12 that includes the fix should hit unstable in the
middle of January. As you might be aware many are busy with family
stuff and holiday celebrations right now.

As always though it stands to reason that this is a change that should
(have been) reverted in xfsprogs first until a grub that understands it
has been released in a stable point release such that you can use a
stable grub to inspect an XFS filesystem created by a trixie xfsprogs.

It seems the bug has been wrongly reassigned instead of being cloned
and reassigned, so I'm cloning it back to xfsprogs.

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer                              i speak de, en

Message #86 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Julian Andres Klode <julian.klode@canonical.com>

Cc: 1054644@bugs.debian.org, Anthony Iliopoulos <ailiop@suse.com>, Philip Hands <phil@hands.com>, "Darrick J. Wong" <djwong@kernel.org>, debian-boot@lists.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Mon, 25 Dec 2023 16:33:36 +0100

[Message part 1 (text/plain, inline)]

Julian Andres Klode <julian.klode@canonical.com> (2023-12-25):
> The final grub 2.12 that includes the fix should hit unstable in the
> middle of January. As you might be aware many are busy with family
> stuff and holiday celebrations right now.

Sure. I wasn't aware an upstream release was in the pipes, only that
patches have existed and been confirmed OK for close to 2 months.

> As always though it stands to reason that this is a change that should
> (have been) reverted in xfsprogs first until a grub that understands
> it has been released in a stable point release such that you can use a
> stable grub to inspect an XFS filesystem created by a trixie xfsprogs.

The more we tick boxes in the compatibility matrix, the happier, yes.

> It seems the bug has been wrongly reassigned instead of being cloned
> and reassigned, so I'm cloning it back to xfsprogs.

Right, this would have been easier to track if debian-boot@ had been put
(and kept) in the loop all along.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #91 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Julian Andres Klode <julian.klode@canonical.com>

To: Cyril Brulebois <kibi@debian.org>

Cc: 1054644@bugs.debian.org, Anthony Iliopoulos <ailiop@suse.com>, Philip Hands <phil@hands.com>, "Darrick J. Wong" <djwong@kernel.org>, debian-boot@lists.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Mon, 25 Dec 2023 16:40:14 +0100

On Mon, Dec 25, 2023 at 04:33:36PM +0100, Cyril Brulebois wrote:
> Julian Andres Klode <julian.klode@canonical.com> (2023-12-25):
> > The final grub 2.12 that includes the fix should hit unstable in the
> > middle of January. As you might be aware many are busy with family
> > stuff and holiday celebrations right now.
> 
> Sure. I wasn't aware an upstream release was in the pipes, only that
> patches have existed and been confirmed OK for close to 2 months.

We picked the previous XFS patch for extent parsing but did not pick
this one because it had not been merged at that point yet, the fix
only got merged two weeks or so ago, and we didn't want to take chances
and pick it ahead of time as it's security critical code (filesystem
parsing is where all the security bugs live!).

The release was supposed to be out 2 weeks ago but got pushed back
another week to last week's release, sadly.

-- 
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer                              i speak de, en

Message #96 received at 1054644@bugs.debian.org (full text, mbox, reply):

From: Cyril Brulebois <kibi@debian.org>

To: Julian Andres Klode <julian.klode@canonical.com>

Cc: 1054644@bugs.debian.org, Anthony Iliopoulos <ailiop@suse.com>, Philip Hands <phil@hands.com>, "Darrick J. Wong" <djwong@kernel.org>, debian-boot@lists.debian.org

Subject: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Mon, 25 Dec 2023 16:44:34 +0100

[Message part 1 (text/plain, inline)]

Julian Andres Klode <julian.klode@canonical.com> (2023-12-25):
> We picked the previous XFS patch for extent parsing but did not pick
> this one because it had not been merged at that point yet, the fix
> only got merged two weeks or so ago, and we didn't want to take chances
> and pick it ahead of time as it's security critical code (filesystem
> parsing is where all the security bugs live!).
> 
> The release was supposed to be out 2 weeks ago but got pushed back
> another week to last week's release, sadly.

Thanks for all the details, and sorry if it appeared I was chasing you
down; I just stumbled upon this again while re-testing various things,
and was merely wondering whether things were.


Cheers,
-- 
Cyril Brulebois (kibi@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

[signature.asc (application/pgp-signature, inline)]

Message #101 received at 1054644-done@bugs.debian.org (full text, mbox, reply):

From: Bastian Germann <Bastian.Germann@gmx.de>

To: 1054644-done@bugs.debian.org, 1059424-done@bugs.debian.org

Subject: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Date: Sat, 27 Jan 2024 05:54:08 +0100

Version: grub2/2.12-1

Send a report that this bug log contains spam.