Debian Bug report logs - #1050082
octave-dev: mkoctfile assigns wrong output file

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Graham Inggs <ginggs@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: octave-image: could FTBFS due to missing .oct files

Date: Sat, 19 Aug 2023 13:27:44 +0000

Source: octave-image
Version: 2.14.0-4
Tags: ftbfs patch

Hi Maintainer

While rebuilding octave-* packages for the octave-abi-58 transition in
Ubuntu 23.10, octave-image FTBFS due to missing .oct files.  I've
copied some of the output below.

Upon investigation, I found the following files were not built:
bwconncomp.oct
bwlabeln.oct
conndef.oct
imerode.oct
imreconstruct.oct
watershed.oct

Instead, the following were:
connectivity.oct
strel.oct

I was able to solve it with a simple patch:

--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -24,10 +24,10 @@
     $(FLAGGED_MKOCTFILE) -c $<

 $(conn_dependent): %.oct: %.cc connectivity.o
-    $(FLAGGED_MKOCTFILE) $^
+    $(FLAGGED_MKOCTFILE) $^ -o $@

 $(strel_dependent): %.oct: %.cc strel.o
-    $(FLAGGED_MKOCTFILE) $^
+    $(FLAGGED_MKOCTFILE) $^ -o $@

 %.oct: %.cc
     $(FLAGGED_MKOCTFILE) $<

I'm not sure what changed, or when, but I was able to reproduce this
failure in the Ubuntu 23.04 release.

Regards
Graham


!!!!! test failed
'conndef' undefined near line 48, column 12

The ’conndef’ function belongs to the image package from Octave Forge
which seems to not be installed in your system.

Message #10 received at 1050082@bugs.debian.org (full text, mbox, reply):

From: Rafael Laboissière <rafael@debian.org>

To: Graham Inggs <ginggs@debian.org>

Cc: 1050082@bugs.debian.org

Subject: Re: Bug#1050082: octave-image: could FTBFS due to missing .oct files

Date: Thu, 24 Aug 2023 12:38:14 +0200

Control: tags -1 + unreproducible moreinfo

* Graham Inggs <ginggs@debian.org> [2023-08-19 13:27]:

> Source: octave-image
> Version: 2.14.0-4
> Tags: ftbfs patch
>
> Hi Maintainer
>
> While rebuilding octave-* packages for the octave-abi-58 transition in 
> Ubuntu 23.10, octave-image FTBFS due to missing .oct files.  I've 
> copied some of the output below.
>
> Upon investigation, I found the following files were not built:
>
>  bwconncomp.oct
>  bwlabeln.oct
>  conndef.oct
>  imerode.oct
>  imreconstruct.oct
>  watershed.oct
>
> Instead, the following were:
>
>  connectivity.oct
>  strel.oct
>
> I was able to solve it with a simple patch:
>
>  --- a/src/Makefile.in
>  +++ b/src/Makefile.in
>  @@ -24,10 +24,10 @@
>      $(FLAGGED_MKOCTFILE) -c $<
>
>  $(conn_dependent): %.oct: %.cc connectivity.o
>  -    $(FLAGGED_MKOCTFILE) $^
>  +    $(FLAGGED_MKOCTFILE) $^ -o $@
>
>  $(strel_dependent): %.oct: %.cc strel.o
>  -    $(FLAGGED_MKOCTFILE) $^
>  +    $(FLAGGED_MKOCTFILE) $^ -o $@
>
>  %.oct: %.cc
>      $(FLAGGED_MKOCTFILE) $<
>
> I'm not sure what changed, or when, but I was able to reproduce this 
> failure in the Ubuntu 23.04 release.
>
> Regards
>
> Graham
>
>  !!!!! test failed
>  'conndef' undefined near line 48, column 12
>
>  The ’conndef’ function belongs to the image package from Octave Forge
>  which seems to not be installed in your system.

Thanks for your bug report, but I am afraid I cannot reproduce this 
bug on my sid system.

Could you please post the full log for the failing build?

Best,

Rafael Laboissière

Message #17 received at 1050082@bugs.debian.org (full text, mbox, reply):

From: Graham Inggs <ginggs@debian.org>

To: 1050082@bugs.debian.org

Subject: Re: Bug#1050082: octave-image: could FTBFS due to missing .oct files

Date: Thu, 24 Aug 2023 11:37:35 +0000

Hi Rafael

On Thu, 24 Aug 2023 at 10:38, Rafael Laboissière <rafael@debian.org> wrote:
> Thanks for your bug report, but I am afraid I cannot reproduce this
> bug on my sid system.
>
> Could you please post the full log for the failing build?

Here are build logs from the recent rebuild against octave-abi-58 in
Ubuntu 23.10 [1], as well as a test rebuild in Ubuntu 23.04 [2] from
2023-03-24.

The builds for riscv64 succeeded because they were built with
'nocheck', but the logs do show the presence of the incorrect files
connectivity.oct and strel.oct in the package contents.

Regards
Graham


[1] https://launchpad.net/ubuntu/+source/octave-image/2.14.0-4build1
[2] https://launchpad.net/ubuntu/+archive/test-rebuild-20230324-lunar/+sourcepub/14575637/+listing-archive-extra

Message #22 received at 1050082@bugs.debian.org (full text, mbox, reply):

From: Rafael Laboissière <rafael@debian.org>

To: Graham Inggs <ginggs@debian.org>

Cc: 1050082@bugs.debian.org

Subject: Re: Bug#1050082: octave-image: could FTBFS due to missing .oct files

Date: Thu, 24 Aug 2023 16:07:02 +0200

Control: tags -1 - moreinfo unreproducible ftbfs patch
Control: tags -1 + confirmed upstream
Control: reassign -1 octave-dev 8.3.0-1
Control: affects -1 octave-image
Control: notfound -1 octave-image/2.14.0-4
Control: forwarded -1 https://savannah.gnu.org/bugs/index.php?64590

* Graham Inggs <ginggs@debian.org> [2023-08-24 11:37]:

> Hi Rafael
>
> On Thu, 24 Aug 2023 at 10:38, Rafael Laboissière <rafael@debian.org> wrote:
>> Thanks for your bug report, but I am afraid I cannot reproduce this
>> bug on my sid system.
>>
>> Could you please post the full log for the failing build?
>
> Here are build logs from the recent rebuild against octave-abi-58 in 
> Ubuntu 23.10 [1], as well as a test rebuild in Ubuntu 23.04 [2] from 
> 2023-03-24.
>
> The builds for riscv64 succeeded because they were built with 
> 'nocheck', but the logs do show the presence of the incorrect files 
> connectivity.oct and strel.oct in the package contents.
>
> Regards 
> Graham
>
>
>  [1] https://launchpad.net/ubuntu/+source/octave-image/2.14.0-4build1
>  [2] https://launchpad.net/ubuntu/+archive/test-rebuild-20230324-lunar/+sourcepub/14575637/+listing-archive-extra

Thanks for the links, Graham.

After inspection, I concluded that the problem comes from mkoctfile. I 
am hereby reassign this bug report. I also reported it upstream.

Even though your patch ”fixes” the problem for the octave-image package, 
I would prefer that the upstream developers of Octave cope with the 
issue. Hence, I am thereby removing tags ftbfs and patch.

Best,

Rafael Laboissière

Message #43 received at 1050082-submitter@bugs.debian.org (full text, mbox, reply):

From: Rafael Laboissière <noreply@salsa.debian.org>

To: 1050082-submitter@bugs.debian.org

Subject: Bug#1050082 marked as pending in octave

Date: Tue, 29 Aug 2023 09:14:18 +0000

Control: tag -1 pending

Hello,

Bug #1050082 in octave reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/pkg-octave-team/octave/-/commit/db92b3da684e8a3046a7135cda1332df9f762558

------------------------------------------------------------------------
d/p/mkoctfile-skip-options.patch: New patch

Closes: #1050082
Thanks: Markus Mützel <markus.muetzel@gmx.de>
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1050082

Message #50 received at 1050082-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1050082-close@bugs.debian.org

Subject: Bug#1050082: fixed in octave 8.3.0-2

Date: Wed, 30 Aug 2023 15:42:22 +0000

Source: octave
Source-Version: 8.3.0-2
Done: Rafael Laboissière <rafael@debian.org>

We believe that the bug you reported is fixed in the latest version of
octave, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1050082@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Rafael Laboissière <rafael@debian.org> (supplier of updated octave package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 30 Aug 2023 06:02:05 -0300
Source: octave
Architecture: source
Version: 8.3.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Octave Group <team+pkg-octave-team@tracker.debian.org>
Changed-By: Rafael Laboissière <rafael@debian.org>
Closes: 1050082
Changes:
 octave (8.3.0-2) unstable; urgency=medium
 .
   * d/p/mkoctfile-skip-options.patch: New patch.
     Thanks to Markus Mützel <markus.muetzel@gmx.de> (Closes: #1050082)
Checksums-Sha1:
 44a857247e96feba17ca30b35c9649f984d42b31 3452 octave_8.3.0-2.dsc
 7da8b85b6adc9234a581d33b4eeff4dacef462c9 62896 octave_8.3.0-2.debian.tar.xz
Checksums-Sha256:
 f25d01cf0443bff42c1f46d2c56214629146f4bed62e47be09222b39948226d1 3452 octave_8.3.0-2.dsc
 a488e7d746e7606191cbb30d728373eab3683088d54cdf4fea0b3f17355dfd24 62896 octave_8.3.0-2.debian.tar.xz
Files:
 6dd5c824c72934265b8579706be6dfbd 3452 math optional octave_8.3.0-2.dsc
 a2305c588012956943052c07dddd24f4 62896 math optional octave_8.3.0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCAAwFiEEP0ZDkUmP6HS9tdmPISSqGYN4XJAFAmTvWokSHHJhZmFlbEBk
ZWJpYW4ub3JnAAoJECEkqhmDeFyQproQAIBkoy9SmaConLC0VRiZnqwFuwK5w+kR
6KqWHF1p5uFDWYLxXAmUh4e3goTY58WEs/EG57daLxfWhByxDKzsnDcLzdXbX93q
/vEc17om9Jb03QUGQYaa7y5EOL/8dudoK7MDED7yv7A0rwr0kbJCxLtDbv1SrPJo
gPEcbtA4J4GiHezwPYk6S6/VaPWqMHJhyZAMU+GZxb8rn2nEkfR5TD5NCpNpHK26
2TQl4P3DpmG7Xfshz/G7jmqejDy7vTqRqHBN6ICycPoTZfPUJ1NGjhXLpwf9f8+W
+cOvMrkvUv13OOfhXIzOYafAgvFV4grdafxLkCbAirqVnirbSFzQHIKJ8N5YaQUn
8ZLNlrwNfx9cj0H0IS9RQkD7GE8xvWKH+VfI9cULDiIvkxHIfw8fLPrK8lhdPcV8
z1TXx/HxXqlo3F83LuAbFawToW+zBDtdrA32/APIuquRnFdv7jSi82FcLCO5+82w
nKNB6F/sCy4qmlTJWG2d9eR84yWsV4Oguu7z35fx4qMVjMZwt//OsI57MYTSKF1r
WjxQL4UUOBadJosgtFyvEW6fBzMM6yyXvWYy6I7QxskFwG3JzgSRt2Bnv0flutGh
o1vXtobvcnTskjQIV7gzG1FnhU3UvT8cUiS+luFqFiQpaGaMM0phGtT9wv2Nf8FW
iRZEvm9Xrp6B
=9I+p
-----END PGP SIGNATURE-----

Message #55 received at 1050082@bugs.debian.org (full text, mbox, reply):

From: Graham Inggs <ginggs@debian.org>

To: Rafael Laboissière <rafael@debian.org>, 1050082@bugs.debian.org

Subject: Re: Bug#1050082: octave-image: could FTBFS due to missing .oct files

Date: Tue, 5 Sep 2023 09:40:00 +0000

Hi Rafael

On Thu, 31 Aug 2023 at 09:04, Rafael Laboissière <rafael@debian.org> wrote:
> Bug#1050082 has been (hopefully) fixed with the upload of octave/8.3.0-2.
> Could you please confirm that this really fixes the autobuild issue in
> Ubuntu?

I confirm that octave-image builds successfully in Ubuntu, without
needing my patch, against octave/8.3.0-2.

Thank you for your thorough investigation!

Regards
Graham

Send a report that this bug log contains spam.