Debian Bug report logs - #1036572
vcmi: reproducible-builds: build path triggers buildid differences

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: vcmi: reproducible-builds: build path triggers buildid differences

Date: Mon, 22 May 2023 15:18:05 -0700

[Message part 1 (text/plain, inline)]

Source: vcmi
Version: 1.1.0+dfsg-1
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Differences in the build path result in a different embedded rpath,
which results in a different buildid...

The attached patch fixes this by passing
-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to dh_auto_configure, which uses
relative paths for the embedded rpath.

According to my local tests, with this patch applied (and timestamp path
just submitted), vcmi should build reproducibly! (The salsa reprotest
job has both time and build_path variations disabled, apparently)

Thanks for maintaining vcmi!

live well,
  vagrant

[0002-debian-rules-Pass-DCMAKE_BUILD_RPATH_USE_ORIGIN-ON-v.patch (text/x-diff, inline)]

From 5a4e77f25bde94ee6e30e743ffaf844a6759aa16 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 8 May 2023 16:50:44 -0700
Subject: [PATCH 2/2] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
 dh_auto_configure.

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 2e502ae..c62df87 100755
--- a/debian/rules
+++ b/debian/rules
@@ -31,6 +31,7 @@ override_dh_auto_configure:
 	dh_auto_configure -- \
 		-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=ON \
 		-DCMAKE_INSTALL_RPATH=/usr/lib/$(DEB_HOST_MULTIARCH)/vcmi \
+		-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON \
 		-DBIN_DIR=games \
 		-DFORCE_BUNDLED_FL=OFF \
 		-DENABLE_GITVERSION=OFF \
-- 
2.39.2

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.