Debian Bug report logs - #1036521
pygopherd: reproducible-builds: Garbled pygopherd.txt /bin/sh -> dash

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: pygopherd: reproducible-builds: Garbled pygopherd.txt /bin/sh -> dash

Date: Sun, 21 May 2023 14:14:52 -0700

[Message part 1 (text/plain, inline)]

Source: pygopherd
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

When /bin/sh points to dash, pygopherd.txt is generated with garbled
content:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/pygopherd.html

  /usr/share/doc/pygopherd/pygopherd.txt.gz

  N.NA.AM.ME.E
  vs.
  NAME

...and various other oddities.

The first attached patch fixes this by adjusting the upstream Makefile
to explicitly call groff with bash.

And... for good measure, a second patch switches to using utf8; this is
2023 after all!


Thanks for maintaining pygopherd!


live well,
  vagrant

[0001-Makefile-Explicitly-call-groff-using-bash-when-gener.patch (text/x-diff, inline)]

From b28d8fe57a1032bcc9d9bfa73b35516a7fd4c010 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 21 May 2023 13:50:34 -0700
Subject: [PATCH 1/2] Makefile: Explicitly call groff using bash when
 generating pygopherd.txt.

When /bin/sh is dash, the resulting pygohperd.txt is a bit garbled.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 3312e6d..e2416e2 100644
--- a/Makefile
+++ b/Makefile
@@ -58,4 +58,4 @@ doc/pygopherd.pdf: doc/pygopherd.ps
 	mv pygopherd.pdf doc
 
 doc/pygopherd.txt:
-	groff -Tascii -man doc/pygopherd.8 | sed $$'s/.\b//g' > doc/pygopherd.txt
+	bash -c "groff -Tascii -man doc/pygopherd.8 | sed $$'s/.\b//g' > doc/pygopherd.txt"
-- 
2.39.2

[0002-Makefile-Generate-pygopherd.txt-with-utf8.patch (text/x-diff, inline)]

From be277736b9fc85a7df1d76318e931ae289bc3034 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 21 May 2023 14:00:30 -0700
Subject: [PATCH 2/2] Makefile: Generate pygopherd.txt with utf8.

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index e2416e2..256e3eb 100644
--- a/Makefile
+++ b/Makefile
@@ -58,4 +58,4 @@ doc/pygopherd.pdf: doc/pygopherd.ps
 	mv pygopherd.pdf doc
 
 doc/pygopherd.txt:
-	bash -c "groff -Tascii -man doc/pygopherd.8 | sed $$'s/.\b//g' > doc/pygopherd.txt"
+	bash -c "groff -Tutf8 -man doc/pygopherd.8 | sed $$'s/.\b//g' > doc/pygopherd.txt"
-- 
2.39.2

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.