Debian Bug report logs - #1035365
lombok: reproducible-builds: build timestamps in files inside of .jar

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: lombok: reproducible-builds: build timestamps in files inside of .jar

Date: Mon, 01 May 2023 17:13:46 -0700

[Message part 1 (text/plain, inline)]

Source: lombok
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps timezone
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build timestamp is embedded in various files inside
/usr/share/java/lombok-1.18.24.jar:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/lombok.html

  META-INF/services/lombok.core.LombokApp

  #·Thu,·25·Apr·2024·11:27:09·-1200
  vs.
  #·Sat,·25·Mar·2023·07:05:45·+1400

The attached patch fixes this by removing the code in
SpiProcessorPersistence.java which adds the build timestamp.

If a date is for some reason necessary to embed in these files, another
option might be to use the SOURCE_DATE_EPOCH environment variable:

  https://reproducible-builds.org/docs/source-date-epoch/


Unfortunately, there may be other non-deterministic issues which prevent
lombok from building reproducibly, but applying this patch should
significantly reduce the noise generated from timestamps.


Thanks for maintaining lombok!


live well,
  vagrant

[0001-src-spiProcessor-lombok-spi-SpiProcessorPersistence..patch (text/x-diff, inline)]

From 9e2381870db66336dee2ac7b1ad6ef00f131cdac Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 1 May 2023 16:27:59 -0700
Subject: [PATCH 1/3] src/spiProcessor/lombok/spi/SpiProcessorPersistence.java:
 Avoid embedding the build timestamp.

https://reproducible-builds.org/docs/timestamps/
---
 src/spiProcessor/lombok/spi/SpiProcessorPersistence.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/spiProcessor/lombok/spi/SpiProcessorPersistence.java b/src/spiProcessor/lombok/spi/SpiProcessorPersistence.java
index 794473a..2d91b02 100644
--- a/src/spiProcessor/lombok/spi/SpiProcessorPersistence.java
+++ b/src/spiProcessor/lombok/spi/SpiProcessorPersistence.java
@@ -141,7 +141,6 @@ class SpiProcessorPersistence {
 		FileObject output = filer.createResource(StandardLocation.CLASS_OUTPUT, "", path + serviceName);
 		Writer writer = output.openWriter();
 		writer.write("# Generated by " + name + "\n");
-		writer.write("# " + new SimpleDateFormat("EEE, d MMM yyyy HH:mm:ss Z", Locale.US).format(new Date()) + "\n");
 		writer.write(value);
 		writer.close();
 	}
-- 
2.39.2

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.