Debian Bug report logs - #1034431
FTBFS creating vof.bin when /bin/sh -> bash

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: FTBFS creating vof.bin when /bin/sh -> bash

Date: Fri, 14 Apr 2023 21:09:21 -0700

[Message part 1 (text/plain, inline)]

Source: qemu
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: shell ftbfs
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

When /bin/sh points to bash (instead of dash), the behavior of "echo"
differs in the rendering of "\n", and so the debian/rules target for
vof.bin fails to correctly create the config.mak.

The attached patch fixes this by switching to use printf, which appears
to behave consistently regardless of the shell (at least with my quick
testing).

Thanks for maintaining qemu!

live well,
  vagrant

[0001-debian-rules-Use-printf-instead-of-echo-to-avoid-dif.patch (text/x-diff, inline)]

From 18c9ac7af5cfad59ed06978baaf1e6a741accbd2 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 14 Apr 2023 20:11:08 -0700
Subject: [PATCH] debian/rules: Use 'printf' instead of 'echo' to avoid
 differences in underlying /bin/sh implementations.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 28f258b8..c22fcefb 100755
--- a/debian/rules
+++ b/debian/rules
@@ -477,7 +477,7 @@ sysdata-components += skiboot
 build-vof: b/vof/vof.bin
 b/vof/vof.bin: | b
 	mkdir -p b/vof
-	echo 'CC=$${CROSS}gcc\nLD=$${CROSS}ld\nOBJCOPY=$${CROSS}objcopy\nEXTRA_CFLAGS=-m32 -mbig-endian' > b/vof/config.mak
+	printf 'CC=$${CROSS}gcc\nLD=$${CROSS}ld\nOBJCOPY=$${CROSS}objcopy\nEXTRA_CFLAGS=-m32 -mbig-endian' > b/vof/config.mak
 	${MAKE} -C b/vof CROSS=${PPC64_CROSSPFX} SRC_DIR=../../pc-bios/vof -f../../pc-bios/vof/Makefile
 install-vof: b/vof/vof.bin
 	install -m 0644 -t ${sysdataidir} $<
-- 
2.39.2

[signature.asc (application/pgp-signature, inline)]

Message #12 received at 1034431-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1034431-close@bugs.debian.org

Subject: Bug#1034431: fixed in qemu 1:8.0~rc4+dfsg-2

Date: Tue, 18 Apr 2023 02:51:42 +0000

Source: qemu
Source-Version: 1:8.0~rc4+dfsg-2
Done: Michael Tokarev <mjt@tls.msk.ru>

We believe that the bug you reported is fixed in the latest version of
qemu, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1034431@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Tokarev <mjt@tls.msk.ru> (supplier of updated qemu package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 18 Apr 2023 05:04:04 +0300
Source: qemu
Architecture: source
Version: 1:8.0~rc4+dfsg-2
Distribution: experimental
Urgency: medium
Maintainer: Debian QEMU Team <pkg-qemu-devel@lists.alioth.debian.org>
Changed-By: Michael Tokarev <mjt@tls.msk.ru>
Closes: 825841 1034431
Changes:
 qemu (1:8.0~rc4+dfsg-2) experimental; urgency=medium
 .
   [ Vagrant Cascadian ]
   * debian/rules: Use 'printf' instead of 'echo' to avoid
     differences in underlying /bin/sh implementations.
     Closes: #1034431
 .
   [ Michael Tokarev ]
   * Provide Debian architecture names for qemu-system-foo packages and
     binaries, for arm64, armel, armhf, powerpc, amd64, loong64 and ppc64el.
     It is now possible to run qemu-system-$debianarch binary or depend on
     qemu-system-$debianarch package. This should simplify various tools
     for cross compilation and the like. Also Closes: #825841.
   * d/qemu-system-ppc.README.Debian: remove obsolete README about video.x
Checksums-Sha1:
 5abceb79afde808b66f5d028270cf3e583c002c3 6518 qemu_8.0~rc4+dfsg-2.dsc
 320e8b663f069405b4112e4244660f1299816574 102980 qemu_8.0~rc4+dfsg-2.debian.tar.xz
 aec8e28823afbc5a1a980395a7d39a02d6c98f03 11106 qemu_8.0~rc4+dfsg-2_source.buildinfo
Checksums-Sha256:
 ecfd8fa803f7bb26609e85f1bdfc5078ccda0615f259f46f49c5555b7b2b9ce7 6518 qemu_8.0~rc4+dfsg-2.dsc
 e7a8606fc5bc1374bf21551ed06b59010a93b1cbffd65cabab85730bdcbc367e 102980 qemu_8.0~rc4+dfsg-2.debian.tar.xz
 2e1916f659b87082beb4c9c082589d8cdecfc5ac34a5aef67b0e4c56f391e719 11106 qemu_8.0~rc4+dfsg-2_source.buildinfo
Files:
 dc7edd453ef5d678ac4410c4cc12889f 6518 otherosfs optional qemu_8.0~rc4+dfsg-2.dsc
 1b0887c1022f6c61f16547ef28082f62 102980 otherosfs optional qemu_8.0~rc4+dfsg-2.debian.tar.xz
 b148c01a90ff23376d4f90c4d489822d 11106 otherosfs optional qemu_8.0~rc4+dfsg-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCgAtFiEEe3O61ovnosKJMUsicBtPaxppPlkFAmQ+ACEPHG1qdEB0bHMu
bXNrLnJ1AAoJEHAbT2saaT5ZLdAH/0lO/1FABJ08fKLFVTBOGgEmmy02hcQLoo8Y
GgkG6kWD+OVtkGqGAPIKix0W9WfhTdv2Hm1oV6rzeyiSNTifb+/aYSlI+LVisT35
H6mgkdAvxAJnYb4zQGDObY9uARBQjZOsOWoXFDL0qI5po3948J4Ty6dvkStufJLZ
0yfsakc4ubcs/tJ3ecjln09WUhSZmemJYdZM0/3JL88LsarfN1ORsmRei79Zup1o
zAWUALfl88OJWFzHUcIlovSW2vIhgk3Qcr5LuYzIyuWxoCx9n2JtJN87NZSDP5Xf
XElG/+Qz8jPWrhcZxHWvRgXUh83lqB7MG9ZnwXOAsuN0PMc164A=
=qWKq
-----END PGP SIGNATURE-----

Message #17 received at 1034431@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: 1034431@bugs.debian.org

Subject: Bug#1034431: FTBFS creating vof.bin when /bin/sh -> bash

Date: Thu, 20 Apr 2023 16:12:35 -0700

[Message part 1 (text/plain, inline)]

Control: found 1034431 1:7.2+dfsg-5

Also appears in the older version... and we fixed these tests on
tests.reproducible-builds.org, so it will likely start to FTBFS there...

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #24 received at 1034431-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1034431-close@bugs.debian.org

Subject: Bug#1034431: fixed in qemu 1:7.2+dfsg-6

Date: Sat, 29 Apr 2023 11:21:19 +0000

Source: qemu
Source-Version: 1:7.2+dfsg-6
Done: Michael Tokarev <mjt@tls.msk.ru>

We believe that the bug you reported is fixed in the latest version of
qemu, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1034431@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Tokarev <mjt@tls.msk.ru> (supplier of updated qemu package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 29 Apr 2023 13:02:55 +0300
Source: qemu
Architecture: source
Version: 1:7.2+dfsg-6
Distribution: unstable
Urgency: medium
Maintainer: Debian QEMU Team <pkg-qemu-devel@lists.alioth.debian.org>
Changed-By: Michael Tokarev <mjt@tls.msk.ru>
Closes: 811087 1034431
Changes:
 qemu (1:7.2+dfsg-6) unstable; urgency=medium
 .
   [ Michael Tokarev ]
   * sync with upstream v7.2.1 stable release, into d/patches/v7.2.1.diff.
     All patches from 7.2.1 (besides stuff not relevant for linux, such
     as mingw compilation fixes) has already been in d/patches/master/,
     now they're in single upstream patch file
   * v7.2.2.diff: upstream 7.2.2 stable/bugfix release
   * hw-pvrdma-protect-against-guest-driver-CVE-2022-1050.patch:
     remove, included in v7.2.2
   * d/rules, d/qemu.desktop: provide an icon for gtk display (qemu.display)
   * d/gbp.conf: set debian branch to debian-bookworm
   * pick 3 more fixes from qemu-devel@:
     rtl8139-fix-large_send_mss-divide-by-zero.patch
     target_i386-Change-wrong-XFRM-value.patch
     hw_mips_malta-Fix-malta-machine-on-big-endian-hosts.patch
   * +linux-user-fix-getgroups-setgroups-allocations.patch (Closes: #811087)
 .
   [ Vagrant Cascadian ]
   * debian/rules: Use 'printf' instead of 'echo' to avoid differences
     in underlying /bin/sh implementations. Closes: #1034431
Checksums-Sha1:
 c2cb1e159ef7719fe59daa205630cc4cf2c78f1b 6450 qemu_7.2+dfsg-6.dsc
 5dba953198cc768762319cef52a86905465a40d5 125508 qemu_7.2+dfsg-6.debian.tar.xz
 6e0ce392a5d222b08e7163a773deab856b69683b 11322 qemu_7.2+dfsg-6_source.buildinfo
Checksums-Sha256:
 d8bb951d13f790e3e24730741bb58829f606207a047cd1dedbbc96ced735898d 6450 qemu_7.2+dfsg-6.dsc
 fdaedf711f1c84bf0c6a9c0cc1817dd38a25917470773b068e3c8670d371f772 125508 qemu_7.2+dfsg-6.debian.tar.xz
 0f753517944332d2eb89209e8db4debae0f399f9254d0bb02401f1db8908161b 11322 qemu_7.2+dfsg-6_source.buildinfo
Files:
 283effb6437e1b7ed3fc0eea438651bd 6450 otherosfs optional qemu_7.2+dfsg-6.dsc
 9f84e7b63893ee6c99a80df7d015b0a2 125508 otherosfs optional qemu_7.2+dfsg-6.debian.tar.xz
 3ae5bcb3492108d7c042fe078aa25315 11322 otherosfs optional qemu_7.2+dfsg-6_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQFDBAEBCgAtFiEEe3O61ovnosKJMUsicBtPaxppPlkFAmRM9GoPHG1qdEB0bHMu
bXNrLnJ1AAoJEHAbT2saaT5ZucQIAMU6hNTlW1UBY4DyAJjFQkBkXhKB+OhRgZGl
MIAzEilEA21vuByIvFugLw6A26PQcjHJZI6CrGst3kY3YdWWZJ6Y2qfPqzGhnXsb
67+Aq0Re3UYxngYS1Q3R+rq2nK7KnxUHdQz2xQhsIYDGiL1IQCFctT2AaQMbxdV5
EP6lYy5rLnVb7//HhIeiNS1ntTbdZ0uI1QMKuirlLYYfnV6PzsodIkESn5okY0bO
1QoBmNBRCWRLQPql5m62Z2S9AX0EWlhUHDkVZoA4jfaePamJuJo3cuHXiYFHveEz
ByM/bLbxfgEqg+5eVzI5KvxpK9kLAS9oKm5FRSXtGbT8D7DoRFg=
=jDR0
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.