Debian Bug report logs - #1034423
php8.2: reproducible-builds: Paths to sed in php-config8.2 and and phpize8.2

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: php8.2: reproducible-builds: Paths to sed in php-config8.2 and and phpize8.2

Date: Fri, 14 Apr 2023 13:47:58 -0700

[Message part 1 (text/plain, inline)]

Source: php8.2
Severity: serious
Justification: TC resolution #994388
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The paths to sed are embedded in two scripts shipped in /usr/bin:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/php8.2.html

  /usr/bin/php-config8.2

  SED="/bin/sed"
  vs.
  SED="/usr/bin/sed"

It appears this was attempted to be fixed in an earlier php package, but
the fix was either never effective, or has for some reason become
ineffective:

  https://bugs.debian.org/1015188

The attached patch fixes this by explicitly specifying the /usr/bin
path, which is compatible with both usrmerge and non-usrmerge systems.

Other approaches would be to adapt configure to be able to override the
autodetection of the path for SED, or perhaps ideal would be to specify
SED without any path, assuming it is always run in an environment where
PATH is set correctly.

Unfortunately, there are other outstanding issues and this patch is not
sufficient to make php8.2 reproducible, but it should reduce the
differences.

Thanks for maintaining php8.2!

live well,
  vagrant

[0001-scripts-php-.in-Explicitly-define-the-path-to-sed.patch (text/x-diff, inline)]

From 830b885bf5495bd079bf698c7a3352ccf7a38633 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 13 Apr 2023 15:59:57 -0700
Subject: [PATCH] scripts/php*.in: Explicitly define the path to sed.

The full path is detected by configure, resulting in a different build
depending on if it is built on a usrmerge or non-usrmerge system.

Since usrmerge systems contain compatibility symlinks for the
non-usrmerge paths, use the non-usrmerge path which is compatible in
both systems.

https://tests.reproducible-builds.org/debian/issues/bookworm/paths_vary_due_to_usrmerge_issue.html
---
 scripts/php-config.in | 2 +-
 scripts/phpize.in     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/php-config.in b/scripts/php-config.in
index 45a07597..05307ee3 100644
--- a/scripts/php-config.in
+++ b/scripts/php-config.in
@@ -1,6 +1,6 @@
 #! /bin/sh
 
-SED="@SED@"
+SED="/bin/sed"
 prefix="@prefix@"
 datarootdir="@datarootdir@"
 exec_prefix="@exec_prefix@"
diff --git a/scripts/phpize.in b/scripts/phpize.in
index 0dcfe21d..0d71e795 100644
--- a/scripts/phpize.in
+++ b/scripts/phpize.in
@@ -7,7 +7,7 @@ exec_prefix="`eval echo @exec_prefix@`"
 phpdir="$prefix/lib/php/@DEBIAN_PHP_API@/build"
 includedir="$prefix/include/php/@DEBIAN_PHP_API@"
 builddir="`pwd`"
-SED="@SED@"
+SED="/bin/sed"
 
 libtool_version=$(dpkg-query -f'${Version}' -W libtool)
 aclocaldir="$prefix/share/aclocal"
-- 
2.39.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1034423-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1034423-close@bugs.debian.org

Subject: Bug#1034423: fixed in php8.2 8.2.5-2

Date: Thu, 27 Apr 2023 10:21:17 +0000

Source: php8.2
Source-Version: 8.2.5-2
Done: Ondřej Surý <ondrej@debian.org>

We believe that the bug you reported is fixed in the latest version of
php8.2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1034423@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ondřej Surý <ondrej@debian.org> (supplier of updated php8.2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Thu, 27 Apr 2023 10:13:47 +0200
Source: php8.2
Architecture: source
Version: 8.2.5-2
Distribution: unstable
Urgency: medium
Maintainer: Debian PHP Maintainers <team+pkg-php@tracker.debian.org>
Changed-By: Ondřej Surý <ondrej@debian.org>
Closes: 1034423 1034892
Changes:
 php8.2 (8.2.5-2) unstable; urgency=medium
 .
   * Hard code sed path to /bin/sed (Closes: #1034423)
   * Remove timestamps from phar (Closes: #1034892)
Checksums-Sha1:
 68fb17e920ae91cb68de27ee690110d5c72e90a5 5684 php8.2_8.2.5-2.dsc
 5ed87998075c4793f4a9cda0c930004a07c86b8d 69324 php8.2_8.2.5-2.debian.tar.xz
 29b57be5d6ec978297a7cf8a2e128362f5709d7c 32494 php8.2_8.2.5-2_amd64.buildinfo
Checksums-Sha256:
 d2e91cc90ed5e43cd1995bdf44aa7e86a4b30fd9323b948558b178d25b62a907 5684 php8.2_8.2.5-2.dsc
 fa1a9d7c27d7625db7d4e22783681a19d685682c9499fdbd42b4b291836458ff 69324 php8.2_8.2.5-2.debian.tar.xz
 c80a675b694cf5830e103bbf5dd48c6c7942bfefbfb3d3e4ef6eb13781f3af41 32494 php8.2_8.2.5-2_amd64.buildinfo
Files:
 c8bd56536b06eeb41e90699f6a72998f 5684 php optional php8.2_8.2.5-2.dsc
 dc8bda29cf9899e76953dbfdbff6c828 69324 php optional php8.2_8.2.5-2.debian.tar.xz
 3e8fc9dc0f74f95726d6b39e3b51b2a4 32494 php optional php8.2_8.2.5-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEw2Gx4wKVQ+vGJel9g3Kkd++uWcIFAmRKSOpfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEMz
NjFCMUUzMDI5NTQzRUJDNjI1RTk3RDgzNzJBNDc3RUZBRTU5QzIACgkQg3Kkd++u
WcJlZBAAiZKNXXE4lkks1covja61GDZZ80BqzIfjR7inLR1v1/Bo5UZbv12t1qNB
fz4livV/8BGQMkAFtAfhLRFkNJs1Mr0FVex95YXHWr0j9AfjT7cy+Lk5kUpyqPv1
JLj4QCddUeyFWxGzvZb7x1LxJQt33S5wWK4lmuXmlw4/GPgO7wdYayn5IrS0vp9/
5Z2oeoL9E/ELtfZKkx9vRoRfz61ywdp4KYt6U14bHM9Sj3xRvk3eENCJW3ZrJp7l
7l5Rva1soKd5evvo4FOKOZEN8+Z4+NFwBk09wf66Fg4oHPrOo+vhOX+fHJcQyOV7
2Sgm69LczoAup+MCrIcZD93/Ms5k24FQcD7E2VuuhrKqZMygBlPyio2iVPZxy9mU
fXlX5ino9eiS2rAdIkzPhK0UrmBoiR2kxPayqMqzh45wLLK35Ok/lpzeI8QNam4k
qZbyx34Eo8c3KXBz7+I19BLd72k6oZTq+xWTrQYpzP6gad+u0tOGGab6REZhbesn
HZp0hCYwS75pPruAbFY5IwftdSme6x2Mthq1o0m0iTlpG4iaaLqeTAPKqJDndYeT
27Hju68Fm/8KJo5l3EWdloKzg3SGo9Rh9g11WLqVI75BYTwXLRp0ihF6B2XUjDjp
jB15H/9a7au77ZUoSQjfNFUBTaDedsJJU6b3uYaOiufW0T5JvVc=
=/0HO
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.