Debian Bug report logs - #1029574
indent shebang bug and misses LFS support

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Helge Deller <deller@gmx.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: indent shebang bug and misses LFS support

Date: Tue, 24 Jan 2023 18:48:01 +0100

[Message part 1 (text/plain, inline)]

Package:  indent
Version: 2.2.12
Tags: hppa, patch, lfs, FTBFS

The indent package has a bug in the script "regression/TEST"
which starts with "#/bin/sh" instead of a correct
shebang which would be "#!/bin/sh". This leads to a FTBFS on
the hppa architecture when running virtualized in qemu-user.

Secondly it would be nice if the indent tool would be built
with large file support. Adding future=+lfs to DEB_BUILD_MAINT_OPTIONS
allows that.

Both are fixed with attached patch. Please apply for next upload.

Thanks,
Helge

[indent.patch (text/x-patch, attachment)]

Message #10 received at 1029574@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: Helge Deller <deller@gmx.de>, 1029574@bugs.debian.org

Subject: Re: Bug#1029574: indent shebang bug and misses LFS support

Date: Tue, 24 Jan 2023 20:07:57 +0100

El 24/1/23 a las 18:48, Helge Deller escribió:
> Package:  indent
> Version: 2.2.12
> Tags: hppa, patch, lfs, FTBFS
> 
> The indent package has a bug in the script "regression/TEST"
> which starts with "#/bin/sh" instead of a correct
> shebang which would be "#!/bin/sh". This leads to a FTBFS on
> the hppa architecture when running virtualized in qemu-user.
> 
> Secondly it would be nice if the indent tool would be built
> with large file support. Adding future=+lfs to DEB_BUILD_MAINT_OPTIONS
> allows that.
> 
> Both are fixed with attached patch. Please apply for next upload.

Thanks for the report and the patch.

I'm curious about the LFS issue: Is it really a good idea to have a .c
file larger than 2GB? I did a quick search and found this tweet:

https://twitter.com/cristalopes/status/776569616692752384

  The largest C++ file we found in GitHub has 528Mb, 57 lines of code.
  Contains the first 50,847,534 primes, all hard coded in an array.

So: What would be the rationale for adding LFS support to the indent program?
"Just in case"?


Another question: I see there are now several ways to enable LFS. In procmail
I had this in debian/rules:

CFLAGS := $(shell dpkg-buildflags --get CFLAGS) $$(getconf LFS_CFLAGS)

Is that equivalent to using future=+lfs or are there any differences?

Thanks.

Message #13 received at 1029574-forwarded@bugs.debian.org (full text, mbox, reply):

From: Santiago Vila <sanvila@debian.org>

To: bug-indent@gnu.org

Cc: Helge Deller <deller@gmx.de>

Subject: Fwd: Bug#1029574: indent shebang bug and misses LFS support

Date: Tue, 24 Jan 2023 20:18:45 +0100

[Message part 1 (text/plain, inline)]

Dear indent authors / hello Andrej.

I received the following report from the Debian bug system.

The shebang thing is clearly an upstream bug.

Regarding the LFS issue, I wonder if it would be possible for
the ./configure script to take care of that (I have no idea).

Thanks.

-------- Mensaje reenviado --------
Asunto: Bug#1029574: indent shebang bug and misses LFS support
Resent-Date: Tue, 24 Jan 2023 17:51:02 +0000
Resent-From: Helge Deller <deller@gmx.de>
Resent-To: debian-bugs-dist@lists.debian.org
Resent-CC: Santiago Vila <sanvila@debian.org>
Fecha: Tue, 24 Jan 2023 18:48:01 +0100
De: Helge Deller <deller@gmx.de>

Package:  indent
Version: 2.2.12
Tags: hppa, patch, lfs, FTBFS

The indent package has a bug in the script "regression/TEST"
which starts with "#/bin/sh" instead of a correct
shebang which would be "#!/bin/sh". This leads to a FTBFS on
the hppa architecture when running virtualized in qemu-user.

Secondly it would be nice if the indent tool would be built
with large file support. Adding future=+lfs to DEB_BUILD_MAINT_OPTIONS
allows that.

Both are fixed with attached patch. Please apply for next upload.

Thanks,
Helge

[indent.patch (text/x-patch, attachment)]

Message #18 received at 1029574@bugs.debian.org (full text, mbox, reply):

From: Helge Deller <deller@gmx.de>

To: Santiago Vila <sanvila@debian.org>, 1029574@bugs.debian.org

Subject: Re: Bug#1029574: indent shebang bug and misses LFS support

Date: Tue, 24 Jan 2023 20:59:21 +0100

Hi Santiago,

On 1/24/23 20:07, Santiago Vila wrote:
> El 24/1/23 a las 18:48, Helge Deller escribió:
>> Package:  indent
>> Version: 2.2.12
>> Tags: hppa, patch, lfs, FTBFS
>>
>> The indent package has a bug in the script "regression/TEST"
>> which starts with "#/bin/sh" instead of a correct
>> shebang which would be "#!/bin/sh". This leads to a FTBFS on
>> the hppa architecture when running virtualized in qemu-user.
>>
>> Secondly it would be nice if the indent tool would be built
>> with large file support. Adding future=+lfs to DEB_BUILD_MAINT_OPTIONS
>> allows that.
>>
>> Both are fixed with attached patch. Please apply for next upload.
>
> Thanks for the report and the patch.
>
> I'm curious about the LFS issue: Is it really a good idea to have a .c
> file larger than 2GB? I did a quick search and found this tweet:

LFS is not just the 2GB limit (_LARGEFILE_SOURCE) when opening files.
I see in src/backup.c the readdir() glibc call is used, which
may fail randomly on big filesystems when built as 32bit binary.
See e.g: https://www.mjr19.org.uk/sw/inodes64.html
For that the define _FILE_OFFSET_BITS=64 is needed to work reliable.

> https://twitter.com/cristalopes/status/776569616692752384
>
>    The largest C++ file we found in GitHub has 528Mb, 57 lines of code.
>    Contains the first 50,847,534 primes, all hard coded in an array.
>
> So: What would be the rationale for adding LFS support to the indent program?
> "Just in case"?

_FILE_OFFSET_BITS=64, needed for readdir() call.

> Another question: I see there are now several ways to enable LFS. In procmail
> I had this in debian/rules:
>
> CFLAGS := $(shell dpkg-buildflags --get CFLAGS) $$(getconf LFS_CFLAGS)
>
> Is that equivalent to using future=+lfs or are there any differences?

Yes, your above code should work:
(sid_hppa)deller@pacific:~/$    getconf LFS_CFLAGS
-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64

Those are the defines which are needed.

Btw, if you add the "_TIME_BITS=64" define too, your are even 64-bit ready...

Thanks!
Helge

Message #23 received at 1029574-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1029574-close@bugs.debian.org

Subject: Bug#1029574: fixed in indent 2.2.12-4

Date: Wed, 25 Jan 2023 18:49:21 +0000

Source: indent
Source-Version: 2.2.12-4
Done: Santiago Vila <sanvila@debian.org>

We believe that the bug you reported is fixed in the latest version of
indent, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1029574@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Santiago Vila <sanvila@debian.org> (supplier of updated indent package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 25 Jan 2023 19:35:00 +0100
Source: indent
Architecture: source
Version: 2.2.12-4
Distribution: unstable
Urgency: medium
Maintainer: Santiago Vila <sanvila@debian.org>
Changed-By: Santiago Vila <sanvila@debian.org>
Closes: 1029574
Changes:
 indent (2.2.12-4) unstable; urgency=medium
 .
   [ Helge Deller ]
   * Add missing shebang to regression/TEST. Closes: #1029574.
     Should fix a FTBFS problem in hppa.
   * Build with Large File Support. Closes: #1029574.
 .
   [ Santiago Vila ]
   * Run unit tests with C locale.
Checksums-Sha1:
 ce856e8a964090886b64d3e91448955717828243 1433 indent_2.2.12-4.dsc
 e2ef9ae22a0c1990bbda58e38fa6106b59c7944d 6624 indent_2.2.12-4.debian.tar.xz
 a6f373b9330a3db70c2083caf0ed64fba0e0d5e4 5436 indent_2.2.12-4_source.buildinfo
Checksums-Sha256:
 6324de46a40a8725111972d1daaa5a611ee29fd402ae5ca6683cf60b00ce417b 1433 indent_2.2.12-4.dsc
 1ed0bcd1403e3961731da586c2e5830742a15afb08bc51677d74f986aba7d0cb 6624 indent_2.2.12-4.debian.tar.xz
 e4d6649ab6ece497d187636d745d70b7a4e7473aa35efa59931bb2259839ee4f 5436 indent_2.2.12-4_source.buildinfo
Files:
 d46e6056c9e4034f750ca52de97d219e 1433 devel optional indent_2.2.12-4.dsc
 16be000d512aef3fe7cd4716414b0a67 6624 devel optional indent_2.2.12-4.debian.tar.xz
 4721a0821d56e51452da8f6c038c2a2f 5436 devel optional indent_2.2.12-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE1Uw7+v+wQt44LaXXQc5/C58bizIFAmPRdzMACgkQQc5/C58b
izKvEQgAhkdJBOVvWreB+AVyOQuR13WCmviB/ojfVHXebjVkLu5iWn2P8YdsrUlR
FUdbZ263l0mZrWLEyp4IFGnnq0v7wdtLZgvGONxGA9ArWFuYWtWkPU+89470y4ZY
WmFuRGzcwGJoPwH5BBsLieA4t1WXWQFKstuc+feqZg9aeaICjjPZ6m55TW/wdY6i
tG14+FyJR+x7OppPYYLME8wYKP5dwXck4p3OMvxvHP+v28r+yniR3Sa4Xw7vPm4P
y49peuC3rdVfke8S+T3Yb0+lHap/vvYi9BuSHHr8OZAKL09Z/808EhqPxwpXpMUj
lf7B5DACyq1JA4q8iTUaXf68Bv6i3g==
=y+rK
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.