Debian Bug report logs - #1029295
python-miio: Compatibility with python3-click > 8.0 (& make the build reproducible)

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: python-miio: Compatibility with python3-click > 8.0 (& make the build reproducible)

Date: Fri, 20 Jan 2023 11:11:19 -0800

[Message part 1 (text/plain, inline)]

Source: python-miio
Version: 0.5.0.1-2
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
python-miio could not be built reproducibly.

This because the generation of the manual pages via help2man was
resulting in an error and thus the inclusion of a Python traceback
within those manpages. This traceback specified the absolute build
path which made the build unreproducible. (As it happens, I believe
there is a Lintian check for manpages that include Python tracebacks.)

However, I believe the issue is deeper than just a reproducibility
issue, in that miio is not actually compatible with python3-click
versions greater than 8.0, as that is the version that Click renamed
the "resultcallback" method to "result_callback":

  https://click.palletsprojects.com/en/8.1.x/api/#click.MultiCommand.result_callback

Patch attached that simply renames these methods.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[python-miio.diff.txt (text/plain, attachment)]

Send a report that this bug log contains spam.