Debian Bug report logs - #1027992
towncrier: Remove temporary files created during build

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: towncrier: please make the build reproducible

Date: Thu, 05 Jan 2023 17:28:04 +0000

[Message part 1 (text/plain, inline)]

Source: towncrier
Version: 21.9.0-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: randomness
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
towncrier could not be built reproducibly.

This is because the testsuite generates a bunch of Python modules with
nondeterminstic contents, which then get installed into the binary
package.

Patch attached that cleans these up after running the tests.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[towncrier.diff.txt (text/plain, attachment)]

Message #10 received at 1027992@bugs.debian.org (full text, mbox, reply):

From: Ben Finney <bignose@debian.org>

To: Chris Lamb <lamby@debian.org>, 1027992@bugs.debian.org

Subject: Re: Bug#1027992: towncrier: Remove temporary files created during build

Date: Fri, 6 Jan 2023 13:52:43 +1100

[Message part 1 (text/plain, inline)]

Control: retitle -1 towncrier: Remove temporary files created during build
Control: tags -1 + pending

On 05-Jan-2023, Chris Lamb wrote:

> This is because the testsuite generates a bunch of Python modules with
> nondeterminstic contents, which then get installed into the binary
> package.

Thanks. Specifically, these are created by Twisted Trial and then left
behind as cruft.

> Patch attached that cleans these up after running the tests.

Since the files are created during PyBuild's operation, I prefer to
instruct PyBuild how to clean it up.

I have applied this change:

=====
modified   debian/changelog
@@ -4,6 +4,7 @@ towncrier (21.9.0-3) UNRELEASED; urgency=medium
   * Declare Build-Depends for architecture-independent packages.
   * Remove a Lintian override for documentation files in wrong directory.
     The files should in fact not be in the package; Lintian is correct.
+  * Remove cruft from the build directory left there by Twisted Trial.
 
  --
 
modified   debian/rules
@@ -17,6 +17,10 @@ export PYBUILD_INSTALL_ARGS = \
 export http_proxy = http://127.0.1.1:9/
 export https_proxy = ${http_proxy}
 
+# Twisted Trial creates temporary Python modules and doesn't clean up.
+twisted_trial_cruft = ${MAIN_PYTHON_PACKAGE}.test.*
+export PYBUILD_AFTER_TEST = rm -r "{build_dir}"/${twisted_trial_cruft}
+
 ␌
 %:
        dh $@ --with python3 --buildsystem=pybuild
=====

-- 
 \       “Pinky, are you pondering what I'm pondering?” “Well, I think |
  `\        so, Brain, but I can't memorize a whole opera in Yiddish.” |
_o__)                                           —_Pinky and The Brain_ |
Ben Finney <bignose@debian.org>

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 1027992@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Ben Finney" <bignose@debian.org>, 1027992@bugs.debian.org

Subject: Re: Bug#1027992: towncrier: Remove temporary files created during build

Date: Fri, 06 Jan 2023 08:51:47 +0000

Hi Ben,

> +twisted_trial_cruft = ${MAIN_PYTHON_PACKAGE}.test.*
> +export PYBUILD_AFTER_TEST = rm -r "{build_dir}"/${twisted_trial_cruft}

Ah, that's much cleaner. Thank you.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #24 received at 1027992-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1027992-close@bugs.debian.org

Subject: Bug#1027992: fixed in towncrier 22.12.0-1

Date: Thu, 12 Jan 2023 04:51:41 +0000

Source: towncrier
Source-Version: 22.12.0-1
Done: Ben Finney <bignose@debian.org>

We believe that the bug you reported is fixed in the latest version of
towncrier, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1027992@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ben Finney <bignose@debian.org> (supplier of updated towncrier package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 12 Jan 2023 15:22:18 +1100
Source: towncrier
Architecture: source
Version: 22.12.0-1
Distribution: unstable
Urgency: medium
Maintainer: Ben Finney <bignose@debian.org>
Changed-By: Ben Finney <bignose@debian.org>
Closes: 1027992
Changes:
 towncrier (22.12.0-1) unstable; urgency=medium
 .
   * The “Claudio Cappelli” release.
 .
   [ Ben Finney ]
 .
   * New upstream release.
     Highlights since previous release:
     * Support Python version 3.7 – 3.11.
     * The ‘check’ command now works for branches that change the news file.
     * The ‘create’ command now has a ‘-m TEXT’ option to define the content
       of the newly created fragment.
     * The ‘build’ command now has a ‘--keep’ option to keep fragments in
       place.
     * Support having the release notes for each version in a separate file.
     * Support fragments not associated with any issue.
     * Default branch for `towncrier check` is now "origin/main"
       (not "origin/master").
   * Declare conformance to “Standards-Version: 4.6.2”.
     No additional changes needed.
   * Declare Build-Depends for architecture-independent packages.
   * Remove a Lintian override for documentation files in wrong directory.
     The files should in fact not be in the package; Lintian is correct.
   * Remove cruft from the build directory left there by Twisted Trial.
     Closes: bug#1027992. Thanks to Chris Lamb for the report.
   * Update URLs for upstream metadata.
   * Merge ‘towncrier(1)’ manual page work from sergiosacj.
     Thanks to Sérgio de Almeida Cipriano Junior.
 .
   [ Sérgio de Almeida Cipriano Junior ]
 .
   * Update UScan configuration to query Python Package Index releases.
Checksums-Sha1:
 626f7c733fb14de3b2cbe3dea8b89902f5a79e04 2113 towncrier_22.12.0-1.dsc
 106526483b2f455d09d5b5e8f7a7e7de7da64072 54660 towncrier_22.12.0.orig.tar.gz
 1d12786175555b174f1b9c576865547ee933d365 12652 towncrier_22.12.0-1.debian.tar.xz
 2183eb9a51556e23c5b621be549769ef5c68b4bf 8689 towncrier_22.12.0-1_amd64.buildinfo
Checksums-Sha256:
 a638d59c2acf19dcb1d8ff2c0b47026395aecbb944bfa67ce24bb3f372cf50b8 2113 towncrier_22.12.0-1.dsc
 bcf09b9711f4e0f4fe705aa6a379a40d4e86763e2323b8e7d45a5b2d340d77ed 54660 towncrier_22.12.0.orig.tar.gz
 f60611b18df2b1d922a188d9c2210c84755ab4faba5720ef869c46817e495f2f 12652 towncrier_22.12.0-1.debian.tar.xz
 1271346f78f7af451a3b956daf404ab738cf22f15c4aa09f75cbbcf02351a153 8689 towncrier_22.12.0-1_amd64.buildinfo
Files:
 1ff8406b35f1672fff951b2ac8dbc4b0 2113 devel optional towncrier_22.12.0-1.dsc
 9ba9511addff3212ab8dcfee68e1fa70 54660 devel optional towncrier_22.12.0.orig.tar.gz
 ebc8b52eb25cad2a0c72daef7030d31c 12652 devel optional towncrier_22.12.0-1.debian.tar.xz
 3d9eccf73b573cbc7bb22fd2bab58391 8689 devel optional towncrier_22.12.0-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEYVng8p4vpBLgeVxz+bRqrIRCDIIFAmO/jEcACgkQ+bRqrIRC
DIJJsw/8CmRvC6+t03abcJQ/tYbHj945EFMTVcAOAs1HNRFq6L/DfV8/KkldqS/8
zPUOhpunkrUabs4oD/uK84DwgBul0yEBvwsTOITiDivGz1s5cG20TvBhKzDCJ5V3
l+dC7WPmwgnnGGyDyY8Us7JR7BSwf+Uctj9OWSI3Nsf97X2WtN9+iy7KBE98fBLb
qNjut3sh79hNTpFE0VCEGDxcwDrzriPkYUOcFeLgrYVlVN5Hx+2PPZefcsWFH6AP
uywLuLW4FaAeb7Rlwi8ym/sJBYLUJnxuxJ13f9P4p+R4TIkxkddvtjFKFkw6wzMy
vqRUxaq07uIOIS28UA161Vj02rmswqo6hb3Qcj1jTzpTXQ4WWA90mmz26rCmOx3a
emlMbyoqFzD9sqqaf5WK2I8ZHyPuF7+WKa4F8dDyyPstdtMsdUsxJfKE0RqPK8Ou
F9w3HoxpurJVTUAVNTu9LX6gwKBJjM8lLA5q/HRFPIuNcgD2YhjMMEkDNtt4Gro4
QtdVp7Jlmcas7n7Koiy2jFi5Ng/z/SgZEMpsMUvu+hCkUdJ4A/dB667Hjqw/GoFA
i23qJCv4LfFVVgiVvYC8J23IbJ9onA7wyE/bOKuyrITHB0/KCMNWmsLjdeSopRTJ
srOb9RclulPVMu0FZqpGjG6amp409UyXXZNtHokdvDitBFm3QKY=
=l9TS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.