Debian Bug report logs - #1026877
opari2: please make the build reproducible

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: opari2: please make the build reproducible

Date: Fri, 23 Dec 2022 05:32:47 +0000

[Message part 1 (text/plain, inline)]

Source: opari2
Version: 2.0.7-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
opari2 could not be built reproducibly.

Patch attached that exports CFLAGS from dpkg-buildflags(1), ensuring
that -fdebug-prefix-map (and similar) to the underlying build system.

Patch attached.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[opari2.diff.txt (text/plain, attachment)]

Message #10 received at 1026877@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: Chris Lamb <lamby@debian.org>, 1026877@bugs.debian.org

Subject: Re: Bug#1026877: opari2: please make the build reproducible

Date: Fri, 23 Dec 2022 11:53:58 +0100

Control: tags -1 + pending

Hello,

Chris Lamb, le ven. 23 déc. 2022 05:32:47 +0000, a ecrit:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> opari2 could not be built reproducibly.
> 
> Patch attached that exports CFLAGS from dpkg-buildflags(1), ensuring
> that -fdebug-prefix-map (and similar) to the underlying build system.

Thanks for the patch!

I'm wondering, though, how it is that the salsa reprotest CI didn't
catch it:

https://salsa.debian.org/debian/opari2/-/jobs/3675809

Is there some salsa-ci option that I should enable to make it more
picky?

Samuel

Message #17 received at 1026877@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Samuel Thibault" <sthibault@debian.org>, 1026877@bugs.debian.org

Subject: Re: Bug#1026877: opari2: please make the build reproducible

Date: Fri, 23 Dec 2022 18:00:37 +0000

Hi Samuel,

> I'm wondering, though, how it is that the salsa reprotest CI didn't
> catch it:
>
> https://salsa.debian.org/debian/opari2/-/jobs/3675809

That's a good question and I don't actually know the answer. :(

Indeed, I'm not actually that familiar with reprotest myself, so I'm
likely not the best person to ask. Could you quickly try the
reproducible-builds@lists.alioth.debian.org mailing list?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #22 received at 1026877@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: reproducible-builds@lists.alioth.debian.org, 1026877@bugs.debian.org

Subject: Salsa reprotest CI not picky enough? (Was: Bug#1026877: opari2: please make the build reproducible)

Date: Sat, 24 Dec 2022 00:04:02 +0100

Hello,

Chris Lamb, le ven. 23 déc. 2022 05:32:47 +0000, a ecrit:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> opari2 could not be built reproducibly.
> 
> Patch attached that exports CFLAGS from dpkg-buildflags(1), ensuring
> that -fdebug-prefix-map (and similar) to the underlying build system.

I'm wondering how it is that the salsa reprotest CI didn't catch it:

https://salsa.debian.org/debian/opari2/-/jobs/3675809

Is there some salsa-ci option that I should enable to make it more
picky?

Samuel

Message #27 received at 1026877@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Samuel Thibault <sthibault@debian.org>, reproducible-builds@lists.alioth.debian.org, 1026877@bugs.debian.org

Subject: Re: Salsa reprotest CI not picky enough? (Was: Bug#1026877: opari2: please make the build reproducible)

Date: Fri, 23 Dec 2022 16:01:48 -0800

[Message part 1 (text/plain, inline)]

On 2022-12-24, Samuel Thibault wrote:
> Chris Lamb, le ven. 23 déc. 2022 05:32:47 +0000, a ecrit:
>> Whilst working on the Reproducible Builds effort [0] we noticed that
>> opari2 could not be built reproducibly.
>> 
>> Patch attached that exports CFLAGS from dpkg-buildflags(1), ensuring
>> that -fdebug-prefix-map (and similar) to the underlying build system.
>
> I'm wondering how it is that the salsa reprotest CI didn't catch it:
>
> https://salsa.debian.org/debian/opari2/-/jobs/3675809
>
> Is there some salsa-ci option that I should enable to make it more
> picky?

  https://salsa.debian.org/debian/opari2/-/jobs/3696823#L1036

  INFO:reprotest:build "experiment-1": FIX environment, FIX build_path, ...

Something is telling reprotest to not vary build paths. I also see weird
things suggesting the standard build path reprotest uses is duplicated:

  https://salsa.debian.org/debian/opari2/-/jobs/3696823#L473

  make[1]: Entering directory '/tmp/reprotest.57Bwiu/const_build_path/const_build_path'

Normally, there would just be a single "const_build_path" subdir. I
noticed this issue on one of the packages I maintain, but haven't poked
at it yet.

This suggests to me the salsa-ci reprotest jobs are somehow manually
adjusting the build paths in some way above-and-beyond how reprotest
normally varies the build path? We probably should follow-up with the
salsa-ci folks...


The example for the salsa-ci suggests that build paths variations are
enabled by default under the "Adding extra arguments to reprotest":

  https://salsa.debian.org/salsa-ci-team/pipeline/-/tree/master#adding-extra-arguments-to-reprotest

  variables:
    SALSA_CI_REPROTEST_ARGS: --variations=-build_path

You could try inverting it, and passing --variations=+build_path


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 1026877@bugs.debian.org (full text, mbox, reply):

From: Samuel Thibault <sthibault@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>

Cc: reproducible-builds@lists.alioth.debian.org, 1026877@bugs.debian.org

Subject: Re: Salsa reprotest CI not picky enough? (Was: Bug#1026877: opari2: please make the build reproducible)

Date: Sat, 24 Dec 2022 12:07:45 +0100

Hello,

Vagrant Cascadian, le ven. 23 déc. 2022 16:01:48 -0800, a ecrit:
> The example for the salsa-ci suggests that build paths variations are
> enabled by default under the "Adding extra arguments to reprotest":
> 
>   https://salsa.debian.org/salsa-ci-team/pipeline/-/tree/master#adding-extra-arguments-to-reprotest
> 
>   variables:
>     SALSA_CI_REPROTEST_ARGS: --variations=-build_path
> 
> You could try inverting it, and passing --variations=+build_path

That seems to be working indeed:

https://salsa.debian.org/debian/opari2/-/jobs/3702025

I let the reproducibility team discuss with CI about really having
--variations=+all enabled by default :)

Samuel

Send a report that this bug log contains spam.