Debian Bug report logs - #1024638
opencv: embeds build path in Python extension

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Victor Westerhuis <victor@westerhu.is>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: opencv: embeds build path in Python extension

Date: Tue, 22 Nov 2022 16:06:51 +0100

[Message part 1 (text/plain, inline)]

Source: opencv
Version: 4.6.0+dfsg-7
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello maintainer,

Apologies for yet another small reproducible build patch. I neglected
to check my resolution for #972566 for reproducibility.

Stripping the rpath from the Python extension makes its BuildId
reproducible. The extension still works and both arch:all and arch:any
builds succeed locally.

Thanks for maintaining OpenCV!

Regards,

Victor Westerhuis

- -- System Information:
Debian Release: bookworm/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (100, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.0.0-4-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_NL.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en_US:en:nl_NL:nl
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCAAxFiEE6OxII3T+o0Ujs6ECQz2Rq5dHQPsFAmN85YQTHHZpY3RvckB3
ZXN0ZXJodS5pcwAKCRBDPZGrl0dA+4nTD/0VbXgUr5hsjE4SAGb/nTAJmXfEg6Cb
c1+pd9f4IfKhObGSfvkd24oNrgmvTQ9ZA1DyHQeMPFKmANNUh7lU2cAq+grgP/zK
BnTXFfFo+VST440W3PC6v9uWmBgU1tQ/CR+VLc+QDCXFSCx4yjfvWVn3F8YVFKjQ
TJHq4Vu6ynGMLFy//rHK1hT93Ehsqdywye9K1dvPKjOrfPbN15u+O+aUMIR/PFq4
sxi5HSpOF5Si3AujkKW0l5z6+hryc03wTD8/NcjpcKKcpe1KDXOAGSKkpet1APp4
/1D+UdsXQVc+ubve/XO5+pLEVznLTsa8QdhU39HZSGUwgoqkIIBwjRaO1Tmmb03+
jTCS1EmJameFnX9rc5QMsSALaB7wSigP/pY7wypJ9uN8dl6+JdCs/d0o5GDTsDT4
KfXbYecxjCqQtHrcRzCQPFniJ1k5+pPQfdciD9NfgqB9CXXkFcnBZUpbSLEqw6j0
BhmWNeVH2BIk7A1H81KbMiNmSWdSFbElLFm9hN8RsrbMWw/q/XShgwAKajxPxELn
faJ1JCB1leulSiuFekNf1nDas/6zPyo5ltDvqs9FYUWjvx5J213Mp4SIHupYVIly
m+cb9qdwyOQkEw8PcAI/RXM5BNKnpBFaQEFWtQbRrGYKxCg8ZbvqR5fzxxH59q+s
FScUESqwp7Xzbg==
=wUNR
-----END PGP SIGNATURE-----

[0001-Make-Python-extensions-reproducible.patch (text/plain, attachment)]

Message #10 received at 1024638@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Victor Westerhuis <victor@westerhu.is>, 1024638@bugs.debian.org

Subject: Re: Bug#1024638: opencv: embeds build path in Python extension

Date: Tue, 22 Nov 2022 10:56:07 -0800

[Message part 1 (text/plain, inline)]

On 2022-11-22, Victor Westerhuis wrote:
> Stripping the rpath from the Python extension makes its BuildId
> reproducible. The extension still works and both arch:all and arch:any
> builds succeed locally.
...
> diff --git a/debian/rules b/debian/rules
> index b4d654102..6bd845023 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -151,6 +151,7 @@ override_dh_auto_configure:
>  		-- --name=opencv --system=custom --configure-args "\
>  			dh_auto_configure -S cmake -D modules/python -B {build_dir} -- \
>  				-GNinja \
> +				-DCMAKE_SKIP_RPATH=ON \
>  				-DOpenCV_BINARY_DIR=$(CURDIR)/$(BUILDDIR) \
>  				-DOPENCV_PYTHON_STANDALONE_INSTALL_PATH={install_dir} \
>  				-DOPENCV_SKIP_PYTHON_LOADER=ON \

I would recommend using -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON instead of
-DCMAKE_SKIP_RPATH=ON.

This is the default behavior with (the currently experimental) debhelper
compat level 14. A little more detail on the issue is available here:

  https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html

The main advantage of CMAKE_BUILD_RPATH_USE_ORIGIN is it is more likely
to work with test suites that depend on the full path.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 1024638-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1024638-close@bugs.debian.org

Subject: Bug#1024638: fixed in opencv 4.6.0+dfsg-10

Date: Mon, 16 Jan 2023 04:23:41 +0000

Source: opencv
Source-Version: 4.6.0+dfsg-10
Done: Nobuhiro Iwamatsu <iwamatsu@debian.org>

We believe that the bug you reported is fixed in the latest version of
opencv, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024638@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <iwamatsu@debian.org> (supplier of updated opencv package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 16 Jan 2023 11:23:50 +0900
Source: opencv
Architecture: source
Version: 4.6.0+dfsg-10
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Nobuhiro Iwamatsu <iwamatsu@debian.org>
Closes: 1024638
Changes:
 opencv (4.6.0+dfsg-10) unstable; urgency=medium
 .
   * Update d/rules.
     Add -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to configure of python extension
     (Closes: #1024638)
Checksums-Sha1:
 8402812b31ec99ebe0fbffd163c70a0127f57496 6876 opencv_4.6.0+dfsg-10.dsc
 5506b2de96b60aa792870533b9b5f538a645960c 34200 opencv_4.6.0+dfsg-10.debian.tar.xz
 84646e52d5edf43e053ff79080bff4496d592170 47970 opencv_4.6.0+dfsg-10_amd64.buildinfo
Checksums-Sha256:
 4bed24d01dd1ef821febc5c07683066eba1de3bef32fcc36b4eae0ab8cb50b5e 6876 opencv_4.6.0+dfsg-10.dsc
 4e3b913f073c341718d2478efc3e1f2c8fb7dbb399282566b0c4ab07da983de1 34200 opencv_4.6.0+dfsg-10.debian.tar.xz
 aebe138fd39036b355b0f5a16467c94a412bc5ac2634466c76805221565353a0 47970 opencv_4.6.0+dfsg-10_amd64.buildinfo
Files:
 6bc94bf9881d7b3ce73fe75bc541dde1 6876 devel optional opencv_4.6.0+dfsg-10.dsc
 8295a8b11d14e3e061819a548d5058e0 34200 devel optional opencv_4.6.0+dfsg-10.debian.tar.xz
 73c72b85825f60c0b03b353b222b40af 47970 devel optional opencv_4.6.0+dfsg-10_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXmKe5SMhlzV7hM9DMiR/u0CtH6YFAmPEwDMACgkQMiR/u0Ct
H6b9+g//cOyIO7YniTe17imSGg3FPHUyAjaaJREhdXAIBwqaoNfcOeDDdx4/I1JP
/hG2bMEnjZvMmH6rUigD1W5majZIgT912tb1YEZhAukBEyAem5CnVskASNn2aVZy
bq+uTzxjBN9Eg+8JaW4+IeWt+mrRc+fW2ZKOeHuCgcmGt7JvhqPN/djDad0EYAxI
YfzDq8b/EExQxI9FFBUx5srYmcVE3a4GlikK4kb46jdta063Z1owLYnTtJnxu2y1
44SPmp6PI1qF41ad5XbGbydbbqymUcosX6e/bf4z+qcKCpucHXAr5vw7QjGz25V4
4sICKXQb5XFSYlzrFsBwo5QQvoxr4igWH1htZiSyr/AwbaQ2n/pRi+jpGNz7v9RB
YszeoRr8tbWc9lLK6Q1aoBvI1giGz0kA1xIpcSNgvO2kTuaFPPrROQoqm1cdhxjq
+lS7LJqtd6Mp6CXUOyIrNyQiNP3/PJYLQxiqebNx0kb+LoVtyBPqx0/+9KvQ1Nen
SfKr8F4DvOFCBwGUwPCFYS1T/hbP2Ou5z9PeVVLxzT9RmNGsWMHRjU1vDR09ABvd
jDjRer5gyY4hDA5BritBQE3AZfQcV606zr+J6kV7OzYuceXSOE9ut7e11GR2FhLL
o3m2z94xnVQTSYb72VG4HKQpmrD9vW995vBwI24YvmFTfFvFTnQ=
=F7pc
-----END PGP SIGNATURE-----

Message #20 received at 1024638@bugs.debian.org (full text, mbox, reply):

From: Victor Westerhuis <victor@westerhu.is>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 1024638@bugs.debian.org

Subject: Re: Bug#1024638: opencv: embeds build path in Python extension

Date: Wed, 01 Feb 2023 01:11:48 +0100

Vagrant Cascadian <vagrant@reproducible-builds.org> schreef op 22 november 2022 19:56:07 CET:
>On 2022-11-22, Victor Westerhuis wrote:
>> Stripping the rpath from the Python extension makes its BuildId
>> reproducible. The extension still works and both arch:all and arch:any
>> builds succeed locally.
>...
>> diff --git a/debian/rules b/debian/rules
>> index b4d654102..6bd845023 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -151,6 +151,7 @@ override_dh_auto_configure:
>>  		-- --name=opencv --system=custom --configure-args "\
>>  			dh_auto_configure -S cmake -D modules/python -B {build_dir} -- \
>>  				-GNinja \
>> +				-DCMAKE_SKIP_RPATH=ON \
>>  				-DOpenCV_BINARY_DIR=$(CURDIR)/$(BUILDDIR) \
>>  				-DOPENCV_PYTHON_STANDALONE_INSTALL_PATH={install_dir} \
>>  				-DOPENCV_SKIP_PYTHON_LOADER=ON \
>
>I would recommend using -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON instead of
>-DCMAKE_SKIP_RPATH=ON.
Unfortunately the Python modules are built as a separate module via a separate Cmake invocation, so this has not worked. The rpaths passed to the linker of the Python libraries are absolute build paths, so they are not reproducible. 
>
>This is the default behavior with (the currently experimental) debhelper
>compat level 14. A little more detail on the issue is available here:
>
>  https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
>
>The main advantage of CMAKE_BUILD_RPATH_USE_ORIGIN is it is more likely
>to work with test suites that depend on the full path.
OpenCV does not ship tests for its Python module, so this is not an issue. 
>
>live well,
>  vagrant

Control: reopen -1

I would suggest to change the d/rules files to my original proposal. 
-- 
Groet, Regards,

Victor Westerhuis

Message #29 received at 1024638-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1024638-close@bugs.debian.org

Subject: Bug#1024638: fixed in opencv 4.6.0+dfsg-11

Date: Wed, 01 Mar 2023 04:42:36 +0000

Source: opencv
Source-Version: 4.6.0+dfsg-11
Done: Nobuhiro Iwamatsu <iwamatsu@debian.org>

We believe that the bug you reported is fixed in the latest version of
opencv, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024638@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <iwamatsu@debian.org> (supplier of updated opencv package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 01 Mar 2023 10:21:45 +0900
Source: opencv
Architecture: source
Version: 4.6.0+dfsg-11
Distribution: unstable
Urgency: medium
Maintainer: Debian Science Team <debian-science-maintainers@lists.alioth.debian.org>
Changed-By: Nobuhiro Iwamatsu <iwamatsu@debian.org>
Closes: 1024638
Changes:
 opencv (4.6.0+dfsg-11) unstable; urgency=medium
 .
   * Update d/rules.
     Use -DCMAKE_SKIP_RPATH=ON instead of -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON.
     (Closes: #1024638)
Checksums-Sha1:
 3c2600206c776a828dda032a8779c9d1d2c0af7a 6876 opencv_4.6.0+dfsg-11.dsc
 4c432c4f356d2065d38a65099582e25a15aca667 34264 opencv_4.6.0+dfsg-11.debian.tar.xz
 f4006ac48fd3871cfd06375fc240d86dcae6d10c 47689 opencv_4.6.0+dfsg-11_amd64.buildinfo
Checksums-Sha256:
 8a6d27c28ce99447eb49a84438756a7aac1829d531d8dfb955b4f76128bed96c 6876 opencv_4.6.0+dfsg-11.dsc
 ec11a51f2d801e5b29736852181a0e1bad53ce5ee08a70b41fd66c72bbf90f12 34264 opencv_4.6.0+dfsg-11.debian.tar.xz
 51f5b0150df4da80586f3c0e9de8a3dffad611ae732613679e546d6625846150 47689 opencv_4.6.0+dfsg-11_amd64.buildinfo
Files:
 3de8b7ffc4cd5fa5b2ad63ac8425e749 6876 devel optional opencv_4.6.0+dfsg-11.dsc
 9c900dbf7b0e246bf48f4c01f8a4c0cd 34264 devel optional opencv_4.6.0+dfsg-11.debian.tar.xz
 2649e3fdf4b1aea5e5243b856bd0d8ef 47689 devel optional opencv_4.6.0+dfsg-11_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXmKe5SMhlzV7hM9DMiR/u0CtH6YFAmP+vw0ACgkQMiR/u0Ct
H6YFKQ/9E2t72zZfAGC3TKkpp/aS6yblLl95fKGpRyX0+U6VY+f2TrymrRvJNVgi
H87vlQM1TiLbHpWSClyuhQy8hYMhmyL30p0q7DospIdIYsL7K9XoZ+dNXsfH/9Z7
wpDaoWW2cBwf1sb+M9spIThh6xvoWCTsPBl0DU7+H+yAJqyFD8SBg/+NjXL6qpE/
zXeYl4ColD8uq3RFGjqfZ9ztvfrGAFLD5LG3maEou8loFS1KhwH4awZmJLWd+PGG
AR26vNs/oe6qKdWSy+AhoW8hxpg+JQNfOIwQ7Jz4Vj+CEE8Z7sf7swWDxtg1rsGy
Sp3gNY5kkh9/EcN4GasJ7Dr6M0hagmL90TcVM+lyrUUvohe6s4Hf6nuFCQEYcNDg
/eYcF+Urp1hPjSxooZcDxRjjEKmmoLeBSFKYMWpTCyYhvRZKaqcrdihnWlKxYepg
WctpIvzAmorawHoG+EzZbZ8J/gTPQ3weREFZ3LOLHJh0Pibh6EJoNMcGVNZVYY26
jGObatNSZMXqsMJCxmLMFD//MBmckleZLlF/R0toVyeGXifWShc/Vz7b/UOrAFRo
ae4N+AymLKmp1ZCC0TqmoyN5Z7rrTNhy63Gdmhd0LUZSKAFGpdttiNQ0QBCKLPGL
cDqVlSnraumSUrqC4HlenMgpYHDGpaUAC2whNsS4lQLrRx/wU5M=
=7g6K
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.