Debian Bug report logs - #1024530
jh7100-bootloader-recovery: reproducible builds: Embeds build date in jh7100_recovery_boot.bin

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: jh7100-bootloader-recovery: reproducible builds: Embeds build date in jh7100_recovery_boot.bin

Date: Sun, 20 Nov 2022 16:05:30 -0800

[Message part 1 (text/plain, inline)]

Source: jh7100-bootloader-recovery
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build date is embedded in jh7100_recovery_boot.bin:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/jh7100-bootloader-recovery.html

  /usr/lib/firmware/jh71xx/jh7100_recovery_boot.bin

  000050d0:·6465·6275·6700·0000·3232·3130·3232·2d30··debug...221022-0
  vs.
  000050d0:·6465·6275·6700·0000·3233·3131·3235·2d30··debug...231125-0

The attached patch to the upstream Makefile fixes this by using the
SOURCE_DATE_EPOCH environment variable.

Alternately, if possible, removing the date entirely would be even
better!

According to my local tests, With this patch applied jh7100-bootloader-recovery should
build reproducibly on tests.reproducible-builds.org!

Thanks for maintaining jh7100-bootloader-recovery!

live well,
  vagrant

[0001-Makefile-Use-SOURCE_DATE_EPOCH-to-set-SUFFIX-availab.patch (text/x-diff, inline)]

From 4c99cf32973187a1f4a024a7ea97ca44b738c347 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 20 Nov 2022 23:25:11 +0000
Subject: [PATCH] Makefile: Use SOURCE_DATE_EPOCH to set SUFFIX available.

https://reproducible-builds.org/docs/source-date-epoch/
---
 Makefile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index dfe8087..be351de 100644
--- a/Makefile
+++ b/Makefile
@@ -5,7 +5,12 @@ EMPTY  :=
 SPACE  := $(EMPTY) $(EMPTY)
 PROGRAM = jh7100_recovery_boot
 
-SUFFIX=$(shell date +%y%m%d)
+DATE_FMT = +%y-%m-%d
+ifdef SOURCE_DATE_EPOCH
+    SUFFIX ?= $(shell date -u -d "@$(SOURCE_DATE_EPOCH)" "$(DATE_FMT)" 2>/dev/null || date -u -r "$(SOURCE_DATE_EPOCH)" "$(DATE_FMT)" 2>/dev/null || date -u "$(DATE_FMT)")
+else
+    SUFFIX ?= $(shell date "$(DATE_FMT)")
+endif
 GIT_VERSION=$(shell git show -s --pretty=format:%h)
 DEB_VERSION=$(shell dpkg-parsechangelog --show-field Version)
 VERSION=$(SUFFIX)-$(DEB_VERSION)
-- 
2.38.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1024530-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1024530-close@bugs.debian.org

Subject: Bug#1024530: fixed in jh7100-bootloader-recovery 0~2021.07.14~git2b268a1c-2

Date: Wed, 25 Jan 2023 14:37:13 +0000

Source: jh7100-bootloader-recovery
Source-Version: 0~2021.07.14~git2b268a1c-2
Done: Domenico Andreoli <cavok@debian.org>

We believe that the bug you reported is fixed in the latest version of
jh7100-bootloader-recovery, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024530@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Domenico Andreoli <cavok@debian.org> (supplier of updated jh7100-bootloader-recovery package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 25 Jan 2023 14:16:22 +0100
Source: jh7100-bootloader-recovery
Architecture: source
Version: 0~2021.07.14~git2b268a1c-2
Distribution: unstable
Urgency: medium
Maintainer: Domenico Andreoli <cavok@debian.org>
Changed-By: Domenico Andreoli <cavok@debian.org>
Closes: 1024530
Changes:
 jh7100-bootloader-recovery (0~2021.07.14~git2b268a1c-2) unstable; urgency=medium
 .
   [ Jelmer Vernooij ]
   * Apply multi-arch hints.
     + jh7100-bootloader-recovery: Add Multi-Arch: foreign.
 .
   [ Domenico Andreoli ]
   * Add 000-drop-date-from-embedded-version.patch, make the build
     reproducible. (Closes: #1024530)
   * Update standards version to 4.6.2, no changes needed.
Checksums-Sha1:
 1a041e2670f76440b8b2ddfbcea2876bfb73de3c 2287 jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2.dsc
 e5f3c10b3ead4c9348cf60e4f950ab88de01d177 4056 jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2.debian.tar.xz
 7e887a55faef26b3a45d14d107a6577169763d35 13235 jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2_arm64.buildinfo
Checksums-Sha256:
 028f2f73f9d5c2ed7758ab8dfc54c2a9c8d968b40ea8a2c21c125ed8572567d1 2287 jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2.dsc
 93f96a27a7f87578729015467295eec70d134fbe1facda52716b685af40af0ef 4056 jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2.debian.tar.xz
 3bab141fc84392af4177e6fd5f0f6a951cb3fc8a14ba37179acff7b041e77da4 13235 jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2_arm64.buildinfo
Files:
 0b55d47dcdb878038217f3d45ee3866d 2287 electronics optional jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2.dsc
 169fe49691d9f0ebad50d7b83ba3a793 4056 electronics optional jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2.debian.tar.xz
 e5c85c93cf763a0f589ff7b85dce4eb3 13235 electronics optional jh7100-bootloader-recovery_0~2021.07.14~git2b268a1c-2_arm64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE0shRjWi8VJar72jypoxgteDmkTcFAmPRN8YRHGNhdm9rQGRl
Ymlhbi5vcmcACgkQpoxgteDmkTcIvxAAgVWFe38xWMT2+gfR1DGNkCajgKO2ErNI
Gfcf9Ann0YGRXe7EW8L3biS6Ohfh+miLA8EH5re3WxcBJtaKr7TooUNbnw9Kn4o+
0Z9eqXTlAL0k8oRC7trLi01d0H7HKIj0gj44+KJG5cOSzQHQ2zyVh1DDM6sNhyiJ
VAHVcTcDHQI1xVUPxYQcsDYft3fRhCM5mMAlgmQFuJ4VPSr0h8zd3nOqVQM8mAJh
ZCRwrjyTO5QJpBGp5IJQlUtRSuXnkPJEkzgTBTMLKdP54QK9k5lJ3mujrU1AbcDV
DGGd7lcVKC+y/2DDU/RApHJLv5aDbvRfFAQa06P9vlLSJDOLBe+aDd+FSor1cdVY
Azunbfil8oQfIoQBWEeGKw/p9WGfm3P5lSI1VnyvkKpt902aqMILYEggD/nx7vsv
OILL2RIxFoUUQrg7Y5IgmJy+DLQxQIn1c/B4FECDDG20sUm2kTTk1+mtdvAgR9Mw
2WAEzk6UzEmY5Dxdk1Yg18Yhjmx2rFR16k4mBwlh3NldTsXtB4WWbrWJb6hpuTpr
+EhJ7qFRkIGHLZPexHumzwOzgRqhbetl9g3KQrizzgfZHFe3rLEcHrVX365p1eoo
mw26a7opejc1uKY64e6WUUKDMxbPSt85RHfv3grITBGmTKfz3H1OKr3QgJZeQNSH
XfaQJfB6Tpw=
=3zOm
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.