Debian Bug report logs - #1024399
xrprof: reproducible-builds: build path embedded in /usr/bin/xrprof

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: xrprof: reproducible-builds: build path embedded in /usr/bin/xrprof

Date: Fri, 18 Nov 2022 11:49:34 -0800

[Message part 1 (text/plain, inline)]

Source: xrprof
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/xrprof:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xrprof.html

  /build/1st/xrprof-0.3.1/src/xrprof.c:71
  vs.
  /build/2/xrprof-0.3.1/2nd/src/xrprof.c:71

The attached patch to debian/rules fixes this by passing the default
CFLAGS to dh_auto_build, which includes the -ffile-prefix-map argument.

According to my local tests, with this patch applied xrprof should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining xrprof!

live well,
  vagrant

[0001-debian-rules-Pass-default-CFLAGS-to-dh_auto_build.patch (text/x-diff, inline)]

From dcf2ad058ef860eb7f9ac64a83149cbe267662e3 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 18 Nov 2022 19:44:54 +0000
Subject: [PATCH] debian/rules: Pass default CFLAGS to dh_auto_build.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 0da069d..c8bdedc 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,7 +4,7 @@
 	dh $@
 
 override_dh_auto_build:
-	dh_auto_build -- prefix=/usr
+	dh_auto_build -- prefix=/usr CFLAGS="$(CFLAGS)"
 
 override_dh_auto_install:
 	dh_auto_install -- prefix=/usr
-- 
2.38.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1024399@bugs.debian.org (full text, mbox, reply):

From: Dirk Eddelbuettel <edd@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 1024399@bugs.debian.org

Cc: Dirk Eddelbuettel <edd@debian.org>

Subject: Re: Bug#1024399: xrprof: reproducible-builds: build path embedded in /usr/bin/xrprof

Date: Fri, 18 Nov 2022 14:23:59 -0600

Hi Vagrant,

On 18 November 2022 at 11:49, Vagrant Cascadian wrote:
| Source: xrprof
| Severity: normal
| Tags: patch
| User: reproducible-builds@lists.alioth.debian.org
| Usertags: buildpath
| X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
| 
| The build path is embedded in /usr/bin/xrprof:
| 
|   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xrprof.html
| 
|   /build/1st/xrprof-0.3.1/src/xrprof.c:71
|   vs.
|   /build/2/xrprof-0.3.1/2nd/src/xrprof.c:71
| 
| The attached patch to debian/rules fixes this by passing the default
| CFLAGS to dh_auto_build, which includes the -ffile-prefix-map argument.

Nice!

If it is that simple .. I will happily do so.  Thanks for the patch!

| According to my local tests, with this patch applied xrprof should build
| reproducibly on tests.reproducible-builds.org!
| 
| Thanks for maintaining xrprof!

Thanks for looking reproducible builds! I have a few other packages that do
not comply but I am a little out of my depth. (I get patches for R builds and
some other things to not embed time/date etc.)

Best,  Dirk
 
| live well,
|   vagrant
| From dcf2ad058ef860eb7f9ac64a83149cbe267662e3 Mon Sep 17 00:00:00 2001
| From: Vagrant Cascadian <vagrant@reproducible-builds.org>
| Date: Fri, 18 Nov 2022 19:44:54 +0000
| Subject: [PATCH] debian/rules: Pass default CFLAGS to dh_auto_build.
| 
| ---
|  debian/rules | 2 +-
|  1 file changed, 1 insertion(+), 1 deletion(-)
| 
| diff --git a/debian/rules b/debian/rules
| index 0da069d..c8bdedc 100755
| --- a/debian/rules
| +++ b/debian/rules
| @@ -4,7 +4,7 @@
|  	dh $@
|  
|  override_dh_auto_build:
| -	dh_auto_build -- prefix=/usr
| +	dh_auto_build -- prefix=/usr CFLAGS="$(CFLAGS)"
|  
|  override_dh_auto_install:
|  	dh_auto_install -- prefix=/usr
| -- 
| 2.38.1
| 
| x[DELETED ATTACHMENT signature.asc, application/pgp-signature]

-- 
dirk.eddelbuettel.com | @eddelbuettel | edd@debian.org

Message #15 received at 1024399@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Dirk Eddelbuettel <edd@debian.org>, 1024399@bugs.debian.org

Subject: Re: Bug#1024399: xrprof: reproducible-builds: build path embedded in /usr/bin/xrprof

Date: Fri, 18 Nov 2022 12:53:04 -0800

[Message part 1 (text/plain, inline)]

On 2022-11-18, Dirk Eddelbuettel wrote:
> On 18 November 2022 at 11:49, Vagrant Cascadian wrote:
> | The build path is embedded in /usr/bin/xrprof:
> | 
> |   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xrprof.html
> | 
> |   /build/1st/xrprof-0.3.1/src/xrprof.c:71
> |   vs.
> |   /build/2/xrprof-0.3.1/2nd/src/xrprof.c:71
> | 
> | The attached patch to debian/rules fixes this by passing the default
> | CFLAGS to dh_auto_build, which includes the -ffile-prefix-map argument.
>
> Nice!
>
> If it is that simple .. I will happily do so.  Thanks for the patch!

For clarity, I have only done build testing, not testing that the
installed program behaves correctly, but most of the default debian
flags *should* be fine... :)

If you want to be extra careful you might want to review the build logs
and check which flags are actually used with and without the patch.

Another option might be to patch the upstream Makefile(s) to use "CFLAGS
+=" instead of "CFLAGS =", though that still may change which flags are
actually used.

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 1024399-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1024399-close@bugs.debian.org

Subject: Bug#1024399: fixed in xrprof 0.3.1-3

Date: Fri, 18 Nov 2022 21:08:16 +0000

Source: xrprof
Source-Version: 0.3.1-3
Done: Dirk Eddelbuettel <edd@debian.org>

We believe that the bug you reported is fixed in the latest version of
xrprof, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024399@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dirk Eddelbuettel <edd@debian.org> (supplier of updated xrprof package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 18 Nov 2022 14:24:33 -0600
Source: xrprof
Architecture: source
Version: 0.3.1-3
Distribution: unstable
Urgency: medium
Maintainer: Dirk Eddelbuettel <edd@debian.org>
Changed-By: Dirk Eddelbuettel <edd@debian.org>
Closes: 1024399
Changes:
 xrprof (0.3.1-3) unstable; urgency=medium
 .
   * debian/rules: Apply small patch to enable reproducible builds (by
     ensuring default CFLAGS are passed on) 	(Closes: #1024399)
 .
   * debian/control: Set Standards-Version: to current version
   * debian/control: Switch to virtual debhelper-compat (= 12)
Checksums-Sha1:
 e510eb93676cc4d3210ff4c818d8f2dbb7fb9f01 1680 xrprof_0.3.1-3.dsc
 40a0a9fd544f8c3b86141fa1bc1e9aa511b5c178 6660 xrprof_0.3.1-3.debian.tar.xz
 63655e95a910e93a02775fb4679dd6622c88c7ad 6276 xrprof_0.3.1-3_amd64.buildinfo
Checksums-Sha256:
 e8906224ac10941040ae7f9a1f9c96f21da6f959c6d017490349d638f4c16504 1680 xrprof_0.3.1-3.dsc
 f11188d80d0a347174fccc6d7acba881bbf7cb988349c0f99f441aeb6deec26a 6660 xrprof_0.3.1-3.debian.tar.xz
 595e20fa5de9c4a5e85cffd205209567e0ddb6ffbeb61375d7e4b354657667e5 6276 xrprof_0.3.1-3_amd64.buildinfo
Files:
 707556d262255cd676430be71a67c9b8 1680 math optional xrprof_0.3.1-3.dsc
 f4239ad87461b84ef1f0494c60ae8fc7 6660 math optional xrprof_0.3.1-3.debian.tar.xz
 c744de3cf94f7224138c2c4259d3c4ed 6276 math optional xrprof_0.3.1-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIVAwUBY3fqS6FIn+KrmaIaAQhHBQ//Qn/XOqJRqKhiJhxz5YPh2NEvtA2gayNM
U4UQ74O0nu3NMNEWqW10l/A8SRJtzGU3RDBVEfpMkxNe0l6GeKZO/pLMtlq/yW82
z2lMOUBoETYTuorkdCgzFjpQ3vzdrggBS+hDksDdq92lt9bhonk6y3xmVyIlsBeP
0bljGircM9d7U/i7yrOrsCIJrBphbFL4sk8wbbHj140jafZR0K0LahKXrRA+Qz75
atPOz4Cubk1BvwmnGQuA+PFYp2rslkQjbnhqvv0ELjoZRTL3QJ9WfheBd57mohVR
HGsB1qV9QR+dXAFHD8AV+AfE3BonJglxdY+2klS6n9FiOfuXNRw7PDk/wOV5kQxp
cqC7jq4/g9cwGeQ0gLFz5z6joeaqJC40h3ZxcFIiGl+gQ+C+TWEbVJtdyJXtt5y1
SlnhJWZ+sX5/lYichdOuSfCZmCzdlgCtP1hEn6M//idrDfmhQHfyxFBG4xqgSjBV
QEMlqOo1UTH4knngRxwkgs2bdBzh931WbOm7cYHJCVcsXD0RiY1X777vskLuUhri
oLynfll5rXWD25BQN9ic7EWksPxrON37VmPU7AB9boQ52FbtyQ1OYvLod64cFLBP
UYn4yMIJGwPWUQEh7N0kJM8N1jmiz2w1nk94a6al99x6sWBTYv34kQBcDvsjZp8T
BbTvJqhsjWk=
=7TLR
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.