Debian Bug report logs - #1024291
gnunet: reproducible-builds: embedded path to "ifconfig" may differ

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: gnunet: reproducible-builds: embedded path to "ifconfig" may differ

Date: Wed, 16 Nov 2022 20:38:08 -0800

[Message part 1 (text/plain, inline)]

Source: gnunet
Severity: important
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The path to the "ifconfig" binary differs depending on if it is built in an
environment with or without usrmerge:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/gnunet.html

  /usr/include/gnunet/gnunet_config.h

  #define·IFCONFIG·"/sbin/ifconfig"
  vs.
  #define·IFCONFIG·"/usr/sbin/ifconfig"

The attached patch fixes this in debian/rules by passing the
IFCONFIG_BINARY variable to dh_auto_configure, using the most compatible
path.

According to my local tests, With this patch applied gnunet should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining gnunet!

live well,
  vagrant

[0001-debian-rules-Pass-IFCONFIG_BINARY-to-ensure-consiste.patch (text/x-diff, inline)]

From 846543aeec468ef2ebb82209ee064f39446ff5e8 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 17 Nov 2022 04:19:14 +0000
Subject: [PATCH 1/2] debian/rules: Pass IFCONFIG_BINARY to ensure consistent
 path.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 89dbecc..1e70915 100755
--- a/debian/rules
+++ b/debian/rules
@@ -14,7 +14,7 @@ execute_after_dh_auto_clean:
 	rm -rf src/integration-tests/*.py
 
 override_dh_auto_configure:
-	dh_auto_configure -- --disable-rpath --with-microhttpd=yes $(shell dpkg-buildflags --export=configure) VAR_IFCONFIG_BINARY=/sbin/ifconfig
+	dh_auto_configure -- --disable-rpath --with-microhttpd=yes $(shell dpkg-buildflags --export=configure) VAR_IFCONFIG_BINARY=/sbin/ifconfig IFCONFIG_BINARY=/sbin/ifconfig
 
 override_dh_auto_test:
 	# Disabling test suite, incomplete
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1024291-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1024291-close@bugs.debian.org

Subject: Bug#1024291: fixed in gnunet 0.19.1-2

Date: Wed, 04 Jan 2023 08:41:10 +0000

Source: gnunet
Source-Version: 0.19.1-2
Done: Daniel Baumann <daniel.baumann@progress-linux.org>

We believe that the bug you reported is fixed in the latest version of
gnunet, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024291@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <daniel.baumann@progress-linux.org> (supplier of updated gnunet package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 04 Jan 2023 08:29:01 +0100
Source: gnunet
Architecture: source
Version: 0.19.1-2
Distribution: sid
Urgency: medium
Maintainer: Daniel Baumann <daniel.baumann@progress-linux.org>
Changed-By: Daniel Baumann <daniel.baumann@progress-linux.org>
Closes: 1024291 1025989
Changes:
 gnunet (0.19.1-2) sid; urgency=medium
 .
   * Uploading to sid.
   * Updating variable name for ifconfig binary in rules, thanks to Vagrant
     Cascadian <vagrant@reproducible-builds.org> (Closes: #1024291).
   * Adding updated Brazilian-Portuguese Debconf translations from Paulo
     Henrique de Lima Santana (phls) <phls@debian.org> (Closes: #1025989).
Checksums-Sha1:
 dc91be842f4179951dea5b9c6e06dc676b51fa75 2506 gnunet_0.19.1-2.dsc
 c880ffcfe1cb20f61d0ea737ec1e369e5c7715f5 68728 gnunet_0.19.1-2.debian.tar.xz
 8f99ed2634c163a0860622e821b7283b472206f0 18473 gnunet_0.19.1-2_amd64.buildinfo
Checksums-Sha256:
 b714bf065a03687c45d9a8959895e3228195d7037c469a658a7806c713b1df0e 2506 gnunet_0.19.1-2.dsc
 8cace5a7a079aa12c72ceb1f0db9e5e245395079438471f0abe774f58d26cffd 68728 gnunet_0.19.1-2.debian.tar.xz
 20c63d4fd4a9feb147ed8c2e3c89a715a3bb6b84af5e2d7a67fe10e4bdf1711d 18473 gnunet_0.19.1-2_amd64.buildinfo
Files:
 fa509f94294d797e93caa1866469349b 2506 net optional gnunet_0.19.1-2.dsc
 9c4f49fede08f8a229a3c203bf043cd8 68728 net optional gnunet_0.19.1-2.debian.tar.xz
 47ed89932e7bf547e4899a0d06780abb 18473 net optional gnunet_0.19.1-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEgTbtJcfWfpLHSkKSVc8b+YaruccFAmO1LwsACgkQVc8b+Yar
ucdvsQ/8D3AMJdyT/9BSJDNLa/dJ7wECHtZdbr8dQ4gnhNrr+KEUsmbCqjiXSsDC
dUY0G9VUWjNWs/PnD/NC2rUDKWqZvf74PNQRIObc83xjVagALFrNI3Ingt+L5t8Y
QMejzu/2NtnJnrh3U2Mbi0NafWYplRuCDjItdI1EiOaPzJ+634J6jtIdu9qjJGZh
avwz+l5IUayqXEZ1IzmvaEJykA7Oh/5hJBvI9qxZVumGVRF9U8LMav44jkvriYGf
TKVFI6jeW9nICefFr7lF6/YrXCtY18id/b81vaQa5q3b1OuPI4Fd6w2LQPoakgKB
w4+BQzJfbKlrlF5dnG1oILZcbkxvbRUe4uyfn0rAtsuV60ZkXRipp0pJp7ze1TSU
pC5Y95DkwewVxabCqvFQWxXwoOgW+vT80JjDSlZI7m7xB2ADdMaoN5maORi0l2ic
QM1fiwITF62e0cj5Lg0x6P/WC6WQtmfLoeVyatGtfR6R2gitA6tXpA3no9JjKSFQ
oWRmBPUgpr997z6reCUAfUTTp9d62459Eh/Mm/0tgzJxrWnIENo0Z5EvC1vUiZDX
iRNoSYjCfnIyT8SxlljQVZ7Mij3Dvi5VWBlKmO0ABmXq2i2+inmfj6+9ANHvAdIG
o0djWN/DvtFF6cj807CrL0uMZJESQOpFayUKtNQXQMRvG10SxQA=
=Hcfw
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.