Debian Bug report logs - #1024289
openfortivpn: reproducible-builds: embedded path to "resolvconf" may differ

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: openfortivpn: reproducible-builds: embedded path to "resolvconf" may differ

Date: Wed, 16 Nov 2022 19:32:47 -0800

[Message part 1 (text/plain, inline)]

Source: openfortivpn
Severity: important
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: usrmerge
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The path to the "resolvconf" binary differs depending on if it is built
in an environment with or without usrmerge:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/openfortivpn.html

  /usr/bin/openfortivpn
  
  /sbin/resolvconf
  vs.
  /usr/sbin/resolvconf

The attached patch fixes this in debian/rules by passing the
--with-resolvconf argument to dh_auto_configure, using the most
compatible path.

According to my local tests, With this patch applied openfortivpn should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining openfortivpn!

live well,
  vagrant

[0001-debian-rules-Pass-with-resolvconf-to-dh_auto_configu.patch (text/x-diff, inline)]

From 14e67565a16f7674f8181c72e80f191df0d91dbe Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Thu, 17 Nov 2022 03:22:53 +0000
Subject: [PATCH] debian/rules: Pass --with-resolvconf to dh_auto_configure to
 ensure consistent path regardless of the build environment.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 0279b75..dea45c8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,7 +13,7 @@ export DEB_CFLAGS_MAINT_APPEND  = -Wno-unused-function
 override_dh_auto_configure:
 	aclocal
 	automake --add-missing
-	dh_auto_configure -- --with-pppd=/usr/sbin/pppd
+	dh_auto_configure -- --with-pppd=/usr/sbin/pppd --with-resolvconf=/sbin/resolvconf
 
 override_dh_installdocs:
 	dh_installdocs README.md
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1024289-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1024289-close@bugs.debian.org

Subject: Bug#1024289: fixed in openfortivpn 1.19.0-2

Date: Tue, 22 Nov 2022 03:50:30 +0000

Source: openfortivpn
Source-Version: 1.19.0-2
Done: Daniel Echeverri <epsilon@debian.org>

We believe that the bug you reported is fixed in the latest version of
openfortivpn, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1024289@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Echeverri <epsilon@debian.org> (supplier of updated openfortivpn package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 21 Nov 2022 21:16:43 -0500
Source: openfortivpn
Architecture: source
Version: 1.19.0-2
Distribution: unstable
Urgency: medium
Maintainer: Daniel Echeverri <epsilon@debian.org>
Changed-By: Daniel Echeverri <epsilon@debian.org>
Closes: 1024289
Changes:
 openfortivpn (1.19.0-2) unstable; urgency=medium
 .
   [ Debian Janitor ]
   * debian/copyright
     + Use spaces rather than tabs to start continuation lines.
   * debian/rules
     + Drop unnecessary dependency on dh-autoreconf.
   * Remove obsolete field Name from debian/upstream/metadata
 .
   [ Daniel Echeverri ]
   * Pass resolvconf to dh_auto_configure to ensure consistent
     path regardless of the build environment. (Closes: #1024289)
     + Thanks Vagrant Cascadian for the patch!
Checksums-Sha1:
 dc34f4ae93b852eaa5f0bae2f6964b0ddaed6ece 2093 openfortivpn_1.19.0-2.dsc
 005759fd2b1d2d2d63599bb296e61baa51d2969b 5624 openfortivpn_1.19.0-2.debian.tar.xz
 e4a154940a884e6262b0816b38191f70052eb1bb 6552 openfortivpn_1.19.0-2_amd64.buildinfo
Checksums-Sha256:
 3d9aff42f7c4037e02ad31a2c5c9b406894be8ef36c6ee650cab8006dfcff874 2093 openfortivpn_1.19.0-2.dsc
 9b6ba8c48cb901819a0cbb4532005c6bd2ec03c1650ef7604fc53aec48d8f950 5624 openfortivpn_1.19.0-2.debian.tar.xz
 5ef14dd51cd57756d2fb98300d22b4cabb154883d8b9d8ac6710c33bb2a2fdc3 6552 openfortivpn_1.19.0-2_amd64.buildinfo
Files:
 19802b1be2c2f3653fcfd347cb136599 2093 net optional openfortivpn_1.19.0-2.dsc
 59a574661d9e177f88db5093178f9f53 5624 net optional openfortivpn_1.19.0-2.debian.tar.xz
 9f2971f16d888b3467de2221fad30dbd 6552 net optional openfortivpn_1.19.0-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEE0NCFsWnDv9lASFj6IfwpUEtSMNsFAmN8QQ8THGVwc2lsb25A
ZGViaWFuLm9yZwAKCRAh/ClQS1Iw22ihEAC+YdLysJ3vA9Ho6LfKgx/a9FrOQvQM
kOy8E3lGgetu+/IQDQ5xaQUISR5t8Oyr7EnH3OnOab56U+/wSKnYlnXS6Ul+5nyW
elg6q7fltjkd+PKi9xJCLUyLFJ5CL16Mo9u26RFXsFFnsSeC4faj6c9XK3nn8TWh
F+VbmCzcFN8rSuQB7QoRHpTi0pF4f1KjmoeJkR3FH6jQU7/H0HZg1I7cEMDfhBON
H+Wspq/jk72sGd93dauwo+3wPQTRgrbhg4J0pNPZ0N6YiggtRqX/2N32ET5rVWKD
GLSNX+glgHKXKmXjl6af1qb6vesLYE1cMf/Wm+Fno0hwp7+0UkLatIM81QvvJFVt
ngBlhqCF3Bwv/vUsyj4EUafhtXKn/LWAseHEarIdurWrlkfaUZ136LN3EsvS1KbR
EY28eA2zIwWL5UMkUBkU6ZTVsows0A+j4K9/GiUdkCde4AYGdRtNnwxUb94wXiPi
t40Y9U6PiBEcXFojdfVj+y84xcTPBr5R4HqMrKjxumRdAR2En9n+QNjEJupDC3rh
3RZDbKsCj1KSqLZ4vYrMI/k0+rwifwDoXZvu8TzpJ2mEHkUmoIpGTCYsIQUIU5qh
FIZG6fZ2YbNhrR6d4jptHe41O1yl1WlphIhYFbsxx2VNy7j/+4+vPtWVoPK9dLJQ
JtxRrFeXjDdQIA==
=SZ9R
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.