Debian Bug report logs - #102292
cvs loginfo broken or interface changed

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: submit@bugs.debian.org

Subject: cvs loginfo broken or interface changed

Date: Mon, 25 Jun 2001 20:35:22 -0400

Package: cvs
Version: 1.11.1p1-1

I have had the folling entry in my cvs loginfo file for s long time:

debconf mail -s "CVS Commit of %s" debconf-commits

This is quite similar to the following example from cvs's own
documentation:

^prog1          Mail -s %s ceder

It has worked fine up until today, when I received several mails similar
to the one below. Notice the large set of addresses it was sent to. I
can only guess that cvs has begin passing the names of each modified
file to the loginfo program. This seems like a rather bad API change to
make at this stage, especially since it makes use of simple mail
commands difficult to impossible, and forces use of wrapper programs
that discard these arguments instead.

----- Forwarded message from Joey Hess <joey@kitenet.net> -----

From: joey@kitenet.net (Joey Hess)
Date: Mon, 25 Jun 2001 17:02:46 -0400 (EDT)
To: changelog@kitenet.net, debconf-commits@kitenet.net,
	postinst@kitenet.net, templates@kitenet.net,
	templates.de@kitenet.net, templates.es@kitenet.net,
	templates.fi@kitenet.net, templates.fr@kitenet.net,
	templates.gl@kitenet.net, templates.it@kitenet.net,
	templates.ja@kitenet.net, templates.ko@kitenet.net,
	templates.nl@kitenet.net, templates.pl@kitenet.net,
	templates.pt_BR@kitenet.net, templates.ru@kitenet.net,
	templates.sv@kitenet.net, templates.zh_CN@kitenet.net,
	templates.zh_TW@kitenet.net
Subject: CVS Commit of joey-cvs/public/packages/debconf/debian

Update of /home/cvs/repository/joey-cvs/public/packages/debconf/debian
In directory kite:/home/joey/tmp/cvs-serv10092/debian

Modified Files:
	changelog postinst templates templates.de templates.es 
	templates.fi templates.fr templates.gl templates.it 
	templates.ja templates.ko templates.nl templates.pl 
	templates.pt_BR templates.ru templates.sv templates.zh_CN 
	templates.zh_TW 
Log Message:
   * Added debconf-show, which displays all questinos belonging to a
     package, their values, and indicates if they have been seen or not, all
     in a compact format handy for bug reports. Now why didn't I think of
     this before?
   * To keep the bit scales balanced, removed an unused template.

----- End forwarded message -----

-- 
see shy jo

Message #10 received at 102292@bugs.debian.org (full text, mbox, reply):

From: warner-debbugs@lothar.com

To: 102292@bugs.debian.org

Subject: loginfo workaround

Date: 18 Jul 2001 02:07:29 -0000

The way CVS uses the command from $CVSROOT/loginfo changed in the last few
versions:

 cvs-1.10:   %s -> "module"
 cvs-1.11:   %s -> "module file1.c file2.c"
 cvs-1.11.1: %s -> 'module file1.c file2.c'

The CVS cvs tree comments (src/logmsg.c v1.50) say that the change was made to
better accomodate filenames which contain embedded single quotes. (of course
it does that in exchange for causing problems with filenames that contain
double quotes. I assume this is some kind of windows thing.). When the loginfo
string puts the %s inside double quotes, the extra quotes annihilate each
other and leave the filenames bare on the command line, where they'll probably
be interpreted as email addresses.

A workaround was suggested on the CVS mailing list. Instead of:
 mail -s "cvs commit: %s" mailaddress
use something like:
 mail -s "cvs commit: "%s mailaddress

The shell will concatenate the two strings regardless of the delimiters used
on the second one. (Putting the %s inside single quotes would fail for any
users still running cvs-1.11).

Still, it's an annoying API change. I'm not convinced that it was a good idea.

hope that helps,
 -Brian

Message #15 received at 102292-done@bugs.debian.org (full text, mbox, reply):

From: Joey Hess <joeyh@debian.org>

To: 102292-done@bugs.debian.org

Subject: closing

Date: Mon, 25 Jul 2005 23:51:37 -0400

[Message part 1 (text/plain, inline)]

I suspect that there is no point in keeping this bug open, as the API
change is a done deal (and I don't use cvs anymore anyway ;-)

-- 
see shy jo

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.